From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Apr 2021 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161920403320013 (code B ref -1); Fri, 23 Apr 2021 18:54:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2021 18:53:53 +0000 Received: from localhost ([127.0.0.1]:38834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0w5-0005Cj-2c for submit@debbugs.gnu.org; Fri, 23 Apr 2021 14:53:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:60740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0w3-0005Cc-Qm for submit@debbugs.gnu.org; Fri, 23 Apr 2021 14:53:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la0w3-0007YV-Iq for guix-patches@gnu.org; Fri, 23 Apr 2021 14:53:51 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la0vv-0001gK-Jz for guix-patches@gnu.org; Fri, 23 Apr 2021 14:53:51 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D6F5E3059; Fri, 23 Apr 2021 14:53:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 23 Apr 2021 14:53:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=LflpN3IKgze2migbwdUwfBf VwAphjdl+Eof0yU8LPPQ=; b=DW+2KCwWXP7f+9Py8fpV28pNzM1rXMHt3/g+UN5 QpYCd2zAFbJaIDVXmN0JpiMTsUwXjXRFYIMAF3ioJDcxY5A6tdajbumXXX3GRXIe UsT2+VXu35Hp5VBOpgogDw+Qz5UAKj4jYzr8o3apmWdvx1XEXp4Ec/8RheNMV/+V pE9k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LflpN3 IKgze2migbwdUwfBfVwAphjdl+Eof0yU8LPPQ=; b=N2zPePt6bLI1AvnBKp1Of7 Ly22QW1CiyGIFYIqr/lI1076MrI5TbQzOkzODi1iL8HIu/gMPXWMpvCleMgbQJQ/ 47niW6g0a43NXPEzXMO/2EXoiuRCaxZ3NvDmBWGf9GQOgGiD9FmovhIpDD10udfm L0Mho+sVN4cR6EULNJWyVjaoHnLmtrsjDaYAQDkF+s4A3idtrfS031oluya5VoSw OTMOj+GRq1KsjBOUL49KK9CBqqLFtDW490LTiF283vKOsXELIwnv5Wmsiy173qMn Ptyf3M/AfkaHIlltB/m3gt26v94IXzWr2b+0GHtpJ6Odm4TxPYY4GHguGuCdJMGw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre dtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfetjeetjedtfefggfelheevleejte fhleevveetkedtheeugedtgfekueekheejnecukfhppedutddtrdduuddrudeiledruddu keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from jasmine.lan (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 2403F108005C for ; Fri, 23 Apr 2021 14:53:41 -0400 (EDT) From: Leo Famulari Date: Fri, 23 Apr 2021 14:53:15 -0400 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@famulari.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. --- gnu/installer/services.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..440b8c67db 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -103,6 +104,11 @@ (type 'networking) (packages '((specification->package "nss-certs"))) (recommended? #t)) + (system-service + (name (G_ "Network time service, to set the clock automatically")) + (type 'network-management) + (snippet '((service ntp-service-type))) + (recommended? #t)) ;; Network connectivity management. (system-service -- 2.31.1 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Apr 2021 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161920421120312 (code B ref 47979); Fri, 23 Apr 2021 18:57:01 +0000 Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 18:56:51 +0000 Received: from localhost ([127.0.0.1]:38840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0yx-0005HX-Jf for submit@debbugs.gnu.org; Fri, 23 Apr 2021 14:56:51 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0yv-0005HL-FR for 47979@debbugs.gnu.org; Fri, 23 Apr 2021 14:56:50 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6BF503062; Fri, 23 Apr 2021 14:56:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 23 Apr 2021 14:56:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:mime-version:content-type; s= mesmtp; bh=tkxOXxKG+Q3sjqlCWMkNBTvEnXSNgCYpDP6hSCaR4t8=; b=qQQTt DMN9PZ77wdctrxJnjZhNiMfEdo1D3MZ8XRGnzCQO9ztmpUsPoUCkqnG5m+bpkQ7K qZdLl2hmZ9JNfba/Nzjr8+OLD4Fop+SnGu9Qu9u5KPuxqfNXZ9zYP+fh9+j/k+rR Ox/74vnri9WX2YJ6xvMILnFoP1LhpB07SkJmlY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=tkxOXxKG+Q3sjqlCWMkNBTvEnXSNg CYpDP6hSCaR4t8=; b=vt3p7VLyfYAvdSw3uLBeU56AnFr3TCNLUBjySFyT2OSxR 8EmcDWqDqKLibTj4mlA7XZV5vdXzd96/KojnTobUNPQxK/EAuxIYEsEuJg8Ycgiz nbZTMnqK6ZDuo8uprDAMoQ1o4wDhGEIkAWiQUNhmJaFZNLr/7rZAjR9CqPX2IYkS DlKJs0pM9Ew4oW0cbWsVq/0XC4VLW6580rgzQ/vIHaCdWkHOyOegNkd9v18dBQDb uqpRJnw2rwIL6eFl28xbEIAsq6a7YOjPYvL24Av3mAMEx1ZPqePlZXSzoVeK8RX1 e7TZeN127vKRNoXJ9jOjVM+vRuPxEuMyARc+sNHmw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggusehgtderre dttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeejieeutdffleegudehgefhhfduueeule evveeggeehveffkeeihfevvdfhkeefvdenucfkphepuddttddruddurdduieelrdduudek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvoh esfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DC1B1080064 for <47979@debbugs.gnu.org>; Fri, 23 Apr 2021 14:56:42 -0400 (EDT) Date: Fri, 23 Apr 2021 14:56:40 -0400 From: Leo Famulari Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/W+bpfFPT4zmGquK" Content-Disposition: inline X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --/W+bpfFPT4zmGquK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hey everyone, please disregard this patch. It doesn't do what I meant. Sorry for being hasty and sending the wrong thing. --/W+bpfFPT4zmGquK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDGGgACgkQJkb6MLrK fwgzhBAA0Ii0++wXRQ0v0mbjyDVWkP4dU/+eEEuiuYeBlByM+7o0VI/K/T+VBPmr rOGnyA9Wt+t8Q3HeJnatDP81pkHbDoN4alj7CAgit+c4ZqJG2P607Q2RlcqxaFsI W9SRRa1/AjtFL/K3acABPJGBlYMEBqbNf4x5qLFuEzJVE91MBDZtrsqOo1HLgyiy 8be8+KgVYBhrSbqKzyaMJBxBn61X8lanvNZ4MsIPHS7KbLKgA4IXrYFYk0XMEDxG Z2JUBeLAVT0PRFdOEzsMi4836gPh8lzSDzCFGbjvkNYEFYrVNoetNcWz3U6jfrhM 1EHNIQgEYW5RzmYCMzbZQLnWh44IUSLNRoiz503ibB3lyWMOw+5Nh/yCwsfrYv82 og/ndo1skIpe3NnXdiX5ySYxpJyf9eTM3IepXIUgt0Ht1K7/FuERHUWzUwFcCdVs HCl4ju/dqm6lXGBaJ9zEFB2NS5qj/YhuDJeYmF1dbbUjYtzqvDVcZe1SmxiWVm5O f59jRlQdi6jEiJnvrylO6r4m/KVfIrxzHKq2lSvRIJ23lLytwJ15sSoMpyPOkFn3 OPoRWxtRk22Mu5JvCs1zyWTviNOeebYMV8HeR4z9MXxq2sDUV5OOY2ZeCOR9XO1f YkFm696HhYnkfHaAs97DvCEKQ3YVpovCLy+RmeYDy+rwgZTpxeE= =u6bC -----END PGP SIGNATURE----- --/W+bpfFPT4zmGquK-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Apr 2021 22:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16192179719365 (code B ref 47979); Fri, 23 Apr 2021 22:47:01 +0000 Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 22:46:11 +0000 Received: from localhost ([127.0.0.1]:39131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la4Yt-0002Qz-2j for submit@debbugs.gnu.org; Fri, 23 Apr 2021 18:46:11 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la4Yr-0002Qe-4S for 47979@debbugs.gnu.org; Fri, 23 Apr 2021 18:46:10 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 216863628; Fri, 23 Apr 2021 18:46:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 23 Apr 2021 18:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=jkVETC9nd3YaKb6TjDPg7IRk gQ6YElHsDINI9nv27yQ=; b=U9aZxA4PddFbyLUf6os6TIN92SM+yJ79K5yLm7oy bYJEPLy68byxJjxNzdpjxy/Idz87rJlbRg2SXim6vIiR3GNNkeZjpT/TJuXXHNjo xKtKOEdumWmIZClLheurC9S7Kc8P7HRxC8vSrmhyQTu7skKtiPffNtvj9/Cuy4ph Nv0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jkVETC 9nd3YaKb6TjDPg7IRkgQ6YElHsDINI9nv27yQ=; b=nzfTzedfRh+OUDEamCH6VX g+R9MuoC0lchMZ9sZGIcAF3q59gsvmCcKPAkmMUPMI5glbVRWk61qdPNBoXUapBc LUyL2xkGbZjk2t+Kt7DOVRQ5O2Dmu82+xdZ07WItX0na61IX07hyqOAlLHVD0g0d UqeyB7zEijt+sfXNLCohro3dKZ82fCUJpv3+B019nfoSI8jJBZzxikNov/kaYYkP bebndygZkgxMp9H9KgX/R5XhLoLUZgx4FYhuZc4vXLwWaxf0XPoOdBCZ1ZmociFL y7yz7BRBqtwJQ+xcDMW3GmAz3OohN6Gx5r0Op1OAOUP4PsL/AoF/ZY59PFf+MPtw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddufedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepiefghfeffedtffekveektddtieekfe ffledtgfevkeekteeufedtfefhgefhkeefnecukfhppedutddtrdduuddrudeiledruddu keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 5F09A24005D for <47979@debbugs.gnu.org>; Fri, 23 Apr 2021 18:46:02 -0400 (EDT) Date: Fri, 23 Apr 2021 18:45:59 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t0ubvqyjGjrAhPNs" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --t0ubvqyjGjrAhPNs Content-Type: multipart/mixed; boundary="BKTfMUvwn05mzvcF" Content-Disposition: inline --BKTfMUvwn05mzvcF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Okay, here is a patch that does what I want. That is, when the user does not select any desktop environments, it prompts them about enabling NTP, with the checkbox already checked. However, with this patch, the installer crashes after partitioning, like this: ------ In ./gnu/installer/services.scm: 38:0 19 (%system-service-snippet-procedure (#< name: "= Network time service, to set the clock automatically" type: administration = recommended?: #t snippet: ((service ntp-servi=E2=80=A6>)) In ice-9/boot-9.scm: 1669:16 18 (raise-exception _ #:continuable? _) 1667:16 17 (raise-exception _ #:continuable? _) 1667:16 16 (raise-exception _ #:continuable? _) 1667:16 15 (raise-exception _ #:continuable? _) 1667:16 14 (raise-exception _ #:continuable? _) 1667:16 13 (raise-exception _ #:continuable? _) 1667:16 12 (raise-exception _ #:continuable? _) 1667:16 11 (raise-exception _ #:continuable? _) 1667:16 10 (raise-exception _ #:continuable? _) 1667:16 9 (raise-exception _ #:continuable? _) 1667:16 8 (raise-exception _ #:continuable? _) 1667:16 7 (raise-exception _ #:continuable? _) 1764:13 6 (_ #<&compound-exception components: (#<&assertion-failure> #<= &origin origin: "struct-vtable"> #<&message message: "Wrong type argument i= n position 1 (expecting struct): ~S"> #<&irrit=E2=80=A6>) In ice-9/eval.scm: 619:8 5 (_ #(#(# #< na= me: newt init: # exit: # exit-error: = # f=E2=80=A6>) =E2=80=A6)) 619:8 4 (_ #(#(#(# #< = name: newt init: # exit: # exit-error= : #) =E2=80=A6) #)) In ice-9/ports.scm: 463:17 3 (call-with-output-file _ _ #:binary _ #:encoding _) In ice-9/eval.scm: 619:8 2 (_ #(#(# wrong-type-arg (= "struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" = ((#< name: "Network =E2=80=A6>)) =E2=80=A6)) #)) 159:9 1 (_ #(#(# wrong-type-arg (= "struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" = ((#< name: "Network =E2=80=A6>)) =E2=80=A6)) #)) In unknown file: 0 (make-stack #t) ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in po= sition 1 (expecting struct): (#< name: "Network time servic= e, to set the clock automatically" type: administration recommended?: #t sn= ippet: ((service ntp-service-type)) packages: ()>) ------ So, I've done something wrong. But I don't know what :) I'm going to keep trying but hopefully somebody can help me. --BKTfMUvwn05mzvcF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-installer-Recommend-ntp-service-type-for-non-graphic.patch" Content-Transfer-Encoding: quoted-printable =46rom c70ed1b6ed621a56ab258cf5cfce45c50cb1831f Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 14:50:15 -0400 Subject: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. --- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.= scm index 74f28e41ba..60c62a52b1 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright =A9 2021 Tobias Geerinckx-Rice +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) =20 +(define (run-system-administration-cbt-page) + "Run a page to select various system adminstrative services." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Miscellaneous services") + #:info-text (G_ "Select miscellaneous system services to run on your= system.") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (list (run-network-management-page) + (run-system-administration-cbt-page)) '())))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..17ff31d2ec 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright =A9 2018 Mathieu Othacehe ;;; Copyright =A9 2019 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) =20 + ;; System administration + (system-service + (name (G_ "Network time service, to set the clock automatically")) + (type 'administration) + (snippet '((service ntp-service-type))) + (recommended? #t)) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) --=20 2.31.1 --BKTfMUvwn05mzvcF-- --t0ubvqyjGjrAhPNs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDTicACgkQJkb6MLrK fwjlRw/+MK0M4CWE8ia/QcGVtvBR4OBUVF+TE+cvTrpL+mmSKY+OND00IHOngicI mhh7qUZcwlIIYFseox+IPO4Yw29SxYGOctyE+k2DqTkYJ8QFUKVetO9WKIqYdQF9 LTEaG8wZQLakSPCvfZpw3FtD7D+//gwH9ncu42Z+4OXcGCugT2STurfzbTWioHnO 4q+ASbbqAqO2rRxTaJg4jhEeUOTV2hDwGmCegtvHYJfukbLiuZyq6MU/bB1tWaDl BN2Yb5Kn9Apn8Nere1xGA/+3cUonrP/v85+eZ4VnwCpSEJb/8jlhLQEqTWSTbZ63 1sODXTIJWrXwbl8LaKStV4NmhSOYje7HwHRnksWzBLa5Ht+Kg6pb+zEEBubs0E06 LFFT9akSestWqIngxDXCOUn9I3Cd3lXlpzvd4yT05zpbvJdzcOUtZbxb9R1hAdQ2 lYUpfP7LK9S2kbPLtTugqoppIGs6dlezhONbwym8nDXZup/btgv0xObp2UcPu2FY KCk/O/oD50gK7Gbnk8cXUoMNZhlhgngXYCc+JW1XE/FhLN6o32C2d5yQuavdFo56 DZ6JC2hVD+KfdmNcrwMRvlGb/euzu3R6AAJ27EAdrwGc8KD/Ba1v1fXhDWcHpg1l /KtCLKUrR7I1c21VopBjL4B9wvsu+Ti44rfXpMzxECNNK6FXGt0= =gQrc -----END PGP SIGNATURE----- --t0ubvqyjGjrAhPNs-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Apr 2021 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161922004712895 (code B ref 47979); Fri, 23 Apr 2021 23:21:02 +0000 Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 23:20:47 +0000 Received: from localhost ([127.0.0.1]:39154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la56M-0003Lv-JJ for submit@debbugs.gnu.org; Fri, 23 Apr 2021 19:20:46 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:59965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la56K-0003Lg-Iv for 47979@debbugs.gnu.org; Fri, 23 Apr 2021 19:20:45 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id AFC3F3868; Fri, 23 Apr 2021 19:20:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 23 Apr 2021 19:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=AjgWhCZaned1CHbZBVLuzKyI SChbNDDqXHz69eWVElw=; b=1E5vA8ty9UhuGOWwHCsqT1skqF+6GlLZ+5+QFVlh nMb96OyQ3wpowEkJlK4GOrw8EZbvZzareDIDcKGWdKcTG3Z9P39h5RKpIawn8T/S /60pXpY7OZgt9AdFwMx2W0O/f/FH/dE6sJtZpEqk8FtGjhEuiXrfClzvCfbbh92M 660= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AjgWhC Zaned1CHbZBVLuzKyISChbNDDqXHz69eWVElw=; b=RehAZcaMMAOoYMx7ZfKNXh WYce5WaT2/LSGKLfKRQ6RPrv7HLSJ7lIw0jtfmTQoX0iAVeTmrUX+um4freoWnam 3Y4JtqbtiACNPG3nHMph/ZUpgOKyVWq6AzsETScWhTWtfk7yjapRbE39sg7Ctx0k Yy/KFYRpSwWj5edmtCKXH9mVZQyEMjtuhBt3wHINC6NEWGin8I8xxun0pBbn1Q9s EvWS0UFOJ8pTdS6J4vw7QR5SOA3/QC7es94Y3cBd+rhesXbkN2MR0x0jqTPHvzSr kwoqENTPwJOHVqNKvyL1t6WpkuQlkoyGeL+5fSOPwqbaGuOJx1Sklty7di01c83A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddufedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepudekveegteekleetgfeitdejgfejke ffudethedvhfeukeduleeikeejfeehffetnecukfhppedutddtrdduuddrudeiledruddu keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id E08D11080066 for <47979@debbugs.gnu.org>; Fri, 23 Apr 2021 19:20:37 -0400 (EDT) Date: Fri, 23 Apr 2021 19:20:35 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JBlACcxucxP3sLMg" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --JBlACcxucxP3sLMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote: > However, with this patch, the installer crashes after partitioning, like > this: By the way, I'm testing this by building the installer in the same way as our Makefile: $ guix environment guix -- ./pre-inst-env guix system image -t iso9660 --label="GUIX_x86_64-linux-leo" --system=x86_64-linux gnu/system/install.scm I create a QEMU disk: $ qemu-img create -f qcow2 guix-system.img 50G And then I use the ISO I built, after copying it out of the store: $ qemu-system-x86_64 -m 1024 -smp 1 -enable-kvm -nic user,model=virtio-net-pci -boot menu=on,order=d -drive file=guix-system.img -drive media=cdrom,file=image.iso --JBlACcxucxP3sLMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDVkMACgkQJkb6MLrK fwhBEA//e+eWdYCUeYAmyNXyaqocDSnOEd98VVhskGHjql4YChsow2JlIODHRWW0 fghagCxtQrgrHs/YRnDbGTTuvKVTXckox3T+uAAIwWNGXNOaN3B46nPQp2dZX6So FzyYelO7MmIlxh+p22GPT3cwaaIP1PsqcEMHNX1zi9Nz6+eGqbO4VbHnY2G/t9Vy JSS8v001cOwpNsbFfh2kIUz3+5SQp8K6MSvpIC5v/JdvcaS9zODy7wTH1UjKz/kz hdj2YrMJEMwxz57mN8mlEKp2wa1c+5wyZktwIjL5qeYiEm4zVdXN+k38kT3ttZeF oNzqlDVNFcXWmYxDaniU05erbdvx06CNzpvHb6FZmvj0VHFrpV3/P3rUfEAgbPkk V4dwRGwbRd5WMp4NBnmWAo9n6X1nAAHyHsUtxKbm/Y5P12N37hx+pnvmoxYuOPwa EwfBcAz0r7656ZGYvKyDBfe3PTTJg9XUPDV423+doH5k1gyx8h0zL23FWUl4JI9i sAcAFwRdaS5WwSsWe9fJ3IuJOzCXxz06Vl4tuD9J0FyzKSfId/y3WrtSD8lNqGqt XUd/C9/1sUSQJbGyZ0aebGpGL+nBG/blpAXcY9x+7IfxO5b335v3ExP8djb9Bxse u2XfQ4NoZt2pB5gEzwPb3wywasLUVWrGW0Usfcw8UXz7/bEmYSw= =Vbie -----END PGP SIGNATURE----- --JBlACcxucxP3sLMg-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Apr 2021 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161927583228364 (code B ref 47979); Sat, 24 Apr 2021 14:51:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Apr 2021 14:50:32 +0000 Received: from localhost ([127.0.0.1]:41284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laJc8-0007NP-C1 for submit@debbugs.gnu.org; Sat, 24 Apr 2021 10:50:32 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laJc5-0007NA-Rn for 47979@debbugs.gnu.org; Sat, 24 Apr 2021 10:50:31 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 17BDF1B23; Sat, 24 Apr 2021 10:50:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 24 Apr 2021 10:50:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=TBdTQy4eXOmdNVe48HQ/6/pT puwn+/CJuZWnq9UZM80=; b=Nz82fCNzVAsWLPvNwhtGHXEH66KCmavNKS5h3/NZ b+ZlE63HJIAVxfaGi7fcpsBfs6kfbkKCddGxfIiHh+cUofwp790D1oS/yL2d5Tfu tDcfzBucywcHLpiuEa4g0N961G45m4hRbJqYJqFWV3TnKP/AgGwtQ8S2T7yz/JkH auQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TBdTQy 4eXOmdNVe48HQ/6/pTpuwn+/CJuZWnq9UZM80=; b=ugwfYW+MOOyy04ivqM6mve mf/byAJf+vEdQLhW63rH+inCa0MyxDCoyqzKcLQMP63oca05h7Sra3olXRNpTzc/ 0OcKYqDii0RgX2AqIE0DRriI5a9xT16GTFsK/GcJGIcnfJVj8QX19Me+wMG5VKgI VDIrPy4V6nZhBTJ49dTNYuva7OmHvrh8mplGjTodQRiHm82C3By/L/a6PKrS1CXN ANFeo8vUcyixx95vMEESAuJDPAoLPWoHS5TraWYHJmMsOvvOFYiP0BJLmE/8gJE0 xdf6w1uMzpe9WaDu/XKCZGn+h/F6hQacondEcWcZtwirCuqPU52XuusMP4OPHShw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddugedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvdevgeekudeivdeileduveekuefgue euleehtdffgefftdefkeevleffueefudeknecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 774B9240066 for <47979@debbugs.gnu.org>; Sat, 24 Apr 2021 10:50:22 -0400 (EDT) Date: Fri, 23 Apr 2021 20:56:43 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dHkJjldvz7gEzIKb" Content-Disposition: inline In-Reply-To: X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --dHkJjldvz7gEzIKb Content-Type: multipart/mixed; boundary="eqwIqxzZxv0Qks4S" Content-Disposition: inline --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote: > ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): (#< name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-service-type)) packages: ()>) With Leo Prikler's help on #guix [0], I got it to work :) I've attached the working patch, as well as a patch to offer the GPM "console mouse" service on non-graphical systems. [0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921 --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-installer-Recommend-ntp-service-type-for-non-graphic.patch" Content-Transfer-Encoding: quoted-printable =46rom 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 14:50:15 -0400 Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphi= cal systems. We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. --- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.= scm index 74f28e41ba..ee003b24b1 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright =A9 2021 Tobias Geerinckx-Rice +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) =20 +(define (run-system-administration-cbt-page) + "Run a page to select various system adminstration services." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Miscellaneous services") + #:info-text (G_ "Select miscellaneous services to run on your system= =2E") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-system-administration-cbt-page)) '())))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..b50bd3e412 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright =A9 2018 Mathieu Othacehe ;;; Copyright =A9 2019 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) =20 + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service, to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) --=20 2.31.1 --eqwIqxzZxv0Qks4S Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0002-installer-Offer-gpm-service-type-for-non-graphical-s.patch" Content-Transfer-Encoding: quoted-printable =46rom a00274e70d700b9325ad9ab7cd1804d444a5dc37 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 20:42:28 -0400 Subject: [PATCH 2/2] installer: Offer 'gpm-service-type' for non-graphical systems. * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index b50bd3e412..27beb5da66 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) =20 ;; Network connectivity management. (system-service --=20 2.31.1 --eqwIqxzZxv0Qks4S-- --dHkJjldvz7gEzIKb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDbMgACgkQJkb6MLrK fwhyVQ/+I4Z9bPvlS/m9+XhUARgOepoymiLl3ykv4fdS6os5LSqdxDQp5LcaGyrL 1FM1AOUrQZ0rd2ZO0XGpYh/eyvE+edaBP1Bpnd0/LTjzZqCn4z8fQo6xn1O6rDyO MuurlXYMlGivSZtngH0UeEcOi85JQaF6eBVIk9+yH4OCzS/e2HiFQhzmpE032vx8 MLaJ5HycJFrmKmPCB53Zp+rkvjqwRL9S8b51afYp5hABxoGfSX2JkGARRSSfZxRD ARtqvwqCgU3DzB6X7BmWBEa9MU5WWRGSc7wOX2CCPag6A6RbXcTO3rQV8P+xi8SD SkQB7WAlvHTx7ueLsn3SK/OBqKTVgtf98kFTtzBQiNfN4p+NFDPSQ/MpowNAO6NI WhZAQNNE/jMoZBVmOxKBbdDxCJk41K86Vvv4QV/IvXJC03s1eyraM/91cXgTG8+o IVr/q6Vbs3QErrsoZg2E/NVeS6rQaa/8vmiSkzM1+gel66NLBGVZBcOVKQayfc+A ITKcr2fo6tPM3LxnHA/tKn44kFmGNeutGrcjeijHThYGHR1An/d51y1M5vVLaLEI /O/wNigTWVgAhHcmH64Y9zk1SSxJsFS4OzTpBs4CV3xZq8rTL8GXx+g8wux3sgLw /wMBlIJPgHd2KJdeFAUgIpAsHTflmXSa/H0kAbstw5QiV5bCCfI= =U8RK -----END PGP SIGNATURE----- --dHkJjldvz7gEzIKb-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 May 2021 04:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16199301834333 (code B ref 47979); Sun, 02 May 2021 04:37:01 +0000 Received: (at 47979) by debbugs.gnu.org; 2 May 2021 04:36:23 +0000 Received: from localhost ([127.0.0.1]:40277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld3qB-00017p-K4 for submit@debbugs.gnu.org; Sun, 02 May 2021 00:36:23 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld3qA-00017h-3T for 47979@debbugs.gnu.org; Sun, 02 May 2021 00:36:22 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 075A25C0068; Sun, 2 May 2021 00:36:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 02 May 2021 00:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=zdwX6918hI3ED4fnjf3NVADg xzIYMQipvYas7pW9R+8=; b=WRUmXM2fXlj97bV9NCHzl4rMSr2WSE/BS7lNokyY eMM+jZajQ9mGEi5Kb2dfkP00No3Fa8Ft0Xxx8z32BqevxAQSqyUB3ewqgTkWsyLL U+Ef35WSrm/20vLIx1u13e6+FmrrL3OpbQJaHK6qfcBb2tSvNYqfiq3lRmXE/AqD 8zY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zdwX69 18hI3ED4fnjf3NVADgxzIYMQipvYas7pW9R+8=; b=j4L7gmDLvwSxeAVs5nBhcL wa+CMxhHlQZjZxN/XO9WZs/+Lt2P5+0+xbUDYw9X1ecabfTa4OziZ7w1BCHv2s8K LRGRv/3jpGvPT3+A/m0mI2lTF1+9Am6xFhFQ+GJlJ/m1eyboPosL5sMfZsD2E7ml hv9yvQsISyOpL/HtbgLEgCbHnnfv5jE99d7D0WRZhw4yzLWxivyYElI6UKWtnWIL CDzgkLOmJk0pLMmTf/7TjNpmoNqnEe3aITv9U777U5qL3g71WshD/1uHl7W8Y+K/ DH1QDKnNOv1eYCEjeGrtLqsyVTp5VxykUZbRZE+2ODLnKaCdRHcjmB1nitUMghSQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefuddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppeduiedvrddvudejrdeffedrudduvdenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (d-162-217-33-112.ct.cpe.atlanticbb.net [162.217.33.112]) by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 2 May 2021 00:36:16 -0400 (EDT) Date: Sun, 2 May 2021 00:36:14 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Apr 23, 2021 at 08:56:43PM -0400, Leo Famulari wrote: > With Leo Prikler's help on #guix [0], I got it to work :) > > I've attached the working patch, as well as a patch to offer the GPM > "console mouse" service on non-graphical systems. > > [0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921 > From 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Fri, 23 Apr 2021 14:50:15 -0400 > Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphical > systems. > > We had several bug reports with a root cause of "the clock was > incorrect" from users who used the installer to install a non-graphical > Guix System. > > * gnu/installer/services.scm (%system-services): Add the ntp-service-type. > * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New > variable. > (run-services-page): Use run-system-administration-cbt-page when not > installing a desktop. Ping! I suppose it's too late for 1.3.0, due to the string freeze. But I am asking for review anyways. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 May 2021 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161994752518250 (code B ref 47979); Sun, 02 May 2021 09:26:01 +0000 Received: (at 47979) by debbugs.gnu.org; 2 May 2021 09:25:25 +0000 Received: from localhost ([127.0.0.1]:41777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld8Lt-0004kI-1M for submit@debbugs.gnu.org; Sun, 02 May 2021 05:25:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld8Lr-0004kC-Am for 47979@debbugs.gnu.org; Sun, 02 May 2021 05:25:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58412) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld8Lm-0007Wo-0a; Sun, 02 May 2021 05:25:18 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=52506 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ld8La-0002uQ-LZ; Sun, 02 May 2021 05:25:15 -0400 From: Mathieu Othacehe References: Date: Sun, 02 May 2021 11:25:05 +0200 In-Reply-To: (Leo Famulari's message of "Sun, 2 May 2021 00:36:14 -0400") Message-ID: <87sg351o9a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Leo, > I suppose it's too late for 1.3.0, due to the string freeze. It looks rather nice, but I'll test it more thoroughly after the release. Did you make sure that the installer tests are passing with: make check-system TESTS="gui-installed-os gui-uefi-installed-os gui-installed-os-encrypted gui-installed-desktop-os-encrypted" Thanks, Mathieu From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 May 2021 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.161996894315618 (code B ref 47979); Sun, 02 May 2021 15:23:02 +0000 Received: (at 47979) by debbugs.gnu.org; 2 May 2021 15:22:23 +0000 Received: from localhost ([127.0.0.1]:43295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldDvL-00043q-8A for submit@debbugs.gnu.org; Sun, 02 May 2021 11:22:23 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldDvH-00043j-Ib for 47979@debbugs.gnu.org; Sun, 02 May 2021 11:22:21 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7A5065C00EE; Sun, 2 May 2021 11:22:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 02 May 2021 11:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=n2T/4+fcvuzXbHSk7q9IIpKt JnyfOVInGLxioXeCWVU=; b=q0bprp9wp9PAsyL7ODLIhj31qpASCW0mvSS90Nzr RslBla4Y+2DCZudfm03b1x82siSR3eTNiaf6+4kbLCIEa+PSKjbRiq3N32TPkrZW VK2/PClVFThrbaVCjVaFK5bdE5xyNW31P8A7aNdLIIOyWobaRcqhXS9cokKcqMPi I9w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=n2T/4+ fcvuzXbHSk7q9IIpKtJnyfOVInGLxioXeCWVU=; b=Ix/fKqrmnwnStjzpTy5Kh8 2Yy5bBv8dDIJrsD07saUNqYTGHLslRW6NAU9oJsuVLGNjCtLEryxc/7J1oLL+kkk lVXJkJQWmJtCpDZFABNl3WT5MSZV68lqKq4PJaHwYUU5dDrp3Qa187NF3Av99KIX rZyArHy/vCYlOLln0puMJC/Jl+Fd2dCFQZT2e7gRlDa1D4vr5vYAQQxzZq/Gm6KV 3zKAIEaogkVOXlK7FN4l/fvtFJ1fWXVm7EkSyNdILERE+dkQOjCA/0dZx3HRRFEO 7LC45itkvCZZ7B2AOOmORvmuMKqZnA39sfilFH/3p1gUBxRwk4n5ciX9j7/gv7Mg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefuddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecukfhppeduiedvrddvudejrdeffedrudduvdenucevlhhushhtvghrufhiiigvpe dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (d-162-217-33-112.ct.cpe.atlanticbb.net [162.217.33.112]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 May 2021 11:22:13 -0400 (EDT) Date: Sun, 2 May 2021 11:22:11 -0400 From: Leo Famulari Message-ID: References: <87sg351o9a.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sg351o9a.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, May 02, 2021 at 11:25:05AM +0200, Mathieu Othacehe wrote: > > Hey Leo, > > > I suppose it's too late for 1.3.0, due to the string freeze. > > It looks rather nice, but I'll test it more thoroughly after the > release. Did you make sure that the installer tests are passing with: > > make check-system TESTS="gui-installed-os gui-uefi-installed-os > gui-installed-os-encrypted gui-installed-desktop-os-encrypted" I tested it on "bare metal", but I will run the systems tests, too. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 13:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16216019433660 (code B ref 47979); Fri, 21 May 2021 13:00:03 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 12:59:03 +0000 Received: from localhost ([127.0.0.1]:36028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk4k2-0000wx-Pr for submit@debbugs.gnu.org; Fri, 21 May 2021 08:59:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk4jx-0000wQ-Po for 47979@debbugs.gnu.org; Fri, 21 May 2021 08:59:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40394) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk4js-0000Hf-6d; Fri, 21 May 2021 08:58:52 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=49936 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk4jp-00080W-E1; Fri, 21 May 2021 08:58:52 -0400 From: Mathieu Othacehe References: Date: Fri, 21 May 2021 14:58:48 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 23 Apr 2021 20:56:43 -0400") Message-ID: <87lf88qm47.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Leo, > +(define (run-system-administration-cbt-page) > + "Run a page to select various system adminstration services." > + (let ((items (filter (lambda (service) > + (eq? 'administration > + (system-service-type service))) > + %system-services))) > + (run-checkbox-tree-page > + #:title (G_ "Miscellaneous services") > + #:info-text (G_ "Select miscellaneous services to run on your system.") > + #:items items > + #:selection (map system-service-recommended? items) > + #:item->text (compose G_ system-service-name) > + #:checkbox-tree-height 5 > + #:exit-button-callback-procedure > + (lambda () > + (raise > + (condition > + (&installer-step-abort))))))) Indentation is off here, > + ;; Miscellaneous system administration services. > + (system-service > + (name (G_ "Network time service, to set the clock automatically")) > + (type 'administration) > + (recommended? #t) > + (snippet '((service ntp-service-type)))) > + here, > + (system-service > + (name (G_ "GPM mouse daemon, to use the mouse in the console")) > + (type 'administration) > + (snippet '((service gpm-service-type)))) and here. Those patches are breaking the installer tests because they introduce a new dialog. You need to add something like: --8<---------------cut here---------------start------------->8--- ((checkbox-list (title "Miscellaneous services") (text _) (items ,services)) (filter choose-misc-service? services)) --8<---------------cut here---------------end--------------->8--- in the (gnu installer tests) module, to fix this error: --8<---------------cut here---------------start------------->8--- conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) /gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) sexp: (checkbox-list (title "Miscellaneous services") (text "Select miscellaneous services to run on your system.") (items ("Network time service, to set the clock automatically" "GPM mouse daemon, to use the mouse in the console"))) May 21 14:53:11 localhost instaBacktrace: ller[180]: running form # ("Miscellaneous services") with 1 clients 2 (primitive-load "/gnu/store/9vzfy688gawwn2p06nn75kiqqz3?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(# #)) --8<---------------cut here---------------end--------------->8--- Otherwise, it looks fine :) Thanks, Mathieu From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16216042407259 (code B ref 47979); Fri, 21 May 2021 13:38:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 13:37:20 +0000 Received: from localhost ([127.0.0.1]:36070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk5L5-0001t0-FI for submit@debbugs.gnu.org; Fri, 21 May 2021 09:37:19 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk5L3-0001so-Vv for 47979@debbugs.gnu.org; Fri, 21 May 2021 09:37:18 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B41415C00D7; Fri, 21 May 2021 09:37:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 21 May 2021 09:37:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=/BBDIU1GogR5BIWL8KYGK5Ks arMizOQq4sjoQX99CT4=; b=AJcGdRuIiUHafuVR2lhPuiY2dz0WmswH/ua7e3lk rqYOC0C46BCBU/2JAWv4E5aCTFXMoVbobOHlVIZ7zco/QbkEQIdWyMVA8skl0AeU wIlT8IX2quoKhfjHlrMv3PZ9E58IGIVADJ8lLA3w3cB0gQqowtsKyDS9Ci4mrGyK kj0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/BBDIU 1GogR5BIWL8KYGK5KsarMizOQq4sjoQX99CT4=; b=GQgLRi4kYn7lTY3QsmZlmw YvO4c6rrL03csXMTo4yvKyUgdqp1RUzlGFL4JCHZjcnj7OkNY90gL6/icnf7ZWpg TU1yn7tzNDw4S4697lxtKycJhoPVhWGg+OO4Lrp/ozQGyzPvmwGrtwNzCYxIvnDR xSnFBvc3cc28W+UjU9MQYQiL1ys0r0dM6C66ZRhr/bPgK49y4qEGrzetHL9Fd5yV CU7f9xd2ZmMuvjqQsoBJsYP8cpNPnAAd1IzWxcKioOYC2fRrAkEmDNLC5TB/4le4 cwyhN6DvYMRIThHp5LZjDhDid3fVhqmnalC4NGz3ATTsVTJ58MIJX18RcmtqUpAQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 09:37:12 -0400 (EDT) Date: Fri, 21 May 2021 09:37:10 -0400 From: Leo Famulari Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf88qm47.fsf_-_@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thanks for the review. On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > > +(define (run-system-administration-cbt-page) > > + "Run a page to select various system adminstration services." > > + (let ((items (filter (lambda (service) > > + (eq? 'administration > > + (system-service-type service))) > > + %system-services))) > > + (run-checkbox-tree-page > > + #:title (G_ "Miscellaneous services") > > + #:info-text (G_ "Select miscellaneous services to run on your system.") > > + #:items items > > + #:selection (map system-service-recommended? items) > > + #:item->text (compose G_ system-service-name) > > + #:checkbox-tree-height 5 > > + #:exit-button-callback-procedure > > + (lambda () > > + (raise > > + (condition > > + (&installer-step-abort))))))) > > Indentation is off here, > > > + ;; Miscellaneous system administration services. > > + (system-service > > + (name (G_ "Network time service, to set the clock automatically")) > > + (type 'administration) > > + (recommended? #t) > > + (snippet '((service ntp-service-type)))) > > + > > here, > > > + (system-service > > + (name (G_ "GPM mouse daemon, to use the mouse in the console")) > > + (type 'administration) > > + (snippet '((service gpm-service-type)))) > > and here. I don't see the problems. I copied from existing pieces of similar code and I don't really have a sense of what's right and wrong for indenting this kind of thing. > Those patches are breaking the installer tests because they > introduce a new dialog. You need to add something like: > > --8<---------------cut here---------------start------------->8--- > ((checkbox-list (title "Miscellaneous services") (text _) > (items ,services)) > (filter choose-misc-service? services)) > --8<---------------cut here---------------end--------------->8--- > > in the (gnu installer tests) module, to fix this error: Okay, I'll work on that. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162160692420943 (code B ref 47979); Fri, 21 May 2021 14:23:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:22:04 +0000 Received: from localhost ([127.0.0.1]:37331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk62O-0005Rj-Fu for submit@debbugs.gnu.org; Fri, 21 May 2021 10:22:04 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk62I-0005R7-AG for 47979@debbugs.gnu.org; Fri, 21 May 2021 10:22:02 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 234885C00E3; Fri, 21 May 2021 10:21:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 21 May 2021 10:21:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=+x9ToePeom6NI8RZLtXZw7Vs cKyQCZgQ33CXDnrOa18=; b=uD5YL8n0NEAzEMZDqfcIRH++o9hdpkNG4KlWoOoV KyqIvZzOe99btUqfA5YyHogX/HUFba6ZO7aXeqaedTR5t5JIai9yMnsI5j1mGeWD ToFVho2n3IGfCtt5Dz+2ufY9GJMUDxgbFLy1ZnTHXSQrqguNt9/BW89U4JOP1mLb 4t0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+x9Toe Peom6NI8RZLtXZw7VscKyQCZgQ33CXDnrOa18=; b=q6ihuvmWQmNIyohbRD3dw0 g2zOk/zRNQfVx6JbuDFtwmMQn+fEed1CjDHt2LWFrHdiItPbRQ5r0+5XPi+/Ocse j4vrczOHyvE0+CI3UlmKMxwZh348DJr5uxWhQjz6gIKl3mkhOUv178ssT560OUoE vGmzAiarwkKSs02GsLbcQBkOYAy0Q4nvOnnggkumqpw41bU1UcitubnUDIYFQnh3 VrKdbKx6cv+pBbRDyiDr6+7e2a9Esp+Vz7PeBvK14nZs+TPoNZMkSzeYMK3JWOBm lEqifCWnZbE/AHbypExkiopCz54FJqxHT2j1J4qhBr7gAuQ9zHixEhHWewEEOelw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 10:21:52 -0400 (EDT) Date: Fri, 21 May 2021 10:21:50 -0400 From: Leo Famulari Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf88qm47.fsf_-_@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > Those patches are breaking the installer tests because they > introduce a new dialog. You need to add something like: > > --8<---------------cut here---------------start------------->8--- > ((checkbox-list (title "Miscellaneous services") (text _) > (items ,services)) > (filter choose-misc-service? services)) > --8<---------------cut here---------------end--------------->8--- > > in the (gnu installer tests) module, to fix this error: How do I run this test? I can never figure out the names of the tests used by `make check-system`... From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162160717221370 (code B ref 47979); Fri, 21 May 2021 14:27:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:26:12 +0000 Received: from localhost ([127.0.0.1]:37347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk66O-0005Yc-1D for submit@debbugs.gnu.org; Fri, 21 May 2021 10:26:12 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk66L-0005YO-Hn for 47979@debbugs.gnu.org; Fri, 21 May 2021 10:26:10 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 786C35C013A; Fri, 21 May 2021 10:26:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 21 May 2021 10:26:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=MaDnaj3xHh95buBiAOq8pGGs lkjOH6s3RUzya82lzSw=; b=r7JzDchOBdJNQUcxVJfUXnuSoTjHYBCEWnQ2IVHV Nwog+Vxb8DZFU7PHy4tDlYIb7ThYgJ4A52qaTHDFxjEW7R/M3EGqTn2p1uEdtm1K YlDoaHhw+zMQ7sFMknKYcIwFAupvMSsW9oki0Z0FMc8r7gSg+fpIMLouHzFYWNVI Axo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MaDnaj 3xHh95buBiAOq8pGGslkjOH6s3RUzya82lzSw=; b=Rm5BtIUH6eSiT2JB0g0Fga dIAZBbfu8+UYMrHGTQnvMK0k5AmHbW/ntCQjPJEK5+I9vSbrD6ugJYjRHiXdlXF1 vIUmpW0Ak9AU86+t+kT+552MZ6KEQ1WxBbL8Z03eN18n0rxePzmLEXGXhtOAtQ5t iYUhCo6WCj11C8AbOr/nCbBf0yR3VJcguUEUTo3Q9ZDHs8O91X3UqCTUhwyeOIb8 8ah4xunemr5SX1e8wdVUz8DlYt0jS0lwPu8N1DMx5ujbQBc1X3RyP669PMPq0wWO 1pbVfgH5ZIfOfDCaIJvy+MSphazE3MTxjzkh0nLwD34Ev2qcRcHZ2u+lpiWUgjLg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 10:26:04 -0400 (EDT) Date: Fri, 21 May 2021 10:26:02 -0400 From: Leo Famulari Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, May 21, 2021 at 10:21:50AM -0400, Leo Famulari wrote: > On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > > Those patches are breaking the installer tests because they > > introduce a new dialog. You need to add something like: > > > > --8<---------------cut here---------------start------------->8--- > > ((checkbox-list (title "Miscellaneous services") (text _) > > (items ,services)) > > (filter choose-misc-service? services)) > > --8<---------------cut here---------------end--------------->8--- > > > > in the (gnu installer tests) module, to fix this error: > > How do I run this test? I can never figure out the names of the tests > used by `make check-system`... With informed use of grep I found it: `make check-system TESTS=iso-image-installer`. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162160799022705 (code B ref 47979); Fri, 21 May 2021 14:40:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:39:50 +0000 Received: from localhost ([127.0.0.1]:37366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk6Ja-0005u9-0K for submit@debbugs.gnu.org; Fri, 21 May 2021 10:39:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk6JW-0005tu-Fo for 47979@debbugs.gnu.org; Fri, 21 May 2021 10:39:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45516) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk6JR-0006dt-9B; Fri, 21 May 2021 10:39:41 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=51890 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk6JQ-000139-RT; Fri, 21 May 2021 10:39:41 -0400 From: Mathieu Othacehe References: <87lf88qm47.fsf_-_@gnu.org> Date: Fri, 21 May 2021 16:39:39 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 21 May 2021 10:21:50 -0400") Message-ID: <875yzcqhg4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > How do I run this test? I can never figure out the names of the tests > used by `make check-system`... The installer tests are defined in the (gnu tests install) module. You can then search for "%test-gui" for all the graphical installation tests. You can run all of them by typing: --8<---------------cut here---------------start------------->8--- make check-system TESTS="gui-installed-os gui-uefi-installed-os gui-installed-os-encrypted gui-installed-desktop-os-encrypted" --8<---------------cut here---------------end--------------->8--- Fixing the "gui-installed-os" test should be enough to fix all of them though. Thanks, Mathieu From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162163091013344 (code B ref 47979); Fri, 21 May 2021 21:02:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 21:01:50 +0000 Received: from localhost ([127.0.0.1]:37872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCHF-0003T9-M9 for submit@debbugs.gnu.org; Fri, 21 May 2021 17:01:50 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCHA-0003Sq-FA for 47979@debbugs.gnu.org; Fri, 21 May 2021 17:01:47 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7BC195C0097; Fri, 21 May 2021 17:01:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 21 May 2021 17:01:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=K8gOh46n6CfCh2yqokan4D7q E715S4XI0Ui+TTKhbpE=; b=FsNjUIiDX0lgbp2qavGDCl+YkPsh9v3Ux6zA6VfD xorHg/Tt8adIW7PKtPEA9FyVx3Z6lwRcNwL7/Zq76vJMsCylSJWCyxymd6kito75 xm06KgGFSNIPUv5V5IZD9AIqxpApTpsqDboz/rt7j5Gp63CfMRtCZGaer0mCktVj Of8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=K8gOh4 6n6CfCh2yqokan4D7qE715S4XI0Ui+TTKhbpE=; b=q0yweQqPHP09p+zokOVt1e qVq/MJ9wrLswa40el6HWIxE4U7m0AN58WNPBAMmaR5pxQz2DcLYEpgntsykAlKO6 izZSBcqA7Et/tHZ12Obq98juU0JDzXrKdgzrOT0ZcjbiMhB7PJwvHno8DQJVscdm psGJEVBMdAZnieMEZE7AHKLc5JuiJKA0gW+dFD8IqCpWZvbKfhFiRZuZ0S46TVuD 3Y3pnyrMzr9y8Pv2GSafjU92/AzYOblA9JR7iOQKnmTC08HxlVL9ASXwkK6w4dfu gNVxI8a/uqVPs7dWoUY+vIIt4YKUf9XWD2zbGj9+kEYaXCYLh9Jthi/D6SKuu/0g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudekveegteekleetgfeitdejgfejkeffudethedvhfeukeduleeikeejfeeh ffetnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 17:01:38 -0400 (EDT) Date: Fri, 21 May 2021 17:01:36 -0400 From: Leo Famulari Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QMnDj7+gJPBXmqal" Content-Disposition: inline In-Reply-To: <87lf88qm47.fsf_-_@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --QMnDj7+gJPBXmqal Content-Type: multipart/mixed; boundary="M/5A9YxJzre/T287" Content-Disposition: inline --M/5A9YxJzre/T287 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > Those patches are breaking the installer tests because they > introduce a new dialog. You need to add something like: >=20 > --8<---------------cut here---------------start------------->8--- > ((checkbox-list (title "Miscellaneous services") (text _) > (items ,services)) > (filter choose-misc-service? services)) > --8<---------------cut here---------------end--------------->8--- >=20 > in the (gnu installer tests) module, to fix this error: I started implementing this, in the attached v4 patch series. I tried copying existing code, e.g. the choose-network-service? part of the tests. However, it now crashes in a different way when I do `guix environment guix -- make check-system TESTS=3Dgui-installed-os -j1`: ------ [...] building /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.dr= v... -builder for `/gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.= xz.drv' failed to produce output path `/gnu/store/f99fblkzb6ip268sg096shhs7= wzjyp55-Python-3.5.9.tar.xz' build of /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.dr= v failed View build log at '/var/log/guix/drvs/fr/1m1ydzpylhm9psk4y9kavk8qb6maq5-Pyt= hon-3.5.9.tar.xz.drv.bz2'. cannot build derivation `/gnu/store/s7q1xs3mkld23v8541bvrzmq5j5xw5ad-Python= -3.5.9.tar.xz.drv': 1 dependencies couldn't be built=20 building /gnu/store/1nnawddi9gw8k71figgphhrpn86dzsxl-activate-service.scm.d= rv... cannot build derivation `/gnu/store/l2f280iinh1hfp19k49r9vlhnbmbbss8-python= -minimal-3.5.9.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/k43m6gi372wzwz0xir1axms8vp2jyv1c-glibc-= 2.31.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.= 2.8p15.drv': 1 dependencies couldn't be built=20 cannot build derivation `/gnu/store/b1py4d1j3ym2k69zbzi0r3hh08afxkn9-shephe= rd-ntpd.scm.drv': 1 dependencies couldn't be built=20 cannot build derivation `/gnu/store/mf7gj4cn0cb9ml3c4v1n1kg1293jjp57-shephe= rd-ntpd.go.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/gs4kgf2x2syj64zf6s2r02sclffmf48n-shephe= rd.conf.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/dy6w4vsvrxzsq9hg8pj7731k6p0z90cg-boot.d= rv': 1 dependencies couldn't be built building /gnu/store/15j31c7b2kc4hf03yxpqjsibgkyi40rv-module-import-compiled= =2Edrv... cannot build derivation `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system= =2Edrv': 1 dependencies couldn't be built=20 guix system: error: build of `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-s= ystem.drv' failed conversation expecting pCommand failed with exit code 1. =20 = =20 Press Enter to continue. = =20 attern ((quote installation-complete)) = =20 May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been stopped= =2E=20 May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been started= =2E=20 May 21 22:47:27 localhost installer[219]: command ("guix" "system" "init" "= --fallback" "--no-grafts" "--no-substitutes" "/mnt/etc/config.scm" "/mnt") = failed with exit code 1 =20 May 21 22:47:27 localhost installer[183]: unmounting "/mnt/" =20 /gnu/store/5fwnbmlfq6bp37n94j36jdcfapm0mhbz-shepherd-marionette.scm:1:1718:= ERROR: = =20 1. &pattern-not-matched: = =20 pattern: ((quote installation-complete)) = =20 sexp: (installation-failure) = =20 Backtrace: = =20 2 (primitive-load "/gnu/store/gpxpcz96pdckj3a69q5cjzxaxq5?") = =20 In ice-9/eval.scm: = =20 191:35 1 (_ #f) = =20 619:8 0 (_ #(# #)) ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((q= uote (complete-installation installer-socket)))'. note: keeping build directory `/tmp/guix-build-installation.drv-8' builder for `/gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv' = failed with exit code 1 build of /gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv failed View build log at '/var/log/guix/drvs/np/hpbnbm3z6xaq8fvl91ihh66n9hhm9m-ins= tallation.drv.gz'. cannot build derivation `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-in= stalled-os.drv': 1 dependencies couldn't be built guix build: error: build of `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gu= i-installed-os.drv' failed make: *** [Makefile:6859: check-system] Error 1 ------ I'm a little lost... --M/5A9YxJzre/T287 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename*0="v4-installer-Recommend-ntp-service-for-non-graphical-systems."; filename*1=patch Content-Transfer-Encoding: quoted-printable =46rom ef1dfe36130fa276ce1b2a4213cde14d649bfbf8 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 14:50:15 -0400 Subject: [PATCH v4 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems. We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. * gnu/installer/tests.scm (choose-services): Add and use a choose-misc-service? procedure. --- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 11 +++++++++-- 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.= scm index 74f28e41ba..ee003b24b1 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright =A9 2021 Tobias Geerinckx-Rice +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) =20 +(define (run-system-administration-cbt-page) + "Run a page to select various system adminstration services." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Miscellaneous services") + #:info-text (G_ "Select miscellaneous services to run on your system= =2E") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-system-administration-cbt-page)) '())))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..1dae40daec 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright =A9 2018 Mathieu Othacehe ;;; Copyright =A9 2019 Ludovic Court=E8s ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =A9 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) =20 + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service (NTP), to set the clock automatical= ly")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 8ccd327a7c..7a4989ef88 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -220,7 +220,11 @@ ROOT-PASSWORD, and USERS." (string-contains service "NSS")))) (choose-network-management-tool? (lambda (service) - (string-contains service "DHCP")))) + (string-contains service "DHCP"))) + (choose-misc-service? + (lambda (service) + (string-contains service "NTP")))) + "Converse over PORT to choose networking services." (define desktop-environments '()) =20 @@ -240,7 +244,10 @@ ROOT-PASSWORD, and USERS." (multiple-choices? #f) (items ,services)) (null? desktop-environments) - (find choose-network-management-tool? services)))) + (find choose-network-management-tool? services)) + ((checkbox-list (title "Miscellaneous services") (text _) + (items ,services)) + (filter choose-misc-service? services)))) =20 (define (edit-configuration-file file) "Edit FILE, an operating system configuration file generated by the --=20 2.31.1 =46rom 8fa2cd50e36835358c0533ded36674d5499b76fe Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 23 Apr 2021 20:42:28 -0400 Subject: [PATCH v4 2/2] installer: Offer 'gpm-service-type' for non-graphic= al systems. * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 1dae40daec..91b22c6f19 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) =20 ;; Network connectivity management. (system-service --=20 2.31.1 --M/5A9YxJzre/T287-- --QMnDj7+gJPBXmqal Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoH6kACgkQJkb6MLrK fwhtUA//SbL8Bvwk6597+T4davhVCnn2B3aGGdEog14jLZAKJaD7bvOcaj/S2yYo QX1eQdaiYPJZbxYGx3DsgpqU4urlGb10XQGAhU6GGZs0yTYD8Ez0VLoNfMxL/1Oh D8mNmE+EN/1e7mgl+n7QubQWvb0p2k9VVKly3WGwLITc9ZNCPlD947zu8GC1ILp2 6KLqtDF9mQs0Aa6tkcPtr13dxg5sad5i9AeQzCIB9CpN96XCZgP0/xrSYMmKkCIy Vk5PC3yQ/gkf2SMx/kd+hEq5dvP/2MapAA5Fot3DaLGqQbi4AD1IbobJXPc6VfDQ DsxoxjBkfRJ7FNf+BdPanMR7zkV/SgNf/r4dY4+t5U8hhVcN9qdXbYDJaOyt+k3h T6gb3ETRTgUILPzb3VUS5AS6DKwTO0kvHgvB5lauSf7c/WLdJ74DVY4JNd62DjBr KLB6ukoQ/JzeB6htlGgJZp7o8YxyibfjtX8aEsbtZ5lKzDs8S5kIPUB0QytcPeOK rV3qDhrzOpgEbe85YVimvtbsTGoQzjLDfyXVAEXCCJqx1nlSepIglDQBSHdwylfL DKRVOUukFTtEuu1LJ1FEhzSEpZxNrJFnxhy8f6NgIqgib0gBlWEDJoABQWqN8CjX M9Wt8CTqvkssAzEasnciuG3MKkirpEQDjA/h+6dWDPW/4ilQyog= =ZZo3 -----END PGP SIGNATURE----- --QMnDj7+gJPBXmqal-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162163348717622 (code B ref 47979); Fri, 21 May 2021 21:45:02 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 21:44:47 +0000 Received: from localhost ([127.0.0.1]:37958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCwo-0004aA-OE for submit@debbugs.gnu.org; Fri, 21 May 2021 17:44:46 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCwm-0004Zv-HQ for 47979@debbugs.gnu.org; Fri, 21 May 2021 17:44:45 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 67D7F5C0268; Fri, 21 May 2021 17:44:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 21 May 2021 17:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=hWdhPHlPfOVlFdvIj7DoY+qR hXpOx/YsuYdW8sLk1Z4=; b=uwaptQQvFV5iVMtw0TiIcZL3ZiDtwSaciVa1rYiN qCzH9yPcgBBAHVmRT7Su6TMPn+6vXMubeMrRvhmVJu8VIjY+mESq1OtQHVGWbE8s i54QP2BwV9bumHo/4aAUgxttiPXP159GKaUM8GDex1YmMpoIbGIJjyieDtkBHmB+ sUI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hWdhPH lPfOVlFdvIj7DoY+qRhXpOx/YsuYdW8sLk1Z4=; b=dIt0LR4tiFyN2oO318s+9W jTieAqt/0HoEavdmvfw40bnkGS5Diz952HI8xALlHFMNAkGkCBu9xDtQQy9OABiY A5mQ4YQ5Yz1eYH7fJbFulYzdY3GA6143IOpp+ZYat8AnbqQvjAinIO7+sCcbPQB1 xGJp/cwU1c/yjzPY16HjPAuOxGqPR2oY98Tt/e81obZVAlea8RsrZJhhc02b21dv mu9OF3fRPLzwTw3BuHNidwyvdOxrgduQuZftx88srDoCMSm+Gfp+kegUEtvZ+qqm teC9eNPHDuhnAqMCRBSmiXZFrq/OiAEyFc+a2+FSCv3w99UHGyJl7MPXH6cV6Tig == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejgedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 17:44:39 -0400 (EDT) Date: Fri, 21 May 2021 17:44:37 -0400 From: Leo Famulari Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c75BJIcHFU95R+h6" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --c75BJIcHFU95R+h6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 21, 2021 at 05:01:36PM -0400, Leo Famulari wrote: > I tried copying existing code, e.g. the choose-network-service? > part of the tests. The tests succeed when I amend the v4 patch to do "(choose-misc-service? (const #f))" in (gnu installer tests). I'm not really sure what it means :/ --c75BJIcHFU95R+h6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoKcUACgkQJkb6MLrK fwgfvw/+IKIrxmjP/nRSn9pwy0XzRa7znPfm37IJXmuv5LfCvG05p2fkCsL4rN97 bBZJgY0Q5k1/T1PLRC8PmmRvEgkzmibwYn42HPkWsXng+DDnhptipUvvRvF74vqA xnhV+R4D81oaox1bpwQd9aFJW0gOhXsMzz47t77RDSL1jxnYJK9LM7fBqKfIc3MU KkaUofqZPs+8Xg5IkiHx2RZraqlhHeyijj+jtELoOQd6/3UCfcdY4Plqw29hYDNH gmvdvufVIhBNFWvUJ96mFg7pgiJUSqL0M8AaKtUn6IdReQjreaPYPi+KwltPVoPg scWRN6OlAxq8JItI8ghBM0V1RpNk5Ur/VlzDnxXtFdnU/ftlaTajAAtEIFjHAQdH 7UVCqbzTEfitzEXbmH1im93tv65Pce7Aouv9nqOq7QCvkd3WdfuhcYFsiEoSw42T IeR9xtQDxdlqJe28lEowAUn1e/0KidhmhtL8mlndjbrMU+2R7iaVlZHfKloBKpi4 mTJBZDdiT3qzbrOWy1al6RREBD750W0BI5HzzRKnFj+JiVmv+ZFk7PvxnKwaukBa 6sku5SxO4y3nCANg72iI1snk0eUgbLurauNayFymsP+yXAfdGPr0M1G935V7EhBz 05b+KVw2UXnjUKAl9AOvdfORDf3c7vwfX/jsBW24QA14E9Sk1hM= =2QD0 -----END PGP SIGNATURE----- --c75BJIcHFU95R+h6-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162254102024575 (code B ref 47979); Tue, 01 Jun 2021 09:51:01 +0000 Received: (at 47979) by debbugs.gnu.org; 1 Jun 2021 09:50:20 +0000 Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12R-0006OI-Qx for submit@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12O-0006Nx-E2 for 47979@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo12I-0006w2-RE; Tue, 01 Jun 2021 05:50:10 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=45336 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo127-0006tq-LU; Tue, 01 Jun 2021 05:50:10 -0400 From: Mathieu Othacehe References: <87lf88qm47.fsf_-_@gnu.org> Date: Tue, 01 Jun 2021 11:49:55 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 21 May 2021 17:01:36 -0400") Message-ID: <87tumh6hj0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Leo, > cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built The installation tests are run in a network isolated environment. This means that we need to make sure that every single derivation that will be needed during the installation is made available. It is for sure a tricky business. If you have a look to the error line I pasted above, you will see that the installer tries to build the ntp package because the ntp-service-type is now included. The following patch fixes the "gui-installed-os" test by making sure that the ntp package is available in the installation environment. I did not check for the other installation tests. --8<---------------cut here---------------start------------->8--- diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index b5263f5f0d..e9ebc63b64 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1608,8 +1608,9 @@ build (current-guix) and then store a couple of full system images.") (swap-devices (if encrypted? '() (list (uuid "11111111-2222-3333-4444-123456789abc")))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 10 04:30:08 2021 Received: (at control) by debbugs.gnu.org; 10 Jun 2021 08:30:08 +0000 Received: from localhost ([127.0.0.1]:35423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrG4m-0000sR-Jn for submit@debbugs.gnu.org; Thu, 10 Jun 2021 04:30:08 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:32611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrG4l-0000qU-0k for control@debbugs.gnu.org; Thu, 10 Jun 2021 04:30:07 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3Ahi1Vo62wEPaeNeQt2ym0UQqjBNYkLtp133Aq?= =?us-ascii?q?2lEZdPUzSKylfhuV/cjzuiWetN98Yh0dcQPpAse9qA3nn6KdiLN5VYtKNzOIhI?= =?us-ascii?q?LHFuxf0bc=3D?= X-IronPort-AV: E=Sophos;i="5.83,263,1616454000"; d="scan'208";a="384032736" Received: from unknown (HELO ribbon) ([193.50.110.80]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 10:29:40 +0200 Date: Thu, 10 Jun 2021 10:29:40 +0200 Message-Id: <8735tqazrf.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #47979 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) severity 47979 important quit From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v5] gnu: binutils: Fix CVE-2021-45078. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164036907218923 (code B ref 47979); Fri, 24 Dec 2021 18:05:01 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Dec 2021 18:04:32 +0000 Received: from localhost ([127.0.0.1]:38004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ovf-0004v6-Ji for submit@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:32 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:54097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ovb-0004uq-OG for 47979@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:30 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A3587320148A; Fri, 24 Dec 2021 13:04:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 24 Dec 2021 13:04:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=RP/bYKTdaTZFcLpEDa7uhxv iiGzaaJrMSUmV7nT28a8=; b=zU00uGm+natB2cZcV4brDKW8ijP3oiTIj5Piy3E 1wWoRooEZithD1f3Grh8edRF8tNE00yaCPnL1/FYpSaJSb32NGj1clzFKdtjAAWU csWwnVmU5Ad177CfNg60torY6iiyZyemmqLGR09v0JprK8VevmrIWF12RNKew0au xvtk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=RP/bYKTdaTZFcLpED a7uhxviiGzaaJrMSUmV7nT28a8=; b=kDAvKLa5MjWpX7NudNlfIomjST6rwd5FK 5J8aM2ARdUgvncEA5r3Eq3NWhVM7rhYPGS6gXLd7p7lH9v26idSGo47yeZORlHDy g/kYEMwi+LCyprJ6DtJmi72xpALBaY9xEqzedq39rSYvcUvL4JuP4h/45L9jMjG8 EAqcow57BNAkTp4b7vmhDchzqyfVogjMUGS3rczIzWXdZtPb9Q3dItsHCqHt1dg1 oOfHU4kouRk+WG03jaOBmAvfKrd2+mI/L92EB0icTwEUTTpJ9A31r7bNLU6tQHCs 6LkLF4nuj2Mhg8xoDMh24D3v2Vpt8lyeQtgS9AVAL8u+PjdnijJsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeekgeehfeefffeiuefhgeelieevveelie duveffteelgefhgeehhfekhedvtdegjeenucffohhmrghinhepmhhithhrvgdrohhrghdp shhouhhrtggvfigrrhgvrdhorhhgpdhtvgigihhnfhhordhnrghmvgenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghr ihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Fri, 24 Dec 2021 13:04:20 -0500 (EST) From: Leo Famulari Date: Fri, 24 Dec 2021 13:04:15 -0500 Message-Id: <802baa40ed72d1020c15226ec295187bbb1565be.1640369055.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/patches/binutils-CVE-2021-45078.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/base.scm (binutils)[source]: Use it. --- gnu/local.mk | 1 + gnu/packages/base.scm | 3 +- .../patches/binutils-CVE-2021-45078.patch | 257 ++++++++++++++++++ 3 files changed, 260 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/binutils-CVE-2021-45078.patch diff --git a/gnu/local.mk b/gnu/local.mk index aa0117a3f5..546b940eb6 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -906,6 +906,7 @@ dist_patch_DATA = \ %D%/packages/patches/binutils-loongson-workaround.patch \ %D%/packages/patches/binutils-mingw-w64-timestamp.patch \ %D%/packages/patches/binutils-mingw-w64-deterministic.patch \ + %D%/packages/patches/binutils-CVE-2021-45078.patch \ %D%/packages/patches/blender-2.79-gcc8.patch \ %D%/packages/patches/blender-2.79-gcc9.patch \ %D%/packages/patches/blender-2.79-newer-ffmpeg.patch \ diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index 12e4de52d4..be6fbf608d 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -521,7 +521,8 @@ (define-public binutils (sha256 (base32 "1m3b2rdfv1dmdpd0bzg1hy7i8a2qng53szc6livyi3nh6101mz37")) (patches (search-patches "binutils-loongson-workaround.patch" - "binutils-2.37-file-descriptor-leak.patch")))) + "binutils-2.37-file-descriptor-leak.patch" + "binutils-CVE-2021-45078.patch")))) (build-system gnu-build-system) (arguments `(#:configure-flags '(;; Add `-static-libgcc' to not retain a dependency diff --git a/gnu/packages/patches/binutils-CVE-2021-45078.patch b/gnu/packages/patches/binutils-CVE-2021-45078.patch new file mode 100644 index 0000000000..fca692bdb5 --- /dev/null +++ b/gnu/packages/patches/binutils-CVE-2021-45078.patch @@ -0,0 +1,257 @@ +Fix CVE-2021-45078 (incomplete fix for CVE-2018-12699): + +https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45078 +https://sourceware.org/bugzilla/show_bug.cgi?id=28694 + +Patch copied from upstream source repository: + +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=161e87d12167b1e36193385485c1f6ce92f74f02 + +From 161e87d12167b1e36193385485c1f6ce92f74f02 Mon Sep 17 00:00:00 2001 +From: Alan Modra +Date: Wed, 15 Dec 2021 11:48:42 +1030 +Subject: [PATCH] PR28694, Out-of-bounds write in stab_xcoff_builtin_type + + PR 28694 + * stabs.c (stab_xcoff_builtin_type): Make typenum unsigned. + Negate typenum earlier, simplifying bounds checking. Correct + off-by-one indexing. Adjust switch cases. +--- + binutils/stabs.c | 87 ++++++++++++++++++++++++------------------------ + 1 file changed, 43 insertions(+), 44 deletions(-) + +diff --git a/binutils/stabs.c b/binutils/stabs.c +index 274bfb0e7fa..83ee3ea5fa4 100644 +--- a/binutils/stabs.c ++++ b/binutils/stabs.c +@@ -202,7 +202,7 @@ static debug_type stab_find_type (void *, struct stab_handle *, const int *); + static bool stab_record_type + (void *, struct stab_handle *, const int *, debug_type); + static debug_type stab_xcoff_builtin_type +- (void *, struct stab_handle *, int); ++ (void *, struct stab_handle *, unsigned int); + static debug_type stab_find_tagged_type + (void *, struct stab_handle *, const char *, int, enum debug_type_kind); + static debug_type *stab_demangle_argtypes +@@ -3496,166 +3496,167 @@ stab_record_type (void *dhandle ATTRIBUTE_UNUSED, struct stab_handle *info, + + static debug_type + stab_xcoff_builtin_type (void *dhandle, struct stab_handle *info, +- int typenum) ++ unsigned int typenum) + { + debug_type rettype; + const char *name; + +- if (typenum >= 0 || typenum < -XCOFF_TYPE_COUNT) ++ typenum = -typenum - 1; ++ if (typenum >= XCOFF_TYPE_COUNT) + { +- fprintf (stderr, _("Unrecognized XCOFF type %d\n"), typenum); ++ fprintf (stderr, _("Unrecognized XCOFF type %d\n"), -typenum - 1); + return DEBUG_TYPE_NULL; + } +- if (info->xcoff_types[-typenum] != NULL) +- return info->xcoff_types[-typenum]; ++ if (info->xcoff_types[typenum] != NULL) ++ return info->xcoff_types[typenum]; + +- switch (-typenum) ++ switch (typenum) + { +- case 1: ++ case 0: + /* The size of this and all the other types are fixed, defined + by the debugging format. */ + name = "int"; + rettype = debug_make_int_type (dhandle, 4, false); + break; +- case 2: ++ case 1: + name = "char"; + rettype = debug_make_int_type (dhandle, 1, false); + break; +- case 3: ++ case 2: + name = "short"; + rettype = debug_make_int_type (dhandle, 2, false); + break; +- case 4: ++ case 3: + name = "long"; + rettype = debug_make_int_type (dhandle, 4, false); + break; +- case 5: ++ case 4: + name = "unsigned char"; + rettype = debug_make_int_type (dhandle, 1, true); + break; +- case 6: ++ case 5: + name = "signed char"; + rettype = debug_make_int_type (dhandle, 1, false); + break; +- case 7: ++ case 6: + name = "unsigned short"; + rettype = debug_make_int_type (dhandle, 2, true); + break; +- case 8: ++ case 7: + name = "unsigned int"; + rettype = debug_make_int_type (dhandle, 4, true); + break; +- case 9: ++ case 8: + name = "unsigned"; + rettype = debug_make_int_type (dhandle, 4, true); + break; +- case 10: ++ case 9: + name = "unsigned long"; + rettype = debug_make_int_type (dhandle, 4, true); + break; +- case 11: ++ case 10: + name = "void"; + rettype = debug_make_void_type (dhandle); + break; +- case 12: ++ case 11: + /* IEEE single precision (32 bit). */ + name = "float"; + rettype = debug_make_float_type (dhandle, 4); + break; +- case 13: ++ case 12: + /* IEEE double precision (64 bit). */ + name = "double"; + rettype = debug_make_float_type (dhandle, 8); + break; +- case 14: ++ case 13: + /* This is an IEEE double on the RS/6000, and different machines + with different sizes for "long double" should use different + negative type numbers. See stabs.texinfo. */ + name = "long double"; + rettype = debug_make_float_type (dhandle, 8); + break; +- case 15: ++ case 14: + name = "integer"; + rettype = debug_make_int_type (dhandle, 4, false); + break; +- case 16: ++ case 15: + name = "boolean"; + rettype = debug_make_bool_type (dhandle, 4); + break; +- case 17: ++ case 16: + name = "short real"; + rettype = debug_make_float_type (dhandle, 4); + break; +- case 18: ++ case 17: + name = "real"; + rettype = debug_make_float_type (dhandle, 8); + break; +- case 19: ++ case 18: + /* FIXME */ + name = "stringptr"; + rettype = NULL; + break; +- case 20: ++ case 19: + /* FIXME */ + name = "character"; + rettype = debug_make_int_type (dhandle, 1, true); + break; +- case 21: ++ case 20: + name = "logical*1"; + rettype = debug_make_bool_type (dhandle, 1); + break; +- case 22: ++ case 21: + name = "logical*2"; + rettype = debug_make_bool_type (dhandle, 2); + break; +- case 23: ++ case 22: + name = "logical*4"; + rettype = debug_make_bool_type (dhandle, 4); + break; +- case 24: ++ case 23: + name = "logical"; + rettype = debug_make_bool_type (dhandle, 4); + break; +- case 25: ++ case 24: + /* Complex type consisting of two IEEE single precision values. */ + name = "complex"; + rettype = debug_make_complex_type (dhandle, 8); + break; +- case 26: ++ case 25: + /* Complex type consisting of two IEEE double precision values. */ + name = "double complex"; + rettype = debug_make_complex_type (dhandle, 16); + break; +- case 27: ++ case 26: + name = "integer*1"; + rettype = debug_make_int_type (dhandle, 1, false); + break; +- case 28: ++ case 27: + name = "integer*2"; + rettype = debug_make_int_type (dhandle, 2, false); + break; +- case 29: ++ case 28: + name = "integer*4"; + rettype = debug_make_int_type (dhandle, 4, false); + break; +- case 30: ++ case 29: + /* FIXME */ + name = "wchar"; + rettype = debug_make_int_type (dhandle, 2, false); + break; +- case 31: ++ case 30: + name = "long long"; + rettype = debug_make_int_type (dhandle, 8, false); + break; +- case 32: ++ case 31: + name = "unsigned long long"; + rettype = debug_make_int_type (dhandle, 8, true); + break; +- case 33: ++ case 32: + name = "logical*8"; + rettype = debug_make_bool_type (dhandle, 8); + break; +- case 34: ++ case 33: + name = "integer*8"; + rettype = debug_make_int_type (dhandle, 8, false); + break; +@@ -3664,9 +3665,7 @@ stab_xcoff_builtin_type (void *dhandle, struct stab_handle *info, + } + + rettype = debug_name_type (dhandle, name, rettype); +- +- info->xcoff_types[-typenum] = rettype; +- ++ info->xcoff_types[typenum] = rettype; + return rettype; + } + +-- +2.27.0 + -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v5 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164036909318972 (code B ref 47979); Fri, 24 Dec 2021 18:05:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Dec 2021 18:04:53 +0000 Received: from localhost ([127.0.0.1]:38010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ow1-0004vr-84 for submit@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:53 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:43651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ovz-0004vb-Ah for 47979@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:51 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B2721320187F; Fri, 24 Dec 2021 13:04:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 24 Dec 2021 13:04:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=ITjdwy6X/ot6Wq7hPo7oPVE 0pyphwLn0/q/gZGuffxU=; b=gF1TsYDNOPmPOiKtE8mowT03SI7lTfwqVSKLKPv pmGvIVIPhAyJXWcItCRwOHLkrLqKf035AmPUvey503+P2SQF4P86MUBadjIczuuP Qemxkofq7QAZULBI94Qp0mpm5LZE/hklVAfCv8Ax1U9xUXUXFhcWLUPOM4mMb1ZI HMAI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ITjdwy 6X/ot6Wq7hPo7oPVE0pyphwLn0/q/gZGuffxU=; b=ZgikOMOQfsjgwHpCVVHwD9 7epr0bdYclhBPaa9/r2EyeN0SH7m8mkLiMSw1lvKs2IQgdDyRGCvk8TCY7abMV/D KkISDAWGZ9RaJFOuCAcoDba0MFExgb/xLnjQLEDxqClzefNSrjkvubtZtnp0Xbj7 N8aORf/5v2x5TYCEYr3frb4BZVNoAt0l1/ftGFuU/u2QFz6VuC31kQGv2iVIkVJr URfULp3/j22zJjXag8W+B/so601rbPoBbeYN27aS7MNIT+SS7takMJlNahyPyDfG K5+FusseT8t8eSL/Jlp6YtLuEBtL0ZxvPhVaeV963iTWUafVJybVMIHZtpt+hplA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre dtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfetjeetjedtfefggfelheevleejte fhleevveetkedtheeugedtgfekueekheejnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Fri, 24 Dec 2021 13:04:44 -0500 (EST) From: Leo Famulari Date: Fri, 24 Dec 2021 13:04:40 -0500 Message-Id: X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. * gnu/installer/tests.scm (choose-services): Add and use a choose-misc-service? procedure. * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add ntp-service-type. --- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 10 +++++++++- gnu/tests/install.scm | 5 +++-- 4 files changed, 42 insertions(+), 4 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index 1af4e7df2d..56cb3f6787 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -90,6 +91,25 @@ (define (run-other-services-cbt-page) (condition (&installer-step-abort))))))) +(define (run-system-administration-cbt-page) + "Run a page to select various system adminstration services." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Miscellaneous services") + #:info-text (G_ "Select miscellaneous services to run on your system.") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -121,6 +141,7 @@ (define (run-services-page) (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-system-administration-cbt-page)) '()) (run-other-services-cbt-page)))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 341d8b69c8..94c49307f0 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (define %system-services (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service (NTP), to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 12d1d91608..dc2371ce97 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -221,7 +221,11 @@ (define* (choose-services port (choose-network-management-tool? (lambda (service) (string-contains service "DHCP"))) - (choose-other-service? (const #f))) + (choose-other-service? (const #f)) + (choose-misc-service? + (lambda (service) + (string-contains service "NTP")))) + "Converse over PORT to choose services." (define desktop-environments '()) @@ -243,6 +247,10 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) + ((checkbox-list (title "Miscellaneous services") (text _) + (items ,services)) + (filter choose-misc-service? services)) + ((checkbox-list (title "Other services") (text _) (items ,services)) (filter choose-other-service? services)))) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 154f98b2e1..ae8c6051f1 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1685,8 +1685,9 @@ (define* (installation-target-os-for-gui-tests (list (swap-space (target (uuid "11111111-2222-3333-4444-123456789abc")))))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v5 2/2] installer: Offer 'gpm-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164036909718985 (code B ref 47979); Fri, 24 Dec 2021 18:05:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Dec 2021 18:04:57 +0000 Received: from localhost ([127.0.0.1]:38012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ow4-0004w9-RD for submit@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:57 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:54083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ow1-0004ve-0H for 47979@debbugs.gnu.org; Fri, 24 Dec 2021 13:04:53 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 618663201487; Fri, 24 Dec 2021 13:04:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 24 Dec 2021 13:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=teqBrmXr5h tyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=K5FuuSfwi96r/1ksszb5Y49wIR NeGTu9bfy+hN4eEXuY32ZdgSm9TmqwW1VfHxcMTuEFvsIN5J/a9genYNpUjyL0+0 TgnWcJW1Nd5G7CfDiKueGtvt1AZznSkf3+ZZO7AbnbyLk2Luf+eW6Whuig1GFTwk Tz6BiA5R5FoSXest8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=teqBrmXr5htyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=Sqt9iWuy FGwjb7Puoy+atxmkzGS6wNbaTnMs4650CFW8HWuLU3ORzICdRmBJb9xXPpSvT0eg GoBXJzaK5fy8R2LE7h4fbR80F9yZkwPZnX5Nj/6QWlFfdevdJZFM5/y5FdFRsubY ERoInWC0CYJSJHeX74emjmS0NEi9BgWxVrTGoyVjAWo2IUyArPhoeZWYadyDh1X1 JVaQfyidmKCw+pkiUQdszW6QCoaOfFI+mLjFU8jnaKPVNwuHaBXuRaeeOq8KS3IX kk4O7UzLNlFrZ/PD9L1XkJNb9sDNkKcpKk+2uaLlGNV5VW7N3O9jvF/mFdOhGnve gniPkeorKsKYaw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpefhgeegteeitddvudduveeuhedvhe fhfeehgfehvdfhudegueekhedvhfffhffhgeenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Fri, 24 Dec 2021 13:04:46 -0500 (EST) From: Leo Famulari Date: Fri, 24 Dec 2021 13:04:41 -0500 Message-Id: <3f4e7ef8e9e4088cd567d6c0b6d5effa7daf59c9.1640369080.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 94c49307f0..be6e75cbc4 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (define %system-services (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v5 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Cc: Tobias Geerinckx-Rice , Maxim Cournoyer Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164036966820119 (code B ref 47979); Fri, 24 Dec 2021 18:15:02 +0000 Received: (at 47979) by debbugs.gnu.org; 24 Dec 2021 18:14:28 +0000 Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0p5I-0005EQ-Am for submit@debbugs.gnu.org; Fri, 24 Dec 2021 13:14:28 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:34695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0p5C-0005Dt-JM for 47979@debbugs.gnu.org; Fri, 24 Dec 2021 13:14:23 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id A1E8C32009BB; Fri, 24 Dec 2021 13:14:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 24 Dec 2021 13:14:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=fRYY8zrUOcy9fYvXr4S52cFm YFG4IxUFZkGWCQpFt3E=; b=JtuR/wiLlzOWPyRFw4BwwwUWssyGBOCrxi3TSmGk qmsDh2t/1IIwhiYfw0IGEl8DCuO6OzjCbJ+mdZz0QAgZCgw4xF1ArAf2fjQs12sX dKvdn0dG/wXYk/chZZGzE3SmZaibsYd0EO+i3XjisyJaKD1iHq8Q1rw/wKR2qSNO lv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fRYY8z rUOcy9fYvXr4S52cFmYFG4IxUFZkGWCQpFt3E=; b=HpjFLahK3s6iS2bgUNUwkz DCFGRySojdexyUEBMAer9EaoqTwWh7AEn1YZU9Y5MyH1flP5Lea5PIMCAtv0282S s7Svc6qmtBV0NWtFSz9n3hd9dvlhNiBgkJi46nA/5ZUhM4qWz4VpQ+HhOmHKWASH wZ4h6ucA9L1GG9OjkK1kvguWgAgm/09huz9m6XvUD0nD/9jVPNKcD9wBhvYjN4sB 3VFvZm0wVnLi0CS6OmQGlxA4U6blRh50wh0+e/gllhyTAMGX2zXQlZrCARUImzQC IWhiXpI7cG9vkMLCvQ9ogqZxKU1Gh6hRj/O6EXtjLTEHAS4SlbjTKEaWBvjcUlhg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepffdvleethedtjeevueffgedvheehveevleduheevtddukeduheeggefgiedv vddvnecuffhomhgrihhnpehgnhhurdhorhhgpdhstghmrdhsohenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdr nhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Dec 2021 13:14:15 -0500 (EST) Date: Fri, 24 Dec 2021 13:14:13 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Dec 24, 2021 at 01:04:40PM -0500, Leo Famulari wrote: > We had several bug reports with a root cause of "the clock was > incorrect" from users who used the installer to install a non-graphical > Guix System. > > * gnu/installer/services.scm (%system-services): Add the ntp-service-type. > * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New > variable. > (run-services-page): Use run-system-administration-cbt-page when not > installing a desktop. > * gnu/installer/tests.scm (choose-services): Add and use a > choose-misc-service? procedure. > * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add > ntp-service-type. This v5 patch series is rebased on current master. It passes `make check-system TESTS="gui-installed-os"`. When a desktop environment is not selected, it adds a page to the installer suggesting NTP, and offering GPM (console mouse). I would have said that it's ready to go, but commit 6f13881f1e92 "installer: Offer the CUPS printing service." also added a page to the installer offering NTP, unconditionally. That is because the run-other-services page that it adds offers all recommended services. https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6f13881f1e92832023caadb3cb51ce393e685e58 However, that breaks the installation, because NTP is provided by %desktop-services, and services may not be duplicated in config.scm. So, we need to adjust the functionality added by 6f13881f1e92. I think we should only offer NTP when the user does not choose any desktops. If you'd like to test these patches, you can follow the steps described previously: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47979#14 I still think we need to ensure that NTP is either enabled or suggested for all installations. I remember the wave of bug reports due to "clock is wrong" after 1.3.0. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 1/3] installer: Offer the CUPS printing service on a dedicated page. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070530604 (code B ref 47979); Sun, 26 Dec 2021 20:32:01 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:45 +0000 Received: from localhost ([127.0.0.1]:41624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBF-0007xT-AM for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:45 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBD-0007xD-I4 for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:44 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3903E320024A; Sun, 26 Dec 2021 15:31:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 26 Dec 2021 15:31:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=V0WbCjdUKX2p+GUYhuVRuYT 7tbkIif30whujIQ0ciSI=; b=tG5IV57Wb+evocHpxVCmkrERi8JJ5iicPuyb1BL JRvHEPLLdT/ogwEsyPQTP1kOjBTCcaE3jeM2+aY3ZGDCYg/6imK9vt/sUljlEJHQ 2hhR2TDFm32UyxP6d7n7nXSkf5rLwG2c0ZZktUOlhfWnZDrVxdUyDa5+085eDjbN I1hc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=V0WbCjdUKX2p+GUYh uVRuYT7tbkIif30whujIQ0ciSI=; b=JymYSiMMSKttGfcDB7xFbFG7d/hPwGr6o iEnQRANixBaECM9JspXr05uYsjxj78fv5FYwKYLNFTawhw6uSQPs9Mq/sfd2R/wC Hdz3PhYDXgujy6B3bK29ZyZRdnP5bCPJgXTIDglUl0BbVmyLcTbp1DVD6bGRw9xd sKp45X2TwCO+YB3KeO4FG+hIhZTTeJf4sESwqvsmih60lEjn/TPweg1HqStaJTdz 2kP/Y+tW2H5KVX5De4VyfVJ0vXJ8qhPfMLWKXAHa50T03Qt6woBIfga3yMC+Nfs3 adb0uYrBFBmaJHEg0Aam/wB4PUlUi2fGyLckmOKCgdQDgQAr5x9xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepteeuiefgleehkeevffevteffueegueduvd egieffveekuefffeetuddvhffhudfhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:36 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:29 -0500 Message-Id: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Currently, this page of the installer offers to the user all installer services that are not of the types 'desktop', 'network-management', or 'networking'. Concretely, this means that it offers the CUPS printing service, because that is the only service of a different type defined in the installer. In later commits, we will add some services of a new type, and we only want them to be offered when the user is installing a non-graphical system. At least one of these new services (NTP) is part of %desktop-services. If it were offered on run-other-services-cbt-page, and the user had configured a system using %desktop-services, the user could accidentally add NTP to their services twice, which is an error and would break installation. So, this commit makes the run-other-services-cbt-page be more specific about what services to offer. This allows us to later create a new checkbox page that only runs when %desktop-services is not selected. * gnu/installer/newt/services.scm (run-other-services-cbt-page): Rename to ... (run-printing-services-cbt-page): ... new variable, and select only 'document' services. (run-services-page): Adjust accordingly. * gnu/installer/tests.scm (choose-services): Adjust accordingly. --- gnu/installer/newt/services.scm | 16 +++++++--------- gnu/installer/tests.scm | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index 1af4e7df2d..b4b5219b20 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -68,18 +68,16 @@ (define (run-networking-cbt-page) (condition (&installer-step-abort))))))) -(define (run-other-services-cbt-page) - "Run a page allowing the user to select other services." +(define (run-printing-services-cbt-page) + "Run a page allowing the user to select document services such as CUPS." (let ((items (filter (lambda (service) - (not (member (system-service-type service) - '(desktop - network-management - networking)))) + (eq? 'document + (system-service-type service))) %system-services))) (run-checkbox-tree-page - #:info-text (G_ "You can now select other services to run on your \ + #:info-text (G_ "You can now select the CUPS printing service to run on your \ system.") - #:title (G_ "Other services") + #:title (G_ "Printing and document services") #:items items #:selection (map system-service-recommended? items) #:item->text (compose G_ system-service-name) @@ -123,4 +121,4 @@ (define (run-services-page) (if (null? desktop) (list (run-network-management-page)) '()) - (run-other-services-cbt-page)))) + (run-printing-services-cbt-page)))) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 12d1d91608..5d931149b8 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -243,7 +243,7 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) - ((checkbox-list (title "Other services") (text _) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070930622 (code B ref 47979); Sun, 26 Dec 2021 20:32:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:49 +0000 Received: from localhost ([127.0.0.1]:41628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBI-0007xp-Od for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:49 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:35857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBE-0007xG-O8 for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:45 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E88DE3200929; Sun, 26 Dec 2021 15:31:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Dec 2021 15:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=HBampG0kvWTu9PzRH5owyXrp3UXQO4g2xDHBMB0O5pw=; b=M7jwjHjuHhBZ 5EfOXxOKt3rlWANUPS0do89z7ZCj7GAL4wDH3gpoyQG42vJqSMdCzoi713Zdsuaa PaUnTUH2hJAHQale1Se89NXGK6DX5ixzIhAKNjJ/zjyCkQmAyIWnJFk+g1nkrBef idlE4NOTn9qQQAxhXfDWHUzZFejPMGE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=HBampG0kvWTu9PzRH5owyXrp3UXQO4g2xDHBMB0O5 pw=; b=YxoQCAjywUrwlrBpM7FZnvBoGnUfc88NbX5QDiH3pvaC8IBV3iPMhcEvA fowGbUYhnapxtAPI/WnVs6iHmgTUUgru6qujwMfctoayAz/VZYEVIcf+hnFxNYuW CLNtr80v/14Fq2iG6rb/A/Yk/kklsDIKx3yMVsDeRBvfPgzIR1bd8bHANJGA1Hig FpluS78wDJLX8yO/MII6bZH28njXiLRgNdH/3eYkrNU8XkLGSdIMIDvY6nqikZ9K iYFhUMj64Y2akxQc2KpKsJTkMOq4w9/P1+cBUdf2h6xxM6h/z9a05g1syN+smpp1 BP1zQ1+g2PI1f1YtS7+onzUTH9HNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhggtgfgsehtke ertdertdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefgfeftdfgveetfffhgfekkeeuje egueevieeikeetheffffekvefgffegheffheenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:38 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:30 -0500 Message-Id: <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. * gnu/installer/tests.scm (choose-services): Add and use a choose-misc-service? procedure. * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add ntp-service-type. --- gnu/installer/newt/services.scm | 25 ++++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 10 +++++++++- gnu/tests/install.scm | 5 +++-- 4 files changed, 44 insertions(+), 4 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index b4b5219b20..c218825813 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +89,27 @@ (define (run-printing-services-cbt-page) (condition (&installer-step-abort))))))) +(define (run-console-services-cbt-page) + "Run a page to select various system adminstration services for non-graphical +systems." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Console services") + #:info-text (G_ "Select miscellaneous services to run on your \ +non-graphical system.") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -119,6 +141,7 @@ (define (run-services-page) (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-console-services-cbt-page)) '()) (run-printing-services-cbt-page)))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 341d8b69c8..94c49307f0 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (define %system-services (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service (NTP), to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 5d931149b8..39be59f689 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -221,7 +221,11 @@ (define* (choose-services port (choose-network-management-tool? (lambda (service) (string-contains service "DHCP"))) - (choose-other-service? (const #f))) + (choose-other-service? (const #f)) + (choose-misc-service? + (lambda (service) + (string-contains service "NTP")))) + "Converse over PORT to choose services." (define desktop-environments '()) @@ -243,6 +247,10 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) + ((checkbox-list (title "Console services") (text _) + (items ,services)) + (filter choose-misc-service? services)) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 154f98b2e1..ae8c6051f1 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1685,8 +1685,9 @@ (define* (installation-target-os-for-gui-tests (list (swap-space (target (uuid "11111111-2222-3333-4444-123456789abc")))))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 3/3] installer: Offer 'gpm-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055070930628 (code B ref 47979); Sun, 26 Dec 2021 20:32:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:31:49 +0000 Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBJ-0007xr-6P for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:49 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:59859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBF-0007xJ-WF for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:31:46 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4C2253200993; Sun, 26 Dec 2021 15:31:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 26 Dec 2021 15:31:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=teqBrmXr5h tyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=J1mhMJBGEqgiavL+LRhUDO3HTh n4mkfz9QErieoJcDbkzjXZwrIJesfk/hny8SoVEao5x3QzwooMi0wp0gOpcJiHe6 zeXiyIEm2wjkweDmlsUkBcZFqT7Js3cV0cD2OsGP03o0tQIqv8iNYUmlnt2YCwWT BfrOw/HArcxrnjAU0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=teqBrmXr5htyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=Uy6Pu6C7 JIs4vrQypij7tOBoyrv/MmJVnWovAfuJYBY4nn0/5vD6aTOsBsCD9iGk+L4yJS68 cjb/oHqF2RlinrvnQmfMHOWWC2APyEhJwP6Wpr80j5waojY8m6xKTArM1YtzI6uF KBBALEUGEMFyTeVSZUAkIILTBkLdVXyqN6P+9e8QzJLhgUVAri1PV+d9ae3zWWP4 trV/DhXV3GRyGNZ731GyxkshB2DrNqM83kBhdtZGeszm3GIAJqwX/rBBgvz1ntU7 AN8pcg9XUCpYo3sElwQBZcuiSKygFwAu8dPEzzhfvJP6GRBcc4kqdEs4b9y0ccUy mUeoe/VPFWsP9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephfeggeetiedtvdduudevueehvdehhf efhefghedvhfdugeeukeehvdfhfffhhfegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:31:39 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 15:31:31 -0500 Message-Id: <1a104bb17072170af44b1d2886e98f2377c28f74.1640550687.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 94c49307f0..be6e75cbc4 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (define %system-services (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164055083630899 (code B ref 47979); Sun, 26 Dec 2021 20:34:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 20:33:56 +0000 Received: from localhost ([127.0.0.1]:41645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aDM-00082E-1S for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:33:56 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aDK-00081x-7H for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 15:33:54 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 89DC23200929; Sun, 26 Dec 2021 15:33:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 26 Dec 2021 15:33:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=qsbXahxl+HPH/2Z1vh8DtWcf XGFSMpRGTjGYKgsqxBA=; b=k4hZ/hac5ReDfo7O8dE2LrRtuA3zy9qzRcP3nuDe PGX84sLOrtDrJFrExZWlLSuB1XVNOGoKURsRSj2r6UR02uZ6S/WwI4jcjZ9p+k2V Ivd7l4z3vT6T8zhA9bP0Gy4KSVANu77IifIMWen9ZqJKlKnqNeByyzx0t4n0QB3u gws= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qsbXah xl+HPH/2Z1vh8DtWcfXGFSMpRGTjGYKgsqxBA=; b=Mml5ORc1oDs6OKGKfKad0U K1jQcqQ58e4pzBPOjoNiIV3yN4sujfdvnHcNak6oaMW+zuS6xCtyt6hsc8qzSR1j WvG8puZpYIlKvgOJrLDTD214NEAX5XC8JFKpLddaCN+FWF+BQls+S0fBoR2Koa8T 3EMcdztWi9qzHcsylrfIrjOpbb90Oncg4Vq+vh9Y6eIoHW19ulxPuqgXeOmFfz1b YGZUjfi8+iIZXoEzyMTpV1pO4Aiu8aQXmf57oUw4XgRLHhGxVvrZIg2uArd7XOHB NUR1sAB/wQp6nhwsEUxQljeRUjjBsSJqBVHLwwVDTQSOgXXlzR7G/WH2Ac4oFRxw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepudekveegteekleetgfeitdejgfejke ffudethedvhfeukeduleeikeejfeehffetnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Sun, 26 Dec 2021 15:33:47 -0500 (EST) Date: Sun, 26 Dec 2021 15:33:40 -0500 From: Leo Famulari Message-ID: References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jkAnoMK9cQTwfQKQ" Content-Disposition: inline In-Reply-To: <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --jkAnoMK9cQTwfQKQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 26, 2021 at 03:31:30PM -0500, Leo Famulari wrote: > We had several bug reports with a root cause of "the clock was > incorrect" from users who used the installer to install a non-graphical > Guix System. >=20 > * gnu/installer/services.scm (%system-services): Add the ntp-service-type. > * gnu/installer/newt/services.scm (run-system-administration-cbt-page): N= ew > variable. > (run-services-page): Use run-system-administration-cbt-page when not > installing a desktop. > * gnu/installer/tests.scm (choose-services): Add and use a > choose-misc-service? procedure. > * gnu/tests/install.scm (installation-target-os-for-gui-tests):= Add > ntp-service-type. Here's v6 of this patch series. With it, the installer successfully installs systems with and without %desktop-services, and correctly chooses whether or not to offer NTP and GPM. It also passes `make check-system TESTS=3D"gui-installed-os"`. I think it's ready to go. --jkAnoMK9cQTwfQKQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmHI0aEACgkQJkb6MLrK fwiwIhAA2S9Ib4pRPgo7KC3nHNTRppWY4fwmkIrAMrAbE50HlxuhXW3MqYYdj2TK EZILVqxM1gdZ1y6hnbHMq/CBTCkwEkrVHwlil7e9GtNglI7xIQ4YyySaVQOmANcw xj4izj2mygfuUnqSM2C9gw1UX+S5h2EHYWNTgIX3cDmZQbwJKQKMqn6LulPIPk8A ZQkGXhlyB7NMp6G9aq3yeCTYHnR3XOuu/BWBakwy2kaj/S3uRGn/NbZExFkBCmTY doMSn/62zdioWa97gDO0Inh5reSg/FB6TUVn4gMrjxG2+41+EPwePgSD8nrW96fw rev5NBIJjGVFzIUAMYQlxe6IzjSb4PyMibR7dOOFfT5At3r/NZ+6EMueOz/VYagQ RzXZtOVrEYxMoOzudNgnUVNpT9V8iVr6+bnW3bNz/2d+ZnD3TDaTRV4//ab5o9t4 MQ+wmauG6oPrco0PerDlLf+XeNB0WflAOiRocoRAnCv85JNo2iZA1eZ1SPR38e9f tmnrCcQlGj1urNNwV84MU4aJncJrYJi+yAAS3VPFPE+mhBrhywX4+q5RUJcMYc9K n5kbDaFIKhOb67wUEkrtDNt6JIWdgOEKG9IW5NS4z+N+qFtceAQf0Y15MB9/GxV2 E/5CNx2QPRX/iO9nEGiNb1QGnNuwmogB/L0yXAnx2ZW63xPpPWc= =VH0A -----END PGP SIGNATURE----- --jkAnoMK9cQTwfQKQ-- From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16405527822135 (code B ref 47979); Sun, 26 Dec 2021 21:07:02 +0000 Received: (at 47979) by debbugs.gnu.org; 26 Dec 2021 21:06:22 +0000 Received: from localhost ([127.0.0.1]:41707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aik-0000YN-2Y for submit@debbugs.gnu.org; Sun, 26 Dec 2021 16:06:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aii-0000Y4-DF for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 16:06:20 -0500 Received: from [2001:470:142:3::e] (port=36340 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aiZ-00049K-FC; Sun, 26 Dec 2021 16:06:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ZWnt9vAqruwppWHq0IKik3/afvkKCJDqgXe4IYIFYn4=; b=VQPy1OtU9oXr3eTNw33Z P8zS+A05dT1xE8iD2Hne8vfrpls6V2miXOABm7dpgWXTanq2MEvGm3qyCIkHhLG4LT/t6+W5yG51/ UHbihSPVI31q/QG+iu0FkL0T+PN7AqT2hAIz//ERVahUbD/6PCm3JmRmTvgYZ0rJIiLdLX4CCgz/+ AVo8Iwa2aNHyPWMCju9M0ymkUE+xoUBCLuOnCucVkOd1W0/dXJ1u9wdda9uSahIloIew3Ymc7xs+C OvV+PSZ+oIlMnZvAC7zw4U0KcAPHM4dE+2zUOzx+kC5BrEfJc0C8Ilz6wgknG6Z6W+HByLkTnrGzA 4t6idLUsBkCMwQ==; Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=48556 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aiZ-0000E8-DD; Sun, 26 Dec 2021 16:06:11 -0500 From: Mathieu Othacehe References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> Date: Sun, 26 Dec 2021 22:06:09 +0100 In-Reply-To: (Leo Famulari's message of "Sun, 26 Dec 2021 15:33:40 -0500") Message-ID: <87a6gnnkji.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Leo, > It also passes `make check-system TESTS="gui-installed-os"`. Nice! You might also want to check that the gui-installed-desktop-os-encrypted test is passing as it covers desktop installation. Otherwise, it LGTM. Thanks, Mathieu From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v6 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Dec 2021 00:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164056667827793 (code B ref 47979); Mon, 27 Dec 2021 00:58:01 +0000 Received: (at 47979) by debbugs.gnu.org; 27 Dec 2021 00:57:58 +0000 Received: from localhost ([127.0.0.1]:41914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1eKs-0007ED-6H for submit@debbugs.gnu.org; Sun, 26 Dec 2021 19:57:58 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1eKp-0007Dp-Kn for 47979@debbugs.gnu.org; Sun, 26 Dec 2021 19:57:56 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6F5BA5C0048; Sun, 26 Dec 2021 19:57:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 26 Dec 2021 19:57:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=tckC1ONjg1Kb6PaMSS2aIG6d XigNBuuW86SwWDyQdlQ=; b=HVVsnpMasAkXbdUiqxlrnZzLsyMAUunzSlzc6Bl7 wm5J7TgKH8RMdfqrKsV2GuYiwZinvOc2hMbiZmaaUq7RLqqApTkinkISIzWvhAOU x1AZX7KnkNbdqNDodMCg2dqP0HRjVHmDumQ6pyQ824HMfxKi0ttYjbXV6vdaryum jtw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=tckC1O Njg1Kb6PaMSS2aIG6dXigNBuuW86SwWDyQdlQ=; b=K1nBu6a2U8T0dDfW7YhCuq v7hL9sN+EdcwbgrkEd/w8ACLBPV3nor0XsCuUWVt5j9L5UjvLL0gQf+SWZRez9UG Wo0J4L6xNYP5mK0IfGdcjMESSyClgN+9wlwj3gm1lvf1ZmOflzjTF80pjjSl7DNv crYC9EzK9I+v6K6xVWerGCWX3THBu3zUHMfThERhTjqA5Psts5HGKWbTqM0LvNrt uWBZ79AGfFs9/QEnX0HOZHYgfBAH6DHB45vaE/h+jmuykzNA6OK2HOQnOGkpsDWs yAMjHvt8u261M0hZ9JYqigjbKWBRm22Q2wgOFtO8glrFOlq3BFF88WuPgDlZ1fQQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudduhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Dec 2021 19:57:50 -0500 (EST) Date: Sun, 26 Dec 2021 19:57:48 -0500 From: Leo Famulari Message-ID: References: <18b693c017c779578de0a6a367ebf0eab95c7054.1640550687.git.leo@famulari.name> <817dd7dd12e866f87428dcac82fff96e42c4ba77.1640550687.git.leo@famulari.name> <87a6gnnkji.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6gnnkji.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Dec 26, 2021 at 10:06:09PM +0100, Mathieu Othacehe wrote: > Nice! You might also want to check that the > gui-installed-desktop-os-encrypted test is passing as it covers desktop > installation. Otherwise, it LGTM. Good idea, these changes did break that test. I'm tweaking the patches now and re-testing. From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 1/3] installer: Offer the CUPS printing service on a dedicated page. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Dec 2021 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164064386627983 (code B ref 47979); Mon, 27 Dec 2021 22:25:02 +0000 Received: (at 47979) by debbugs.gnu.org; 27 Dec 2021 22:24:26 +0000 Received: from localhost ([127.0.0.1]:44493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPp-0007HE-PU for submit@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:26 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:35241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPm-0007Go-Rq for 47979@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:24 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 9B8433200F76; Mon, 27 Dec 2021 17:24:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 27 Dec 2021 17:24:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=V0WbCjdUKX2p+GUYhuVRuYT 7tbkIif30whujIQ0ciSI=; b=KB4AsaVWibaO0hWcJnS3IEHfKq1GX/U1vYwek39 zdwR0nc8JSeNW1e244WkzJVbYM/yzMiRAicpSTtgqzWFjFlZqvq3cWhtscFP116D yTF4MX1Rjt9lag3chusVriosrKSsuCHzgBbwcQ0K2ecv+/aajlfgMYVNqLtKaPVb uhRc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=V0WbCjdUKX2p+GUYh uVRuYT7tbkIif30whujIQ0ciSI=; b=G33dBZTtPv0mK0x2ztMSFrcxXqrlqmz/t dYiO+EfBJmqwKIzlA7TTiaOVkZPTxgVUQHtTlVyIT85iUQ+64/lvI3hPpElOsrbL R26OGCbBDjSfYvZTS64hIPEWcpzxVhBSmyYY6AqTdlmsEtr2h9NbQx585XIIPctz EB90Q54hOgdnlYFGHUcYdVQeg79KdJH8pMiXNj93NufUz4JXRH9AD/I4PfQCrjgi BjvZEv/zXu8hDvKMaxA2dTJPFztyVDm8yI2mHZ/tnhggMU8DnDPzZopKT6i9sevV dLKYJpSUwep9C52AMD14m60dVdyUBWkQrESWauAPe7EbE/W2KVxJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddujedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeetueeigfelheekveffveetffeugeeuud dvgeeiffevkeeuffefteduvdfhhfduhfenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Mon, 27 Dec 2021 17:24:15 -0500 (EST) From: Leo Famulari Date: Mon, 27 Dec 2021 17:24:08 -0500 Message-Id: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Currently, this page of the installer offers to the user all installer services that are not of the types 'desktop', 'network-management', or 'networking'. Concretely, this means that it offers the CUPS printing service, because that is the only service of a different type defined in the installer. In later commits, we will add some services of a new type, and we only want them to be offered when the user is installing a non-graphical system. At least one of these new services (NTP) is part of %desktop-services. If it were offered on run-other-services-cbt-page, and the user had configured a system using %desktop-services, the user could accidentally add NTP to their services twice, which is an error and would break installation. So, this commit makes the run-other-services-cbt-page be more specific about what services to offer. This allows us to later create a new checkbox page that only runs when %desktop-services is not selected. * gnu/installer/newt/services.scm (run-other-services-cbt-page): Rename to ... (run-printing-services-cbt-page): ... new variable, and select only 'document' services. (run-services-page): Adjust accordingly. * gnu/installer/tests.scm (choose-services): Adjust accordingly. --- gnu/installer/newt/services.scm | 16 +++++++--------- gnu/installer/tests.scm | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index 1af4e7df2d..b4b5219b20 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -68,18 +68,16 @@ (define (run-networking-cbt-page) (condition (&installer-step-abort))))))) -(define (run-other-services-cbt-page) - "Run a page allowing the user to select other services." +(define (run-printing-services-cbt-page) + "Run a page allowing the user to select document services such as CUPS." (let ((items (filter (lambda (service) - (not (member (system-service-type service) - '(desktop - network-management - networking)))) + (eq? 'document + (system-service-type service))) %system-services))) (run-checkbox-tree-page - #:info-text (G_ "You can now select other services to run on your \ + #:info-text (G_ "You can now select the CUPS printing service to run on your \ system.") - #:title (G_ "Other services") + #:title (G_ "Printing and document services") #:items items #:selection (map system-service-recommended? items) #:item->text (compose G_ system-service-name) @@ -123,4 +121,4 @@ (define (run-services-page) (if (null? desktop) (list (run-network-management-page)) '()) - (run-other-services-cbt-page)))) + (run-printing-services-cbt-page)))) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 12d1d91608..5d931149b8 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -243,7 +243,7 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) - ((checkbox-list (title "Other services") (text _) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Dec 2021 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164064386627989 (code B ref 47979); Mon, 27 Dec 2021 22:25:02 +0000 Received: (at 47979) by debbugs.gnu.org; 27 Dec 2021 22:24:26 +0000 Received: from localhost ([127.0.0.1]:44495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPq-0007HH-5p for submit@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:26 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:55477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPn-0007Gs-MH for 47979@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:24 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 0225D3201134; Mon, 27 Dec 2021 17:24:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 27 Dec 2021 17:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=bftX3DDPaUDpIJWT2joryxDqo2k2OwZ+1NvS/qkaQi8=; b=ESC5ttcHSxQh JinDnl6P40tlg98S4eFnveIGwVR/dBsKUph3uqwIQrkzfuOVKhfN51axMIGsigi2 jXODJffBFnlieDhJ8riNfAr/6oN84zp+pyEAy9WvB220ah3GysTGMU7G3KRsIU6j od2G73uP8NCiZpxL6VaM6qSGWd7vPGw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=bftX3DDPaUDpIJWT2joryxDqo2k2OwZ+1NvS/qkaQ i8=; b=JltYQOX+VOMe4HxEQGO4YVDjTc20ifUTRcSOWgZbXaK3WE65hOhxjxKlg b+C2KbuRq5/82soMlfRKQHMyyLu+U0YzXWHt+EhUKZ9WpIuBmWIXjeyICA3yFQJ5 FCbymbgfckF5o7SzQ0De8DvJnxAG9TiHZ6J8PidDPnzKDv4j1b9NpdnOU8sfaLHo 3KYU6uJ6wIoshzGKec4+lqazxquWjA3/ez/j22Zn7WGUluT9+A48N29RCmXf6vSQ WVUFEVGBNyxF+jZ7goJLR9wyVuZRwQ8OXg0WAWw62Sta8VxqsuT75IIsMKGbOjn/ l9SYM2rYmMNCai4ci2Uhjdm6GWGzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddujedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfgggtgfesth ekredtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhu lhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepfefgfedtgfevteffhffgkeekue ejgeeuveeiieekteehffffkeevgfffgeehffehnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Mon, 27 Dec 2021 17:24:17 -0500 (EST) From: Leo Famulari Date: Mon, 27 Dec 2021 17:24:09 -0500 Message-Id: X-Mailer: git-send-email 2.34.0 In-Reply-To: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The system test "gui-installed-os" passes with this commit, but "gui-installed-desktop-os-encrypted" fails like this: ------ [...] conversation expecting pattern ((quote checkbox-list) ((quote title) "Network service") ((quote text) _) ((quote items) services)) Dec 27 23:03:44 localhost installer[194]: form # ("Network service"): client 19 replied () Dec 27 23:03:44 localhost installer[194]: running form # ("Network management") with 1 clients conversation expecting pattern ((quote list-selection) ((quote title) "Network management") ((quote multiple-choices?) #f) ((quote items) services)) Dec 27 23:03:44 localhost installer[194]: form # ("Network management"): client 19 replied "DHCP client (dynamic IP address assignment)" Dec 27 23:03:44 localhost installer[194]: running form # ("Console services") with 1 clients conversation expecting pattern ((quote checkbox-list) ((quote title) "Console services") ((quote text) _) ((quote items) services) ((quote null?) (quote desktop-environments))) /gnu/store/bvbv7a5nfzqwq5d7z33kqr8yzx1q5x70-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote checkbox-list) ((quote title) "Console services") ((quote text) _) ((quote items) services) ((quote null?) (quote desktop-environments))) sexp: (checkbox-list (title "Console services") (text "Select miscellaneous services to run on your non-graphical system.") (items ("Network time service (NTP), to set the clock automat) Backtrace: 2 (primitive-load "/gnu/store/ipxa2igymg4j2b84ivka5qcp5bs?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(# #)) ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (choose-services installer-socket #:choose-desktop-environment? (const #f) #:choose-network-service? (const #f). note: keeping build directory `/tmp/guix-build-installation.drv-9' builder for `/gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv' failed with exit code 1 build of /gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv failed ------ It seems that this page is being run even when a desktop is selected, which does not happen when using the installer directly. Can somebody help me write the system test correctly, so that it's not run when a desktop is selected? We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New variable. (run-services-page): Use run-system-administration-cbt-page when not installing a desktop. * gnu/installer/tests.scm (choose-services): Add and use a choose-misc-service? procedure. * gnu/tests/install.scm (installation-target-os-for-gui-tests): Add ntp-service-type. --- gnu/installer/newt/services.scm | 25 ++++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 9 +++++++++ gnu/tests/install.scm | 5 +++-- 4 files changed, 44 insertions(+), 3 deletions(-) diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index b4b5219b20..c218825813 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +89,27 @@ (define (run-printing-services-cbt-page) (condition (&installer-step-abort))))))) +(define (run-console-services-cbt-page) + "Run a page to select various system adminstration services for non-graphical +systems." + (let ((items (filter (lambda (service) + (eq? 'administration + (system-service-type service))) + %system-services))) + (run-checkbox-tree-page + #:title (G_ "Console services") + #:info-text (G_ "Select miscellaneous services to run on your \ +non-graphical system.") + #:items items + #:selection (map system-service-recommended? items) + #:item->text (compose G_ system-service-name) + #:checkbox-tree-height 5 + #:exit-button-callback-procedure + (lambda () + (raise + (condition + (&installer-step-abort))))))) + (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management"))) @@ -119,6 +141,7 @@ (define (run-services-page) (append desktop (run-networking-cbt-page) (if (null? desktop) - (list (run-network-management-page)) + (cons (run-network-management-page) + (run-console-services-cbt-page)) '()) (run-printing-services-cbt-page)))) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 341d8b69c8..94c49307f0 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -104,6 +105,13 @@ (define %system-services (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services. + (system-service + (name (G_ "Network time service (NTP), to set the clock automatically")) + (type 'administration) + (recommended? #t) + (snippet '((service ntp-service-type)))) + ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager")) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index 5d931149b8..4175feaed9 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -221,7 +221,11 @@ (define* (choose-services port (choose-network-management-tool? (lambda (service) (string-contains service "DHCP"))) + (choose-misc-service? + (lambda (service) + (string-contains service "NTP"))) (choose-other-service? (const #f))) + "Converse over PORT to choose services." (define desktop-environments '()) @@ -243,6 +247,11 @@ (define desktop-environments '()) (null? desktop-environments) (find choose-network-management-tool? services)) + ((checkbox-list (title "Console services") (text _) + (items ,services) + (null? desktop-environments)) + (filter choose-misc-service? services)) + ((checkbox-list (title "Printing and document services") (text _) (items ,services)) (filter choose-other-service? services)))) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 154f98b2e1..ae8c6051f1 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1685,8 +1685,9 @@ (define* (installation-target-os-for-gui-tests (list (swap-space (target (uuid "11111111-2222-3333-4444-123456789abc")))))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 3/3] installer: Offer 'gpm-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Dec 2021 22:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164064387428011 (code B ref 47979); Mon, 27 Dec 2021 22:25:03 +0000 Received: (at 47979) by debbugs.gnu.org; 27 Dec 2021 22:24:34 +0000 Received: from localhost ([127.0.0.1]:44497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPx-0007Hh-Qa for submit@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:34 -0500 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:40251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1yPp-0007Gu-9K for 47979@debbugs.gnu.org; Mon, 27 Dec 2021 17:24:28 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 71F072B001E8; Mon, 27 Dec 2021 17:24:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 27 Dec 2021 17:24:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=teqBrmXr5h tyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=J/IexXSTMuiyq7uabLsYEYeBBZ Xuw/pvQXs90npKR1inZOeyWWmffpwQ8H2h4cHq8wWFduSzBWiYoNmfY6djQJ1/mJ P1dASV+6EndUXBRdjatqVQSdfX9/zy5a3a4SqWcmXxsZctIxvFiaiESiHS9ZuBaJ Z+m5x9RXND0SREHGU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=teqBrmXr5htyzCkSRaihbWRAnjF8Ly1PRoVmYrVnun8=; b=fr1L1oSI SVfZWEyJUGJQOasNTd4t8hXPQK2SploPV+jl8moAM/ePWeWg8k9NQaPy2E4Zxd0e JZCav+Y3WmSTt2eySflKMT8fvbzQUUSGlDJHdJBeNsUV+TRuhqngdoOz09uK3jFn RNFqHcChgotsySCuguuU3Sd8DwU/E2v0F3I++DajtLLC2dJzz8O0FiEmmk/Uhj1b FK4608vboAsmBzvuZHdZa2LAN1XHtwa5B8pyez8cKybo9EvTx/EaPsUKxL4S8/ia M4QeFE8iII4tSQNBrRUG7CEUtvC7FZjvIlO4WDXL065Fzp/qImeCTOSNzJdMewiz X/kiWcQRB4udnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddujedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecuogfvvgigthfqnhhlhidqqdfuphgrmhgsohhtqd gkgedvuddqheduucdlfedttddmnecujfgurhephffvufffkffojghfggfgsedtkeertder tddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrih drnhgrmhgvqeenucggtffrrghtthgvrhhnpefhgeegteeitddvudduveeuhedvhefhfeeh gfehvdfhudegueekhedvhfffhffhgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Mon, 27 Dec 2021 17:24:18 -0500 (EST) From: Leo Famulari Date: Mon, 27 Dec 2021 17:24:10 -0500 Message-Id: <70c03dd3a7570d5024ba1f3b1a52c7e39cd7ef4e.1640643713.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 In-Reply-To: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/installer/services.scm (%system-services): Add the gpm-service-type. --- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index 94c49307f0..be6e75cbc4 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -111,6 +111,10 @@ (define %system-services (type 'administration) (recommended? #t) (snippet '((service ntp-service-type)))) + (system-service + (name (G_ "GPM mouse daemon, to use the mouse in the console")) + (type 'administration) + (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service -- 2.34.0 From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Dec 2021 23:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Cc: othacehe@gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16406491965803 (code B ref 47979); Mon, 27 Dec 2021 23:54:03 +0000 Received: (at 47979) by debbugs.gnu.org; 27 Dec 2021 23:53:16 +0000 Received: from localhost ([127.0.0.1]:44649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1zno-0001VX-AM for submit@debbugs.gnu.org; Mon, 27 Dec 2021 18:53:16 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1znl-0001VE-A5 for 47979@debbugs.gnu.org; Mon, 27 Dec 2021 18:53:15 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 525D33200EAD; Mon, 27 Dec 2021 18:53:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 27 Dec 2021 18:53:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=12OvYdveIfQgrL601AGKDThC hFLw8JH9ANjDUFAkeSk=; b=t7FxO3DmzFi/8CuYMUIhnAhCJnv1IdrMSvc1oTRU qm7AGBOUVbrMFEIdgL3MCTK9jStzM0t3r10ZjgV5FrO3EvByIqYy+MRN1W9LvouE 5tXhSftlEkThlrPTYMpmbcfim0gajOKZYpFKIDFisFeYjmSyMzPQf/Ed57txPRc7 s6U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=12OvYd veIfQgrL601AGKDThChFLw8JH9ANjDUFAkeSk=; b=X5V7S8YTuKlkPYmZH+OeuR UBYmO9tcm026YfOqXuUP+9iOCmBiJZW4vWrP19j7jl6KWkvPlvzejoUJH6eQobOg g4qF2nnC4WnHrp7Uo0pnoBP2Kc8dymmhRVReN3QzfNrJpu7A2iIr3cdcH9/Wq1bi mIztC1Kpwv7jmi18pW3/mCjFYQYxn7fp6Up+SG5zPowB98vT+YtP1wOhlaZ9xAIW cSJ/cVsSBiz/mpzSWwWtXe77+N4FRvcInXZglVlji4SinJm0KFLpy0ao6lAwnb5c hVaXhR7g6L9IxSnl8bxwiJlZGi4VZSAkDU8UtJIIcMOrY32fjHvaiTJd1yJHHh7Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddukedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepueekkedtffdvtddugeejgedtvefhue efiedvjeeitdeigedtveejvdejheffvefgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Dec 2021 18:53:05 -0500 (EST) Date: Mon, 27 Dec 2021 18:53:03 -0500 From: Leo Famulari Message-ID: References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Dec 27, 2021 at 05:24:09PM -0500, Leo Famulari wrote: > The system test "gui-installed-os" passes with this commit, but > "gui-installed-desktop-os-encrypted" fails like this: > > ------ > [...] > conversation expecting pattern ((quote checkbox-list) ((quote title) "Network service") ((quote text) _) ((quote items) services)) > Dec 27 23:03:44 localhost installer[194]: form # ("Network service"): client 19 replied () > Dec 27 23:03:44 localhost installer[194]: running form # ("Network management") with 1 clients > conversation expecting pattern ((quote list-selection) ((quote title) "Network management") ((quote multiple-choices?) #f) ((quote items) services)) > Dec 27 23:03:44 localhost installer[194]: form # ("Network management"): client 19 replied "DHCP client (dynamic IP address assignment)" > Dec 27 23:03:44 localhost installer[194]: running form # ("Console services") with 1 clients > conversation expecting pattern ((quote checkbox-list) ((quote title) "Console services") ((quote text) _) ((quote items) services) ((quote null?) (quote desktop-environments))) > /gnu/store/bvbv7a5nfzqwq5d7z33kqr8yzx1q5x70-shepherd-marionette.scm:1:1718: ERROR: > 1. &pattern-not-matched: > pattern: ((quote checkbox-list) ((quote title) "Console services") ((quote text) _) ((quote items) services) ((quote null?) (quote desktop-environments))) > sexp: (checkbox-list (title "Console services") (text "Select miscellaneous services to run on your non-graphical system.") (items ("Network time service (NTP), to set the clock automat) > Backtrace: > 2 (primitive-load "/gnu/store/ipxa2igymg4j2b84ivka5qcp5bs?") > In ice-9/eval.scm: > 191:35 1 (_ #f) > 619:8 0 (_ #(# #)) > > ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (choose-services installer-socket #:choose-desktop-environment? (const #f) #:choose-network-service? (const #f). > note: keeping build directory `/tmp/guix-build-installation.drv-9' > builder for `/gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv' failed with exit code 1 > build of /gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv failed > ------ > > It seems that this page is being run even when a desktop is selected, > which does not happen when using the installer directly. > > Can somebody help me write the system test correctly, so that it's not > run when a desktop is selected? Any ideas, Mathieu? From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Dec 2021 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.164066730814864 (code B ref 47979); Tue, 28 Dec 2021 04:56:01 +0000 Received: (at 47979) by debbugs.gnu.org; 28 Dec 2021 04:55:08 +0000 Received: from localhost ([127.0.0.1]:44858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n24Vv-0003rg-V5 for submit@debbugs.gnu.org; Mon, 27 Dec 2021 23:55:08 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:53321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n24Vp-0003r0-Ea for 47979@debbugs.gnu.org; Mon, 27 Dec 2021 23:55:05 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4E0163200BF9; Mon, 27 Dec 2021 23:54:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 27 Dec 2021 23:54:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=B+q7LPV4tLehayOGtOlgSsXC IcUQpGcahqr3IUUcYq4=; b=AUdSZp7q+pRvigSgeNzxWbEb/24Z0W99rgxZfWC8 3MtdZGEjwfHuKX5eeQc7X+MeMv6rYPOm2d8do6Bjbl91s8vIuia9s0Wu6iNJqol5 pSm8f0DoVRPEwbMuCV+hFFstZbmCSCvwTuTmj0AYL4Z/sVrW+eyD3Y+mEDv1C2jb mkc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=B+q7LP V4tLehayOGtOlgSsXCIcUQpGcahqr3IUUcYq4=; b=lJvOprYYk6zlxBt546p76R M3o76ZilY4HvXENURfQjn0ZUkRlHiWT+iFqxzlg62Dp0DmvCiuqJne6WA1tPn9r/ clYX+Xse3Ap0Qj+WzeXVqvg2O8u57852KV4U/LtsQBpkKMRojyOJWzuLqHDXRIZN xCDSXV/I/zPSQLJD0aM49nDKj8agRlLlZjG4MKjv2ijc6Hguagv/8WcJV7fQcAUb 8gQMpAKdYM+KsrJPRFV5mFqp9zd3rK+OrCocmF96QPi0pF/JmACpHzJr5uUuiKjw yeuBm/kmQgycT+8bfo960dYI6+L2CKFRWccOd7c3fxcZlrGJzIq4qelhdJY7YJYQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddukedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepueekkedtffdvtddugeejgedtvefhue efiedvjeeitdeigedtveejvdejheffvefgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <47979@debbugs.gnu.org>; Mon, 27 Dec 2021 23:54:54 -0500 (EST) Date: Mon, 27 Dec 2021 23:54:52 -0500 From: Leo Famulari Message-ID: References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Dec 27, 2021 at 05:24:09PM -0500, Leo Famulari wrote: > 1. &pattern-not-matched: > pattern: ((quote checkbox-list) ((quote title) "Console services") ((quote text) _) ((quote items) services) ((quote null?) (quote desktop-environments))) > sexp: (checkbox-list (title "Console services") (text "Select miscellaneous services to run on your non-graphical system.") (items ("Network time service (NTP), to set the clock automat) [...] > + ((checkbox-list (title "Console services") (text _) > + (items ,services) > + (null? desktop-environments)) ^ | There's a typo here that could cause the error mentioned above. > + (filter choose-misc-service? services)) Rebuilding... From unknown Sun Jun 15 08:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Dec 2021 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16406800594230 (code B ref 47979); Tue, 28 Dec 2021 08:28:02 +0000 Received: (at 47979) by debbugs.gnu.org; 28 Dec 2021 08:27:39 +0000 Received: from localhost ([127.0.0.1]:44979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n27pb-00016A-6B for submit@debbugs.gnu.org; Tue, 28 Dec 2021 03:27:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n27pZ-00015u-BJ for 47979@debbugs.gnu.org; Tue, 28 Dec 2021 03:27:38 -0500 Received: from [2001:470:142:3::e] (port=58082 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n27pT-0007rD-Ro; Tue, 28 Dec 2021 03:27:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=opmmKxhPtxkYSG1iLUb6Ww+vm5ACFbDxoAW3x/ypuEU=; b=nKFmRUNla38iE2SImw/8 sQaD4RHioUM4lZT0LcyNx4GRskZEuAFbP2mOlYEzBYaVVVPh+dxwTC7P7/sOqLwOvkgmw+Dn/Gxo9 yNmQuhJKXMalVnJqMuivyfcDR7xSzvyE9dwgNERR/ATN30Og2+05wG7NCr7R3RYHk6rjGAOwQZlx1 71bzgxFSmSiawEvPjejaKuSaQIm7xj7tNSIcI2FcN/bvgdPlLTuKFWh1dQe5m5upExzwp6MqOEmBR WiXp8P4MAPNiGt7VAt6EW23uljhMmUd0wTqZ9/KDaeOt6NzQZMTp09c/QkjgoYbkBDG9Yzf3ASawG Obqk+iejSXJkPg==; Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=59822 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n27pT-0007ww-TK; Tue, 28 Dec 2021 03:27:32 -0500 From: Mathieu Othacehe References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> Date: Tue, 28 Dec 2021 09:27:29 +0100 In-Reply-To: (Leo Famulari's message of "Mon, 27 Dec 2021 23:54:52 -0500") Message-ID: <87tuetyw0e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Leo, >> + (null? desktop-environments)) > ^ > | > There's a typo here that could cause the error mentioned above. Right. I have started a wip-harden-installer branch, and configured Cuirass to run the system tests on it: https://ci.guix.gnu.org/jobset/wip-harden-installer, to prevent my laptop from burning. Don't hesitate to push your commits there :). Thanks, Mathieu From unknown Sun Jun 15 08:46:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Famulari Subject: bug#47979: closed (Re: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems.) Message-ID: References: X-Gnu-PR-Message: they-closed 47979 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 47979@debbugs.gnu.org Date: Tue, 28 Dec 2021 20:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1640723702-16263-1" This is a multi-part message in MIME format... ------------=_1640723702-16263-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47979: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical s= ystems. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47979@debbugs.gnu.org. --=20 47979: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47979 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1640723702-16263-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47979-done) by debbugs.gnu.org; 28 Dec 2021 20:34:36 +0000 Received: from localhost ([127.0.0.1]:47546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2JB5-0004DZ-MZ for submit@debbugs.gnu.org; Tue, 28 Dec 2021 15:34:35 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2JB3-0004DL-O3 for 47979-done@debbugs.gnu.org; Tue, 28 Dec 2021 15:34:34 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C234D3200E31; Tue, 28 Dec 2021 15:34:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 28 Dec 2021 15:34:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=H25VKfgI2j5f/kfcRLg8+S6y cvY9f9Q1mHxV0GtaFNU=; b=pLYA/+S5BLGSmr2hj2jg+L4CmAKG+6wcvM9Jmcq+ b0RmkSGDh1AFzXQZ/hAMhJF0RGTptnpja66ZCJjBJtf4zBxqRvQLoYyVdWCR6K8N lw0N7v0wMvyV5l2k0SRbnQArkqJi0qzJpIFfMy1apfRnOWe2BJih+BhpdXmpnZUw Okw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=H25VKf gI2j5f/kfcRLg8+S6ycvY9f9Q1mHxV0GtaFNU=; b=lKyLshSyZ5DHifJBgVjC7W iy351MfbckKQbck8JKQFthXPHvlu7QLl8BpET5mxM5Kx4y8b81KPMrSpfG6+VXV8 nt6dYZMfiOUZfR7mwEgRJ6X+QSTXLtgYbCfUmbnPXW1zaSDRxKWXzqhaLpu32XJF WOgMUKP9JVIi/k2n7XrIaIVCWQOZn0UDciuv8Hka/E8QG+fFfP79EEBaXGsj+FsL fk91QiIN3t+UKvkwGacDJN2zjRdl9iC0JK3dcjgVXVSOTqJTWU4FoHcwm9ioPXnz vtvQhpRUE+FZAUK1eN1l608RID7SNU7NFcSxcBDSftpT/eLuJ5rbJrgEyTDK/bXg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudduledgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepvddvudegffefiedttdfhfedvuefhgfekieekgeekveetgefhfeetgfeguedu ffeinecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Dec 2021 15:34:27 -0500 (EST) Date: Tue, 28 Dec 2021 15:34:24 -0500 From: Leo Famulari To: Mathieu Othacehe Subject: Re: [bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems. Message-ID: References: <422b32c84a0ae293398777f5233565b9c282d5da.1640643713.git.leo@famulari.name> <87tuetyw0e.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tuetyw0e.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47979-done Cc: 47979-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Dec 28, 2021 at 09:27:29AM +0100, Mathieu Othacehe wrote: > >> + (null? desktop-environments)) > > ^ > > | > > There's a typo here that could cause the error mentioned above. I fixed this bug and pushed as 0d9d151424ab5823e441f056237819277b8aa072. Thanks a lot for your help! > Right. I have started a wip-harden-installer branch, and configured > Cuirass to run the system tests on it: > https://ci.guix.gnu.org/jobset/wip-harden-installer, to prevent my > laptop from burning. I found that the Guix test suite itself fails on berlin, even in the build container as used when building current-guix-package in the system tests, but maybe it succeeds when run on the build nodes via CI: https://issues.guix.gnu.org/46413 That's why I spent a long time running the system tests on my own computer. ------------=_1640723702-16263-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Apr 2021 18:53:53 +0000 Received: from localhost ([127.0.0.1]:38834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0w5-0005Cj-2c for submit@debbugs.gnu.org; Fri, 23 Apr 2021 14:53:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:60740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la0w3-0005Cc-Qm for submit@debbugs.gnu.org; Fri, 23 Apr 2021 14:53:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la0w3-0007YV-Iq for guix-patches@gnu.org; Fri, 23 Apr 2021 14:53:51 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la0vv-0001gK-Jz for guix-patches@gnu.org; Fri, 23 Apr 2021 14:53:51 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D6F5E3059; Fri, 23 Apr 2021 14:53:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 23 Apr 2021 14:53:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=LflpN3IKgze2migbwdUwfBf VwAphjdl+Eof0yU8LPPQ=; b=DW+2KCwWXP7f+9Py8fpV28pNzM1rXMHt3/g+UN5 QpYCd2zAFbJaIDVXmN0JpiMTsUwXjXRFYIMAF3ioJDcxY5A6tdajbumXXX3GRXIe UsT2+VXu35Hp5VBOpgogDw+Qz5UAKj4jYzr8o3apmWdvx1XEXp4Ec/8RheNMV/+V pE9k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LflpN3 IKgze2migbwdUwfBfVwAphjdl+Eof0yU8LPPQ=; b=N2zPePt6bLI1AvnBKp1Of7 Ly22QW1CiyGIFYIqr/lI1076MrI5TbQzOkzODi1iL8HIu/gMPXWMpvCleMgbQJQ/ 47niW6g0a43NXPEzXMO/2EXoiuRCaxZ3NvDmBWGf9GQOgGiD9FmovhIpDD10udfm L0Mho+sVN4cR6EULNJWyVjaoHnLmtrsjDaYAQDkF+s4A3idtrfS031oluya5VoSw OTMOj+GRq1KsjBOUL49KK9CBqqLFtDW490LTiF283vKOsXELIwnv5Wmsiy173qMn Ptyf3M/AfkaHIlltB/m3gt26v94IXzWr2b+0GHtpJ6Odm4TxPYY4GHguGuCdJMGw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre dtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfetjeetjedtfefggfelheevleejte fhleevveetkedtheeugedtgfekueekheejnecukfhppedutddtrdduuddrudeiledruddu keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from jasmine.lan (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 2403F108005C for ; Fri, 23 Apr 2021 14:53:41 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Date: Fri, 23 Apr 2021 14:53:15 -0400 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@famulari.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) We had several bug reports with a root cause of "the clock was incorrect" from users who used the installer to install a non-graphical Guix System. * gnu/installer/services.scm (%system-services): Add the ntp-service-type. --- gnu/installer/services.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index ec5ea30594..440b8c67db 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2019 Ludovic Courtès ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright © 2021 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -103,6 +104,11 @@ (type 'networking) (packages '((specification->package "nss-certs"))) (recommended? #t)) + (system-service + (name (G_ "Network time service, to set the clock automatically")) + (type 'network-management) + (snippet '((service ntp-service-type))) + (recommended? #t)) ;; Network connectivity management. (system-service -- 2.31.1 ------------=_1640723702-16263-1--