From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 20:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47960@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161912450922468 (code B ref -1); Thu, 22 Apr 2021 20:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Apr 2021 20:48:29 +0000 Received: from localhost ([127.0.0.1]:35659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZgFQ-0005qK-Kc for submit@debbugs.gnu.org; Thu, 22 Apr 2021 16:48:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:57042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZgFO-0005qB-OH for submit@debbugs.gnu.org; Thu, 22 Apr 2021 16:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgFO-00089N-GH for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 16:48:26 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:49339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgFK-0003BX-PC for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 16:48:25 -0400 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8E9941C000B for ; Thu, 22 Apr 2021 20:48:18 +0000 (UTC) From: Protesilaos Stavrou Date: Thu, 22 Apr 2021 23:48:16 +0300 Message-ID: <87mttq6o6n.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=217.70.183.197; envelope-from=info@protesilaos.com; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On trunk the (setq delete-by-moving-to-trash t) no longer works in Dired and Eshell when trying to delete a directory. Steps to reproduce with emacs -Q: + Evaluate (setq delete-by-moving-to-trash t). + Use 'C-x C-j' to jump to a dired buffer. + Then type '+' and create a new directory named "test" or whatever. + With point over the newly created directory ,type "D", and confirm. You get an error: "file-error: Renaming: Not a directory [...]" Same if you try to delete the directory with the 'rm -r' command from inside eshell (though 'rmdir' works in this case). For completeness, M-x shell works with either 'rm -r' and 'rmdir'. -- Protesilaos Stavrou https://protesilaos.com From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Protesilaos Stavrou Cc: 47960@debbugs.gnu.org Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.161912588224739 (code B ref 47960); Thu, 22 Apr 2021 21:12:01 +0000 Received: (at 47960) by debbugs.gnu.org; 22 Apr 2021 21:11:22 +0000 Received: from localhost ([127.0.0.1]:35678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZgbZ-0006Qx-OF for submit@debbugs.gnu.org; Thu, 22 Apr 2021 17:11:21 -0400 Received: from heytings.org ([95.142.160.155]:49360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZgbY-0006Qq-Lz for 47960@debbugs.gnu.org; Thu, 22 Apr 2021 17:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1619125879; bh=YZtQ0IJlo2gaG2Lv1lLIS5Y843if/PAb7wW4NtAMiGY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=nSirWBl3ElhS4lFgRNnfSxG1cBUTVvz6wtWaguN3xtsiyFc/AkmAnt3ngjv75Gam4 a6HUazfw0e8d7/dr0+D7dk9GI0c12IWOoz+Wqrm/lWVZe+Aqf3dwLHvqgT4lbsNEAj IvVYuzy6wva0HH2lPIRL3rM9vvd6pnXNIvjY9h4ab6wCp3MoW9G7C/LNiB9DcDK0Mb +DUCrZJ0tQSGZDuOw8mItwRmKg86NzREIm8zV35aXRh0uyq7+CdsJQUzwudjxuiY8w LekS/ClzErUu1PPFwQlre+jlr5T8U0z5Zs+OtP/ISeDJXolJ1oM2wzUTo/1NQ3M+n+ j9qLBSFgr69Pw== Date: Thu, 22 Apr 2021 21:11:19 +0000 From: Gregory Heytings In-Reply-To: <87mttq6o6n.fsf@protesilaos.com> Message-ID: References: <87mttq6o6n.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > On trunk the (setq delete-by-moving-to-trash t) no longer works in Dired > and Eshell when trying to delete a directory. > > Steps to reproduce with emacs -Q: > > + Evaluate (setq delete-by-moving-to-trash t). > + Use 'C-x C-j' to jump to a dired buffer. > + Then type '+' and create a new directory named "test" or whatever. > + With point over the newly created directory ,type "D", and confirm. > > You get an error: "file-error: Renaming: Not a directory [...]" > > Same if you try to delete the directory with the 'rm -r' command from > inside eshell (though 'rmdir' works in this case). > > For completeness, M-x shell works with either 'rm -r' and 'rmdir'. > Are you sure this bug is not due to something going wrong on your machine? I'm unable to reproduce this bug here, both Dired and Eshell seem to work as expected. Did you by any chance define a 'system-move-file-to-trash' function? Does it work when you (setq trash-directory )? From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 21:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gregory Heytings Cc: 47960@debbugs.gnu.org Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.161912773227556 (code B ref 47960); Thu, 22 Apr 2021 21:43:02 +0000 Received: (at 47960) by debbugs.gnu.org; 22 Apr 2021 21:42:12 +0000 Received: from localhost ([127.0.0.1]:35709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZh5P-0007AO-VE for submit@debbugs.gnu.org; Thu, 22 Apr 2021 17:42:12 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZh5N-0007A8-Ib for 47960@debbugs.gnu.org; Thu, 22 Apr 2021 17:42:10 -0400 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 761AF1BF203; Thu, 22 Apr 2021 21:42:01 +0000 (UTC) From: Protesilaos Stavrou References: <87mttq6o6n.fsf@protesilaos.com> Date: Fri, 23 Apr 2021 00:42:00 +0300 In-Reply-To: (Gregory Heytings's message of "Thu, 22 Apr 2021 21:11:19 +0000") Message-ID: <87bla66lp3.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-04-22, 21:11 +0000, Gregory Heytings wrote: >> >> On trunk the (setq delete-by-moving-to-trash t) no longer works in >> Dired and Eshell when trying to delete a directory. >> >> Steps to reproduce with emacs -Q: >> >> + Evaluate (setq delete-by-moving-to-trash t). >> + Use 'C-x C-j' to jump to a dired buffer. >> + Then type '+' and create a new directory named "test" or whatever. >> + With point over the newly created directory ,type "D", and confirm. >> >> You get an error: "file-error: Renaming: Not a directory [...]" >> >> Same if you try to delete the directory with the 'rm -r' command from >> inside eshell (though 'rmdir' works in this case). >> >> For completeness, M-x shell works with either 'rm -r' and 'rmdir'. >> > > Are you sure this bug is not due to something going wrong on your > machine? I'm unable to reproduce this bug here, both Dired and Eshell > seem to work as expected. It could be, though I have only updated Emacs in the last ~10 days. What seems to be the issue is when a deleted entry of the same name already exists. I emptied my trash and tried the above recipe: the problem would not occur. But upon immediate retry the problem appeared, presumably because "test" already existed in the trash. > Did you by any chance define a 'system-move-file-to-trash' function? No > Does it work when you (setq trash-directory )? Yes, it does. Both for my original recipe and with the other case I mentioned above. I have always set this to nil, which makes it use the trash of freedesktop.org. -- Protesilaos Stavrou https://protesilaos.com From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Apr 2021 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Protesilaos Stavrou Cc: Lars Ingebrigtsen , 47960@debbugs.gnu.org Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.161921036430173 (code B ref 47960); Fri, 23 Apr 2021 20:40:02 +0000 Received: (at 47960) by debbugs.gnu.org; 23 Apr 2021 20:39:24 +0000 Received: from localhost ([127.0.0.1]:39011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la2aC-0007qa-F1 for submit@debbugs.gnu.org; Fri, 23 Apr 2021 16:39:24 -0400 Received: from heytings.org ([95.142.160.155]:50588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la2a9-0007qR-Vz for 47960@debbugs.gnu.org; Fri, 23 Apr 2021 16:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1619210360; bh=Fsu3A19ZaxUTm5JyhPGwhH85tAolTJqITRKj2c5CF44=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=aANI0sgC0doORcAAPIJpONFHruADHigPg61Qug1aNyrCe4n9ofvG2AJ8sgTWtBexw sDGGEBP+l7I6Oj6vKmEIP0Lg2wQ6K5JMdQxu6FCj0UnjUNI5lOzwMRIB8Ook/RKf/z B6frlIQvfvyqy0VVRe7l7s5Ou+yn8GyQU4vpWNS+lDVdByMRouVTm023SwESYQdCQe MCxtFpVW/kt7ZFfGdDy2q5kGI8w5XOOZmsG5k/u+MIpohTtbAUKuu0aAkAGwgt2hN9 ziE/DGY9/GE129oVctk64HnlI9zGn03ImxyHDAFIBV8LHlSCVMYvb01JKedEMD7JkS n6wHdPYyyjosQ== Date: Fri, 23 Apr 2021 20:39:20 +0000 From: Gregory Heytings In-Reply-To: <87bla66lp3.fsf@protesilaos.com> Message-ID: References: <87mttq6o6n.fsf@protesilaos.com> <87bla66lp3.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bh71MWLj8f" Content-ID: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --bh71MWLj8f Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: > > What seems to be the issue is when a deleted entry of the same name > already exists. I emptied my trash and tried the above recipe: the > problem would not occur. But upon immediate retry the problem appeared, > presumably because "test" already existed in the trash. > Indeed, this path of the code was recently changed (commit a5197e2240), and indeed, when a directory with the same name is trashed twice, it fails. Patch attached. (It can't be applied yet, I'm still waiting for the end of my paperwork.) --bh71MWLj8f Content-Type: text/x-diff; name=Fix-bug-when-moving-directories-to-trash.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: Content-Description: Content-Disposition: attachment; filename=Fix-bug-when-moving-directories-to-trash.patch RnJvbSA2OGRlY2U4YzgxMDQ1YWFkOGM1ODk3NzdhN2RjNjZhN2UzOGU2Mzg1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBGcmksIDIzIEFw ciAyMDIxIDIwOjMyOjAyICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBi dWcgd2hlbiBtb3ZpbmcgZGlyZWN0b3JpZXMgdG8gdHJhc2gNCg0KKiBsaXNw L2ZpbGVzLmVsIChtb3ZlLWZpbGUtdG8tdHJhc2gpOiBQYXNzIHRoZSBjb3Jy ZWN0IGRpci1mbGFnIHRvDQptYWtlLXRlbXAtZmlsZSBzbyB0aGF0IGEgZGly ZWN0b3J5IGlzIGNyZWF0ZWQgd2hlbiBhIGRpcmVjdG9yeSBpcw0KYmVpbmcg dHJhc2hlZCAoQnVnIzQ3OTYwKS4NCi0tLQ0KIGxpc3AvZmlsZXMuZWwgfCA0 ICsrKy0NCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlz cC9maWxlcy5lbA0KaW5kZXggNzQ0MGMxMWEyMS4uMjcyODJmMDlmYyAxMDA2 NDQNCi0tLSBhL2xpc3AvZmlsZXMuZWwNCisrKyBiL2xpc3AvZmlsZXMuZWwN CkBAIC03ODc4LDYgKzc4NzgsNyBAQCBtb3ZlLWZpbGUtdG8tdHJhc2gNCiAN CiAJICAgICAgIDs7IE1ha2UgYSAudHJhc2hpbmZvIGZpbGUuICBVc2UgT19F WENMLCBhcyBwZXIgdHJhc2gtc3BlYyAxLjAuDQogCSAgICAgICAobGV0KiAo KGZpbGVzLWJhc2UgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgZm4pKQ0KKyAg ICAgICAgICAgICAgICAgICAgICAoaXMtZGlyZWN0b3J5IChmaWxlLWRpcmVj dG9yeS1wIGZuKSkNCiAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJ3cml0 ZSBuaWwpDQogICAgICAgICAgICAgICAgICAgICAgIGluZm8tZm4pDQogICAg ICAgICAgICAgICAgICA7OyBXZSdyZSBjaGVja2luZyBmdXJ0aGVyIGRvd24g d2hldGhlciB0aGUgaW5mbyBmaWxlDQpAQCAtNzg4OSw3ICs3ODkwLDggQEAg bW92ZS1maWxlLXRvLXRyYXNoDQogICAgICAgICAgICAgICAgICAgICAgICAg IGZpbGVzLWJhc2UgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1ha2UtdGVtcC1maWxl DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXhw YW5kLWZpbGUtbmFtZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZpbGVzLWJhc2UgdHJhc2gtZmlsZXMtZGlyKSkpKSkNCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmaWxlcy1i YXNlIHRyYXNoLWZpbGVzLWRpcikNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGlzLWRpcmVjdG9yeSkpKSkNCiAJCSAoc2V0cSBp bmZvLWZuIChleHBhbmQtZmlsZS1uYW1lDQogCQkJCShjb25jYXQgZmlsZXMt YmFzZSAiLnRyYXNoaW5mbyIpDQogCQkJCXRyYXNoLWluZm8tZGlyKSkNCi0t IA0KMi4zMC4yDQoNCg== --bh71MWLj8f-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 07:02:25 2021 Received: (at control) by debbugs.gnu.org; 25 Apr 2021 11:02:25 +0000 Received: from localhost ([127.0.0.1]:42097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lacWv-0007Bo-Gg for submit@debbugs.gnu.org; Sun, 25 Apr 2021 07:02:25 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:40536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lacWu-00076H-40 for control@debbugs.gnu.org; Sun, 25 Apr 2021 07:02:24 -0400 Received: by mail-pg1-f180.google.com with SMTP id b17so1207267pgh.7 for ; Sun, 25 Apr 2021 04:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=3Ek4gM8eVbDxE/l70jEarihD/j7vQPbZ+BoBo2tmqoU=; b=OwBk/Bo5jYo+p5ifx7UnlFicFiBi5g3QzER2wmE6EX7JC/GrMZn6jBdnUGUEP7Taad TyPQ2GbeBkenmwm+un7fTFH/t19fBZifOyCekEY0KvpkcnGbuPzZgX2rUMYqxFb38xA2 ZP4eIZPriOE4rZ8oi8WigYVkh3+zFqNhJOK0x6bEoM3XdqC3Qxn3YHJ/tsdNCh4/aaa6 /C9AlIH63FSKAfROOp6h/Pwi4IxSVm2B9IKr03cy2X7mk1/uL05q3kXlLafh13CNZDsr 9JCE76XZ9IEHKtOpl1Xhsfgp0+hy46qGA+ydunBwYNue4PCtH83SdELpu8pdu8VAQvAY M1nw== X-Gm-Message-State: AOAM53370ILz1YUZI6f8hX0TCfvptJSgA+m+dMaRSATnSH6cpXpAUHP+ Ur3OC8MREEVPFFzMlO2aOdkVR74Fs0USyvILVgFTiPQZ X-Google-Smtp-Source: ABdhPJxynrwNGnixrWEyqpYGNVFQpOlhey7Tuy6fSVjtbJr7Ux7lbwQl5vr5x+LmOgGnTy9GY2O11uzM0GzzSJVNr8E= X-Received: by 2002:aa7:828f:0:b029:200:6e27:8c8f with SMTP id s15-20020aa7828f0000b02902006e278c8fmr12632560pfm.44.1619348538478; Sun, 25 Apr 2021 04:02:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 25 Apr 2021 06:02:18 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 25 Apr 2021 06:02:18 -0500 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47960 + patch thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.180 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.180 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47960 + patch thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.180 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.180 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different tags 47960 + patch thanks From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 20:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: Lars Ingebrigtsen , 47960@debbugs.gnu.org Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.162042010312070 (code B ref 47960); Fri, 07 May 2021 20:42:01 +0000 Received: (at 47960) by debbugs.gnu.org; 7 May 2021 20:41:43 +0000 Received: from localhost ([127.0.0.1]:45854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf7I7-00038c-8O for submit@debbugs.gnu.org; Fri, 07 May 2021 16:41:43 -0400 Received: from heytings.org ([95.142.160.155]:42004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf7I4-00038W-2O for 47960@debbugs.gnu.org; Fri, 07 May 2021 16:41:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620420099; bh=M02t/jsNitHI0xy5c4a7Xft5zJPqJDQucjmBxhN+VSc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Xt0icadBTIIZCIWB5xnR5Mi6hDnIPIu3ysHdOpSENGqRT2xmILHHJ0EtZ33Ph6abv F+svxSCuuwGNd8LbEV93EjdQXhlrWIown4+4pid1qpwEDXlckAzA8WHUazsw7Qbkv6 PW/hsvNjpC9V+9rC7x2+fABOiPrOD9L7C0txLXZnh5xf/+o7HJLRrihArQ4pgugAtB +ukbftDpFW/dELPRsaUA5BKaqoLjpFqeBIRuUUeowF4P7XIyJkLd2DhwEr5yQ77LVV 0U/hdKABN1MdnWtjScDQGODd8Yt2kOla3VqfzzGWLWFYJj+ScANCf3lxWRyFuS+AWw YdUSfQ66Cm+1g== Date: Fri, 07 May 2021 20:41:38 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <9d2af818310102f47009@heytings.org> References: <87mttq6o6n.fsf@protesilaos.com> <87bla66lp3.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) A shorter (and therefore better) patch to solve this issue has been proposed in bug#48280. It should be applied instead of this one. From debbugs-submit-bounces@debbugs.gnu.org Sat May 08 07:44:41 2021 Received: (at control) by debbugs.gnu.org; 8 May 2021 11:44:41 +0000 Received: from localhost ([127.0.0.1]:49711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfLNx-0006Fz-7S for submit@debbugs.gnu.org; Sat, 08 May 2021 07:44:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfLNv-0006Ft-EJ for control@debbugs.gnu.org; Sat, 08 May 2021 07:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qgWPH4GT4Fa7XSHfK+JqwkK5WASTaDU5WYOzXCf8eVg=; b=YqZHLdnTgtReCn6yVx7dVrSvCN Mql/cRRFquSz9bWvwFT4T6t2T9hCM4QfmD+oGgBzAbC0neMFova0Eo9JLEFr5yTvC7BfRpk1AJ2pG z6u2Ayzby9B75OmrY+WPDRWRtwBb6jzW3+ouWXwN/vqYx4mZ42f+Qsv1tv0WzXo+yKlQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfLNn-0003mo-U7 for control@debbugs.gnu.org; Sat, 08 May 2021 13:44:33 +0200 Date: Sat, 08 May 2021 13:44:30 +0200 Message-Id: <875yzttppd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48280 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 48280 47960 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 48280 47960 quit From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 18:23:37 2021 Received: (at control) by debbugs.gnu.org; 24 May 2021 22:23:37 +0000 Received: from localhost ([127.0.0.1]:44112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llIz3-0006f6-FK for submit@debbugs.gnu.org; Mon, 24 May 2021 18:23:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llIyx-0006ea-HC for control@debbugs.gnu.org; Mon, 24 May 2021 18:23:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F7IgUVtbeoxM0i47MsFth5fJtKQwS1+EHKFBrdlZ23Q=; b=ThELeB2Wv+zkI88a/yxkh0U8vi /x2gc4taa9+w13Egq2JdzV+0hDz5kO48Igty8Gxbeoy9IJrmGhUjzSvR5h0PpzbM4wxMclg3Gtc11 f2pmUaHv03D+vC9Xgo3URnbnmsFRfoipAO9scAWZBOZElZKiGm9NBZdX+LzndxYZMsRI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llIyq-0006xF-2F for control@debbugs.gnu.org; Tue, 25 May 2021 00:23:26 +0200 Date: Tue, 25 May 2021 00:23:23 +0200 Message-Id: <87v97793fo.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48280 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 48280 fixed close 48280 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 48280 fixed close 48280 28.1 quit From unknown Wed Aug 20 01:21:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 May 2021 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Gregory Heytings Cc: Protesilaos Stavrou , 47960@debbugs.gnu.org Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.162189518225923 (code B ref 47960); Mon, 24 May 2021 22:27:02 +0000 Received: (at 47960) by debbugs.gnu.org; 24 May 2021 22:26:22 +0000 Received: from localhost ([127.0.0.1]:44122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llJ1h-0006k3-U2 for submit@debbugs.gnu.org; Mon, 24 May 2021 18:26:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llJ1g-0006jp-90 for 47960@debbugs.gnu.org; Mon, 24 May 2021 18:26:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0z+4DBpB5RkciwGfGV/wFkdcxAnsmWGtAbbvbJR76QI=; b=l/3tlhKWmog9dmS2dxQt4Wh4mr GbODgNW4MZHgU9WJ2+MFqGGdl3ZQTBtkvkte4sb+HflWxVRpVup8Vgfgw3lvFPFbIyoWeYIIA+M/1 Dm9GFO149uewalU+AAPi8FA0z4luuqA/QvjivMLjwXnZVe6MrCH5alQk0S+NhQljUdiE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llJ1Y-0006yz-28; Tue, 25 May 2021 00:26:14 +0200 From: Lars Ingebrigtsen References: <87mttq6o6n.fsf@protesilaos.com> <87bla66lp3.fsf@protesilaos.com> <9d2af818310102f47009@heytings.org> X-Now-Playing: Mikel Rouse's _Swingers Castle_: "Ascending Room" Date: Tue, 25 May 2021 00:26:11 +0200 In-Reply-To: <9d2af818310102f47009@heytings.org> (Gregory Heytings's message of "Fri, 07 May 2021 20:41:38 +0000") Message-ID: <87pmxf93b0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gregory Heytings writes: > A shorter (and therefore better) patch to solve this issue has been > proposed in bug#48280. It should be applied instead of this one. Your version of the patch looked more obviously (well, somewhat) correct to me -- since it didn't change when the directory was created, if I read the two patches correctly. (Which may be important if [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gregory Heytings writes: > A shorter (and therefore better) patch to solve this issue has been > proposed in bug#48280. It should be applied instead of this one. Your version of the patch looked more obviously (well, somewhat) correct to me -- since it didn't change when the directory was created, if I read the two patches correctly. (Which may be important if there's a race condition.) And since the copyright clerk just said that your copyright assignment is complete, I've now applied and pushed your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 18:26:28 2021 Received: (at control) by debbugs.gnu.org; 24 May 2021 22:26:28 +0000 Received: from localhost ([127.0.0.1]:44125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llJ1o-0006kL-57 for submit@debbugs.gnu.org; Mon, 24 May 2021 18:26:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llJ1l-0006jv-AN for control@debbugs.gnu.org; Mon, 24 May 2021 18:26:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dJ4Aopkw/2Sb7+g54QwQjIda5Vrl6Dpfojv7cl4yEcI=; b=t1uNdNwgs6Gzq8nXFF+grQGwUK /5FxTkFkjtfBqjqK7wVueAYpYO1WG5ften7PtXrmbDuwLkLpu/VntZmQqwRTdBBhRDsIsaTJZbMRc DuL7rCYpryHwUamtCNOJYvEsP5aF+GCNFswnye09o0Yga4f8NWUElflx9NNGpm4hasI0=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llJ1d-0006zB-Qk for control@debbugs.gnu.org; Tue, 25 May 2021 00:26:19 +0200 Date: Tue, 25 May 2021 00:26:17 +0200 Message-Id: <87o8cz93au.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47960 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47960 fixed close 47960 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47960 fixed close 47960 28.1 quit