GNU bug report logs - #47944
Unable to customize button face in `describe-package'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47944 in the body.
You can then email your comments to 47944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Unable to customize button face in `describe-package'
Date: Wed, 21 Apr 2021 23:42:26 +0200

Severity: minor

There is currently no way to customize the button face in
`describe-package'; the face is hard-coded.  This leads to issues with
`hl-line-mode', for example:

    https://gitlab.com/protesilaos/modus-themes/-/issues/180

I'm thinking that we could just use the `custom-button' face here as it
looks similar enough, and should already exist in most popular themes.

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 64d7d56019..f2e83d3fda 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2696,9 +2696,9 @@ package-make-button
 function is a convenience wrapper used by `describe-package-1'."
   (let ((button-text (if (display-graphic-p) text (concat "[" text "]")))
         (button-face (if (display-graphic-p)
-                         '(:box (:line-width 2 :color "dark grey")
-                                :background "light grey"
-                                :foreground "black")
+                         (progn
+                           (require 'cus-edit) ; for the custom-button face
+                           'custom-button)
                        'link)))
     (apply #'insert-text-button button-text 'face button-face 'follow-link t
            properties)))

Thoughts?

Message #8 received at 47944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 47944 <at> debbugs.gnu.org
Subject: Re: bug#47944: Unable to customize button face in `describe-package'
Date: Fri, 23 Apr 2021 00:03:13 +0300

On 2021-04-21, 23:42 +0200, Stefan Kangas <stefan <at> marxist.se> wrote:

> Severity: minor
>
> There is currently no way to customize the button face in
> `describe-package'; the face is hard-coded.  This leads to issues with
> `hl-line-mode', for example:
>
>     https://gitlab.com/protesilaos/modus-themes/-/issues/180
>
> I'm thinking that we could just use the `custom-button' face here as it
> looks similar enough, and should already exist in most popular themes.
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index 64d7d56019..f2e83d3fda 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -2696,9 +2696,9 @@ package-make-button
>  function is a convenience wrapper used by `describe-package-1'."
>    (let ((button-text (if (display-graphic-p) text (concat "[" text "]")))
>          (button-face (if (display-graphic-p)
> -                         '(:box (:line-width 2 :color "dark grey")
> -                                :background "light grey"
> -                                :foreground "black")
> +                         (progn
> +                           (require 'cus-edit) ; for the custom-button face
> +                           'custom-button)
>                         'link)))
>      (apply #'insert-text-button button-text 'face button-face 'follow-link t
>             properties)))
>
> Thoughts?

Is there any chance that cus-edit, from whence custom-button comes from,
is not loaded while describe-package is in use?

Otherwise yes, I think that face feels right and would solve the issue
you linked to.

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #11 received at 47944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 47944 <at> debbugs.gnu.org
Subject: Re: bug#47944: Unable to customize button face in `describe-package'
Date: Sun, 25 Apr 2021 06:02:06 -0500

tags 47944 fixed
close 47944 28.1
thanks

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> On 2021-04-21, 23:42 +0200, Stefan Kangas <stefan <at> marxist.se> wrote:
>
>> Severity: minor
>>
>> There is currently no way to customize the button face in
>> `describe-package'; the face is hard-coded.  This leads to issues with
>> `hl-line-mode', for example:
>>
>>     https://gitlab.com/protesilaos/modus-themes/-/issues/180
>>
>> I'm thinking that we could just use the `custom-button' face here as it
>> looks similar enough, and should already exist in most popular themes.
>>
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 64d7d56019..f2e83d3fda 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -2696,9 +2696,9 @@ package-make-button
>>  function is a convenience wrapper used by `describe-package-1'."
>>    (let ((button-text (if (display-graphic-p) text (concat "[" text "]")))
>>          (button-face (if (display-graphic-p)
>> -                         '(:box (:line-width 2 :color "dark grey")
>> -                                :background "light grey"
>> -                                :foreground "black")
>> +                         (progn
>> +                           (require 'cus-edit) ; for the custom-button face
>> +                           'custom-button)
>>                         'link)))
>>      (apply #'insert-text-button button-text 'face button-face 'follow-link t
>>             properties)))
>>
>> Thoughts?
>
> Is there any chance that cus-edit, from whence custom-button comes from,
> is not loaded while describe-package is in use?

Yes, try:

0. emacs -Q
1. M-x describe-package RET <some package from GNU ELPA> RET

> Otherwise yes, I think that face feels right and would solve the issue
> you linked to.

Thanks, I have now pushed this to master.

Message #14 received at 47944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 47944 <at> debbugs.gnu.org
Subject: Re: bug#47944: Unable to customize button face in `describe-package'
Date: Sun, 25 Apr 2021 21:00:10 +0300

On 2021-04-25, 06:02 -0500, Stefan Kangas <stefan <at> marxist.se> wrote:

> tags 47944 fixed
> close 47944 28.1
> thanks

[...]

> Thanks, I have now pushed this to master.

Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.