GNU bug report logs - #47935
coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs

Previous Next

To reply to this bug, email your comments to 47935 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: bug-guix <at> gnu.org
Subject: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs
Date: Wed, 21 Apr 2021 11:35:50 -0400

Hi all,

I’m continuing my testing of the 1.3.0 branch, and I’ve found that coreutil's tests/tail-2/inotify-dir-recreate.sh fails on filesystems where tail detects that it cannot use inotify safely (probably arising out of this check: https://github.com/coreutils/coreutils/blob/34a48bf0f0552aaed21a7dba4a5488946a978317/src/tail.c#L2486-L2491). Example for this: overlayfs used by docker/podman/etc.

The author of tail’s inotify support explains it here: https://github.com/containers/podman/issues/5493#issuecomment-598851397

A quick and easy fix for v1.3.0 may be to just disable tests/tail-2/inotify-dir-recreate.sh :-)

Cheers,
Carl Dong
contact <at> carldong.me
"I fight for the users"

Message #8 received at 47935 <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: 47935 <at> debbugs.gnu.org
Subject: Re: bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails
 on overlayfs
Date: Wed, 21 Apr 2021 21:20:25 -0400

Upstream bug filed: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47940

Message #13 received at 47935 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Carl Dong <contact <at> carldong.me>
Cc: 47935 <at> debbugs.gnu.org
Subject: Re: bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh
 fails on overlayfs
Date: Thu, 03 Jun 2021 21:29:09 +0200

Hi Carl,

Carl Dong <contact <at> carldong.me> skribis:

> I’m continuing my testing of the 1.3.0 branch, and I’ve found that coreutil's tests/tail-2/inotify-dir-recreate.sh fails on filesystems where tail detects that it cannot use inotify safely (probably arising out of this check: https://github.com/coreutils/coreutils/blob/34a48bf0f0552aaed21a7dba4a5488946a978317/src/tail.c#L2486-L2491). Example for this: overlayfs used by docker/podman/etc.
>
> The author of tail’s inotify support explains it here: https://github.com/containers/podman/issues/5493#issuecomment-598851397

[...]

> Upstream bug filed: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47940

With people more on more interested in finally getting ‘core-updates’
merged, now’s a good time to look into this bug.  :-)

In the bug report upstream, you hint at a possible fix.  Could you
provide a patch for this?

Alternatively, if that turns out to be too tricky, can you think of a
workaround, such as skipping the offending code during tests?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.