GNU bug report logs - #47930
[PATCH] gnu: Add pbgzip.

Previous Next

Full log

Message #20 received at 47930 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Efraim Flashner <efraim <at> flashner.co.il>,
 Maxime Devos <maximedevos <at> telenet.be>, Xinglu Chen <public <at> yoctocell.xyz>
Cc: 47930 <at> debbugs.gnu.org
Subject: Re: [bug#47930] [PATCH] gnu: Add pbgzip.
Date: Thu, 29 Apr 2021 14:22:43 +0200

[Message part 1 (text/plain, inline)]

On 4/29/21 9:29 AM, Efraim Flashner wrote:
> On Thu, Apr 22, 2021 at 06:40:46PM +0200, Maxime Devos wrote:
>> Xinglu Chen schreef op wo 21-04-2021 om 23:45 [+0200]:
>>> On Wed, Apr 21 2021, Roel Janssen wrote:
>>>
>>>> [...]
>>>> +      (arguments
>>>> +       `(#:phases
>>>> +         (modify-phases %standard-phases
>>>> +           (add-after 'unpack 'autogen
>>>> +             (lambda _
>>>> +               (zero? (system* "sh" "autogen.sh")))))))
>>> IIRC, phases don’t have to return #t, so you could remove ‘zero?’.
>> Try running (system* "does-not-exist").  It will fail by returning
>> something non-zero.  If I recall how to call "invoke" correctly,
>> I would recommend (invoke "sh" "autogen.sh") here.  "invoke" raises
>> an exception when the command fails, instead of returning something.
> While we're at it, can this phase replace 'bootstrap? It seems to me we
> shouldn't need both phases.
This indeed seems to be the best thing to do.  I attached a new patch.

I had to leave autoconf and automake in the native-inputs because
otherwise the command "aclocal" and "autom4te" couldn't be found.

Thanks all for the feedback!  I hope this new patch is fine.

Kind regards,
Roel Janssen

[0001-gnu-Add-pbgzip.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.