GNU bug report logs - #47930
[PATCH] gnu: Add pbgzip.

Previous Next

Full log

Message #14 received at 47930 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Xinglu Chen <public <at> yoctocell.xyz>, Roel Janssen <roel <at> gnu.org>, 
 47930 <at> debbugs.gnu.org
Subject: Re: [bug#47930] [PATCH] gnu: Add pbgzip.
Date: Thu, 22 Apr 2021 18:40:46 +0200

[Message part 1 (text/plain, inline)]

Xinglu Chen schreef op wo 21-04-2021 om 23:45 [+0200]:
> On Wed, Apr 21 2021, Roel Janssen wrote:
> 
> > [...]
> > +      (arguments
> > +       `(#:phases
> > +         (modify-phases %standard-phases
> > +           (add-after 'unpack 'autogen
> > +             (lambda _
> > +               (zero? (system* "sh" "autogen.sh")))))))
> 
> IIRC, phases don’t have to return #t, so you could remove ‘zero?’.

Try running (system* "does-not-exist").  It will fail by returning
something non-zero.  If I recall how to call "invoke" correctly,
I would recommend (invoke "sh" "autogen.sh") here.  "invoke" raises
an exception when the command fails, instead of returning something.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.