GNU bug report logs - #47925
28.0.50; define-minor-mode without body results in false warning

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47925: closed (28.0.50; define-minor-mode without body
 results in false warning)
Date: Tue, 27 Apr 2021 13:28:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 27 Apr 2021 09:27:45 -0400
with message-id <jwvv987n9h7.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#47925: 28.0.50; define-minor-mode without body results in false warning
has caused the debbugs.gnu.org bug report #47925,
regarding 28.0.50; define-minor-mode without body results in false warning
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47925: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47925
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; define-minor-mode without body results in false warning
Date: Wed, 21 Apr 2021 00:24:06 +0200

I have a mode that leaves out all the optional arguments because its
sole purpose is the enable its minor-mode map:

  (define-minor-mode transient-resume-mode
    "Auxiliary minor-mode used to resume a transient after viewing help.")

which is supported:

  (define-minor-mode MODE DOC [KEYWORD VAL ... &rest BODY])

Unfortunately that results in a warning:

  transient.el:3318:20: Warning: Use keywords rather than deprecated positional
      arguments to `define-minor-mode'

because INIT-VALUE is nil in this case, not keywordp.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 47925-done <at> debbugs.gnu.org
Subject: Re: bug#47925: 28.0.50; define-minor-mode without body results in
 false warning
Date: Tue, 27 Apr 2021 09:27:45 -0400

>> I have pushed a patch to `master` which hopefully fixes this without
>> introducing regressions.
> That seems to be working.  Thanks!

Thanks, closing,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.