GNU bug report logs - #47921
[PATCH] build: Fix elf-dynamic-info-soname.

Previous Next

Package: guix-patches;

Reported by: Dion Mendel <guix <at> dm9.info>

Date: Tue, 20 Apr 2021 20:57:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Dion Mendel <guix <at> dm9.info>, 47921 <at> debbugs.gnu.org
Subject: [bug#47921] [PATCH] build: Fix elf-dynamic-info-soname.
Date: Wed, 21 Apr 2021 13:49:33 +0200
[Message part 1 (text/plain, inline)]
Dion Mendel schreef op wo 21-04-2021 om 03:44 [+0800]:
> * guix/build/gremlin.scm (elf-dynamic-info-soname): Return the value of
>   the dynamic-entry instead of the dynamic-entry record itself.

1. IIUC, this change would cause a world-rebuild, so this patch would have
   to applied on core-updates.  The subject line should have been
   [PATCH core-updates]: etcetera.
2. How did you test this patch?
3. What does this patch fix?
4. elf-dynamic-info-soname is a record accessor.  Did you mean elf-dynamic-info?
5. According to the docstring (core-updates, c9a61dff8242612ae8275829a5ee31ff45ff08b1):

  "Return dynamic-link information for ELF as an <elf-dynamic-info> object, or
#f if ELF lacks dynamic-link information."

  So this patch actually _introduces_ a bug.  Or you need to modify the docstring
  as well.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.