GNU bug report logs - #47907
[PATCHES] Jupyter Notebook: Enable tests.

Previous Next

Package: guix-patches;

Reported by: Lars-Dominik Braun <lars <at> 6xq.net>

Date: Tue, 20 Apr 2021 09:50:02 UTC

Severity: normal

Tags: patch

Done: Lars-Dominik Braun <lars <at> 6xq.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47907: closed ([PATCHES] Jupyter Notebook: Enable tests.)
Date: Mon, 26 Apr 2021 08:40:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 26 Apr 2021 10:39:39 +0200
with message-id <YIZ8S88uM6yoi2DX <at> noor.fritz.box>
and subject line Re: [PATCHES] Jupyter Notebook: Enable tests.
has caused the debbugs.gnu.org bug report #47907,
regarding [PATCHES] Jupyter Notebook: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47907: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47907
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Lars-Dominik Braun <lars <at> 6xq.net>
To: guix-patches <at> gnu.org
Subject: [PATCHES] Jupyter Notebook: Enable tests.
Date: Tue, 20 Apr 2021 11:49:00 +0200
[Message part 3 (text/plain, inline)]
Hi,

this patch series is mostly a QA patchset and enables tests on most of
Jupyter Notebook’s components. There are also two possibly controversial
changes:

- It moves the definition of JUPYTER_PATH to jupyter-core. I’d argue
  this is the more correct approach, because that package actually deals
  with this search path and installing any Jupyter package makes it work
  out of the box without installing the strange jupyter meta-package.
- It enables pandoc/LaTeX for nbconvert. The Notebook lists PDF output
  in its “Export as” menu and I feel both are useful, even though they
  increase the closure.

You can also pull the patchset here:
https://github.com/PromyLOPh/guix/tree/work-merge-jupyter

Cheers,
Lars

Lars-Dominik Braun (12):
  gnu: Move search path JUPYTER_PATH.
  gnu: python-jupyter-core: Enable tests.
  gnu: Add python-json-spec.
  gnu: Add python-fastjsonschema.
  gnu: python-nbformat: Enable tests.
  gnu: Add python-jupyter-client-bootstrap.
  gnu: Add python-ipykernel-bootstrap.
  gnu: python-jupyter-client: Enable tests.
  gnu: python-ipykernel: Add missing inputs.
  gnu: Add python-pytest-dependency.
  gnu: python-nbconvert: Enable more tests.
  gnu: python-notebook: Fix tests.

 gnu/packages/check.scm      |  23 +++
 gnu/packages/python-xyz.scm | 281 ++++++++++++++++++++++++++++++------
 2 files changed, 256 insertions(+), 48 deletions(-)

-- 
2.26.3

[0002-gnu-python-jupyter-core-Enable-tests.patch (text/x-diff, attachment)]
[0011-gnu-python-nbconvert-Enable-more-tests.patch (text/x-diff, attachment)]
[0012-gnu-python-notebook-Fix-tests.patch (text/x-diff, attachment)]
[0004-gnu-Add-python-fastjsonschema.patch (text/x-diff, attachment)]
[0001-gnu-Move-search-path-JUPYTER_PATH.patch (text/x-diff, attachment)]
[0006-gnu-Add-python-jupyter-client-bootstrap.patch (text/x-diff, attachment)]
[0009-gnu-python-ipykernel-Add-missing-inputs.patch (text/x-diff, attachment)]
[0010-gnu-Add-python-pytest-dependency.patch (text/x-diff, attachment)]
[0005-gnu-python-nbformat-Enable-tests.patch (text/x-diff, attachment)]
[0003-gnu-Add-python-json-spec.patch (text/x-diff, attachment)]
[0007-gnu-Add-python-ipykernel-bootstrap.patch (text/x-diff, attachment)]
[0008-gnu-python-jupyter-client-Enable-tests.patch (text/x-diff, attachment)]
[Message part 16 (message/rfc822, inline)]
From: Lars-Dominik Braun <lars <at> 6xq.net>
To: 47907-done <at> debbugs.gnu.org
Subject: Re: [PATCHES] Jupyter Notebook: Enable tests.
Date: Mon, 26 Apr 2021 10:39:39 +0200
Hi,

I merged them with minor modifications based on Ricardo’s suggestions as
2209e5c7531bfe5e81c86f0a581d16569ee9b719 and preceding.




This bug report was last modified 4 years and 22 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.