GNU bug report logs - #47898
[PATCH] [core-updates] Add option --xpath0 to xmllint from libxml2

Previous Next

Full log

Message #26 received at 47898 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: Marius Bakke <marius <at> gnu.org>
Cc: 47898 <at> debbugs.gnu.org
Subject: Re: [bug#47898] [PATCH] [core-updates] Add option --xpath0 to xmllint
 from libxml2
Date: Sat, 15 May 2021 21:21:50 +0200

[Message part 1 (text/plain, inline)]

> Please also register this patch in gnu/local.mk.  Can you also add your
> copyright at the top of xml.scm?

Done!

> 
> [...]
> 
>> +(define-public libxml2-xpath0
>> +  (package
>> +    (name "libxml2-xpath0")
>> +    (version "2.9.10")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append "ftp://xmlsoft.org/libxml2/libxml2-"
>> +                                 version ".tar.gz"))
>> +             (sha256
>> +              (base32
>> +               
>> "07xynh8hcxb2yb1fs051xrgszjvj37wnxvxgsj10rzmqzy9y3zma"))
>> +             (patches (list (search-patch 
>> "libxml2-Add-option-xpath0.patch")))))
> 
> You can inherit another record in Scheme to avoid duplicating all the
> fields.  Then the package can be shortened to:
> 
>   (define-public libxml2-xpath0
>     (package/inherit libxml2
>       (name "libxml2-xpath0")
>       (source (origin
>                 (inherit (package-source libxml2))
>                 (patches (append (search-patches
> "libxml2-Add-option-xpath0.patch")
>                                  (origin-patches (package-source 
> libxml2))))))
>       (description
>        "...")))
> 
> We should fill out that description to mention how it differs from the
> regular libxml2.  Can you give it a try?  I can make the other changes
> on your behalf, but not sure what to write.
> 
> Thanks,
> Marius

Hi, new patch attached. There's a lint warning though: 
"libxml2-xpath0 <at> 2.9.10: no updater for libxml2-xpath0". I don't know 
what it means, maybe it should be fixed before committing?

Best regards,
David

[0001-gnu-libxml2-xpath0-New-package-with-patch-for-xpath0.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.