Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk

From: Ludovic Courtès <[email-masked]>
Date: Mon, 26 Apr 2021 17:53:54 +0200

Hi Mathieu,

Mathieu Othacehe <[email-masked]> skribis:

>> Can you force GPT also in 2.?  All disk partitions get removed anyway.
>> Arch wiki says MSDOS layout does not work on all EFI systems
>> <https://wiki.archlinux.org/index.php/EFI_system_partition#Create_the_partition>.
>
> Well I'm not sure, if someone has an MSDOS partition table with an ESP
> partition it wouldn't be a good idea to wipe it.
>
> The attached patch forces GPT if there's no partition table, and will
> preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it
> on various machines, seems to work fine.

The patch looks reasonable to me, thanks a lot!

(It’s also reasonable to ignore ESP-on-MSDOS IMO.)

Ludo’.