From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 05:30:10 2021 Received: (at submit) by debbugs.gnu.org; 19 Apr 2021 09:30:10 +0000 Received: from localhost ([127.0.0.1]:48437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQEL-0005HZ-T1 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 05:30:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:52438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQEJ-0005HQ-UD for submit@debbugs.gnu.org; Mon, 19 Apr 2021 05:30:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYQEJ-0005et-NI for bug-guix@gnu.org; Mon, 19 Apr 2021 05:30:07 -0400 Received: from pelzflorian.de ([5.45.111.108]:41614 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYQEH-0004Hg-6l for bug-guix@gnu.org; Mon, 19 Apr 2021 05:30:07 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id D8E1936063C for ; Mon, 19 Apr 2021 11:30:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1618824602; bh=u/br9LZEKKL6CMh1lBFBTWEbFC6fKk1M/vmqwNkVdw8=; h=Date:From:To:Subject; b=C3t5LRbuqJ8ZWUmBiaHXiFaPs4CI/zny7TourIwGO83N31Tqi//BQyKjseC3RtAIK 6UoXrTsrK1MabbvNpdkx5Pl9U6yZQGCMaPJXQKcVYdPDm9ZE5HF3wHiaZ1fKlp3w// KZDogpoXY3/xldPB2c294NjnNxKXCycJPom9Vy8w= Date: Mon, 19 Apr 2021 11:29:54 +0200 From: "pelzflorian (Florian Pelz)" To: bug-guix@gnu.org Subject: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When installing from the Guix install image, grub-install fails on my x86_64 ASRock Beebox PC: guix system: error: '/gnu/store/hsc3gsqbxkl64nx38sf2fgs2fxzbpr0i-grub-efi-2.04/sbin/grub-install --boot-directory /mnt/boot --bootloader-id=Guix --efi-directory /boot/efi' exited with status 1; output follows: Installing for x86_64-efi platform. /gnu/store/hsc3gsqbxkl64nx38sf2fgs2fxzbpr0i-grub-efi-2.04/sbin/grub-install: error: failed to get canonical path of `/boot/efi'. I let the Guix installer (git master commit fef2f08bc640f78cc0a86fc7be3eccbc07b5e98c) auto-partition my entire disk without encryption. “fdisk -l /dev/sda” shows: Disk /dev/sda: 238.49 GiB, 256060514304 bytes, 500118192 sectors […] Disklabel type: dos Disk identifier: 0xd0416d83 Device Boot Start End Sectors Size Id Type /dev/sda1 2048 7811071 7009024 3.7G 82 Linux swap / Solaris /dev/sda2 * 7011072 500117583 492306432 234.8G 83 Linux Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 07:01:55 2021 Received: (at 47889) by debbugs.gnu.org; 19 Apr 2021 11:01:55 +0000 Received: from localhost ([127.0.0.1]:48506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYRf8-0007j0-PG for submit@debbugs.gnu.org; Mon, 19 Apr 2021 07:01:55 -0400 Received: from pelzflorian.de ([5.45.111.108]:49680 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYRf4-0007il-8d for 47889@debbugs.gnu.org; Mon, 19 Apr 2021 07:01:53 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 17FF036063C for <47889@debbugs.gnu.org>; Mon, 19 Apr 2021 13:01:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1618830108; bh=DYlyW+5w6ZKLhhzjUNNP5P5gf2K6KCjKi8cK+LuYnM0=; h=Date:From:To:Subject:References:In-Reply-To; b=UMLEaHVdyf9aO9gazccjHGAP7cr0Z2wUy2pzax921Ms2MoiooAkKCH+BjLKjw1Q4K IQotEphahh4dGUd2fWgQWOuTFDUUe5pX0xFtj9DtHwHACeazT9qXSuAv/FzObDG9qv TSlR5gczoFmCqdHdKc25RC8S1iJ0DTW0i3eNap2w= Date: Mon, 19 Apr 2021 13:01:40 +0200 From: "pelzflorian (Florian Pelz)" To: 47889@debbugs.gnu.org Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210419110049.pua6fewptt6uzxge@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 11:29:54AM +0200, pelzflorian (Florian Pelz) wrote: > When installing from the Guix install image, grub-install fails on my > x86_64 ASRock Beebox PC: This error occurred on multiple install attempts, but apparently the last one broke my UEFI; the Beebox can no longer output anything on the screen. I will need some time until I can jumper the mainboard. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 13:27:53 2021 Received: (at 47889) by debbugs.gnu.org; 19 Apr 2021 17:27:53 +0000 Received: from localhost ([127.0.0.1]:51927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXgf-0006WD-6m for submit@debbugs.gnu.org; Mon, 19 Apr 2021 13:27:53 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:39261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXga-0006Vx-5i for 47889@debbugs.gnu.org; Mon, 19 Apr 2021 13:27:51 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 61AF91353; Mon, 19 Apr 2021 13:27:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 19 Apr 2021 13:27:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=23zNQ/q708yeW/d2ils3BP8Q RXhfd6ky5CklaMmVWmk=; b=ftw+EvIpYSne3hg01HPneTU1MyBaziEV1XAwt0PC CDRpxHEKo89uV0oTvmxP2cTIWdrRIISHl0wHMZIALhYVFNcMcZKhDykMTt2AX2Dq SpJFFoQm3BhuOKeGHvi3vuuZwfQF0mmz2DrHKubt1h37M2EtpI8tbfnJzqDF0YR9 TBU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=23zNQ/ q708yeW/d2ils3BP8QRXhfd6ky5CklaMmVWmk=; b=nngGf7SlkTbNHUAyplkMOh mDIJSWp/lh3z9+mfacV7NppgsjggGLFGCRZFc7LGykhmJQDQ2ovjgLyYcq5AZLQr IJW5f/pNy7d/O6DprzrdbZ4UeAAdO/sU/htleypZdu/nyEBKqh7vb6zp4G6Dv7ZM FNXPw0bV3E/FbX4XlFEeFqdzVqVE3Qm3WBXZ/oBH7VFiOMakdNdZfJIByI+ev8no 7uLcvNiIyRNCTjz5RVYI9XNYF88QQl/dGCEHSco3YNKfIvisOkc2rLWr2VTUVvTj hhWEV1K5sBeMD+Wn7Njvr0aaWqQJN3/uXSa8wWhG5EZ5puMEzq+aJlD7MQidNmOg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id A69D4108006A; Mon, 19 Apr 2021 13:27:40 -0400 (EDT) Date: Mon, 19 Apr 2021 13:27:39 -0400 From: Leo Famulari To: "pelzflorian (Florian Pelz)" Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47889 Cc: 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Apr 19, 2021 at 11:29:54AM +0200, pelzflorian (Florian Pelz) wrote: > When installing from the Guix install image, grub-install fails on my > x86_64 ASRock Beebox PC: Can you be specific about which install image you used? For example, can you provide the URL of the image? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 16:19:21 2021 Received: (at 47889) by debbugs.gnu.org; 19 Apr 2021 20:19:21 +0000 Received: from localhost ([127.0.0.1]:52185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYaMa-0002QQ-Uf for submit@debbugs.gnu.org; Mon, 19 Apr 2021 16:19:21 -0400 Received: from pelzflorian.de ([5.45.111.108]:50196 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYaMX-0002QF-A1 for 47889@debbugs.gnu.org; Mon, 19 Apr 2021 16:19:19 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id C1E9E36063C; Mon, 19 Apr 2021 22:19:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1618863555; bh=/es1GT6YA1EBUUm/d6yhe6y3BxYFD6mCCY4WCzy6wMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=R4UOVYDZjTqE1pZZOXQuDPuQ2sm9wB+RtCMsmBBc3smbz1eCIAuxpYW7pyd8j2K6u YV5pBdCdi7ApAneDcCxE+zGepdT2qG2G7d5ogMplVWCiLR4co/I4ufzGcp0Mg7TWMj gE6+pmkPvbUJ/r5umGqW/7TmjIXNFDsXl2tRZ4Vs= Date: Mon, 19 Apr 2021 22:19:04 +0200 From: "pelzflorian (Florian Pelz)" To: Leo Famulari Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210419200342.pkqexpuiz5dq5ury@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 01:27:39PM -0400, Leo Famulari wrote: > On Mon, Apr 19, 2021 at 11:29:54AM +0200, pelzflorian (Florian Pelz) wrote: > > When installing from the Guix install image, grub-install fails on my > > x86_64 ASRock Beebox PC: > > Can you be specific about which install image you used? For example, can > you provide the URL of the image? This one: https://ci.guix.gnu.org/build/175632/details Same thing happened on an image manually created by running ./pre-inst-env guix system image -t iso9660 gnu/system/install.scm on commit fef2f08bc640f78cc0a86fc7be3eccbc07b5e98c (after fixing it by removing the broken “vi” entry from po/packages/LINGUAS which Julien had only fixed in a later commit). Regards, Florian P.S. I can test again, the PC works again after clearing the CMOS. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 20:26:21 2021 Received: (at control) by debbugs.gnu.org; 20 Apr 2021 00:26:21 +0000 Received: from localhost ([127.0.0.1]:52397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYeDd-000494-MP for submit@debbugs.gnu.org; Mon, 19 Apr 2021 20:26:21 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYeDb-00048n-D3 for control@debbugs.gnu.org; Mon, 19 Apr 2021 20:26:20 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 48A655C02DC; Mon, 19 Apr 2021 20:26:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 19 Apr 2021 20:26:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=rkAx6Mk4rvK5q3YOLAeFtr80co0lScZWfY//3+XE7cw=; b=nOJY6pkKP7zk O9QHY7WwveS6zZ4dsOnyWKGZ1Ve4pOtqlGnCYv0lgvJB8vp0PoFdH3XrAWt5Wow+ WQND89sixuVlpga/FMDOE/rr1cIdyKq0N4Dwqo2ErbTlXOQj7EIObc1uGCQ8/Bvn A6yGL37XeIN/79phDQESDkHj67A1cno= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rkAx6Mk4rvK5q3YOLAeFtr80co0lScZWfY//3+XE7 cw=; b=v5D0rpT430aoa0QpFNYp78Jg3CrNpVmx8l+vlnaQ8N9w8W4CTHKySV6xs hC4uxtL9pBE0Uml88bfexAj/5aGbSkV7BGAIl6WXmZXmKFw2C7S8XmJVUSWjrZxW op81pZ4CwQG6bhDzjnmhixgYQvwz0GP6w4EIgs9D47PEfZdy7mZv06+UWBWMgbGt vyUAVglyJSK9ZKlT59vllbBnHxWpsMLwi4CO2SkRu/yMXlQkayo/7tNOa+NaqJwM t6D5mfHlCPylPJEbEf4PUbzX3GFrSVcSyuUdnhglPsZHzJyypPKW0ic9z5L4tEa2 5itzXHzAIVsjcFY+llvJe92Iyn+ig== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpeffhffvkfggtggusehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhl rghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpe fhjeeigfefvedvfeetheegledtkeevuddtgedtudeiteehteegvdefffduffefffenucfk phepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id C0E08240054 for ; Mon, 19 Apr 2021 20:26:12 -0400 (EDT) Date: Mon, 19 Apr 2021 20:26:11 -0400 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: block 47297 with 47889 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.27 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [66.111.4.27 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) block 47297 with 47889 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 09:28:50 2021 Received: (at 47889) by debbugs.gnu.org; 22 Apr 2021 13:28:51 +0000 Received: from localhost ([127.0.0.1]:33178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZZNy-0006lj-JA for submit@debbugs.gnu.org; Thu, 22 Apr 2021 09:28:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZZNv-0006lU-Qd for 47889@debbugs.gnu.org; Thu, 22 Apr 2021 09:28:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZZNq-0005Pi-Bo; Thu, 22 Apr 2021 09:28:42 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33230 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZZNp-0007CA-FW; Thu, 22 Apr 2021 09:28:41 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> Date: Thu, 22 Apr 2021 15:28:39 +0200 In-Reply-To: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Mon, 19 Apr 2021 11:29:54 +0200") Message-ID: <878s5a1m9k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Florian, "pelzflorian (Florian Pelz)" skribis: > When installing from the Guix install image, grub-install fails on my > x86_64 ASRock Beebox PC: > > guix system: error: '/gnu/store/hsc3gsqbxkl64nx38sf2fgs2fxzbpr0i-grub-efi= -2.04/sbin/grub-install --boot-directory /mnt/boot --bootloader-id=3DGuix -= -efi-directory /boot/efi' exited with status 1; output follows: > > Installing for x86_64-efi platform. > /gnu/store/hsc3gsqbxkl64nx38sf2fgs2fxzbpr0i-grub-efi-2.04/sbin/grub-inst= all: error: failed to get canonical path of `/boot/efi'. > > I let the Guix installer (git master commit > fef2f08bc640f78cc0a86fc7be3eccbc07b5e98c) auto-partition my entire > disk without encryption. > > =E2=80=9Cfdisk -l /dev/sda=E2=80=9D shows: > > Disk /dev/sda: 238.49 GiB, 256060514304 bytes, 500118192 sectors > [=E2=80=A6] > Disklabel type: dos > Disk identifier: 0xd0416d83 > > Device Boot Start End Sectors Size Id Type > /dev/sda1 2048 7811071 7009024 3.7G 82 Linux swap / Solaris > /dev/sda2 * 7011072 500117583 492306432 234.8G 83 Linux There=E2=80=99s no EFI (vfat) partition here. Is it an EFI machine? Is /boot/efi mounted when you boot the installation image? If it were EFI, it would be a GPT partition table, not a DOS one. It seems to me there=E2=80=99s confusion here: the generated config file se= ems to be using =E2=80=98grub-efi-bootloader=E2=80=99, but the machine is actua= lly not EFI. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 10:39:07 2021 Received: (at 47889) by debbugs.gnu.org; 22 Apr 2021 14:39:07 +0000 Received: from localhost ([127.0.0.1]:35246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZaTz-00070i-JO for submit@debbugs.gnu.org; Thu, 22 Apr 2021 10:39:07 -0400 Received: from pelzflorian.de ([5.45.111.108]:53724 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZaTu-00070E-7j for 47889@debbugs.gnu.org; Thu, 22 Apr 2021 10:39:06 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 8B16D36063C; Thu, 22 Apr 2021 16:39:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1619102340; bh=U1ydAKW7mmOqxf4Jpt0sg+Q9B2+AJMdS2ZxTsGFLqe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=uAs5eezLG64wVLmNvplNh2GHAUqbwKU85mo+WvoTyJRCAu5myWLta0JbJiCk7b95a xzzrPTlxJjgkxogZfrg6hgcRt4HzJLwnAk1lPziluqe0mSLAuF6O7WVYE4WBkpzG7O mt27wbgRqx1+611cUMOt4MiM4UbYSkDP4uw56oKM= Date: Thu, 22 Apr 2021 16:38:52 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878s5a1m9k.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Apr 22, 2021 at 03:28:39PM +0200, Ludovic Courtès wrote: > There’s no EFI (vfat) partition here. Is it an EFI machine? > > Is /boot/efi mounted when you boot the installation image? No because there is no EFI partition. If I create one and restart the installer, then it is *not* mounted either, only /mnt/boot/efi later during the install. (I believe since the installer is installed as on an external medium, it does not need an EFI partition.) I had booted the install image via UEFI boot and had expected auto partitioning and the default configuration to do the right thing. > If it were EFI, it would be a GPT partition table, not a DOS one. Thank you for explaining. If Guix defaults require GPT on EFI (according to ) some computers apparently really do not support dos partition tables for the EFI system partition), then I think gnu/installer/newt/partition.scm should disallow selecting a DOS scheme when auto partitioning the entire disk. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 06:39:28 2021 Received: (at 47889) by debbugs.gnu.org; 23 Apr 2021 10:39:28 +0000 Received: from localhost ([127.0.0.1]:36235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtDb-0004rZ-T1 for submit@debbugs.gnu.org; Fri, 23 Apr 2021 06:39:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtDX-0004rH-As for 47889@debbugs.gnu.org; Fri, 23 Apr 2021 06:39:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43727) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtDR-0000Dy-Ia; Fri, 23 Apr 2021 06:39:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41148 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZtDP-0008OS-Mv; Fri, 23 Apr 2021 06:39:16 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 23 Apr 2021 12:39:13 +0200 In-Reply-To: <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Thu, 22 Apr 2021 16:38:52 +0200") Message-ID: <87im4ds2su.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: Mathieu Othacehe , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Florian, (Cc: Mathieu.) "pelzflorian (Florian Pelz)" skribis: > On Thu, Apr 22, 2021 at 03:28:39PM +0200, Ludovic Court=C3=A8s wrote: >> There=E2=80=99s no EFI (vfat) partition here. Is it an EFI machine? >>=20 >> Is /boot/efi mounted when you boot the installation image? > > No because there is no EFI partition. If I create one and restart the > installer, then it is *not* mounted either, only /mnt/boot/efi later > during the install. (I believe since the installer is installed as on > an external medium, it does not need an EFI partition.) > > I had booted the install image via UEFI boot and had expected auto > partitioning and the default configuration to do the right thing. The installer determines whether it=E2=80=99s doing a UEFI installation lik= e so: (define (efi-installation?) "Return #t if an EFI installation should be performed, #f otherwise." (file-exists? "/sys/firmware/efi")) It uses that to determine whether to create an EFI System Partition (ESP) and whether to use =E2=80=98grub-efi-bootloader=E2=80=99. Did it create an ESP in your case? I=E2=80=99m not entirely sure how it decides between GPT and DOS, though; Mathieu? We should add UEFI installation tests using OVMF. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 07:12:29 2021 Received: (at 47889) by debbugs.gnu.org; 23 Apr 2021 11:12:29 +0000 Received: from localhost ([127.0.0.1]:36266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtjY-0005gN-Po for submit@debbugs.gnu.org; Fri, 23 Apr 2021 07:12:29 -0400 Received: from pelzflorian.de ([5.45.111.108]:54756 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtjU-0005gC-5E for 47889@debbugs.gnu.org; Fri, 23 Apr 2021 07:12:27 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 0218636063C; Fri, 23 Apr 2021 13:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1619176343; bh=dB1l9hr12SW0I+Tw76twBHw8pBv5DcERshfvhYwR72M=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=3NI1HJy8ensvb+thWpOuJVz6ops1dZgWk7ACTUtt2NmGgx80M/4dRfOZCSMrZuCxx PMNC25J1WJyfdcQ2UIfVtcvgYhQpwALrXO1Fxg9JT/MX5C59+vRTDyeYLUIuJ+qh9O FfF6HHyR92OoMx+BXypaNgdlQm4/fy2C4OnfnBnM= Date: Fri, 23 Apr 2021 13:12:11 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210423111211.jauxzqx6uqh5c76e@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87im4ds2su.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: Mathieu Othacehe , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Apr 23, 2021 at 12:39:13PM +0200, Ludovic Courtès wrote: > The installer determines whether it’s doing a UEFI installation like so: > > (define (efi-installation?) > "Return #t if an EFI installation should be performed, #f otherwise." > (file-exists? "/sys/firmware/efi")) > > It uses that to determine whether to create an EFI System Partition > (ESP) and whether to use ‘grub-efi-bootloader’. > > Did it create an ESP in your case? No, not on a DOS layout, only on GPT layout. I think DOS should not be allowed in auto partitioning (which would be the safer option) or an ESP should be created on DOS as well. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 23:24:39 2021 Received: (at 47889) by debbugs.gnu.org; 24 Apr 2021 03:24:39 +0000 Received: from localhost ([127.0.0.1]:39217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la8uN-0000WT-DA for submit@debbugs.gnu.org; Fri, 23 Apr 2021 23:24:39 -0400 Received: from imta-35.everyone.net ([216.200.145.35]:39766 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la8uL-0000WK-Ci for 47889@debbugs.gnu.org; Fri, 23 Apr 2021 23:24:37 -0400 Received: from pps.filterd (omta001.sj2.proofpoint.com [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 13O3NH4c023485; Fri, 23 Apr 2021 20:24:36 -0700 X-Eon-Originating-Account: HgaCxO1vKDGUP0divjwzq9aNDDtSvrYODhc4YtqeXpo X-Eon-Dm: m0116952.ppops.net Received: by m0116952.mta.everyone.net (EON-AUTHRELAY2 - 53b92217) id m0116952.60622040.24e74d; Fri, 23 Apr 2021 20:24:34 -0700 X-Eon-Sig: AQMHrIJgg49ytaZ/vgIAAAAE,a1eb1d33f5723f275722ec81ceed6c5e X-Eip: scjME-tntOQaopeGtSULaIeKHFbMsfSz-MX7rTLX8Eg Date: Sat, 24 Apr 2021 05:24:26 +0200 From: Bengt Richter To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210424032425.GA18504@LionPure> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87im4ds2su.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-ORIG-GUID: XqPFEycguuu0Mme1BYj6P-hCtKRFXTir X-Proofpoint-GUID: XqPFEycguuu0Mme1BYj6P-hCtKRFXTir X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-23_14:2021-04-23, 2021-04-23 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1034 priorityscore=1501 adultscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104240021 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 47889 Cc: Mathieu Othacehe , "pelzflorian \(Florian Pelz\)" , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, Florian, On +2021-04-23 12:39:13 +0200, Ludovic Courtès wrote: > Hi Florian, > > (Cc: Mathieu.) > > "pelzflorian (Florian Pelz)" skribis: > > > On Thu, Apr 22, 2021 at 03:28:39PM +0200, Ludovic Courtès wrote: > >> There’s no EFI (vfat) partition here. Is it an EFI machine? > >> > >> Is /boot/efi mounted when you boot the installation image? > > > > No because there is no EFI partition. If I create one and restart the > > installer, then it is *not* mounted either, only /mnt/boot/efi later > > during the install. (I believe since the installer is installed as on > > an external medium, it does not need an EFI partition.) > > > > I had booted the install image via UEFI boot and had expected auto > > partitioning and the default configuration to do the right thing. > > The installer determines whether it’s doing a UEFI installation like so: > > (define (efi-installation?) > "Return #t if an EFI installation should be performed, #f otherwise." > (file-exists? "/sys/firmware/efi")) > > It uses that to determine whether to create an EFI System Partition > (ESP) and whether to use ‘grub-efi-bootloader’. > How does that work if you want to mount an external USB disk as the target of your installation partitioning and formatting etc, but which may be intended for another laptop with a different BIOS booting in a different mode than your installer was booted into? (Maybe plug the finished USB disk into another laptop? USB C3.1 is fast enough if connected to a good SSD cassette). I.e., suppose your installer machine was booted UEFI but you want the target disk to be legacy MBR booted on a laptop that can only do that, loading grub2 as embedded in the target disk? Or vice versa? I'd like an interactive install, maybe selecting a target disk something like --8<---------------cut here---------------start------------->8--- $ select choice in $(lsblk -o kname,model,serial|tr -s ' ' _); do break;done 1) KNAME_MODEL_SERIAL 6) dm-0_ 2) sdb_Ultra_Fit_XXXXXXXXXXXXXXXXXXXX 7) nvme0n1_Samsung_SSD_970_EVO_Plus_500GB_XXXXXXXXXXXXXXX 3) sdb1_ 8) nvme0n1p1_ 4) sdb2_ 9) nvme0n1p2_ 5) sr0_USB_SCSI_CD-ROM_XXXXXXXXXXXXXXXX #? 2 $ echo "$choice" sdb_Ultra_Fit_XXXXXXXXXXXXXXXXXXXX --8<---------------cut here---------------end--------------->8--- so then the installation script can continue and mount the associated disk device --8<---------------cut here---------------start------------->8--- $ echo "$choice"|cut -d _ -f1 sdb --8<---------------cut here---------------end--------------->8--- It seems like the /sys/... file system that would show whether the disk is EFI-bootable will be determined by booting the very disk image we are trying to create -- both by its content (MBR and/or GPT, and what bootloader + .cfg, etc) and the BIOS trying to boot it. Sorry for the noise if I am missing some context. > Did it create an ESP in your case? > > I’m not entirely sure how it decides between GPT and DOS, though; > Mathieu? > > We should add UEFI installation tests using OVMF. > > Thanks, > Ludo’. > > > -- Regards, Bengt Richter From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 24 05:32:12 2021 Received: (at 47889) by debbugs.gnu.org; 24 Apr 2021 09:32:12 +0000 Received: from localhost ([127.0.0.1]:39466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laEe3-00032e-OW for submit@debbugs.gnu.org; Sat, 24 Apr 2021 05:32:12 -0400 Received: from pelzflorian.de ([5.45.111.108]:55964 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laEdy-00032S-4W for 47889@debbugs.gnu.org; Sat, 24 Apr 2021 05:32:10 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 080B836063C; Sat, 24 Apr 2021 11:32:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1619256724; bh=G0Ye05EhuIO10qVbh4gAoZGSoxKnNZrY3IzAVdvGnuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZMEZOGX+YK5VjYOaQEgCTre6EwAF+/Vqd9oizZUNrIFzNKuCl6FOLyuGAm5DGClLy DnU7pPtnjpttk0dbcex+ZUQFBI9012ttuKZ2dul+sSrJuLovuTTh1N4m+1zsMLHLC1 F/cdlrZHLOlHFTChjQLTiBTLMHybPltwzogzlebM= Date: Sat, 24 Apr 2021 11:31:55 +0200 From: "pelzflorian (Florian Pelz)" To: Bengt Richter Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210424093155.3qyuyiyog76fl7re@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <20210424032425.GA18504@LionPure> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210424032425.GA18504@LionPure> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Bengt, On Sat, Apr 24, 2021 at 05:24:26AM +0200, Bengt Richter wrote: > How does that work if you want to mount an external USB disk as the target > of your installation partitioning and formatting etc, but which may be intended > for another laptop with a different BIOS booting in a different mode than your > installer was booted into? (Maybe plug the finished USB disk into another laptop? > USB C3.1 is fast enough if connected to a good SSD cassette). Do we want to support such rare use cases in the default configuration? Currently the configuration created by the installer assumes you want to install to the same boot mode (UEFI or “legacy” BIOS) as was selected when booting the installer. This means that if your computer only supports one or the other, you have no choice. It does not depend on what’s on the disk. Also, in UEFI mode, the grub-efi-bootloader from gnu/bootloader/grub.scm would need to be copied and adapted to add the --removable option if you want to install to a removable USB in UEFI mode. This is because grub-efi-bootloader otherwise writes boot information into your BIOS’s NVRAM on the mainboard of the computer doing the install. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 10:16:06 2021 Received: (at 47889) by debbugs.gnu.org; 25 Apr 2021 14:16:06 +0000 Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lafYM-0003yy-4S for submit@debbugs.gnu.org; Sun, 25 Apr 2021 10:16:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lafYK-0003yG-IL for 47889@debbugs.gnu.org; Sun, 25 Apr 2021 10:16:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36867) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lafYE-0001ya-Jn; Sun, 25 Apr 2021 10:15:58 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=56634 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lafYE-0005ve-6U; Sun, 25 Apr 2021 10:15:58 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> Date: Sun, 25 Apr 2021 16:15:56 +0200 In-Reply-To: <87im4ds2su.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 23 Apr 2021 12:39:13 +0200") Message-ID: <87eeeyv49v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: "pelzflorian \(Florian Pelz\)" , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > I=E2=80=99m not entirely sure how it decides between GPT and DOS, though; > Mathieu? > > We should add UEFI installation tests using OVMF. I could reproduce this issue with the following steps: --8<---------------cut here---------------start------------->8--- qemu-img create -f qcow2 guix-system.img 50G qemu-system-x86_64 -m 1024 -bios $(guix build ovmf)/share/firmware/ovmf_x64= .bin -cdrom /gnu/store/ -hda guix-system.img Choose the msdos disk type in the auto-partitioning installer partitioning = menu. --8<---------------cut here---------------end--------------->8--- When using the auto-partitioning, the installer probes the selected installation device type. If it has no type, like with my reproducer, it asks whether to use msdos or gpt. If the disk is already using an msdos or gpt layout, it is preserved. Then, the auto-partitioning considers erroneously that ESP partitions are not supported on msdos disks with the following code snippet: --8<---------------cut here---------------start------------->8--- (and (not has-extended?) ;not msdos? (if (efi-installation?) (and (not esp-partition) (user-partition (fs-type 'fat32) (esp? #t) (size new-esp-size) (mount-point (default-esp-mount-point)))) (user-partition (fs-type 'ext4) (bootable? #t) (bios-grub? #t) (size bios-grub-size)))) --8<---------------cut here---------------end--------------->8--- Finally, grub-efi fails because there's no /boot/efi mount point. This problem can then occur for two reasons: 1. The user is booting the installation image with UEFI support, using an empty installation device, choosing auto-partition and msdos as disk type. 2. The user is booting the installation image with UEFI support, using an already msdos formatted installation device and choosing auto-partition. I think we could solve 1. easily, by forcing the GPT layout. Solving 2. is a bit trickier. As Ludo suggested, we also need to create new installer tests covering UEFI installations. I'll try to come up with a patch soon. Thanks, Mathieu =20=20 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 12:34:26 2021 Received: (at 47889) by debbugs.gnu.org; 25 Apr 2021 16:34:26 +0000 Received: from localhost ([127.0.0.1]:43593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lahiD-0007Jj-Qv for submit@debbugs.gnu.org; Sun, 25 Apr 2021 12:34:25 -0400 Received: from pelzflorian.de ([5.45.111.108]:57636 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lahiB-0007Ja-CR for 47889@debbugs.gnu.org; Sun, 25 Apr 2021 12:34:24 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id C218336063C; Sun, 25 Apr 2021 18:34:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1619368461; bh=22LjVlxZiYx+QL9aMhVkz8yvA1GuizxchaeuTWriu6c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=eO3E5a9Yo8gIJTCCfs6iZSvvfyK8AUJfl6wxyEpbiqURKexdkEbfqkz7y/x6ukiX4 zUBmJ/gv3EkWsJL46YoZhTg2Vw/X2GR+4jtt9/W3WaZhEIWFu84V4hDzzz/MYQZK7R QlWvfgvIn/b1/A/oruQmaFFAsd2FhcODCmEjhmmQ= Date: Sun, 25 Apr 2021 18:34:12 +0200 From: "pelzflorian (Florian Pelz)" To: Mathieu Othacehe Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87eeeyv49v.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Apr 25, 2021 at 04:15:56PM +0200, Mathieu Othacehe wrote: > Finally, grub-efi fails because there's no /boot/efi mount point. > > This problem can then occur for two reasons: > > 1. The user is booting the installation image with UEFI support, using > an empty installation device, choosing auto-partition and msdos as > disk type. > > 2. The user is booting the installation image with UEFI support, using > an already msdos formatted installation device and choosing > auto-partition. > > I think we could solve 1. easily, by forcing the GPT layout. Solving > 2. is a bit trickier. Can you force GPT also in 2.? All disk partitions get removed anyway. Arch wiki says MSDOS layout does not work on all EFI systems . Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 13:12:50 2021 Received: (at 47889) by debbugs.gnu.org; 25 Apr 2021 17:12:50 +0000 Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laiJO-0008CN-56 for submit@debbugs.gnu.org; Sun, 25 Apr 2021 13:12:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laiJM-0008CB-0m for 47889@debbugs.gnu.org; Sun, 25 Apr 2021 13:12:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39882) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laiJF-0005Wo-HS; Sun, 25 Apr 2021 13:12:41 -0400 Received: from [2a01:e0a:19b:d9a0:35c2:b1bf:b4c1:9d32] (port=41098 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1laiJF-00017R-2C; Sun, 25 Apr 2021 13:12:41 -0400 From: Mathieu Othacehe To: "pelzflorian (Florian Pelz)" Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> Date: Sun, 25 Apr 2021 19:12:39 +0200 In-Reply-To: <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sun, 25 Apr 2021 18:34:12 +0200") Message-ID: <878s56uw3c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello Florian, > Can you force GPT also in 2.? All disk partitions get removed anyway. > Arch wiki says MSDOS layout does not work on all EFI systems > . Well I'm not sure, if someone has an MSDOS partition table with an ESP partition it wouldn't be a good idea to wipe it. The attached patch forces GPT if there's no partition table, and will preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it on various machines, seems to work fine. WDYT? Thanks, Mathieu --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-wip-esp.patch >From 65339286fe9d0c4758c04cfcaa177334577741cc Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sun, 25 Apr 2021 19:06:31 +0200 Subject: [PATCH] wip esp --- gnu/installer/newt/partition.scm | 16 +++++++----- gnu/installer/parted.scm | 45 ++++++++++++++------------------ 2 files changed, 28 insertions(+), 33 deletions(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index 81cf68d782..2dcb10bbdb 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -95,14 +95,16 @@ DEVICES list." (define (run-label-page button-text button-callback) "Run a page asking the user to select a partition table label." - (run-listbox-selection-page - #:info-text (G_ "Select a new partition table type. \ + (if (efi-installation?) + "gpt" + (run-listbox-selection-page + #:info-text (G_ "Select a new partition table type. \ Be careful, all data on the disk will be lost.") - #:title (G_ "Partition table") - #:listbox-items '("msdos" "gpt") - #:listbox-item->text identity - #:button-text button-text - #:button-callback-procedure button-callback)) + #:title (G_ "Partition table") + #:listbox-items '("msdos" "gpt") + #:listbox-item->text identity + #:button-text button-text + #:button-callback-procedure button-callback))) (define (run-type-page partition) "Run a page asking the user to select a partition type." diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 9ef263d1f9..6d6e500d71 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -70,6 +70,7 @@ small-freespace-partition? esp-partition? boot-partition? + efi-installation? default-esp-mount-point with-delay-device-in-use? @@ -193,12 +194,8 @@ inferior to MAX-SIZE, #f otherwise." (define (esp-partition? partition) "Return #t if partition has the ESP flag, return #f otherwise." (let* ((disk (partition-disk partition)) - (disk-type (disk-disk-type disk)) - (has-extended? (disk-type-check-feature - disk-type - DISK-TYPE-FEATURE-EXTENDED))) + (disk-type (disk-disk-type disk))) (and (data-partition? partition) - (not has-extended?) (partition-is-flag-available? partition PARTITION-FLAG-ESP) (partition-get-flag partition PARTITION-FLAG-ESP)))) @@ -918,30 +915,26 @@ exists." ;; disk space. Otherwise, set the swap size to 5% of the disk space. (swap-size (min default-swap-size five-percent-disk))) - (if has-extended? - ;; msdos - remove everything. - (disk-remove-all-partitions disk) - ;; gpt - remove everything but esp if it exists. - (for-each - (lambda (partition) - (and (data-partition? partition) - (disk-remove-partition* disk partition))) - non-boot-partitions)) + ;; Remove everything but esp if it exists. + (for-each + (lambda (partition) + (and (data-partition? partition) + (disk-remove-partition* disk partition))) + non-boot-partitions) (let* ((start-partition - (and (not has-extended?) - (if (efi-installation?) - (and (not esp-partition) - (user-partition - (fs-type 'fat32) - (esp? #t) - (size new-esp-size) - (mount-point (default-esp-mount-point)))) + (if (efi-installation?) + (and (not esp-partition) (user-partition - (fs-type 'ext4) - (bootable? #t) - (bios-grub? #t) - (size bios-grub-size))))) + (fs-type 'fat32) + (esp? #t) + (size new-esp-size) + (mount-point (default-esp-mount-point)))) + (user-partition + (fs-type 'ext4) + (bootable? #t) + (bios-grub? #t) + (size bios-grub-size)))) (new-partitions (cond ((or (eq? scheme 'entire-root) -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 07:17:12 2021 Received: (at 47889) by debbugs.gnu.org; 26 Apr 2021 11:17:13 +0000 Received: from localhost ([127.0.0.1]:44770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lazEm-0005c8-Mm for submit@debbugs.gnu.org; Mon, 26 Apr 2021 07:17:12 -0400 Received: from pelzflorian.de ([5.45.111.108]:58688 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lazEk-0005bw-13 for 47889@debbugs.gnu.org; Mon, 26 Apr 2021 07:17:10 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 4086A36063C; Mon, 26 Apr 2021 13:17:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1619435828; bh=jiCqjqFAfKVJQu3jmdNj3rFwtfL2OnXWsVkwotFlgM4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NG8vDwETn2deCAKwWdimkjDev+iMQslJxWaHjTpgcGOxhEdZT4BK0S9EtXjmveqZV 7S7a6WHOoNUCO7WWI4/ZAr/4ByLhYQYtR7ABFNAtzmITvf5u8Z0qltIbizetqlryea 1Rx5VFIXVxzNwwQdaY46mDXzfs13Sbn9Ya6kg7vI= Date: Mon, 26 Apr 2021 13:17:00 +0200 From: "pelzflorian (Florian Pelz)" To: Mathieu Othacehe Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Message-ID: <20210426111700.esxn4cfwrfflez5l@pelzflorian.localdomain> References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878s56uw3c.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47889 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Apr 25, 2021 at 07:12:39PM +0200, Mathieu Othacehe wrote: > > Hello Florian, > > > Can you force GPT also in 2.? All disk partitions get removed anyway. > > Arch wiki says MSDOS layout does not work on all EFI systems > > . > > Well I'm not sure, if someone has an MSDOS partition table with an ESP > partition it wouldn't be a good idea to wipe it. You are right of course; the old ESP may contain boot information for other disks or network boot or whatever. > The attached patch forces GPT if there's no partition table, and will > preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it > on various machines, seems to work fine. Thank you for this patch!! It installs EFI on msdos layout successfully on my Beebox PC. That said, it could force GPT on msdos layouts as well if they lack an ESP. But I’m already happy. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 11:54:08 2021 Received: (at 47889) by debbugs.gnu.org; 26 Apr 2021 15:54:08 +0000 Received: from localhost ([127.0.0.1]:46847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3Ym-0006ge-7u for submit@debbugs.gnu.org; Mon, 26 Apr 2021 11:54:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3Yj-0006gA-NQ for 47889@debbugs.gnu.org; Mon, 26 Apr 2021 11:54:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb3Yd-0002NR-Oh; Mon, 26 Apr 2021 11:53:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58234 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lb3YZ-0005zb-LT; Mon, 26 Apr 2021 11:53:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 26 Apr 2021 17:53:54 +0200 In-Reply-To: <878s56uw3c.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 25 Apr 2021 19:12:39 +0200") Message-ID: <8735vdca99.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: "pelzflorian \(Florian Pelz\)" , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mathieu, Mathieu Othacehe skribis: >> Can you force GPT also in 2.? All disk partitions get removed anyway. >> Arch wiki says MSDOS layout does not work on all EFI systems >> . > > Well I'm not sure, if someone has an MSDOS partition table with an ESP > partition it wouldn't be a good idea to wipe it. > > The attached patch forces GPT if there's no partition table, and will > preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it > on various machines, seems to work fine. The patch looks reasonable to me, thanks a lot! (It=E2=80=99s also reasonable to ignore ESP-on-MSDOS IMO.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 12:37:36 2021 Received: (at 47889) by debbugs.gnu.org; 26 Apr 2021 16:37:36 +0000 Received: from localhost ([127.0.0.1]:46981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb4Eq-0007qk-0M for submit@debbugs.gnu.org; Mon, 26 Apr 2021 12:37:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb4En-0007qQ-Fe for 47889@debbugs.gnu.org; Mon, 26 Apr 2021 12:37:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60427) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb4Ef-0001NX-QJ; Mon, 26 Apr 2021 12:37:28 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=38492 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lb4Ee-0007W7-2V; Mon, 26 Apr 2021 12:37:25 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> <8735vdca99.fsf@gnu.org> Date: Mon, 26 Apr 2021 18:37:22 +0200 In-Reply-To: <8735vdca99.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 26 Apr 2021 17:53:54 +0200") Message-ID: <87im49huil.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo & Florian, > The patch looks reasonable to me, thanks a lot! Thanks for having a look! I'm working on an UEFI installation test as we discussed. Almost there but for a strange reason, even if the installation works smoothly, the created image isn't bootable in QEMU. I'll keep investigating. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 12:48:44 2021 Received: (at 47889) by debbugs.gnu.org; 27 Apr 2021 16:48:44 +0000 Received: from localhost ([127.0.0.1]:50752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbQt9-0007wx-8S for submit@debbugs.gnu.org; Tue, 27 Apr 2021 12:48:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbQt4-0007wi-Im for 47889@debbugs.gnu.org; Tue, 27 Apr 2021 12:48:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54394) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbQsy-0006jO-2V; Tue, 27 Apr 2021 12:48:32 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=49286 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbQsx-0006h7-Eu; Tue, 27 Apr 2021 12:48:31 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> <8735vdca99.fsf@gnu.org> <87im49huil.fsf@gnu.org> Date: Tue, 27 Apr 2021 18:48:30 +0200 In-Reply-To: <87im49huil.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 26 Apr 2021 18:37:22 +0200") Message-ID: <87pmyfoeqp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889 Cc: Florian Pelz , 47889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, Here is a patchset solving this issue and adding a new UEFI system test. The boot issue was quite complex. Turns out it's related to how the OVMF firmware saves persistently the UEFI variables. Regarding the MSDOS/UEFI patch, it is almost identical to what Florian tested. I chose not to force GPT on UEFI if the user disk is already MBR formatted, mostly to keep the code readable. Thanks, Mathieu --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-installer-Force-GPT-disk-label-when-UEFI-is-supporte.patch >From c75278d39e977488516507fb8a67c167facda926 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 27 Apr 2021 17:39:42 +0200 Subject: [PATCH 1/3] installer: Force GPT disk label when UEFI is supported. * gnu/installer/newt/partition.scm (run-label-page): Force the GPT disk label when UEFI is supported. --- gnu/installer/newt/partition.scm | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index 81cf68d782..2bb9b16945 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -95,14 +95,17 @@ DEVICES list." (define (run-label-page button-text button-callback) "Run a page asking the user to select a partition table label." - (run-listbox-selection-page - #:info-text (G_ "Select a new partition table type. \ + ;; Force the GPT label if UEFI is supported. + (if (efi-installation?) + "gpt" + (run-listbox-selection-page + #:info-text (G_ "Select a new partition table type. \ Be careful, all data on the disk will be lost.") - #:title (G_ "Partition table") - #:listbox-items '("msdos" "gpt") - #:listbox-item->text identity - #:button-text button-text - #:button-callback-procedure button-callback)) + #:title (G_ "Partition table") + #:listbox-items '("msdos" "gpt") + #:listbox-item->text identity + #:button-text button-text + #:button-callback-procedure button-callback))) (define (run-type-page partition) "Run a page asking the user to select a partition type." -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-installer-Add-MSDOS-disk-label-support-on-UEFI-syste.patch >From b2ca61abc2f3faf918a9a4d006cb3d7cd2a71f19 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sun, 25 Apr 2021 19:06:31 +0200 Subject: [PATCH 2/3] installer: Add MSDOS disk label support on UEFI systems. * gnu/installer/parted.scm (esp-partition?): Remove the MSDOS check. (auto-partition!): On MSDOS disks, check if an ESP partition is present. If that's the case, do not remove it. Otherwise, if UEFI is supported, create one. --- gnu/installer/parted.scm | 45 +++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 9ef263d1f9..6d6e500d71 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -70,6 +70,7 @@ small-freespace-partition? esp-partition? boot-partition? + efi-installation? default-esp-mount-point with-delay-device-in-use? @@ -193,12 +194,8 @@ inferior to MAX-SIZE, #f otherwise." (define (esp-partition? partition) "Return #t if partition has the ESP flag, return #f otherwise." (let* ((disk (partition-disk partition)) - (disk-type (disk-disk-type disk)) - (has-extended? (disk-type-check-feature - disk-type - DISK-TYPE-FEATURE-EXTENDED))) + (disk-type (disk-disk-type disk))) (and (data-partition? partition) - (not has-extended?) (partition-is-flag-available? partition PARTITION-FLAG-ESP) (partition-get-flag partition PARTITION-FLAG-ESP)))) @@ -918,30 +915,26 @@ exists." ;; disk space. Otherwise, set the swap size to 5% of the disk space. (swap-size (min default-swap-size five-percent-disk))) - (if has-extended? - ;; msdos - remove everything. - (disk-remove-all-partitions disk) - ;; gpt - remove everything but esp if it exists. - (for-each - (lambda (partition) - (and (data-partition? partition) - (disk-remove-partition* disk partition))) - non-boot-partitions)) + ;; Remove everything but esp if it exists. + (for-each + (lambda (partition) + (and (data-partition? partition) + (disk-remove-partition* disk partition))) + non-boot-partitions) (let* ((start-partition - (and (not has-extended?) - (if (efi-installation?) - (and (not esp-partition) - (user-partition - (fs-type 'fat32) - (esp? #t) - (size new-esp-size) - (mount-point (default-esp-mount-point)))) + (if (efi-installation?) + (and (not esp-partition) (user-partition - (fs-type 'ext4) - (bootable? #t) - (bios-grub? #t) - (size bios-grub-size))))) + (fs-type 'fat32) + (esp? #t) + (size new-esp-size) + (mount-point (default-esp-mount-point)))) + (user-partition + (fs-type 'ext4) + (bootable? #t) + (bios-grub? #t) + (size bios-grub-size)))) (new-partitions (cond ((or (eq? scheme 'entire-root) -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0003-tests-Add-gui-uefi-installed-os-test.patch >From 7ae4219b78906f6be1764f487430680afe8ae8ee Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 27 Apr 2021 17:30:28 +0200 Subject: [PATCH 3/3] tests: Add gui-uefi-installed-os test. * gnu/installer/tests.scm (conclude-installation): Rename it into ... (start-installation): ... this new procedure. (complete-installation): New procedure. (choose-partitioning): Add an uefi-support? argument. * gnu/tests/install.scm (uefi-firmware): New procedure. (run-install, qemu-command/writable-image, gui-test-program, installation-target-os-for-gui-tests): Add an uefi-support? argument. (%extra-packages): Add grub-efi, fatfsck/static and dosfstools. (%test-gui-installed-os): New variable. --- gnu/installer/tests.scm | 37 +++++++++++--- gnu/tests/install.scm | 108 ++++++++++++++++++++++++++++++++++++---- 2 files changed, 128 insertions(+), 17 deletions(-) diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm index f318546a2f..8ccd327a7c 100644 --- a/gnu/installer/tests.scm +++ b/gnu/installer/tests.scm @@ -37,7 +37,8 @@ enter-host-name+passwords choose-services choose-partitioning - conclude-installation + start-installation + complete-installation edit-configuration-file)) @@ -281,14 +282,19 @@ instrumented for further testing." (define* (choose-partitioning port #:key (encrypted? #t) + (uefi-support? #f) (passphrase "thepassphrase") (edit-configuration-file edit-configuration-file)) "Converse over PORT to choose the partitioning method. When ENCRYPTED? is true, choose full-disk encryption with PASSPHRASE as the LUKS passphrase. + +When UEFI-SUPPORT? is true, assume that we are running the installation tests +on an UEFI capable machine. + This conversation stops when the user partitions have been formatted, right before the installer generates the configuration file and shows it in a dialog -box." +box. " (converse port ((list-selection (title "Partitioning method") (multiple-choices? #f) @@ -306,11 +312,15 @@ box." disks)) ;; The "Partition table" dialog pops up only if there's not already a - ;; partition table. + ;; partition table and if the system does not support UEFI. ((list-selection (title "Partition table") (multiple-choices? #f) (items _)) + ;; When UEFI is supported, the partition is forced to GPT by the + ;; installer. + (not uefi-support?) "gpt") + ((list-selection (title "Partition scheme") (multiple-choices? #f) (items (,one-partition _ ...))) @@ -338,10 +348,10 @@ box." ;; UUIDs before it generates the configuration file. (values)))) -(define (conclude-installation port) - "Conclude the installation by checking over PORT that we get the generated +(define (start-installation port) + "Start the installation by checking over PORT that we get the generated configuration file, accepting it and starting the installation, and then -receiving the final messages once the 'guix system init' process has +receiving the pause message once the 'guix system init' process has completed." ;; Assume the previous message received was 'starting-final-step'; here we ;; send the reply to that message, which lets the installer continue. @@ -355,8 +365,19 @@ completed." (file ,configuration-file)) (edit-configuration-file configuration-file)) ((pause) ;"Press Enter to continue." - #t) - ((installation-complete) ;congratulations! + (values)))) + +(define (complete-installation port) + "Complete the installation by replying to the installer pause message and +waiting for the installation-complete message." + ;; Assume the previous message received was 'pause'; here we send the reply + ;; to that message, which lets the installer continue. + (write #t port) + (newline port) + (force-output port) + + (converse port + ((installation-complete) (values)))) ;;; Local Variables: diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 4b8963eadd..b5263f5f0d 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -36,8 +36,10 @@ #:use-module (gnu packages bootloaders) #:use-module (gnu packages commencement) ;for 'guile-final' #:use-module (gnu packages cryptsetup) + #:use-module (gnu packages disk) #:use-module (gnu packages emacs) #:use-module (gnu packages emacs-xyz) + #:use-module (gnu packages firmware) #:use-module (gnu packages linux) #:use-module (gnu packages ocr) #:use-module (gnu packages openbox) @@ -73,6 +75,7 @@ %test-lvm-separate-home-os %test-gui-installed-os + %test-gui-uefi-installed-os %test-gui-installed-os-encrypted %test-gui-installed-desktop-os-encrypted)) @@ -206,6 +209,15 @@ guix system init /mnt/etc/config.scm /mnt --no-substitutes sync reboot\n") +(define (uefi-firmware system) + "Return the appropriate QEMU OVMF UEFI firmware for the given SYSTEM." + (cond + ((string-prefix? "x86_64" system) + (file-append ovmf "/share/firmware/ovmf_x64.bin")) + ((string-prefix? "i686" system) + (file-append ovmf "/share/firmware/ovmf_ia32.bin")) + (else #f))) + (define* (run-install target-os target-os-source #:key (script %simple-installation-script) @@ -224,6 +236,7 @@ reboot\n") #:imported-modules '((gnu services herd) (gnu installer tests) (guix combinators)))) + (uefi-support? #f) (installation-image-type 'efi-raw) (install-size 'guess) (target-size (* 2200 MiB))) @@ -235,6 +248,8 @@ packages defined in installation-os." (mlet* %store-monad ((_ (set-grafting #f)) (system (current-system)) + (uefi-firmware -> (and uefi-support? + (uefi-firmware system))) ;; Since the installation system has no network access, ;; we cheat a little bit by adding TARGET to its GC ;; roots. This way, we know 'guix system init' will @@ -273,6 +288,9 @@ packages defined in installation-os." `(,(which #$(qemu-command system)) "-no-reboot" "-m" "1200" + ,@(if #$uefi-firmware + '("-bios" #$uefi-firmware) + '()) #$@(cond ((eq? 'efi-raw installation-image-type) #~("-drive" @@ -322,10 +340,15 @@ packages defined in installation-os." (gexp->derivation "installation" install #:substitutable? #f))) ;too big -(define* (qemu-command/writable-image image #:key (memory-size 256)) +(define* (qemu-command/writable-image image + #:key + (uefi-support? #f) + (memory-size 256)) "Return as a monadic value the command to run QEMU on a writable copy of IMAGE, a disk image. The QEMU VM has access to MEMORY-SIZE MiB of RAM." - (mlet %store-monad ((system (current-system))) + (mlet* %store-monad ((system (current-system)) + (uefi-firmware -> (and uefi-support? + (uefi-firmware system)))) (return #~(let ((image #$image)) ;; First we need a writable copy of the image. (format #t "creating writable image from '~a'...~%" image) @@ -343,6 +366,9 @@ IMAGE, a disk image. The QEMU VM has access to MEMORY-SIZE MiB of RAM." ,@(if (file-exists? "/dev/kvm") '("-enable-kvm") '()) + ,@(if #$uefi-firmware + '("-bios" #$uefi-firmware) + '()) "-no-reboot" "-m" #$(number->string memory-size) "-drive" "file=disk.img,if=virtio"))))) @@ -1400,7 +1426,9 @@ build (current-guix) and then store a couple of full system images.") (define* (gui-test-program marionette #:key (desktop? #f) - (encrypted? #f)) + (encrypted? #f) + (uefi-support? #f) + (system (%current-system))) #~(let () (define (screenshot file) (marionette-control (string-append "screendump " file) @@ -1466,7 +1494,8 @@ build (current-guix) and then store a couple of full system images.") (marionette-eval* '(choose-partitioning installer-socket #:encrypted? #$encrypted? - #:passphrase #$%luks-passphrase) + #:passphrase #$%luks-passphrase + #:uefi-support? #$uefi-support?) #$marionette) (screenshot "installer-run.ppm") @@ -1480,9 +1509,43 @@ build (current-guix) and then store a couple of full system images.") "/dev/vda2") #$marionette)) - (marionette-eval* '(conclude-installation installer-socket) + (marionette-eval* '(start-installation installer-socket) #$marionette) + ;; XXX: The grub-install process uses efibootmgr to add an UEFI Guix + ;; boot entry. The corresponding UEFI variable is stored in RAM, and + ;; possibly saved persistently on QEMU reboot in a NvVars file, see: + ;; https://lists.gnu.org/archive/html/qemu-discuss/2018-04/msg00045.html. + ;; + ;; As we are running QEMU with the no-reboot flag, this variable is + ;; never saved persistently, QEMU fails to boot the installed system and + ;; an UEFI shell is displayed instead. + ;; + ;; To make the installed UEFI system bootable, register Grub as the + ;; default UEFI boot entry, in the same way as if grub-install was + ;; invoked with the --removable option. + (when #$uefi-support? + (marionette-eval* + '(begin + (use-modules (ice-9 match)) + (let ((targets (cond + ((string-prefix? "x86_64" #$system) + '("grubx64.efi" "BOOTX64.EFI")) + ((string-prefix? "i686" #$system) + '("grubia32.efi" "BOOTIA32.EFI")) + (else #f)))) + (match targets + ((src dest) + (rename-file "/mnt/boot/efi/EFI/Guix" + "/mnt/boot/efi/EFI/BOOT") + (rename-file + (string-append "/mnt/boot/efi/EFI/BOOT/" src) + (string-append "/mnt/boot/efi/EFI/BOOT/" dest))) + (_ #f)))) + #$marionette)) + + (marionette-eval* '(complete-installation installer-socket) + #$marionette) (sync) #t)) @@ -1490,7 +1553,7 @@ build (current-guix) and then store a couple of full system images.") ;; Packages needed when installing with an encrypted root. (list isc-dhcp lvm2-static cryptsetup-static e2fsck/static - loadkeys-static)) + loadkeys-static grub-efi fatfsck/static dosfstools)) (define installation-os-for-gui-tests ;; Operating system that contains all of %EXTRA-PACKAGES, needed for the @@ -1509,9 +1572,22 @@ build (current-guix) and then store a couple of full system images.") (guix combinators)))) (define* (installation-target-os-for-gui-tests - #:key (encrypted? #f)) + #:key + (encrypted? #f) + (uefi-support? #f)) (operating-system (inherit %minimal-os-on-vda) + (file-systems `(,(file-system + (device (file-system-label "my-root")) + (mount-point "/") + (type "ext4")) + ,@(if uefi-support? + (list (file-system + (device (uuid "1234-ABCD" 'fat)) + (mount-point "/boot/efi") + (type "vfat"))) + '()) + ,@%base-file-systems)) (users (append (list (user-account (name "alice") (comment "Bob's sister") @@ -1569,6 +1645,7 @@ build (current-guix) and then store a couple of full system images.") #:key (desktop? #f) (encrypted? #f) + (uefi-support? #f) target-os (install-size 'guess) (target-size (* 2200 MiB))) @@ -1581,6 +1658,7 @@ build (current-guix) and then store a couple of full system images.") ((image (run-install target-os '(this is unused) #:script #f #:os installation-os-for-gui-tests + #:uefi-support? uefi-support? #:install-size install-size #:target-size target-size #:installation-image-type @@ -1590,8 +1668,11 @@ build (current-guix) and then store a couple of full system images.") (gui-test-program marionette #:desktop? desktop? - #:encrypted? encrypted?)))) - (command (qemu-command/writable-image image #:memory-size 512))) + #:encrypted? encrypted? + #:uefi-support? uefi-support?)))) + (command (qemu-command/writable-image image + #:uefi-support? uefi-support? + #:memory-size 512))) (run-basic-test target-os command name #:initialization (and encrypted? enter-luks-passphrase) #:root-password %root-password @@ -1602,6 +1683,15 @@ build (current-guix) and then store a couple of full system images.") "gui-installed-os" #:target-os (installation-target-os-for-gui-tests))) +;; Test the UEFI installation of Guix System using the graphical installer. +(define %test-gui-uefi-installed-os + (guided-installation-test + "gui-uefi-installed-os" + #:uefi-support? #t + #:target-os (installation-target-os-for-gui-tests + #:uefi-support? #t) + #:target-size (* 3200 MiB))) + (define %test-gui-installed-os-encrypted (guided-installation-test "gui-installed-os-encrypted" -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 28 09:54:33 2021 Received: (at 47889-done) by debbugs.gnu.org; 28 Apr 2021 13:54:33 +0000 Received: from localhost ([127.0.0.1]:52197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbke8-00008E-Sq for submit@debbugs.gnu.org; Wed, 28 Apr 2021 09:54:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbke7-000082-5T for 47889-done@debbugs.gnu.org; Wed, 28 Apr 2021 09:54:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44021) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbke1-0006Bj-E2; Wed, 28 Apr 2021 09:54:25 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=48362 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbke0-0005nL-SM; Wed, 28 Apr 2021 09:54:25 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> <8735vdca99.fsf@gnu.org> <87im49huil.fsf@gnu.org> <87pmyfoeqp.fsf@gnu.org> Date: Wed, 28 Apr 2021 15:54:23 +0200 In-Reply-To: <87pmyfoeqp.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 27 Apr 2021 18:48:30 +0200") Message-ID: <87k0omwm40.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889-done Cc: 47889-done@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > Regarding the MSDOS/UEFI patch, it is almost identical to what Florian > tested. I chose not to force GPT on UEFI if the user disk is already > MBR formatted, mostly to keep the code readable. Pushed on master and cherry-picked on version-1.3.0 branch. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 29 03:45:29 2021 Received: (at 47889-done) by debbugs.gnu.org; 29 Apr 2021 07:45:29 +0000 Received: from localhost ([127.0.0.1]:54733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lc1MX-00040F-2Z for submit@debbugs.gnu.org; Thu, 29 Apr 2021 03:45:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lc1MT-0003zy-UT for 47889-done@debbugs.gnu.org; Thu, 29 Apr 2021 03:45:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37883) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lc1MO-0005sc-3s; Thu, 29 Apr 2021 03:45:20 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60828 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lc1MN-0006Un-2v; Thu, 29 Apr 2021 03:45:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> <87eeeyv49v.fsf@gnu.org> <20210425163412.duj4t4ind5r5tv4x@pelzflorian.localdomain> <878s56uw3c.fsf@gnu.org> <8735vdca99.fsf@gnu.org> <87im49huil.fsf@gnu.org> <87pmyfoeqp.fsf@gnu.org> <87k0omwm40.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 29 Apr 2021 09:45:17 +0200 In-Reply-To: <87k0omwm40.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 28 Apr 2021 15:54:23 +0200") Message-ID: <87a6pho7oy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47889-done Cc: 47889-done@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Mathieu Othacehe skribis: >> Regarding the MSDOS/UEFI patch, it is almost identical to what Florian >> tested. I chose not to force GPT on UEFI if the user disk is already >> MBR formatted, mostly to keep the code readable. > > Pushed on master and cherry-picked on version-1.3.0 branch. Thanks! Ludo=E2=80=99. From unknown Sun Jun 22 03:56:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 May 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator