From unknown Thu Jun 19 14:23:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Apr 2021 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 47880@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16187731363861 (code B ref -1); Sun, 18 Apr 2021 19:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 19:12:16 +0000 Received: from localhost ([127.0.0.1]:47843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCq8-00010D-0V for submit@debbugs.gnu.org; Sun, 18 Apr 2021 15:12:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:49242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCq6-000106-Kg for submit@debbugs.gnu.org; Sun, 18 Apr 2021 15:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCq6-0004Z7-EL for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:12:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCq3-00023g-NZ for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:12:13 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 08023240028 for ; Sun, 18 Apr 2021 21:12:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618773129; bh=p/ag8HkbCmDDHYCX0itjmy4AtcbZPUaYKoorzd/3qMw=; h=From:To:Subject:Date:From; b=eijMBXsD0bi1r/1BMAxtf1Dkp1I95alYtbPU5FTO/xJWLrw78cvBIdz3LqQ1nrSGY alODNboqe4oZOF+bpB4IWGKIVEo+W+U9qersOcdgmioySP14LFrJ9qS5oRfmU0kMvz KePKN0E087X1GG2ak0BJ6534h5xu/OWgQK37GLSjebfgLwWHaXTICumq3QYZdso1yx GkT3F2i4rnA+MI8ov/PHhXo+XPjgoMJ2yDCm+sLM9ttvvG/o7b6Sv00RxOXOo7kn5k lfQJFY+pdbgCWoIBc4zS/PMMFebbdPqCzE0GhQKILcsI30mKUd8cCDjI6Dm47FgKww 60MgBmPNboQ/A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNfhS2F8cz6tmS for ; Sun, 18 Apr 2021 21:12:08 +0200 (CEST) From: Philip Kaludercic Date: Sun, 18 Apr 2021 19:12:07 +0000 Message-ID: <874kg3pfug.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM=1.499, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Hard-coding a file like this should be avoided, ever since Emacs also supports XDG-compliant configurations paths. Other than that, it might be better to not even store this under XDG_CONFIG_HOME but XDG_DATA_HOME, as automatically generated files are not configurations but data. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0004-lisp-net-rcirc.el-rcirc-log-directory-Use-locate-use.patch >From 620384e1c9f50bcce65cec0771265297678905d2 Mon Sep 17 00:00:00 2001 From: Philip K Date: Sun, 18 Apr 2021 20:41:37 +0200 Subject: [PATCH 4/4] * lisp/net/rcirc.el (rcirc-log-directory): Use locate-user-emacs-file Author: --- lisp/net/rcirc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 7bb8ca671c..4fbc8bc4f7 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1166,7 +1166,7 @@ rcirc-channel-p (or (eq (aref target 0) ?#) (eq (aref target 0) ?&)))) -(defcustom rcirc-log-directory "~/.emacs.d/rcirc-log" +(defcustom rcirc-log-directory (locate-user-emacs-file "rcirc-log") "Directory to keep IRC logfiles." :type 'directory) -- 2.30.2 --=-=-=-- From unknown Thu Jun 19 14:23:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 47880@debbugs.gnu.org Received: via spool by 47880-submit@debbugs.gnu.org id=B47880.161881782417227 (code B ref 47880); Mon, 19 Apr 2021 07:38:02 +0000 Received: (at 47880) by debbugs.gnu.org; 19 Apr 2021 07:37:04 +0000 Received: from localhost ([127.0.0.1]:48275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYOSu-0004Tl-EG for submit@debbugs.gnu.org; Mon, 19 Apr 2021 03:37:04 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:36608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYOSs-0004T5-Hk for 47880@debbugs.gnu.org; Mon, 19 Apr 2021 03:37:03 -0400 Received: by mail-pj1-f54.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so19853018pjh.1 for <47880@debbugs.gnu.org>; Mon, 19 Apr 2021 00:37:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=OMA7zsXXs/ujyuu5AbShm9FWN5R4H2yNzyLD/5hmb4I=; b=AUGsuOwRwNWgimzSlteUIGb7mujkE5QyyfhnfygF+FO7fIM7C3u/epTZ0j5TPRN9qI GCOsJsQc2iXtvsuzYDQwjbQkb4yRg1Tq8f33E6ali1HRUQ1NTIv4dVdIiCgs46KmE/ah /Eg7bWn7kg9pBzYEyW+wEyuTE9EQletJhY5uoQXsZNC/gyGXQymtDODaEcYJ6ko0H3Fb r1a+PRs8wNr7vdopb2IeHCXbwAXwkgSQNmCx8A3/7HSWMWoyQxwQusPKCsfWoCppvDOU aR07xb5yv92TFAuq50AIL8BVYBfV91XejOU/uZvjb7lZEUVA4re9ziFSqso6RgTuCPR+ ZEhg== X-Gm-Message-State: AOAM532pDiTIqvkg3Bqh9F1mMDdD8g8TlX3nVPjyQljRes8dDuGNIPpm ye6ceI3iCgZvDYCmSrae+GSnC/8jQTw/bTliuFY= X-Google-Smtp-Source: ABdhPJytKK3rjbkBTgs77a6ifL1rGjRwG3umgsxFupbSrK11zbEspqW3ukNnmCqZS1HFZWviRb9kHxHu9JtB60RBdTo= X-Received: by 2002:a17:90b:f0b:: with SMTP id br11mr23053303pjb.179.1618817816842; Mon, 19 Apr 2021 00:36:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Apr 2021 07:36:56 +0000 From: Stefan Kangas In-Reply-To: <874kg3pfug.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 18 Apr 2021 19:12:07 +0000") References: <874kg3pfug.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 19 Apr 2021 07:36:56 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 47880 + fixed close 47880 28.1 thanks Philip Kaludercic writes: > Hard-coding a file like this should be avoided, ever since Emacs also > supports XDG-compliant configurations paths. Thanks for the patch! Pushed to master as commit 869e437c10. Note that I adapted the commit message slightly and added a :version tag to the defcustom.