From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 14:56:40 2021 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 18:56:40 +0000 Received: from localhost ([127.0.0.1]:47794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCb1-0006rs-NP for submit@debbugs.gnu.org; Sun, 18 Apr 2021 14:56:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:60820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCb0-0006rl-Fd for submit@debbugs.gnu.org; Sun, 18 Apr 2021 14:56:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCax-0005H3-4b for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 14:56:38 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCau-0001CS-QA for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 14:56:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 49E802400FF for ; Sun, 18 Apr 2021 20:56:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618772188; bh=OVRq+xCnOPlpFmm8zZvMHfyxhxJ8mKSPPmaRdi+CKtg=; h=From:To:Subject:Date:From; b=GYhh+ROVDEi9qGG34t8pKZ35YnjeDkb1y8TS15JRJZBm8fSnn1TaBuIJ18dF/1yZm 0rFtGM0hgBP9tfnSnTtBFv/pKQncCOfWr/aBT0OLHFBro7YGqU3FYl1GwKleV5i8Ua 5G7/J6v0Oi2mBULq1ycN+8eyP2JTkl2KXpCgP+3cGVHGRgjvYgc6Pnq96fFEwV/GCS jiUZd7byf0qxIFcCUmefcTPEKgq0oo12IhgoraprpOVPpqEnZH7uJVqgo+6uaNCS+e pF4hAgHk4jryhGKx9QKzfM1roOAJpOGKYalL9H4tWVW/KASXyyw7bc12aCW9YnbuJG dHuAqS2FWm8PQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNfLM4mkbz9rxK for ; Sun, 18 Apr 2021 20:56:27 +0200 (CEST) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Respect sgml-xml-mode Date: Sun, 18 Apr 2021 18:56:26 +0000 Message-ID: <87eef7pgkl.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM=1.499, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain sgml-xml-mode is a user option that is over-riden by smgl-mode. When I customize sgml-xml-mode to be enabled for every sgml-mode derived mode (specifically html-mode), it is disabled because a HTML file does not have to be a valid XML file -- even if I would want it to be. This patch only sets sgml-xml-mode if we know that the current file is an XML file, but leaves the default value if it cannot be said for sure. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-sgml-mode-Only-set-sgml-xml-mode-if-guessed-to-be-an.patch >From 934906eacc02ded6784653ef7b714b57b7b952b7 Mon Sep 17 00:00:00 2001 From: Philip K Date: Wed, 14 Apr 2021 19:19:01 +0200 Subject: [PATCH 1/4] sgml-mode: Only set sgml-xml-mode if guessed to be an XML file The user preference for sgml-xml-mode is overridden by default if the result of the guess is used as the buffer local value. --- lisp/textmodes/sgml-mode.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el index 67f731917e..d5930e82df 100644 --- a/lisp/textmodes/sgml-mode.el +++ b/lisp/textmodes/sgml-mode.el @@ -623,7 +623,8 @@ sgml-mode (setq-local syntax-propertize-function #'sgml-syntax-propertize) (setq-local syntax-ppss-table sgml-tag-syntax-table) (setq-local facemenu-add-face-function 'sgml-mode-facemenu-add-face-function) - (setq-local sgml-xml-mode (sgml-xml-guess)) + (when (sgml-xml-guess) + (setq-local sgml-xml-mode t)) (unless sgml-xml-mode (setq-local skeleton-transformation-function sgml-transformation-function)) ;; This will allow existing comments within declarations to be -- 2.30.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 19:45:26 2021 Received: (at 47877) by debbugs.gnu.org; 20 Apr 2021 23:45:26 +0000 Received: from localhost ([127.0.0.1]:56387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ03a-0000NP-3m for submit@debbugs.gnu.org; Tue, 20 Apr 2021 19:45:26 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:43549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ03Y-0000N7-FM for 47877@debbugs.gnu.org; Tue, 20 Apr 2021 19:45:24 -0400 Received: by mail-pf1-f180.google.com with SMTP id p67so21938387pfp.10 for <47877@debbugs.gnu.org>; Tue, 20 Apr 2021 16:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=68NQi2R2xOE3PriMByfxgiX/sNestsYCIBNslSl7gd0=; b=HlKe8Q7pwu59oCX3cJ2JsRb2df36jao+JSWbaOJH6cx5eEL+Gair+1wS0Xr6qWGVyO Qm8cecB1iJR58jMqYRH8eVjMH7bv1UNWwPycKqnKcHMKwFUurHNTebBwEusjOLcubtlf 5IRDV3EkmWqelV+L9VglI9qPJLgq1iSpXSfbV3Arvk1aHvQgRUQBFXmrD3aV36EoiJGI LyNzoM/JRMIPMudJudDVldgT0EtxD787gyGeSBwAr5zaOnfFREx3Uro1MQIaF2+Ar5tL OrDaWiL6iUOOCNEwAHkE0znbAVktyaeJQ/yuOvVesdQ42YGBPYibwrCqXRYZKyOEIa9s X+yw== X-Gm-Message-State: AOAM532paqiEyLS01G3vXEYZYHsrLwWOAseJq59xkT+4DjKWmQrnb+Fh cep/+jiMiVriwvLt45ZAqm7Ra0Va8Hl3lH+tW48= X-Google-Smtp-Source: ABdhPJxOHrQhruvGFEGFfpReeEQcRojlJOOqb2QWLtJK6MjCiWmqr4jOmLVo26dgOqLt7CJLOMaky5OwuGKPQST0MTE= X-Received: by 2002:a62:5bc1:0:b029:20d:69a5:189 with SMTP id p184-20020a625bc10000b029020d69a50189mr27229592pfb.57.1618962318693; Tue, 20 Apr 2021 16:45:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 18:45:18 -0500 From: Stefan Kangas In-Reply-To: <87eef7pgkl.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 18 Apr 2021 18:56:26 +0000") References: <87eef7pgkl.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 20 Apr 2021 18:45:18 -0500 Message-ID: Subject: Re: bug#47877: [PATCH] Respect sgml-xml-mode To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47877 Cc: 47877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Philip Kaludercic writes: > sgml-xml-mode is a user option that is over-riden by smgl-mode. When I > customize sgml-xml-mode to be enabled for every sgml-mode derived mode > (specifically html-mode), it is disabled because a HTML file does not > have to be a valid XML file -- even if I would want it to be. > > This patch only sets sgml-xml-mode if we know that the current file is > an XML file, but leaves the default value if it cannot be said for sure. Thanks for the patch. Your explanation sounds reasonable, but could you perhaps provide a recipe for how to reproduce this problem (preferably starting from emacs -Q)? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 03:27:29 2021 Received: (at 47877) by debbugs.gnu.org; 21 Apr 2021 07:27:29 +0000 Received: from localhost ([127.0.0.1]:56853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ7Gj-0001qZ-Db for submit@debbugs.gnu.org; Wed, 21 Apr 2021 03:27:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:41027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ7Gg-0001qC-1Q for 47877@debbugs.gnu.org; Wed, 21 Apr 2021 03:27:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9C91D24002A for <47877@debbugs.gnu.org>; Wed, 21 Apr 2021 09:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618990037; bh=wy4jttOtiGGSz8eVQyduiUSc6NKJFy5mrDjQkuxIwGg=; h=From:To:Cc:Subject:Date:From; b=Wmqhwif/sTLXUhvThyU0Dl+ETq/Xp2OZy4MnZpJw102TUqFizu4XlJA+bURbIbXtW SUag2FFVGb7HSarXQRk6pySaQPAwsP54fUpZBTbW21jLeyrTYAI1EXxR/qb2YWEjXK BAcr4bI3w+iPuyHx9Yaf6Qt0rSsXGjDHa3ENrHAKvbV9NesguMpoG85JPVV6mcfmGO k4WT7J9E3nppsI+9mg/Ejvaz8CFnKgiY4VWyzCSrJnlTXQY2F14oGszHL7v1e8qaC/ tEkdnHM9DuBtMDVJK0Nh6V350c56XspnFkDu38STmUVqcNeiYbkM1QqpszbPK+25FC 0t69E05OgYYjg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FQBvm5nTmz6tmK; Wed, 21 Apr 2021 09:27:16 +0200 (CEST) From: Philip Kaludercic To: Stefan Kangas Subject: Re: bug#47877: [PATCH] Respect sgml-xml-mode References: <87eef7pgkl.fsf@posteo.net> Date: Wed, 21 Apr 2021 07:27:16 +0000 In-Reply-To: (Stefan Kangas's message of "Tue, 20 Apr 2021 18:45:18 -0500") Message-ID: <87lf9ccd2j.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 47877 Cc: 47877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Stefan Kangas writes: > Philip Kaludercic writes: > >> sgml-xml-mode is a user option that is over-riden by smgl-mode. When I >> customize sgml-xml-mode to be enabled for every sgml-mode derived mode >> (specifically html-mode), it is disabled because a HTML file does not >> have to be a valid XML file -- even if I would want it to be. >> >> This patch only sets sgml-xml-mode if we know that the current file is >> an XML file, but leaves the default value if it cannot be said for sure. > > Thanks for the patch. > > Your explanation sounds reasonable, but could you perhaps provide a > recipe for how to reproduce this problem (preferably starting from emacs > -Q)? 1. Customize sgml-xml-mode to t 2. Open a HTML file 3. Insert a tag using C-c C-o, eg.

Compare this to 1. Open a HTML file 2. Manually set sgml-xml-mode to t 3. Insert a tag using C-c C-o, eg.

and in this time you will also have a

tag generated, as intended. -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 09:41:54 2021 Received: (at 47877) by debbugs.gnu.org; 21 Apr 2021 13:41:54 +0000 Received: from localhost ([127.0.0.1]:57222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZD73-0007X6-QY for submit@debbugs.gnu.org; Wed, 21 Apr 2021 09:41:54 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:45961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZD72-0007Wm-3e for 47877@debbugs.gnu.org; Wed, 21 Apr 2021 09:41:53 -0400 Received: by mail-pf1-f175.google.com with SMTP id i190so28850083pfc.12 for <47877@debbugs.gnu.org>; Wed, 21 Apr 2021 06:41:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=umL7tHWwmCJDhxcJ9Jm8rSaAETi9S3USYMX0gLqlxP8=; b=YDcjyN8U5+IkXDUECanZ0iRFogP6QjIT6xcWf2kNHY/ZUC324EpDnfhBGw/PmRiiZs gvSzgXGyvM2BjxE9TFm285+bgTCknMk6khIZrcz875uHZ9TMMpz/x/MCqZXyoGryn+wX KYnSKMY2EArjoYTzwUpYMAZpmL3//Knf1tdkBgnpymYZKeXF+T7gGr2xf3DboaF5knZ/ pysPYGdARhLmZixVzzbro208L75qIcxe9OLZxSl/jcY8ie4hrO+5mm1isIeJCfhhL6mB Vl4szk7NT/HGFnCyMfN02HoRpnMX16SHuh1cFD1fawXdFGJUDX7oryJo54qhJ0OHUKaA wHVw== X-Gm-Message-State: AOAM533HiHPocUcne44ZbttlxXHWYiW4Sk5RGBVMXrAs0mK9e9Z7a75F qBCkvjuIWtjF8W7QXjQr0s6DG43h6ZnzhZKkt6Q= X-Google-Smtp-Source: ABdhPJyNA4OzUNssJm6o+H+9FIu5McXoLhe53Yu6iJLmXz6VZhuyl3xa+fymKhCIGjN5cdD67XdCPx12jzZ4zNdtJlA= X-Received: by 2002:a17:90b:f0b:: with SMTP id br11mr11039445pjb.179.1619012506319; Wed, 21 Apr 2021 06:41:46 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Apr 2021 08:41:45 -0500 From: Stefan Kangas In-Reply-To: <87lf9ccd2j.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 21 Apr 2021 07:27:16 +0000") References: <87eef7pgkl.fsf@posteo.net> <87lf9ccd2j.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 21 Apr 2021 08:41:45 -0500 Message-ID: Subject: Re: bug#47877: [PATCH] Respect sgml-xml-mode To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47877 Cc: 47877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 47877 fixed close 47877 28.1 thanks Philip Kaludercic writes: > Stefan Kangas writes: > >> Philip Kaludercic writes: >> >>> sgml-xml-mode is a user option that is over-riden by smgl-mode. When I >>> customize sgml-xml-mode to be enabled for every sgml-mode derived mode >>> (specifically html-mode), it is disabled because a HTML file does not >>> have to be a valid XML file -- even if I would want it to be. >>> >>> This patch only sets sgml-xml-mode if we know that the current file is >>> an XML file, but leaves the default value if it cannot be said for sure. >> >> Thanks for the patch. >> >> Your explanation sounds reasonable, but could you perhaps provide a >> recipe for how to reproduce this problem (preferably starting from emacs >> -Q)? > > 1. Customize sgml-xml-mode to t > 2. Open a HTML file > 3. Insert a tag using C-c C-o, eg.

> > Compare this to > > > 1. Open a HTML file > 2. Manually set sgml-xml-mode to t > 3. Insert a tag using C-c C-o, eg.

> > and in this time you will also have a

tag generated, as intended. Thanks, I can now see that your patch indeed fixes that problem. So I fixed your commit message to follow our preferred format: sgml-mode: Only set sgml-xml-mode if guessed to be an XML file * lisp/textmodes/sgml-mode.el (sgml-mode): Don't override sgml-xml-mode if the result of the guess is used as the buffer local value. (Bug#47877) It is now pushed to master (3e727cf20b); closing this bug. From unknown Sun Jun 15 08:34:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 May 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator