From unknown Tue Jun 17 20:11:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#47860 <47860@debbugs.gnu.org> To: bug#47860 <47860@debbugs.gnu.org> Subject: Status: 28.0.50; Mini buffer resize when lines are truncated regression Reply-To: bug#47860 <47860@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:11:08 +0000 retitle 47860 28.0.50; Mini buffer resize when lines are truncated regressi= on reassign 47860 emacs submitter 47860 Aaron Jensen severity 47860 normal tag 47860 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 17 21:32:02 2021 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 01:32:02 +0000 Received: from localhost ([127.0.0.1]:44983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXwI4-0005K2-8E for submit@debbugs.gnu.org; Sat, 17 Apr 2021 21:32:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:60718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXwI1-0005Ju-8x for submit@debbugs.gnu.org; Sat, 17 Apr 2021 21:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXwI0-0006CQ-SS for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 21:31:57 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:38535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXwHv-0002og-I1; Sat, 17 Apr 2021 21:31:56 -0400 Received: by mail-io1-xd32.google.com with SMTP id q25so76013iog.5; Sat, 17 Apr 2021 18:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:cc:date:message-id:mime-version; bh=gdmYNqFRd9T9T7G06hFLKyQRBZsgJF+iYc8tvSdhvhs=; b=gcBuF6d78O8SOhfSK+YYQQjTqlcD55+tgZPxR4KC0hiHF93qxmWrBivMbas5Y/Q/gA a+6PgLFBQ5pYmB3N5IPSTEoDYYbjPFSdfd6QEOufGWoc76T64XwXP9mVQd4W99Q07W17 z3Z6by3uhc8Bex1HQY/P8SrTe+dFjsk2kFm3FIpkoUy0tM7SBo0D1PCrmoMtH+BdxrPj QZfO4hJ4q/qNOtGPOGRsfpQzc+YUC0BlMixbGvqDtXCwlBBEPc68BhJ/Y0d+4rCa6I1F zKIwjB6sI9Y5Tw6bZOAmecwbi4I2sA8wKjxhDqAS9/4qhpDPljfybwKIhd39lv7VhXYu tIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:cc:date:message-id:mime-version; bh=gdmYNqFRd9T9T7G06hFLKyQRBZsgJF+iYc8tvSdhvhs=; b=PcJXLtr7BrNhrHoYAH24BJKobix0ipvK9UdI/uEWBM/aaik3n3o6nP6YgIz07rQD8/ iorHmIgU/VeALr8uAcxV2T09cFgVrZcKLpnREck8oyELpcssV8lEsno+oWBA5qI2FFjp hHzMWijsW9Ip7f5HiI+8p4QOwmjvWj27n3Wy3A5BpPnhe54QzSKA76/snH89WFPFw3yR lKKMFbk4B/9Z3cGJ6hL2OaUT2g4F2J4eDOQem3CMD0NEHmzNFGqCUYs1xT5uN7u85H+F K9NZFBFfGcD6XoSuzp8QawYX3k7D2PofxgNI4TBipDvlt9Cz8p++cWyDsm91LlRczHso YvKQ== X-Gm-Message-State: AOAM532qzTlmrY1k79ig/1Cx4M3OmDRddQBjmLofnnzmDHOL/6fDaKNu WfEyqDCPTvsQbgjmj0h2H6NRZQW+vX7zdA== X-Google-Smtp-Source: ABdhPJx0vyMYCjis+ehUqcW4mZd/esQxOzGW71b/VfaqUnP2S0AKb+9wXdEI8qcBBxtCWqb03dq/+Q== X-Received: by 2002:a05:6602:2805:: with SMTP id d5mr3902866ioe.87.1618709508501; Sat, 17 Apr 2021 18:31:48 -0700 (PDT) Received: from MacBook-Pro.local ([205.214.166.193]) by smtp.gmail.com with ESMTPSA id k1sm1108915ils.54.2021.04.17.18.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Apr 2021 18:31:29 -0700 (PDT) From: Aaron Jensen To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Mini buffer resize when lines are truncated regression Date: Sat, 17 Apr 2021 20:31:19 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=aaronjensen@gmail.com; helo=mail-io1-xd32.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TRACKER_ID=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: submit Cc: eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) This is a weird one, but when using selectrum and consult I noticed that in some cases the mini buffer does not get properly resized. I tracked it down to a recent commit: 56c42bd28d9be400e37e122b7abebcd980ea0e8b When one of the lines in the minibuffer is truncated, automatically resizing the mini buffer does not work properly. Specifically, the height is not adjusted to the actual height of the content. To reproduce, you'll need selectrum and consult installed, then, from emacs -Q: (recentf-mode) ;; This should be enough x's to cause truncation (so more than your ;; window width) (setq recentf-list '("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")) (require 'consult) (require 'selectrum) (selectrum-mode) (setq completion-styles '(substring)) (consult-buffer) I expect to see all lines in the minibuffer, including the xxxx..., but instead I just see the first couple. Reverting the above commit fixes the issue. Hopefully this is enough to pinpoint it, but if it's not I can try and find a more narrow repro (I suspect it has something to do w/ the group headers and its dashes because other similar things in the minibuffer do not reproduce this. In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.3.0, NS appkit-2022.30 Version 11.2.3 (Build 20D91)) of 2021-04-11 built on MacBook-Pro.local Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.2.3 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2 --with-gnutls --with-native-compilation --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/10 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include'' Configured features: ACL GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: C/*l Minor modes in effect: bug-reference-prog-mode: t global-flycheck-mode: t flycheck-mode: t global-git-commit-mode: t transient-posframe-mode: t selectrum-prescient-mode: t company-posframe-mode: t company-prescient-mode: t company-tng-mode: t eval-sexp-fu-flash-mode: t eros-mode: t org-roam-mode: t speed-of-thought-mode: t dtrt-indent-mode: t electric-pair-mode: t yas-global-mode: t yas-minor-mode: t winner-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: deferred treemacs-fringe-indicator-mode: t global-auto-revert-mode: t recentf-mode: t better-jumper-mode: t better-jumper-local-mode: t repeat-mode: t global-undo-tree-mode: t undo-tree-mode: t global-evil-collection-unimpaired-mode: t evil-collection-unimpaired-mode: t global-evil-mc-mode: t evil-mc-mode: t evil-snipe-override-mode: t evil-snipe-mode: t evil-snipe-override-local-mode: t evil-snipe-local-mode: t global-evil-matchit-mode: t evil-matchit-mode: t global-evil-surround-mode: t evil-surround-mode: t shell-dirtrack-mode: t evil-mode: t evil-local-mode: t envrc-global-mode: t envrc-mode: t projectile-mode: t persp-mode: t which-key-posframe-mode: t which-key-mode: t mini-frame-mode: t gcmh-mode: t selectrum-mode: t prescient-persist-mode: t +popup-mode: t ws-butler-global-mode: t ws-butler-mode: t show-paren-mode: t save-place-mode: t ns-auto-titlebar-mode: t leader-key-leader-override-mode: t global-leader-key-leader-override-mode: t delete-selection-mode: t savehist-mode: t xterm-mouse-mode: t override-global-mode: t straight-use-package-mode: t straight-package-neutering-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t auto-fill-function: yas--auto-fill transient-mark-mode: t abbrev-mode: t Load-path shadows: /Users/aaronjensen/.emacs.d/straight/build/ivy/elpa hides /Users/aaronjensen/.emacs.d/straight/build/lispy/elpa /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-stan hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-stan /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-exp hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-exp /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-J hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-J /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-emacs-lisp hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-emacs-lisp /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-css hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-css /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-lob hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-lob /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-irc hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-irc /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-forth hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-forth /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-macs hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-macs /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-version hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-version /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-scheme hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-scheme /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-abc hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-abc /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-C hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-C /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-capture hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-capture /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ref hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ref /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-clojure hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-clojure /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-mouse hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-mouse /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ledger hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ledger /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-ctags hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-ctags /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-entities hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-entities /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-archive hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-archive /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-screen hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-screen /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-bibtex hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-bibtex /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-haskell hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-haskell /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-asymptote hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-asymptote /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-table hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-table /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-eww hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-eww /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-org hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-org /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-num hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-num /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-plot hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-plot /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-rmail hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-rmail /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-awk hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-awk /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-groovy hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-groovy /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-octave hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-octave /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-faces hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-faces /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-colview hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-colview /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-R hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-R /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-refile hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-refile /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-timer hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-timer /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ebnf hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ebnf /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-mobile hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-mobile /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-fortran hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-fortran /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-shell hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-shell /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-perl hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-perl /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-sqlite hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-sqlite /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-sed hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-sed /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-list hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-list /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ruby hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ruby /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-eval hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-eval /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-habit hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-habit /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-clock hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-clock /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-goto hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-goto /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-html hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-html /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-src hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-src /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-lisp hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-lisp /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-eshell hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-eshell /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ditaa hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ditaa /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-pcomplete hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-pcomplete /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-lint hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-lint /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-latex hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-latex /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-sass hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-sass /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-io hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-io /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-tangle hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-tangle /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-calc hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-calc /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-java hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-java /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-icalendar hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-icalendar /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-mhe hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-mhe /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-attach-git hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-attach-git /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-md hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-md /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-beamer hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-beamer /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-element hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-element /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-protocol hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-protocol /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-mscgen hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-mscgen /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-gnuplot hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-gnuplot /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-tempo hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-tempo /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-latex hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-latex /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-w3m hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-w3m /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-id hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-id /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-vala hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-vala /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-man hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-man /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-feed hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-feed /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-lua hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-lua /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-table hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-table /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-ocaml hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-ocaml /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-coq hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-coq /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-gnus hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-gnus /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-picolisp hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-picolisp /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-indent hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-indent /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-lilypond hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-lilypond /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-matlab hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-matlab /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-datetree hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-datetree /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-docview hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-docview /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-python hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-python /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-makefile hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-makefile /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-duration hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-duration /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-agenda hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-agenda /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-dot hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-dot /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-js hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-js /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-publish hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-publish /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-inlinetask hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-inlinetask /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-org hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-org /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-keys hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-keys /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-core hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-core /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-compat hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-compat /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-odt hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-odt /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-info hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-info /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-plantuml hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-plantuml /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-eshell hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-eshell /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-ascii hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-ascii /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-loaddefs hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-loaddefs /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-hledger hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-hledger /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-maxima hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-maxima /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ol-bbdb hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ol-bbdb /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-macro hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-macro /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-sql hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-sql /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-attach hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-attach /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-processing hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-processing /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ox-texinfo hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ox-texinfo /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-crypt hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-crypt /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-footnote hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-footnote /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/org-install hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/org-install /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-comint hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-comint /Users/aaronjensen/.emacs.d/straight/build/org-plus-contrib/ob-shen hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/org/ob-shen /Users/aaronjensen/.emacs.d/straight/build/let-alist/let-alist hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/28.0.50/lisp/emacs-lisp/let-alist Features: (shadow mail-extr emacsbug sendmail cua-base org-clock conf-mode semantic/ia semantic/analyze/refs semantic/db-find semantic/db-ref semantic/senator semantic/decorate semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn semantic/ctxt semantic/format semantic/tag-ls semantic/find git-rebase org-goto cal-move timezone magit-extras tabify sql rng-xsd xsd-regexp rng-cmpct tramp-cache lsp-diagnostics lsp-modeline view lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-vetur lsp-html lsp-verilog lsp-vala lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-r lsp-purescript lsp-pyls lsp-pwsh lsp-php lsp-perl lsp-ocaml lsp-nix lsp-nim lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-haxe lsp-groovy lsp-hack lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-clangd lsp-bash lsp-angular lsp-ada lsp-actionscript diary-lib diary-loaddefs hippie-exp vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bug-reference evil-collection-pdf pdf-loader pdf-tools pdf-view pdf-cache dired-aux explain-pause-mode explain-pause-top explain-pause-log-to-socket evil-collection-restclient restclient vterm-toggle tramp-sh evil-collection-vterm vterm term ehelp vterm-module term/xterm xterm dumb-jump popup rng-nxml rng-valid nxml-mode nxml-outln nxml-rap terraform-mode hcl-mode dockerfile-mode yaml-mode json-mode json-reformat json-snatcher js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs sh-script executable lua-mode ruby-electric ruby-refactor rspec-mode evil-ruby-text-objects bundler inf-ruby ruby-mode smie enh-ruby-mode eslintd-fix web-mode disp-table company-rg git-link magit-delta prettier tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp nvm iter2 lsp-ui lsp-ui-flycheck lsp-ui-doc goto-addr lsp-ui-imenu lsp-ui-peek lsp-ui-sideline flycheck lsp-ui-util lsp-mode lsp-protocol spinner network-stream markdown-mode org-pandoc-import gnuplot org-journal org-crypt cal-iso deft org-drill persist tab-line restart-emacs ace-window buffer-move rotate completing-read-xref embark-consult embark ffap desktop frameset pdf-info tq pdf-util wgrep sort drag-stuff speeddating evil-nerd-commenter evil-nerd-commenter-operator evil-nerd-commenter-sdk char-fold sgml-mode facemenu evil-visualstar evil-collection-magit treemacs-magit magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit package url-handlers magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient-posframe transient magit-git magit-section magit-utils consult-selectrum selectrum-prescient selectrum minibuf-eldef crm company-files company-capf company-posframe company-prescient company-tng company eval-sexp-fu eros lispyville lispy swiper ivy ivy-faces ivy-overlay colir lispy-inline avy etags fileloop lispy-tags semantic/db eieio-base semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util iedit iedit-lib vc-git diff-mode vc-dispatcher org-appear orgonomic org-indent org-superstar form-feed ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom browse-url gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec epa epg epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs mail-utils ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-ascii ox-gfm ox-md ox-html table ox-publish ox org-download org-attach async org-roam org-roam-link org-roam-graph xml org-roam-doctor org-roam-dailies org-roam-capture org-roam-db emacsql-sqlite3 emacsql emacsql-compiler org-mac-link org-capture org-roam-completion org-roam-buffer org-roam-faces org-roam-macs org-roam-compat org-id org-refile org-protocol org-tempo tempo evil-org-agenda evil-org org-element avl-tree generator ob-shell org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities time-date noutline outline hide-mode-line popup-mode-core org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs elisp-def ert ewoc evil-collection-debug debug sotlisp skeleton dtrt-indent elec-pair consult treemacs-bookmarks bookmark yasnippet popup-mode-hacks winner treemacs-evil treemacs-perspective treemacs-projectile treemacs-all-the-icons all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-mouse-interface treemacs-tags evil-collection-xref xref project treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture inline hl-line ht treemacs-logging treemacs-customization treemacs-macros autorevert filenotify rainbow-mode xterm-color color evil-collection-helpful helpful imenu trace evil-collection-edebug edebug backtrace info-look find-func f help-fns elisp-refs s dired-subtree dired-hacks-utils evil-collection-dired dired dired-loaddefs dash evil-collection-profiler profiler url-http url url-proxy url-privacy url-expand url-methods url-history mailcap url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-cookie url-domsuf url-util url-gw url-parse auth-source eieio eieio-core eieio-loaddefs password-cache url-vars nsm rmc puny recentf tree-widget better-jumper repeat undo-tree diff queue evil-anzu anzu evil-collection-unimpaired evil-collection-which-key evil-collection-ibuffer evil-collection-help evil-collection-custom evil-collection-process-menu evil-collection annalist evil-mc evil-mc-command-execute evil-mc-command-record evil-mc-cursor-make evil-mc-region evil-mc-cursor-state evil-mc-undo evil-mc-vars evil-mc-known-commands evil-mc-common evil-numbers evil-snipe evil-matchit evil-matchit-sdk evil-surround cus-edit cus-start cus-load wid-edit evil evil-integration evil-maps evil-commands reveal flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex shell pcomplete evil-macros evil-repeat evil-states evil-core evil-common windmove calc calc-loaddefs calc-macs rect evil-digraphs evil-vars envrc inheritenv json map persp-projectile projectile grep compile text-property-search comint ansi-color ibuf-ext ibuffer ibuffer-loaddefs perspective which-key-posframe posframe which-key advice thingatpt ido mini-frame server gcmh gcmh-autoloads explain-pause-mode-autoloads pdf-tools-autoloads autoload radix-tree lisp-mnt tablist-autoloads restclient-autoloads vterm-toggle-autoloads vterm-autoloads dumb-jump-autoloads popup-autoloads terraform-mode-autoloads hcl-mode-autoloads dockerfile-mode-autoloads yaml-mode-autoloads json-mode-autoloads json-snatcher-autoloads json-reformat-autoloads lua-mode-autoloads ruby-electric-autoloads bundler-autoloads inf-ruby-autoloads ruby-refactor-autoloads rspec-mode-autoloads evil-ruby-text-objects-autoloads enh-ruby-mode-autoloads sotlisp-autoloads elisp-def-autoloads lispyville-autoloads lispy-autoloads zoutline-autoloads counsel-autoloads swiper-autoloads ivy-autoloads iedit-autoloads eros-autoloads eval-sexp-fu-autoloads eslintd-fix-autoloads web-mode-autoloads company-rg-autoloads company-posframe-autoloads company-prescient-autoloads company-autoloads git-link-autoloads magit-delta-autoloads xterm-color-autoloads prettier-autoloads nvm-autoloads iter2-autoloads flycheck-autoloads let-alist-autoloads lsp-ui-autoloads lsp-mode-autoloads markdown-mode-autoloads spinner-autoloads org-superstar-autoloads ox-gfm-autoloads org-pandoc-import-autoloads gnuplot-autoloads org-download-autoloads async-autoloads org-journal-autoloads deft-autoloads org-roam-autoloads emacsql-sqlite3-autoloads emacsql-autoloads orgonomic-autoloads org-drill-autoloads persist-autoloads org-appear-autoloads evil-org-autoloads transient-posframe-autoloads restart-emacs-autoloads better-jumper-autoloads hydra ring lv buffer-move-autoloads rotate-autoloads completing-read-xref-autoloads mini-frame-autoloads embark-consult-autoloads embark-autoloads consult-autoloads selectrum-prescient-autoloads selectrum-autoloads persp-projectile-autoloads prescient prescient-autoloads which-key-posframe-autoloads which-key-autoloads popup-mode popup-mode-settings popup-mode-autoloads hide-mode-line-autoloads wgrep-autoloads yasnippet-autoloads form-feed-autoloads drag-stuff-autoloads dtrt-indent-autoloads ws-butler ws-butler-autoloads evil-anzu-autoloads anzu-autoloads evil-collection-autoloads annalist-autoloads evil-mc-autoloads evil-numbers-autoloads speeddating-autoloads evil-snipe-autoloads evil-matchit-autoloads evil-nerd-commenter-autoloads evil-visualstar-autoloads evil-surround-autoloads pp undo-tree-autoloads queue-autoloads paren treemacs-perspective-autoloads perspective-autoloads treemacs-magit-autoloads magit-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads treemacs-all-the-icons-autoloads all-the-icons-autoloads treemacs-projectile-autoloads treemacs-evil-autoloads evil-autoloads goto-chg-autoloads pcase treemacs-autoloads cfrs-autoloads ht-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads projectile-autoloads pkg-info-autoloads epl-autoloads saveplace rainbow-mode-autoloads posframe-autoloads ns-auto-titlebar ns-auto-titlebar-autoloads nano nano-modeline memoize face-remap nano-theme nano-faces nano-theme-light nano-base-colors nano-layout nano-autoloads memoize-autoloads envrc-autoloads inheritenv-autoloads compdef derived compdef-autoloads helpful-autoloads elisp-refs-autoloads f-autoloads s-autoloads use-package-bind-key dired-subtree-autoloads dired-hacks-utils-autoloads dash-autoloads hydra-autoloads lv-autoloads leader-key bind-map leader-key-autoloads bind-map-autoloads delsel savehist xt-mouse edmacro kmacro no-littering no-littering-autoloads finder-inf bind-key easy-mmode use-package-core use-package-autoloads bind-key-autoloads straight-autoloads info straight display-line-numbers comp comp-cstr warnings subr-x rx cl-seq cl-macs cl-extra help-mode seq byte-opt gv cl-loaddefs cl-lib bytecomp byte-compile cconv iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 3314864 582845) (symbols 48 92802 4) (strings 32 364412 115375) (string-bytes 1 14259477) (vectors 16 310952) (vector-slots 8 6522884 139043) (floats 8 2687 2734) (intervals 56 175710 3592) (buffers 992 360)) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 02:57:30 2021 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 06:57:30 +0000 Received: from localhost ([127.0.0.1]:45167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lY1N4-00051n-J5 for submit@debbugs.gnu.org; Sun, 18 Apr 2021 02:57:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:38500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lY1N3-00051f-AZ for submit@debbugs.gnu.org; Sun, 18 Apr 2021 02:57:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lY1N3-0001Li-2H for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 02:57:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47410) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lY1N2-0001pD-QC; Sun, 18 Apr 2021 02:57:28 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1327 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lY1N1-0002Kp-Mp; Sun, 18 Apr 2021 02:57:28 -0400 Date: Sun, 18 Apr 2021 09:57:09 +0300 Message-Id: <835z0kulkq.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Sat, 17 Apr 2021 20:31:19 -0500) Subject: Re: 28.0.50; Mini buffer resize when lines are truncated regression References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > CC: eliz@gnu.org > Date: Sat, 17 Apr 2021 20:31:19 -0500 > > This is a weird one, but when using selectrum and consult I noticed that > in some cases the mini buffer does not get properly resized. I tracked > it down to a recent commit: > > 56c42bd28d9be400e37e122b7abebcd980ea0e8b > > When one of the lines in the minibuffer is truncated, automatically > resizing the mini buffer does not work properly. Specifically, the > height is not adjusted to the actual height of the content. > > To reproduce, you'll need selectrum and consult installed, then, from > emacs -Q: > > (recentf-mode) > ;; This should be enough x's to cause truncation (so more than your > ;; window width) > (setq recentf-list '("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")) > (require 'consult) > (require 'selectrum) > (selectrum-mode) > (setq completion-styles '(substring)) > (consult-buffer) > > I expect to see all lines in the minibuffer, including the xxxx..., but > instead I just see the first couple. Reverting the above commit fixes > the issue. > > Hopefully this is enough to pinpoint it, but if it's not I can try and > find a more narrow repro Yes, please do. I'd very much prefer to see a recipe that doesn't involve 3rd-party packages which specifically are aimed at changing how completion works in the minibuffer. So, please, no consult and no selectrum. Okay? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 13:46:13 2021 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 17:46:13 +0000 Received: from localhost ([127.0.0.1]:47711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYBUn-00056F-2c for submit@debbugs.gnu.org; Sun, 18 Apr 2021 13:46:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:60778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYBUk-000565-69 for submit@debbugs.gnu.org; Sun, 18 Apr 2021 13:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYBUj-0005fp-T2 for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 13:46:05 -0400 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]:35498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYBUf-0002qJ-Ub; Sun, 18 Apr 2021 13:46:05 -0400 Received: by mail-yb1-xb2d.google.com with SMTP id x8so30905266ybx.2; Sun, 18 Apr 2021 10:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f7XpAxIEn/gmhIU6iwdsTSgLvGLLUvZIeX3Jds6ixRs=; b=g1vyCDzyPE/sIwR7NjhoXdaa7eEWQBE7XoiFX+vrSNJ4g68HoeF1MC4gXC12lDn0yf NZnFMM4nBSAOjML6SujOCty4h5b2A/VcELtVGE+e80d4vIkX1ivNVjqwWkXC9rA9HKvz FkYeCTAo+pLLZP3pj2Mbgi5vxDhnrql7e++KG1Dql4+pXcR8ziBD6vbGd0MQu/s4aQHw yYVchMuaMk82XkiM+5y9hRu5O2+VaQJcn/8MeAsszOyrmdIwOoTeGqjpT/UK6KlEl/g+ mPBDZc7Snt2b/FPGIMRv/15D9hz3WlkjstOrKBnFan+4j4moav1ZKtZ05d6EB8ydlN+D fV5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f7XpAxIEn/gmhIU6iwdsTSgLvGLLUvZIeX3Jds6ixRs=; b=jCmhI2X5rASrBcig8k1KuiAS2HRuTa/mZAkhmm6oqu5NayRlKOZRY0vdSk6RwyKbE1 cYS0qtKA8SBUB6tGg+V+ArNdtK6qa4GAB9HYo+4HZBXnDwUjgQwhyiDwqSS30s0CHizE dMCAxxviu1k+VSo/oO2LqNYddRj4wE5v8lAN7Kvq+22GyRR1gB91E9fr4UjMO/PlQh5Q FvbMWVOQq1qmUTE7h20QM43M68xAtdYVgUBmWmCUW0jfbBQMfqh3rR0eOYnpzORADMik qmptkamNNsIqwOLrZVa1/AEZdb66E1IAMUWn8Zp6yt6h3IPZYn9ze25ygarrUy2+PZ25 WCGQ== X-Gm-Message-State: AOAM531P2QNsEZ6gdUjSwSA5oz73heG9JAA5jiKTClYSXRKmb9T534td jPZ0+MOgqAD/7gxAUIPWHgpKlarUaS8Mw/Q0VzxFc4E63gga/Q== X-Google-Smtp-Source: ABdhPJx9Ry6f3Fcy84kMeykrPMgKR5eOwz/y3sLk0YL2YDq2+iB7u6ADBhljNJPrWknv6wNjBbYcg/OxUW33SiflMRc= X-Received: by 2002:a25:99c1:: with SMTP id q1mr11425294ybo.517.1618767959782; Sun, 18 Apr 2021 10:45:59 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> In-Reply-To: <835z0kulkq.fsf@gnu.org> From: Aaron Jensen Date: Sun, 18 Apr 2021 12:45:48 -0500 Message-ID: Subject: Re: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=aaronjensen@gmail.com; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Sun, Apr 18, 2021 at 1:57 AM Eli Zaretskii wrote: > > Yes, please do. I'd very much prefer to see a recipe that doesn't > involve 3rd-party packages which specifically are aimed at changing > how completion works in the minibuffer. So, please, no consult and > no selectrum. Okay? I haven't been able to get selectrum out of the mix yet. It's doing quite a bit and I don't understand minibuffer manipulation well enough to narrow the repro just yet. I did get rid of consult, so now the repro is just: (require 'selectrum) (selectrum-mode) (setq completion-styles '(substring)) (selectrum-completing-read "test: " '("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb")) It may be a bit before I'm able to narrow it down any further. Do you have any sense of how that commit could possibly affect the automatic sizing of the minibuffer? Thanks, Aaron From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 14:03:24 2021 Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 18:03:24 +0000 Received: from localhost ([127.0.0.1]:47734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYBlT-0005XJ-Nk for submit@debbugs.gnu.org; Sun, 18 Apr 2021 14:03:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:37830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYBlR-0005XA-NS for submit@debbugs.gnu.org; Sun, 18 Apr 2021 14:03:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYBlR-0000UM-HA for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 14:03:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53724) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYBlQ-0004oW-99; Sun, 18 Apr 2021 14:03:21 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3609 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYBlP-0005Si-6X; Sun, 18 Apr 2021 14:03:19 -0400 Date: Sun, 18 Apr 2021 21:03:00 +0300 Message-Id: <83blabtqqz.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Sun, 18 Apr 2021 12:45:48 -0500) Subject: Re: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Sun, 18 Apr 2021 12:45:48 -0500 > Cc: bug-gnu-emacs@gnu.org > > On Sun, Apr 18, 2021 at 1:57 AM Eli Zaretskii wrote: > > > > Yes, please do. I'd very much prefer to see a recipe that doesn't > > involve 3rd-party packages which specifically are aimed at changing > > how completion works in the minibuffer. So, please, no consult and > > no selectrum. Okay? > > I haven't been able to get selectrum out of the mix yet. Too bad. > Do you have any sense of how that commit could possibly affect the > automatic sizing of the minibuffer? Not sure what kind of answer you expected here. That change affects Emacs display behavior when lines are truncated, and it could indeed affe ct the mini-window resizing because of that. That change was done to fix a bug, so reverting it is out of the question. We need to understand how the change affects the use case you present. It could be that there's another display bug, or it could be that the package in question itself has a bug that just went unnoticed because of the bug fixed by that commit. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 20:16:14 2021 Received: (at submit) by debbugs.gnu.org; 19 Apr 2021 00:16:14 +0000 Received: from localhost ([127.0.0.1]:48041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYHaH-0008Hj-Vk for submit@debbugs.gnu.org; Sun, 18 Apr 2021 20:16:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:60102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYHaG-0008Hc-42 for submit@debbugs.gnu.org; Sun, 18 Apr 2021 20:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYHaF-0003c0-K4 for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 20:16:11 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:36762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYHaD-0005ro-G0; Sun, 18 Apr 2021 20:16:11 -0400 Received: by mail-yb1-xb31.google.com with SMTP id k73so30428478ybf.3; Sun, 18 Apr 2021 17:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FaNe2YCFHkv3hVE0hnEyi94RlDIGMDFCVm4ObFmPzJI=; b=TFGjN7Ulx+ADukT3TiKkvhytNhlkbbkJ3O9CeB8DM0vLbaw72M7VVZ0d/zS+bQBx0D gO7FMvpgG+kRh0/nx3ubI4nb6suJVlmiDtsz/tZmKckF8YBGtCaxx0+OX/twnmu924t4 feuV6nI+gIOfM135ZHo4JxueCjg8jtMrEz6ZFAavR5fMpo7zG2rGkuISyh3ijoJ7v68x 7IxHo4uXYz4Ro038Z++Et8ILAL6ZHWv5UzQtMw0EaLzkasZddTKzSfQfPrxTsH8ctbVN 58VCkZ/nRx5smJ5yCZweDFezqFEGsGKIyTdBxnDTdYUJ2qYozm9QOW+KINvs07tguDQL 2vaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FaNe2YCFHkv3hVE0hnEyi94RlDIGMDFCVm4ObFmPzJI=; b=eEkAaxi7NWVZ9wMHUS0GBBagtAMQ8O/Kti8YVyl6lWi8/zIiZp42OTycVck3fOrRmE I90FsQyBQ8jSsX0DrblpBSrsEm34Av4eIA5LyQd8vJXWlmOIccfFgLqtC0LEL86UNZgt +9LkRiHNyCtcJXLwjuKEdVBb84GmT2V1Vt9OYa7ENNPy/A+7QBAIUVPPC0ovTS+LvRV/ 9yGnpPXP076xVWwL5+pNl7DKwwI5drbC6VYJselWL9/NmThVf9lcnvyOeDzn9jz8GOad VCwGFD8a0iVbW78wmAUE3EtuYVHwQB5nC210Ypeluzq0xJbxsghAVT0VGB6TxxyeyEf4 n85w== X-Gm-Message-State: AOAM5303hGkTKaIjqaT1UVD8IYXd+QCMRqxMvWJQaA/I/qKk86q9QgSt rMzdfYI9cjCiiZszVBz8CEAw0wIYp0GrzA+/l1FvDdfOubrwjw== X-Google-Smtp-Source: ABdhPJx4/w0vRs24vpSE/cnJy8B50nktXvcyyMfGIrjpLimxLQPeL2y/kc1M2FyODi1M1WUyxBfo2h0yp155MvX7kc4= X-Received: by 2002:a25:a226:: with SMTP id b35mr12448635ybi.275.1618791367552; Sun, 18 Apr 2021 17:16:07 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> In-Reply-To: <83blabtqqz.fsf@gnu.org> From: Aaron Jensen Date: Sun, 18 Apr 2021 19:15:55 -0500 Message-ID: Subject: Re: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=aaronjensen@gmail.com; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Sun, Apr 18, 2021 at 1:03 PM Eli Zaretskii wrote: > > I haven't been able to get selectrum out of the mix yet. > > Too bad. Okay, narrowed it down: (setq hook (lambda nil (remove-hook 'minibuffer-setup-hook hook) (setq-local overlay (make-overlay (point) (point) nil 'front-advance 'rear-advance)) (setq-local truncate-lines t) (setq minibuf-after-string "a\nbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\nccc") ;; (setq minibuf-after-string "a\nbbbbbbb\nccc") (move-overlay overlay (point-max) (point-max)) (overlay-put overlay 'after-string minibuf-after-string))) (unwind-protect (progn (add-hook 'minibuffer-setup-hook hook t) (read-from-minibuffer "")) (remove-hook 'minibuffer-setup-hook hook)) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 08:40:18 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 12:40:18 +0000 Received: from localhost ([127.0.0.1]:48683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTCM-00045j-IQ for submit@debbugs.gnu.org; Mon, 19 Apr 2021 08:40:18 -0400 Received: from heytings.org ([95.142.160.155]:44558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTCH-00045W-RB for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 08:40:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618836012; bh=plE/Y9p+jTe3GonLSyu75OabsUdo9YYuICZVaFC+oyU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=D67Ha9u8WqAyZRL8yIK+IS1I4TtxZ+YqRqFtrUNWpg7K7/tRMB4BjiG1XGgTIWu28 kZyOIVEltKxwOh6wp23npmxuF1jPgQ//ItjAcocAcfEtGBTveNyiMotXpBzpZfju6o Jnd8QE0GnqxAzv8pDQQkDjHIT0QiUYuTogov9lazmKz59Nldj1yXRYV9Vdl/SUT6SH Cst6KA2LUp5NER5BvLEIK+NNSrC0RsaJ5coa8I6Ds9E2i6IJ1gUnOgrwBCF3jFGqGm XFWEzr11jEwmaBi+m8JhOL4OnDsAElwHn+EQ1qhLtqKcKDuRZ+9oL4/8+Z98vZHrE9 QL5pgg7r60Wpg== Date: Mon, 19 Apr 2021 12:40:12 +0000 From: Gregory Heytings To: Aaron Jensen Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression In-Reply-To: Message-ID: References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Okay, narrowed it down: > > (setq hook > (lambda nil > (remove-hook 'minibuffer-setup-hook hook) > (setq-local overlay > (make-overlay (point) (point) nil > 'front-advance 'rear-advance)) > (setq-local truncate-lines t) > (setq minibuf-after-string > "a\nbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\nccc") > ;; (setq minibuf-after-string "a\nbbbbbbb\nccc") > (move-overlay overlay (point-max) (point-max)) > (overlay-put overlay > 'after-string minibuf-after-string))) > > (unwind-protect > (progn > (add-hook 'minibuffer-setup-hook hook t) > (read-from-minibuffer "")) > (remove-hook 'minibuffer-setup-hook hook)) > Thanks. But what do you expect this code to do? I tested it, and for Emacs 24 to 27 you see only "a" in the minibuffer. After commit 56c42bd28d, you see two lines, "a" and "bbb...". From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 09:10:53 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 13:10:53 +0000 Received: from localhost ([127.0.0.1]:48760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTfx-00059O-6M for submit@debbugs.gnu.org; Mon, 19 Apr 2021 09:10:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTfv-00059B-3U for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 09:10:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40097) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYTfp-00017l-AK; Mon, 19 Apr 2021 09:10:45 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYTfo-0001A4-Aa; Mon, 19 Apr 2021 09:10:44 -0400 Date: Mon, 19 Apr 2021 16:10:26 +0300 Message-Id: <83wnsys9ml.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: (message from Gregory Heytings on Mon, 19 Apr 2021 12:40:12 +0000) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Mon, 19 Apr 2021 12:40:12 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , 47860@debbugs.gnu.org > > Thanks. But what do you expect this code to do? I tested it, and for > Emacs 24 to 27 you see only "a" in the minibuffer. After commit > 56c42bd28d, you see two lines, "a" and "bbb...". Exactly the questions to which I would like to know the answers, thanks. IOW, given that the current code does "somewhat" better than everything we had before, what exactly is the problem you (Aaron) see with the offending commit that you call it "regression"? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 10:03:08 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:03:08 +0000 Received: from localhost ([127.0.0.1]:51437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUUV-0007JG-SD for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:03:08 -0400 Received: from mail-pj1-f46.google.com ([209.85.216.46]:52108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUUT-0007Ih-JP for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:03:06 -0400 Received: by mail-pj1-f46.google.com with SMTP id lt13so9150614pjb.1 for <47860@debbugs.gnu.org>; Mon, 19 Apr 2021 07:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RRuXrDM4oi3ekjquqD5qk/XxYU9IX6Mx8UeQ9CMh02Q=; b=NoPLacjZz5/qrLSgnFBC7mVfbgtAF+/cF8nDd9j9MSzsMJUPOAOWTvI3CTfc4wf9IL 97Yq1nwD0rpZZCa8B5/CmWwPEJMHuZYvZa0beSSUtF93ubymVo070KckPQcJ58SuZGNp rX16fKvhS4uT1rKkCEIw0q1mtEpLMZVisXyoRUlduQyXnrxl1fkItXXAOmQb/G/ony0u esvWzxWQN2sG6lCpvP3FsU2FZqinnx4voZPh5waJOxDKBYJ2gACfuKInYOiCNvJHfRZz 3d8kf1jWwYkd06flyjah0vjN8a0ql0vc+MhRJQFD4fOtO79feDUKefBd828xHwiC2w8X ARRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RRuXrDM4oi3ekjquqD5qk/XxYU9IX6Mx8UeQ9CMh02Q=; b=DqGVOvVvxwT5H0uQ58GqrC243ePBygjU0EwN2G0dvczvj8+HwhxWdN/gxLoVDACST6 9N7L/edQvhcLhsDcR51qiVgwC4aY65ymPeQQGNVOpRTDpcDm7WsBzZkpHsN1gmLftyyh bsz6a57ffJ3wb7cty8uqpXSkLaVbiGg/ebAbFvHPwUey8dbgiPke/vR8j5wOK6lO/DnL 1EyXsGAQD6o49OeN9wZRkiHNbOcBH4LTROg1lSouZ7IAf/mWREP26Qw+imF1P8UoatN9 G7vJrv3QDRecEs6T/qnKDpayrWolE0r7VMY9Tl+ZB3yL48gepN4za/vnIhWKfhZUMe1o TaBw== X-Gm-Message-State: AOAM532bzZdM8xGWXSvpO+TcmmWrmJYYEC8v6f/c09oerbspXctqHTJE IpqezbtTR+moB0BeFAEGwUaUgVKytj7HdN5YzLEn8Hb7l9crZw== X-Google-Smtp-Source: ABdhPJxWBCU9fyu5vc4GTgR8i93WEntyXiAzu79gNAlXBM1EIZ+Wlz+jiBG3/4lDhYfmo8f39/xpX0ObSVxr/ju0NOw= X-Received: by 2002:a17:902:e886:b029:e7:386b:1b30 with SMTP id w6-20020a170902e886b02900e7386b1b30mr23372141plg.42.1618840979503; Mon, 19 Apr 2021 07:02:59 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> In-Reply-To: <83wnsys9ml.fsf@gnu.org> From: Aaron Jensen Date: Mon, 19 Apr 2021 09:02:24 -0500 Message-ID: Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 8:10 AM Eli Zaretskii wrote: > > > Date: Mon, 19 Apr 2021 12:40:12 +0000 > > From: Gregory Heytings > > cc: Eli Zaretskii , 47860@debbugs.gnu.org > > > > Thanks. But what do you expect this code to do? I tested it, and for > > Emacs 24 to 27 you see only "a" in the minibuffer. After commit > > 56c42bd28d, you see two lines, "a" and "bbb...". > > Exactly the questions to which I would like to know the answers, > thanks. > > IOW, given that the current code does "somewhat" better than > everything we had before, what exactly is the problem you (Aaron) see > with the offending commit that you call it "regression"? I have not tested with Emacs 27. I have, however, tested with Emacs 28 with and without the commit I mentioned. With the commit reverted, I see this: https://cln.sh/sNpBcb Without it reverted, I see this: https://cln.sh/RtPEie What I expect is for the minibuffer to be sized as the first example and not the second. I have not tested my repro on Emacs 27, so it's interesting to hear that only the first line is displayed. However, This is what it looks like when using selectrum in Emacs 27: https://user-images.githubusercontent.com/8199224/114367956-3f4a8e00-9b7d-11eb-8307-5372fb48de63.png and Emacs 28: https://user-images.githubusercontent.com/8588/114411541-e1fd0f80-9b71-11eb-8ba3-5bf1437a7806.png In Emacs 28, the minibuffer is not resized to be large enough to see all candidates. It also never scrolls, so it's difficult to pick any candidate that is not visible. I do know that Selectrum does some vertical resizing after adding text to the minibuffer, so that may be what causes Emacs 27 to look right. It may also be that that vertical resizing now fails in Emacs 28 for some reason. I did not need the resizing code to reproduce what appears to be *an* issue, but it could very well not be the exact issue I'm seeing in Selectrum if it is indeed the resizing code that's not working properly. I'll spend a little time adding the resize code in and testing in Emacs 27 to see if that helps narrow down to the exact issue I'm seeing on selectrum. Thanks, Aaron From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 10:24:37 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:24:38 +0000 Received: from localhost ([127.0.0.1]:51488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUpJ-0007pl-Mq for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:24:37 -0400 Received: from mail-yb1-f169.google.com ([209.85.219.169]:34442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUpI-0007pE-9z for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:24:36 -0400 Received: by mail-yb1-f169.google.com with SMTP id v3so36594069ybi.1 for <47860@debbugs.gnu.org>; Mon, 19 Apr 2021 07:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PVrPX+hyjQZKZxfTUIQIvGz4499CIZ5vo0AfYH2SKKQ=; b=fuS6fZfSUNjGS/wD/H4J48hQpHbCMBSnaAK129miHJ4K3ocU501piwGej9M+FtQlEA B6WCS1hly7UWumMslkEsRqBX6Pg8LRZZhcu7A/PaQnAV3KKcQY/TKSjkjbL4M43jaM6B zrKF5NBG2t0YZ/fMe1ofoNG+jCduy/8v1UXJnJ2ylx5H/5QJFJit4nJKX6AtIQYNwFa2 VaWLBD70OmDP9by+GFzIqW19ZlWorGld1T2PTU3YLQ6tNzuvSNl3t2df34b5htzFB/7s SN5HuetPkQkn2//ihJaxmegAD/GfrYVmR6wSAyAqNBPM+oGXcP3xl8J8mXmUTNfHaCa5 P1/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PVrPX+hyjQZKZxfTUIQIvGz4499CIZ5vo0AfYH2SKKQ=; b=hQwU/kOUqsirMwwOx0Sn1aOuvXGl76ezE8QmQTDb8oCB0Vr0LyW5D8eJU6dWXxgnnA g7BHbaQE3ftUsiW8ZPGX43qWUv8w9n+bb3QAe/atriHSlQLjbh+JTy3heps59xu2Pb/X ZKBVjdcj1qxYelLD5b/rbsLRVxPDMPQpEk1Sn7s6UrrlsthV9smSy1zFnRhaRMsMh8rc 4B9PvOhfeBbF3GG+I7p6Ov0hzlOlgVDl+QwwKe+i3cGJO4wK444uWz+vyRbtK6noNZm/ 8dCxpBj1gpp1OlXC1JjOS5bgrTYhHAFJxtCQlnpUJ2A//eFtqcOoEuNjhnT3edAg5DCu etpg== X-Gm-Message-State: AOAM5330S7Ggc34UsLjBqbWx020IVU36Pg+iDxLv9pAbsTyKx5QGAnVI qVQvI3JprqY+AyzUdcM2cRfv0eOi2kkvj27rhhs= X-Google-Smtp-Source: ABdhPJzE4wvt5kKofaLr1ve9C+SKoagXdJl+gbUAvzovtg5OqVKrl2pK4OjP0+5sSrXlG2yLxoB6CzrZUALq6DSTEvk= X-Received: by 2002:a25:99c1:: with SMTP id q1mr16601771ybo.517.1618842270781; Mon, 19 Apr 2021 07:24:30 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> In-Reply-To: From: Aaron Jensen Date: Mon, 19 Apr 2021 09:24:19 -0500 Message-ID: Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 9:02 AM Aaron Jensen wrote: > I have not tested with Emacs 27. I have, however, tested with Emacs 28 > with and without the commit I mentioned. > I forgot to mention that when I reverted the commit I got a conflict so I effectively undid another commit in the same area, so my diff looked like this: if ((op & MOVE_TO_POS) != 0 - && (IT_CHARPOS (*it) > to_charpos - || (IT_CHARPOS (*it) == to_charpos - && to_charpos == ZV - && (ZV_BYTE <= 1 || FETCH_BYTE (ZV_BYTE - 1) != '\n')))) + && IT_CHARPOS (*it) > to_charpos) { From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 10:44:16 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:44:16 +0000 Received: from localhost ([127.0.0.1]:51565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYV8J-0008NO-P2 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:44:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYV8I-0008NC-E8 for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:44:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42175) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYV8D-0000NB-0A; Mon, 19 Apr 2021 10:44:09 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4101 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYV8C-0005ek-FQ; Mon, 19 Apr 2021 10:44:08 -0400 Date: Mon, 19 Apr 2021 17:43:50 +0300 Message-Id: <83lf9es5ax.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Mon, 19 Apr 2021 09:24:19 -0500) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Aaron Jensen > Date: Mon, 19 Apr 2021 09:24:19 -0500 > Cc: Gregory Heytings , 47860@debbugs.gnu.org > > On Mon, Apr 19, 2021 at 9:02 AM Aaron Jensen wrote: > > I have not tested with Emacs 27. I have, however, tested with Emacs 28 > > with and without the commit I mentioned. > > > > I forgot to mention that when I reverted the commit I got a conflict > so I effectively undid another commit in the same area, so my diff > looked like this: > > if ((op & MOVE_TO_POS) != 0 > - && (IT_CHARPOS (*it) > to_charpos > - || (IT_CHARPOS (*it) == to_charpos > - && to_charpos == ZV > - && (ZV_BYTE <= 1 || FETCH_BYTE (ZV_BYTE - 1) != '\n')))) > + && IT_CHARPOS (*it) > to_charpos) > { This basically goes back to what we had in all versions up to and including 27. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 10:49:01 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:49:01 +0000 Received: from localhost ([127.0.0.1]:51580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVCv-0008VR-0O for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:49:01 -0400 Received: from heytings.org ([95.142.160.155]:44818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVCs-0008VD-3e for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:48:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618843737; bh=Eir5uVh32m5/flmcfqfDRHUHGmTmAoVDP5FnIkSHofs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=b/DbOYcHUkH12zSZ6INKZSvPBwWNqwuvQR0PuXimd1Y/GTJ4lm9ohMkBUvkgYQHwQ NmTf/eueMfUWyj1z+a9QyQCZbebAgtMr4zKJAXl3LfJRoppkZnBjKcsgyVt21Lds7q 55FyXZjB3PrSOWw4XhspEjlpWfOz6wrpw4I3PWP5r38XQrayHXXr0ZlvpgvAF0X4/F MEzmwMWnEEl9zP4LVKUrKBAxMapd8kFo2CEf/SUUGwM81oYsSfN7WtHJ0QeSb7LFtJ JzjsdcKqbAWcDj2aw1ThJ6DaDz5uSBt5kAfbBF3t86xP1fbgNhsDqy88HaBeOOGy9A 3LOd19o2galzg== Date: Mon, 19 Apr 2021 14:48:56 +0000 From: Gregory Heytings To: Aaron Jensen Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression In-Reply-To: Message-ID: References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > I have not tested with Emacs 27. I have, however, tested with Emacs 28 > with and without the commit I mentioned. > > With the commit reverted, I see this: > > https://cln.sh/sNpBcb > > Without it reverted, I see this: > > https://cln.sh/RtPEie > This is not what I see, nor what Eli sees. We see the second screenshot after commit 56c42bd28d, and only "a" before commit 56c42bd28d. Do you really see that with emacs -Q and your recipe? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 10:49:11 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:49:11 +0000 Received: from localhost ([127.0.0.1]:51587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVD1-0008WK-PY for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:49:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVCy-0008VG-44 for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:49:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42320) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYVCs-0003Dy-Na; Mon, 19 Apr 2021 10:48:58 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4393 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYVCr-00064j-On; Mon, 19 Apr 2021 10:48:58 -0400 Date: Mon, 19 Apr 2021 17:48:40 +0300 Message-Id: <83k0oys52v.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Mon, 19 Apr 2021 09:02:24 -0500) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Aaron Jensen > Date: Mon, 19 Apr 2021 09:02:24 -0500 > Cc: Gregory Heytings , 47860@debbugs.gnu.org > > > IOW, given that the current code does "somewhat" better than > > everything we had before, what exactly is the problem you (Aaron) see > > with the offending commit that you call it "regression"? > > I have not tested with Emacs 27. Not just 27, 27 and all the previous versions. > I have, however, tested with Emacs 28 > with and without the commit I mentioned. > > With the commit reverted, I see this: > > https://cln.sh/sNpBcb > > Without it reverted, I see this: > > https://cln.sh/RtPEie > > What I expect is for the minibuffer to be sized as the first example > and not the second. So you have a package (or two?) that work(s) only with an unreleased codebase of Emacs 28 before those two commits were installed? How do those packages work in Emacs 27 and previous versions? > This is what it looks like when using selectrum in Emacs 27: > > https://user-images.githubusercontent.com/8199224/114367956-3f4a8e00-9b7d-11eb-8307-5372fb48de63.png > > and Emacs 28: > > https://user-images.githubusercontent.com/8588/114411541-e1fd0f80-9b71-11eb-8ba3-5bf1437a7806.png That looks like an entirely different phenomenon than the one presented by the minimal reproducer. Are you sure that the reproducer actually shows the same problem? Bottom line, I'm now even more confused regarding the problem and the effect of the 2 commits you reverted. Reverting them should get you back to what we had in Emacs 27 and before, but you say it doesn't? And the effect on selectrum is very different than the effect on the reproducer you posted. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 11:14:13 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 15:14:13 +0000 Received: from localhost ([127.0.0.1]:51627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVbI-0000iH-Kh for submit@debbugs.gnu.org; Mon, 19 Apr 2021 11:14:13 -0400 Received: from mail-yb1-f171.google.com ([209.85.219.171]:39583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYVbF-0000i2-8y for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 11:14:11 -0400 Received: by mail-yb1-f171.google.com with SMTP id z1so39137858ybf.6 for <47860@debbugs.gnu.org>; Mon, 19 Apr 2021 08:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IYzmOGBgkylOED6VvuZFqbB73oy3VX9MF2rvVndXLXs=; b=qJ9Uiicnf9t9Zm2W9N4VEa8QEQqRvPuybb8ji5Wr3vEjjB75+NHp+7bOgLvI6QMqRt nytgmt7lJe2HcShsg7xF0Q5vPOREmoUN/lhR1b2Q6Vws+ebP6dHqwNAUSTDnUTQFMxHp GA/zRLMs0RYAFDDykDr31h9vLJpnYXtpiF99y+Y8uuOIIsMzLl8iVjY0A6XOPtX+Muvb kOD2kMGw9TiuM6PwRr6qhLoKHjag86UcJWClg2tIqGhPWC9nG9U53OWBi5LlZJH1+E/o Vpnndsdtsk7JxBRosIjc6aAAslumOgrUuOToeunIM67LfqcIbXc0aTteVswAFnZEhpkk alxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IYzmOGBgkylOED6VvuZFqbB73oy3VX9MF2rvVndXLXs=; b=t0H7eMIvTYt9cWr3gM5roracre5355HSh/ofouuTI6ZHunyUPxu+ogNJU9Lwk9IWh5 rqXEY99h695tH1ZK2E0H4VR4W6O5wWPH9mghvyxx5EJajSvqBkNNlpv3MVac6OvUSyus H1pyMKlyrhbuPiswGQWUQCNlCtN5N1H7KvSMgJDerXAEUpdAzrA9LkpAkpbbD0PlyKUz WVYRc+orzDtXoJ37v4lEBLT/oi68XZCAV+ILDZyg7Wk9T5bVB/bahWBvJsmH1BcqUYbX IWW9ZEshMq7gjMrB3mLZDkxijTi/YPNjnZ1YKun/m+Nx1rPzXPoNlCid+zqU8a83sTmF 1r6A== X-Gm-Message-State: AOAM531SPoKpGjW0BiPg9VUHbgUdsI5R2QnA2IhoncHx0VwDkjGKOHD5 Kzj8XQ2T9BV9Jg0dEuyzQyS1t2NM+Js2gntlkUu2Qu4zk498/A== X-Google-Smtp-Source: ABdhPJyJmcvC3L9Tvx7TGgnznl5kPORrvUHp343yTdILMUli6H8foiwZga/28zmpmXKLV4u/xccpVgwFebHxLdJRt8Q= X-Received: by 2002:a25:7157:: with SMTP id m84mr17841294ybc.175.1618845243537; Mon, 19 Apr 2021 08:14:03 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> In-Reply-To: <83k0oys52v.fsf@gnu.org> From: Aaron Jensen Date: Mon, 19 Apr 2021 10:13:51 -0500 Message-ID: Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 9:48 AM Eli Zaretskii wrote: > So you have a package (or two?) that work(s) only with an unreleased > codebase of Emacs 28 before those two commits were installed? How > do those packages work in Emacs 27 and previous versions? No, they work in Emacs 27 and 28 before 56c42bd28d was installed. As I said, selectrum must be doing something else on top of what I narrowed my repro down that triggers the appropriate resize. > > > This is what it looks like when using selectrum in Emacs 27: > > > > https://user-images.githubusercontent.com/8199224/114367956-3f4a8e00-9b7d-11eb-8307-5372fb48de63.png > > > > and Emacs 28: > > > > https://user-images.githubusercontent.com/8588/114411541-e1fd0f80-9b71-11eb-8ba3-5bf1437a7806.png > > That looks like an entirely different phenomenon than the one > presented by the minimal reproducer. Are you sure that the reproducer > actually shows the same problem? Both show a failure to resize properly in correlation with a truncated line. I now believe it's unlikely to be the exact same issue given the behavior on Emacs 27 w/ my repro. Until I've successfully narrowed down something that reproduces on Emacs 27, I can't say for certain that they're related. > Bottom line, I'm now even more confused regarding the problem and the > effect of the 2 commits you reverted. Yeah, well, I'm confused as well. I'm trying to narrow down a repro in multiple codebases I don't fully understand that points to a commit that I do not understand at all. I'm feeling my way through the dark here so I appreciate your patience. > Reverting them should get you > back to what we had in Emacs 27 and before, but you say it doesn't? That's right, it does not, however resetting to 56c42bd28d^ does. Said plainly: there's a difference in my repro between 56c42bd28d^ and master + a revert of 56c42bd28d (and the section associated commit that affected that same area of the code). > And the effect on selectrum is very different than the effect on the > reproducer you posted. In my naivete they looked the same: a failure to resize the minibuffer vertically to the appropriate size. There's more nuance to this though and I'll work on a clarifying repro. If you're willing to install selectrum, it would be helpful if you could at least verify the behavior I'm seeing so that I do not think I've gone mad. This reproduces the problem for me on master, but not on emacs-27. Specifically, on emacs-27, I see both aaaa... and bbbb... visible in the minibuffer, but on master, I only see aaa.... (require 'selectrum) (let ((prompt "test: ") (candidates '("aaa" "bbb")) (candidates '("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"))) (let* ((buf (current-buffer)) default (res (let ((hook (make-symbol "selectrum--minibuffer-setup"))) (fset hook (lambda nil (remove-hook 'minibuffer-setup-hook hook) (setq-local selectrum--last-buffer buf) ;; Track globally and in last buffer. (setq-default selectrum--last-command this-command) (setq-default selectrum--last-prefix-arg current-prefix-arg) (when (buffer-live-p selectrum--last-buffer) (with-current-buffer selectrum--last-buffer (setq-local selectrum--last-command this-command) (setq-local selectrum--last-prefix-arg current-prefix-arg))) (setq-local auto-hscroll-mode nil) (setq-local selectrum--is-initializing t) (setq-local selectrum--candidates-overlay (make-overlay (point) (point) nil 'front-advance 'rear-advance)) (setq-local selectrum--count-overlay (make-overlay (point-min) (point-min))) ;; If metadata specifies a custom sort function use it as ;; `selectrum-preprocess-candidates-function' for this session. (when-let ((sortf (selectrum--get-meta 'display-sort-function))) (setq-local selectrum-preprocess-candidates-function sortf)) (if (not (functionp candidates)) (selectrum--preprocess candidates) (setq-local selectrum--preprocessed-candidates nil) (setq-local selectrum--dynamic-candidates-function candidates)) (let ((default (or (car-safe default) default))) (setq-local selectrum--default-candidate (if (and default (symbolp default)) (symbol-name default) default))) (setq-default selectrum--default-candidate selectrum--default-candidate) ;; Make sure to trigger an "user input changed" event, so that ;; candidate refinement happens in `post-command-hook' and an index ;; is assigned. (setq-local selectrum--previous-input-string nil) (setq-local selectrum--line-height (line-pixel-height)) (add-hook 'post-command-hook #'selectrum--update nil 'local))) (unwind-protect (progn (add-hook 'minibuffer-setup-hook hook t) (read-from-minibuffer prompt)) (remove-hook 'minibuffer-setup-hook hook))))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 12:19:25 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 16:19:25 +0000 Received: from localhost ([127.0.0.1]:51849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYWcO-0002Wp-Rp for submit@debbugs.gnu.org; Mon, 19 Apr 2021 12:19:25 -0400 Received: from mail-yb1-f173.google.com ([209.85.219.173]:40761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYWcN-0002Wc-KP for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 12:19:24 -0400 Received: by mail-yb1-f173.google.com with SMTP id 82so39449583yby.7 for <47860@debbugs.gnu.org>; Mon, 19 Apr 2021 09:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=D4D43nypBEI0GGSmAvoKEd7l6f0ieVR4ugr8pJ60xN0=; b=i5QJhbEqqT0J1GK7zYVgcz46JIgMTUsdasgQ2HCaZqilWexMmZSN2zJeVcbaHojkqQ c0F6b/TNgY1AZalphZG1VMW80AC6bw8rQsSTif8tgyLWuwxrcwLKFImtb64O2S3o6gzX eeoCsWB7XoiZPPGcqONJwSL5X7Wwff1Bw4Xn01Snpf59etCsf1XkWB3jD0LOBEQoljGI QfoegDUYkvIcvAh/m8byy9wjqG9g9+YJcvi2f+UudaPPn+nZm8gVUOdeuvRhC7ltOp2T XLqvPvqtIlscGUERglV2rWu2iQ4KCKidkwGQreyqcyL/l5id0KrPdMGWzadEy48n2KAZ +i3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=D4D43nypBEI0GGSmAvoKEd7l6f0ieVR4ugr8pJ60xN0=; b=O4YYHqu9krjjqwOyVQIq9FzqtY/HP/7o5kO6RNmFBZEoECooxaZIQUvuBEsentjhgN FQgS8QPwAS1mlgtKZLG4UGUjZAcDg5b8qya0FUfN+DyxVJa262LKAEJcWKR87AEmLb8r gLhIgp/T+iK4SUw4Dp0YGQxNq3obWVSqPklETdHMawtIt7LtBmLP7bhSo+agYwIWE5zI p+7N1cgzLGk/VTKjiXBYqHtycKSdX9X5+J2vbQGEZ4AkRFvHY4JISdcAoey4D/wRsfic XgWWvkZSJcLhx6DsZlFNzTTN547iZDZYoo/1WO1ECNOG0TkFrVRXQkPjZ7VvcK6be31w xYsQ== X-Gm-Message-State: AOAM532cQJqhlX83uKOmd7ozxEmrXouhYb0KVAijJ39SREGWiM2cUVm+ sl5cmSI7oUEsgkPHkdZ0cxpQ1fNW5VbTJFFtXvc= X-Google-Smtp-Source: ABdhPJyuWqCRedxyh8buMgcOZxx5m9mD1mmaTQ4O4bwubWW4JtTddGd5ojk2+8cKYPabIQu9YYLxQoHPaM5uTKkFRLI= X-Received: by 2002:a25:1f43:: with SMTP id f64mr19101778ybf.203.1618849158077; Mon, 19 Apr 2021 09:19:18 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> In-Reply-To: From: Aaron Jensen Date: Mon, 19 Apr 2021 11:19:06 -0500 Message-ID: Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 19, 2021 at 10:13 AM Aaron Jensen wrote= : > > If you're willing to install selectrum, it would be helpful if you > could at least verify the behavior I'm seeing so that I do not think > I've gone mad. This reproduces the problem for me on master, but not > on emacs-27. Specifically, on emacs-27, I see both aaaa... and bbbb... > visible in the minibuffer, but on master, I only see aaa.... Okay, here's a selectrum-free repro that, on emacs 27 shows all 3 lines and on emacs 28 shows only two lines: (defun foo--set-window-height (window &optional height) (let ((dheight (or height (cdr (window-text-pixel-size window)))) (wheight (window-pixel-height window)) (window-resize-pixelwise t)) (window-resize window (- dheight wheight) nil nil 'pixelwise))) (setq hook (lambda nil (remove-hook 'minibuffer-setup-hook hook) (setq-local auto-hscroll-mode nil) (setq-local foo--candidates-overlay (make-overlay (point) (point) nil 'front-advance 'rear-advance)) (setq-local truncate-lines t) (setq minibuf-after-string " \naaa\nbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb= bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb= bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb= bbbbbbbbbbb\ncccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc= ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc= ccccccccccccccccccccccccccccccccccccccccccccccccccc") (move-overlay foo--candidates-overlay (point-max) (point-max)) (put-text-property 0 1 'cursor t minibuf-after-string) (overlay-put foo--candidates-overlay 'after-string minibuf-after-string) (foo--set-window-height (active-minibuffer-window)))) (unwind-protect (progn (add-hook 'minibuffer-setup-hook hook t) (read-from-minibuffer "test: ")) (remove-hook 'minibuffer-setup-hook hook)) Screenshot from 27: https://cln.sh/G5j1zB Screenshot from 28: https://cln.sh/2QOHD0 Please let me know if you can repro as I've demonstrated From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 13:15:49 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 17:15:49 +0000 Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXUv-000642-8L for submit@debbugs.gnu.org; Mon, 19 Apr 2021 13:15:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXUq-00063m-Kh for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 13:15:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45647) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYXUl-0000fo-B3; Mon, 19 Apr 2021 13:15:35 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1913 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYXUi-0005n9-9r; Mon, 19 Apr 2021 13:15:34 -0400 Date: Mon, 19 Apr 2021 20:15:15 +0300 Message-Id: <838s5eryak.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Mon, 19 Apr 2021 11:19:06 -0500) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Aaron Jensen > Date: Mon, 19 Apr 2021 11:19:06 -0500 > Cc: Gregory Heytings , 47860@debbugs.gnu.org > > Okay, here's a selectrum-free repro that, on emacs 27 shows all 3 > lines and on emacs 28 shows only two lines: > > (defun foo--set-window-height (window &optional height) > (let ((dheight (or height (cdr (window-text-pixel-size window)))) > (wheight (window-pixel-height window)) > (window-resize-pixelwise t)) > (window-resize > window (- dheight wheight) nil nil 'pixelwise))) Yes, that's the problem: selectrum doesn't rely on the automatic mini-window resize, it resizes the mini-window manually! And it relies on window-text-pixel-size to tell how high should the mini-window become. So the root cause is in window-text-pixel-size when this crazy mix of overlays is used. Will take a look when I have time. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 13:41:11 2021 Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 17:41:11 +0000 Received: from localhost ([127.0.0.1]:51952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXtX-0006sq-H4 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 13:41:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXtV-0006sc-OM for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 13:41:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46025) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYXtQ-0007IW-3v; Mon, 19 Apr 2021 13:41:04 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYXtO-00043h-5i; Mon, 19 Apr 2021 13:41:03 -0400 Date: Mon, 19 Apr 2021 20:40:40 +0300 Message-Id: <835z0irx47.fsf@gnu.org> From: Eli Zaretskii To: aaronjensen@gmail.com In-Reply-To: <838s5eryak.fsf@gnu.org> (message from Eli Zaretskii on Mon, 19 Apr 2021 20:15:15 +0300) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> <838s5eryak.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Mon, 19 Apr 2021 20:15:15 +0300 > From: Eli Zaretskii > Cc: 47860@debbugs.gnu.org, gregory@heytings.org > > So the root cause is in window-text-pixel-size when this crazy mix of > overlays is used. Will take a look when I have time. And here's a much simpler recipe: (progn (with-current-buffer (get-buffer-create "foo") (insert "test: ") (overlay-put (make-overlay (point-max) (point-max)) 'after-string " \naaa\nbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\ncccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc") (setq-local truncate-lines t)) (switch-to-buffer "foo") (window-text-pixel-size)) The result indicates that the buffer has only 4 screen lines, whereas it actually has 5. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 07:07:24 2021 Received: (at 47860) by debbugs.gnu.org; 22 Apr 2021 11:07:24 +0000 Received: from localhost ([127.0.0.1]:33075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZXB6-0007UX-7K for submit@debbugs.gnu.org; Thu, 22 Apr 2021 07:07:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZXB2-0007UH-3c for 47860@debbugs.gnu.org; Thu, 22 Apr 2021 07:07:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47424) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZXAw-0007cT-JS; Thu, 22 Apr 2021 07:07:14 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2699 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZXAu-0005yY-J7; Thu, 22 Apr 2021 07:07:14 -0400 Date: Thu, 22 Apr 2021 14:07:01 +0300 Message-Id: <83eef2poh6.fsf@gnu.org> From: Eli Zaretskii To: aaronjensen@gmail.com In-Reply-To: <835z0irx47.fsf@gnu.org> (message from Eli Zaretskii on Mon, 19 Apr 2021 20:40:40 +0300) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> <838s5eryak.fsf@gnu.org> <835z0irx47.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 19 Apr 2021 20:40:40 +0300 > From: Eli Zaretskii > Cc: 47860@debbugs.gnu.org, gregory@heytings.org > > (progn > (with-current-buffer (get-buffer-create "foo") > (insert "test: ") > (overlay-put (make-overlay (point-max) (point-max)) > 'after-string " > \naaa\nbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\ncccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc") > (setq-local truncate-lines t)) > (switch-to-buffer "foo") > (window-text-pixel-size)) > > The result indicates that the buffer has only 4 screen lines, whereas > it actually has 5. I hope I fixed this now on the master branch, please test. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 09:52:58 2021 Received: (at control) by debbugs.gnu.org; 22 Apr 2021 13:52:58 +0000 Received: from localhost ([127.0.0.1]:33227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZZlJ-00015v-Ph for submit@debbugs.gnu.org; Thu, 22 Apr 2021 09:52:58 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:35827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZZlH-00015V-Om for control@debbugs.gnu.org; Thu, 22 Apr 2021 09:52:56 -0400 Received: by mail-pj1-f53.google.com with SMTP id j14-20020a17090a694eb0290152d92c205dso1007543pjm.0 for ; Thu, 22 Apr 2021 06:52:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=ENLHtEEZhNBtPuEzS1aaznI9SiHi2cp8sj0j7NNImDQ=; b=qMUqo4OvbGPZOavfgfWKeSoMGlJ/8MQcH2jaqvonGx8939ZWf0DnSjoF+jUxS7gxP7 l6PxhttZlS2xKeBzLgKSb9JPGmQV2Faj8DsaCdYuZP355CJww73jItK4Q7T23pfqbldY DUyYrQOTtTRKlKjUF9HYXCZuWOAfKYhlcuDXJhP+wNT7dJ3YVExCN1RXarkYyII3vOwA U1ffqtnvXVR9+Yx+kJveDh1DzLghO+krlRmCm6vLE8HfObB4V9kY/NplfcfWASXbXCOP 8haAKZ/FF9gSTuQ0Kfgi+sHahBEx1Q0W9OmJZWCHJfYwijL9nGWWfSFFLzFZscFFtE7a Z51g== X-Gm-Message-State: AOAM530V01gyJozaO6E+8vUjkt91jvs+6NNNyqMgcDYGtDhNelN89Y/h KtCBO8KZOJin5LmiobuavjxHt/FOA8PvyAqMmrp8bXSR X-Google-Smtp-Source: ABdhPJzgg3b/eE1VZY1bMVqOFy6q3baGElpldONqNMnoVwzX+HCM+89Bd1GIvE2sSywzyiKC1gswxZh1D3FTKOy6rUA= X-Received: by 2002:a17:90a:670b:: with SMTP id n11mr4229333pjj.104.1619099570161; Thu, 22 Apr 2021 06:52:50 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Apr 2021 09:52:49 -0400 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 22 Apr 2021 09:52:49 -0400 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47860 fixed thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.216.53 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.216.53 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47860 fixed thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.216.53 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.216.53 listed in wl.mailspike.net] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty tags 47860 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 12:01:08 2021 Received: (at 47860) by debbugs.gnu.org; 22 Apr 2021 16:01:08 +0000 Received: from localhost ([127.0.0.1]:35352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZblL-0004qw-5e for submit@debbugs.gnu.org; Thu, 22 Apr 2021 12:01:08 -0400 Received: from mail-yb1-f181.google.com ([209.85.219.181]:38837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZblG-0004qH-P5 for 47860@debbugs.gnu.org; Thu, 22 Apr 2021 12:01:06 -0400 Received: by mail-yb1-f181.google.com with SMTP id x76so42046161ybe.5 for <47860@debbugs.gnu.org>; Thu, 22 Apr 2021 09:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OnDcpdYd2g6M078CA/+vCijeBR/bbWXiZ6+g/7zO5+I=; b=GLPziyyj0F3xSrGAFVnFGQKcgjs1nqmG+ufG9CbfprnzdnP96d2lzCCmVo4LNed35Y vIsjvRHn/EHUjQ2kuBW1ovM0Q8mhQJBp11zlisIBigf6RBKJmRZy1rjLo+bHGkOmQTji RJTvZCGsbus45RwOTrLxzT94aUzZwQxDr0CKe8WqchK9PUsEhaLqKIZZPCQOWfeckfpQ a0xBDIbMFQGv8pujg8AC7hNiGku66vWqszT7zTNy+eqh3nC33bF9cJayGTe7TO44PJLv DDe5/iW5i8SzmHsbknxI6QdS5m9Ibz9egg4p8vaGkf7TavIep3BZKGItOth1YMeGDh2K BmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OnDcpdYd2g6M078CA/+vCijeBR/bbWXiZ6+g/7zO5+I=; b=ET0MG7dWru15f7vHdYbZyqZyOoek9m/S/bDMBsUSgsCOmF/5olj1klIHCXgbGaut+F SO2BL/rcAaaLFRfW4TCt8QACJKeTnY1qM957+dnv98KfLXs4POieaYtGP1tgKmxrweU+ bfHrY8B2tOlEcxStspoxwSo9qZlseyeurS93UVWdC13e3+g4+Fh3eaNx36PjTx0r7T1E 7ENVLownjIBt5HbUi5f2+iVyz9M8wgjXLrAe0LBFc2YJyqAL2nqAlJxT4uAnnMiMzdnX MHk45CK1thzThcbZEnQPenM1E3EMsj8ltCDAM0N+uAbsKCf4SPqg0oi9gN44cz5sqFZQ mdEg== X-Gm-Message-State: AOAM531DOWrSjsJxPicu9IeBWJyKmWAn7Ze1Vo2HDe1IVQH6CPd2x6p7 WFHq4sSdPcBsedW9QQwBV0qhdXDND1NdACG59hby0HHc2lk= X-Google-Smtp-Source: ABdhPJyrJyDDOS+HUyuu1R5HLpJ/ncuyKvtvYUATCXLDmevncsBXN/G16rt46SOGEn1Lp0dUhJVo9gZWTERanEqcVHg= X-Received: by 2002:a25:99c1:: with SMTP id q1mr5464429ybo.517.1619107256879; Thu, 22 Apr 2021 09:00:56 -0700 (PDT) MIME-Version: 1.0 References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> <838s5eryak.fsf@gnu.org> <835z0irx47.fsf@gnu.org> <83eef2poh6.fsf@gnu.org> In-Reply-To: <83eef2poh6.fsf@gnu.org> From: Aaron Jensen Date: Thu, 22 Apr 2021 11:00:45 -0500 Message-ID: Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47860 Cc: 47860@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Apr 22, 2021 at 6:07 AM Eli Zaretskii wrote: > > I hope I fixed this now on the master branch, please test. It looks to work for me, thank you! From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 12:50:41 2021 Received: (at 47860-done) by debbugs.gnu.org; 22 Apr 2021 16:50:41 +0000 Received: from localhost ([127.0.0.1]:35419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZcXJ-000691-A0 for submit@debbugs.gnu.org; Thu, 22 Apr 2021 12:50:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZcXG-00068Z-F5 for 47860-done@debbugs.gnu.org; Thu, 22 Apr 2021 12:50:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52706) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZcXA-00049y-Oz; Thu, 22 Apr 2021 12:50:32 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZcXA-00005N-5H; Thu, 22 Apr 2021 12:50:32 -0400 Date: Thu, 22 Apr 2021 19:50:22 +0300 Message-Id: <834kfyp8kx.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Thu, 22 Apr 2021 11:00:45 -0500) Subject: Re: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> <838s5eryak.fsf@gnu.org> <835z0irx47.fsf@gnu.org> <83eef2poh6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47860-done Cc: 47860-done@debbugs.gnu.org, gregory@heytings.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Thu, 22 Apr 2021 11:00:45 -0500 > Cc: 47860@debbugs.gnu.org, Gregory Heytings > > On Thu, Apr 22, 2021 at 6:07 AM Eli Zaretskii wrote: > > > > I hope I fixed this now on the master branch, please test. > > It looks to work for me, thank you! OK, I'm therefore closing the bug. Thanks for testing the solution. From unknown Tue Jun 17 20:11:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 May 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator