Subject: Re: [bug#47852] [PATCH] gnu: Add sc-im

From: "jgart" <[email-masked]>
Date: Sun, 18 Apr 2021 15:39:05 +0000

Hi Xinglu,

I appreciate your review. I attached an updated patch with your suggestions. Thank you for pointing those out. 

I moved home-page closer to the top so that I can reuse it in the url field. 

I've seen a few examples in gnu/packages of this practice and I think it is quite nice.

> I suggest adding it to (gnu packages terminals) instead of creating a
> new file. You will find asciinema and fzf there.

I'm not sure if it makes sense to me for sc-im to go into terminals. 

It seems like terminals has mostly terminal emulators. 

Like I pointed out in my previous email, why wouldn't calcurse and visidata also go into the terminals module?

sc-im is a spreadsheet program for the terminal in the same way that calcurse is a calendar program for the terminal.

Maybe we can do a clean up soon and put all these programs in a new module? 

Let me know if there is anything else I should change.

all the best,

jgart

April 18, 2021 5:25 AM, "Xinglu Chen" <[email-masked]> wrote:

> Thank you for working on this! I have some comments to add.
> 
>> * gnu/packages/visidata.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> 
> I suggest adding it to (gnu packages terminals) instead of creating a
> new file. You will find asciinema and fzf there.
> 
>> +(define-public sc-im
>> + (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
>> + (package
>> + (name "sc-im")
>> + (version "0.8.1")
>> + (source (origin
>> + (method git-fetch)
>> + (uri
>> + (git-reference
>> + (url "https://github.com/andmarti1424/sc-im")
>> + (commit commit-ref)))
> 
> Why not just use ‘version’, or (string-append ... version) if needed?
> 
>> + (file-name (git-file-name name version))
> 
> Indentation is a bit off here.
> 
>> + (synopsis "Spreadsheet program with vim-like keybindings")
>> + (description
>> + "@code{sc-im} is a highly configurable spreadsheet program
>> + providing a vim-like experience. @code{sc-im} supports @{gnuplot} interaction,
>> + functions for sorting and filtering, 256 color support, and much more.")
>> + (home-page "https://github.com/andmarti1424/sc-im")
> 
> Nit: ‘home-page’ usually goes above ‘synopsis’.