GNU bug report logs - #47832
28.0.50; define-fringe-bitmap and emacs --daemon

Previous Next

Full log

Message #35 received at 47832 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 47832 <at> debbugs.gnu.org
Subject: Re: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon
Date: Sat, 17 Apr 2021 12:52:08 +0000

[Message part 1 (text/plain, inline)]

>>> And in any case, the patch for gui_init_fringe is sub-optimal: it 
>>> unnecessarily loops over the standard bitmaps that were superseded. It 
>>> is better to leave the first loop go over the standard bitmaps, 
>>> whether superseded or not, and the second loop go over non-standard 
>>> bitmaps only.
>>
>> It is not sub-optimal, rif->define_fringe_bitmap will only be called 
>> for those standard bitmaps that were superseded.  For the 
>> non-superseded ones, fringe_bitmaps[bt] is NULL.
>
> I meant the first loop, not the second one.
>

Okay, the patch was meant only to fix the bug, but indeed the small 
optimization you mention makes sense.  Updated patch attached.

[Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.