From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 02:16:31 2021 Received: (at submit) by debbugs.gnu.org; 16 Apr 2021 06:16:31 +0000 Received: from localhost ([127.0.0.1]:39917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXHmJ-00018F-1w for submit@debbugs.gnu.org; Fri, 16 Apr 2021 02:16:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:57254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXHmF-000186-JL for submit@debbugs.gnu.org; Fri, 16 Apr 2021 02:16:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXHmF-00007J-Cz for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 02:16:27 -0400 Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:45172 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.90_1) (envelope-from ) id 1lXHmC-000591-VR for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 02:16:27 -0400 Received: from [192.168.1.25] ([90.112.77.34]) by mwinf5d71 with ME id tJGL240040kQMCy03JGLrz; Fri, 16 Apr 2021 08:16:20 +0200 X-ME-Helo: [192.168.1.25] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Fri, 16 Apr 2021 08:16:20 +0200 X-ME-IP: 90.112.77.34 To: bug-gnu-emacs@gnu.org From: David Ponce Subject: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied Message-ID: Date: Fri, 16 Apr 2021 08:16:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=80.12.242.135; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, For the image :scale attribute the Elisp reference manual say that: If both ‘:scale’ and ‘:height’/‘:width’ are specified, the height/width will be adjusted by the specified scaling factor. It seems, however, that this is not true, when the :height or :width or both attributes of an image are specified, the :scale factor is not applied. For ex., evaluating the below code in the *scratch* buffer should produce images with same size, but in the 2nd case the scale factor is not applied: (progn (insert-image (find-image '((:file "/usr/share/icons/oxygen/base/22x22/places/folder.png" :type png :scale 2 )))) (insert-image (find-image '((:file "/usr/share/icons/oxygen/base/22x22/places/folder.png" :type png :scale 2 :height 22 :width 22 )))) ) So, either the manual is wrong, or (better IMO) the code should be fixed. Thanks & Regards, David Ponce In GNU Emacs 28.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.28, cairo version 1.16.0) of 2021-04-15 built on kilauea Repository revision: c2372096433e6a7ab173e5f1993f0c65b85f353e Repository branch: master Windowing system distributor 'Fedora Project', version 11.0.12011000 System Description: Fedora 33 (KDE Plasma) Configured using: 'configure --prefix=/home/dponce --with-cairo PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 50691 7522) (symbols 48 6501 1) (strings 32 18168 1362) (string-bytes 1 604792) (vectors 16 12723) (vector-slots 8 171820 12342) (floats 8 23 45) (intervals 56 197 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 14:15:04 2021 Received: (at 47819) by debbugs.gnu.org; 16 Apr 2021 18:15:04 +0000 Received: from localhost ([127.0.0.1]:41647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSzg-0004fv-5r for submit@debbugs.gnu.org; Fri, 16 Apr 2021 14:15:04 -0400 Received: from outbound.soverin.net ([116.202.65.218]:44593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSzd-0004ey-Mi for 47819@debbugs.gnu.org; Fri, 16 Apr 2021 14:15:02 -0400 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 6B70460191; Fri, 16 Apr 2021 18:14:55 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1618596894; bh=l0utD0ad0hDdBbXM/KHY6drv1+hvNaEEH4TI8n+Y3xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C4A+5KOAjn8L3DndSxxAu6tIv9qX77KEiFu6rbPq2vkiI2lz7PvMScK6KkKJ0ODXS /Q7+NQmJD5zVDcnnbJEAedUV9f0QeGUvMgKe6YJQmm+3x0oAPm4kTqMQ2dnJvmIu+0 1iLJQHtCvEiMPk6ylQDTGM0u/PEZaCRZle7PHemkjB60aohuIbEuGuJv/IDGrUGgvm /kspfjouL3OpidmVhRJ+k0La4+xV+0bbBfKwJePo4nj6pCd4U1nPMOaxI8w+Q3Ahtk boDLDjDDLGgEKaRrL6l6b9ohZ6653seEymj/eVYx068sv/kRpG+3O5EBvQKEZdNIuB p53vgH1o/Gg5g== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 19C30202BD072E; Fri, 16 Apr 2021 19:14:50 +0100 (BST) Date: Fri, 16 Apr 2021 19:14:50 +0100 From: Alan Third To: David Ponce Subject: Re: bug#47819: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied Message-ID: Mail-Followup-To: Alan Third , David Ponce , 47819@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="zk5sGOVNoADNwvlx" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47819 Cc: 47819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --zk5sGOVNoADNwvlx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Apr 16, 2021 at 08:16:20AM +0200, David Ponce wrote: > Hello, > > For the image :scale attribute the Elisp reference manual say that: > > If both ‘:scale’ and ‘:height’/‘:width’ are > specified, the height/width will be adjusted by the specified > scaling factor. > > It seems, however, that this is not true, when the :height or :width > or both attributes of an image are specified, the :scale factor is not > applied. Hmm, I'm not sure which is the more desirable behaviour, but fixing it to match the documentation appears to be trivial. See attached. -- Alan Third --zk5sGOVNoADNwvlx Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Make-scale-affect-width-and-height-bug-47819.patch" >From 6ffcd0d934e028732484ac1f9085901d1515036a Mon Sep 17 00:00:00 2001 From: Alan Third Date: Fri, 16 Apr 2021 19:12:23 +0100 Subject: [PATCH] Make :scale affect :width and :height (bug#47819) * src/image.c (compute_image_size): Multiply width and height values by scale. --- src/image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/image.c b/src/image.c index 1619886f5a..ff4ef01804 100644 --- a/src/image.c +++ b/src/image.c @@ -2040,7 +2040,7 @@ compute_image_size (size_t width, size_t height, int_value = image_get_dimension (img, QCwidth); if (int_value >= 0) { - desired_width = int_value; + desired_width = int_value * scale; /* :width overrides :max-width. */ max_width = -1; } @@ -2048,7 +2048,7 @@ compute_image_size (size_t width, size_t height, int_value = image_get_dimension (img, QCheight); if (int_value >= 0) { - desired_height = int_value; + desired_height = int_value * scale; /* :height overrides :max-height. */ max_height = -1; } -- 2.29.2 --zk5sGOVNoADNwvlx-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 14:51:16 2021 Received: (at 47819) by debbugs.gnu.org; 16 Apr 2021 18:51:16 +0000 Received: from localhost ([127.0.0.1]:41699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXTYe-0007i9-B7 for submit@debbugs.gnu.org; Fri, 16 Apr 2021 14:51:16 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:33440 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXTYY-0007ha-4s for 47819@debbugs.gnu.org; Fri, 16 Apr 2021 14:51:10 -0400 Received: from [192.168.1.25] ([90.112.77.34]) by mwinf5d69 with ME id tWqy2400D0kQMCy03Wqysf; Fri, 16 Apr 2021 20:50:59 +0200 X-ME-Helo: [192.168.1.25] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Fri, 16 Apr 2021 20:50:59 +0200 X-ME-IP: 90.112.77.34 Subject: Re: bug#47819: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied To: Alan Third , 47819@debbugs.gnu.org References: From: David Ponce Message-ID: Date: Fri, 16 Apr 2021 20:50:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47819 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 16/04/2021 20:14, Alan Third wrote: > On Fri, Apr 16, 2021 at 08:16:20AM +0200, David Ponce wrote: >> Hello, >> >> For the image :scale attribute the Elisp reference manual say that: >> >> If both ‘:scale’ and ‘:height’/‘:width’ are >> specified, the height/width will be adjusted by the specified >> scaling factor. >> >> It seems, however, that this is not true, when the :height or :width >> or both attributes of an image are specified, the :scale factor is not >> applied. > > Hmm, I'm not sure which is the more desirable behaviour, but fixing it > to match the documentation appears to be trivial. See attached. > Hi Alan, Your patch fixed the issue for me, and now the specified :scale factor is applied when the :height/:width attributes are specified. IMHO, this is the right fix to be consistent with the documentation. At least because create-image apply a default scale factor, maybe for better rendering on high resolution screens. For ex., a default scale factor of 1.2 is applied on my laptop (1920x1080). Scaling could also make sense when height/width are specified in 'em'? Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 17 04:24:16 2021 Received: (at 47819) by debbugs.gnu.org; 17 Apr 2021 08:24:16 +0000 Received: from localhost ([127.0.0.1]:42256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXgFU-0006jM-2A for submit@debbugs.gnu.org; Sat, 17 Apr 2021 04:24:16 -0400 Received: from outbound.soverin.net ([116.202.65.218]:43307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXgFQ-0006j7-4e for 47819@debbugs.gnu.org; Sat, 17 Apr 2021 04:24:14 -0400 Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id B97F460232; Sat, 17 Apr 2021 08:24:03 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1618647843; bh=LQ+qoVPlSD434HNyPG/Cc/Xfzu6WgcKxwOkn3Reku/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lZARUysw15O4S+bzjZ0QaaB8gqdZZmpJYliHMRaFSRFJoodRR7zL6ZrWWZFWrm2r1 rXa6P+av5SOp98WfAaaFKC3qZaBG7rSXJOFrv+KCfblIy4IkxCs2F6bR/5ySqMHLBS YlR/pghiTDUtFZtjrKZLyGbycsXNel3fhGw3cfM/AGB1P8GHQIJyp8WZqzbf+N3LbN y0o1PV6rEyOQPsUgqjSBpi0/w8+TrjfGIDnd/ByzUP7ShpsRkKXqpnw6wxzFE9vgx7 M6Q+jo0u5pufUpz5w5qIdOHplDbK6jWKOh2joL6oBBhGk7+gMOg8oebqG7jOHjEUKO Wl4LpcnoeD+3w== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id C5E24202BD1099; Sat, 17 Apr 2021 09:23:55 +0100 (BST) Date: Sat, 17 Apr 2021 09:23:55 +0100 From: Alan Third To: David Ponce Subject: Re: bug#47819: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied Message-ID: Mail-Followup-To: Alan Third , David Ponce , 47819@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47819 Cc: 47819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Apr 16, 2021 at 08:50:58PM +0200, David Ponce wrote: > On 16/04/2021 20:14, Alan Third wrote: > > On Fri, Apr 16, 2021 at 08:16:20AM +0200, David Ponce wrote: > > > Hello, > > > > > > For the image :scale attribute the Elisp reference manual say that: > > > > > > If both ‘:scale’ and ‘:height’/‘:width’ are > > > specified, the height/width will be adjusted by the specified > > > scaling factor. > > > > > > It seems, however, that this is not true, when the :height or :width > > > or both attributes of an image are specified, the :scale factor is not > > > applied. > > > > Hmm, I'm not sure which is the more desirable behaviour, but fixing it > > to match the documentation appears to be trivial. See attached. > > > > Hi Alan, > > Your patch fixed the issue for me, and now the specified :scale factor > is applied when the :height/:width attributes are specified. > > IMHO, this is the right fix to be consistent with the > documentation. At least because create-image apply a default scale > factor, maybe for better rendering on high resolution > screens. For ex., a default scale factor of 1.2 is applied on my > laptop (1920x1080). Scaling could also make sense when height/width > are specified in 'em'? I don't know why you would want to use scale with em dimensions, since you can just set the em dimensions directly. For example ":scale 2 :height '(1 . em)" is exactly the same as ":scale 1 :height '(2 . em)", so why bother? Plus if you specify something to be 1em in height, then create-image applies its magic scale factor, you end up with something that is not 1em in height. So yeah, I'm not convinced that this is behaviour we want. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 17 04:42:34 2021 Received: (at 47819-done) by debbugs.gnu.org; 17 Apr 2021 08:42:34 +0000 Received: from localhost ([127.0.0.1]:42267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXgXB-0007Aj-Vh for submit@debbugs.gnu.org; Sat, 17 Apr 2021 04:42:34 -0400 Received: from outbound.soverin.net ([116.202.65.218]:59343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXgX6-0007AQ-BY for 47819-done@debbugs.gnu.org; Sat, 17 Apr 2021 04:42:32 -0400 Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 28ED360232; Sat, 17 Apr 2021 08:42:22 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1618648941; bh=DnwoET4i0Q2mnStoWloyz935rO3AyMlX05Vjj2eulVo=; h=Date:From:To:Subject:References:In-Reply-To:From; b=CboUDwq1cg9gLbRILH0qdBXMckvzptcobITaFIN9skpzvkC7ysFFWQhVzhRhctPNr c3+6Iu7Q02JVA9deJ9u5DDVBSQwrrtl27zdTIT9gwHIWOI6biUzpj2CGqAPtZIr8nA McWjEPzpI97DfJ6Nb3FNjjhF0/3UJkrWarZOx9uWIOzLSxIUX6szLYCLr66N2B3MPc pATHCG7NcQFHM+BSOpe1zZnK5r/ui+7oeJlT8XbHpQe2MWOyrmz7zszJG8O6WmAjTH 4GMUSJ0rD03GF13GBLQtI+VblPagXmJx32vraNEjkAa+QNydzX4NFKkmMXiskN4Zr8 6lWhQ89VYvzeQ== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 7062F202BD137B; Sat, 17 Apr 2021 09:42:18 +0100 (BST) Date: Sat, 17 Apr 2021 09:42:18 +0100 From: Alan Third To: David Ponce , 47819-done@debbugs.gnu.org Subject: Re: bug#47819: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied Message-ID: Mail-Followup-To: Alan Third , David Ponce , 47819-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47819-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Apr 17, 2021 at 09:23:55AM +0100, Alan Third wrote: > > I don't know why you would want to use scale with em dimensions, since > you can just set the em dimensions directly. > > For example ":scale 2 :height '(1 . em)" is exactly the same as > ":scale 1 :height '(2 . em)", so why bother? > > Plus if you specify something to be 1em in height, then create-image > applies its magic scale factor, you end up with something that is not > 1em in height. > > So yeah, I'm not convinced that this is behaviour we want. OK, I'm still convinced this isn't really the behaviour we want, but I did some further investigation and realised this is a bug introduced by me recently. I thought it had worked this way for a long time. I'll just push the change up to fix it. -- Alan Third From unknown Wed Jun 18 00:23:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 May 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator