GNU bug report logs - #47813
28.0.50; Confusing new calling convention for define-minor-mode

Previous Next

Package: emacs;

Reported by: Michael Heerdegen <michael_heerdegen <at> web.de>

Date: Fri, 16 Apr 2021 01:52:01 UTC

Severity: normal

Found in version 28.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Subject: bug#47813: closed (Re: bug#47813: 28.0.50; Confusing new calling
 convention for define-minor-mode)
Date: Sun, 18 Apr 2021 03:57:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#47813: 28.0.50; Confusing new calling convention for define-minor-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 47813 <at> debbugs.gnu.org.

-- 
47813: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47813
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 47813-done <at> debbugs.gnu.org
Subject: Re: bug#47813: 28.0.50; Confusing new calling convention for
 define-minor-mode
Date: Sat, 17 Apr 2021 23:56:11 -0400
Michael Heerdegen [2021-04-18 01:21:13] wrote:
> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> Done, thanks,
> I am happy with all the changes.

Thanks, closing,


        Stefan


[Message part 3 (message/rfc822, inline)]
From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: 28.0.50; Confusing new calling convention for define-minor-mode
Date: Fri, 16 Apr 2021 03:51:04 +0200
Hello,

the new advertised calling contention for `define-minor-mode' is

| (mode doc &rest body)

Nothing wrong with that, but this part from the doc string:

| If you provide BODY, then you must provide at least one keyword
| argument.

says that the convention as printed is not valid - and indeed it
isn't -- e.g. this errors:

  (define-minor-mode test-mode "..." (if test-mode 17 23))

Is it possible to make that keyword-less case work?  Else the calling
convention should be made clearer in some way.

TIA, Michael.


In GNU Emacs 28.0.50 (build 48, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-04-15 built on drachen
Repository revision: ed6b86457ddf73cc2cb2df6a1cf8dab79a265a93
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux bullseye/sid




This bug report was last modified 4 years and 37 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.