Subject: bug#47813: closed (Re: bug#47813: 28.0.50; Confusing new calling convention for define-minor-mode)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 18 Apr 2021 03:57:01 +0000

Your bug report

#47813: 28.0.50; Confusing new calling convention for define-minor-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
47813: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47813
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#47813: 28.0.50; Confusing new calling convention for define-minor-mode
From: Stefan Monnier <[email-masked]>
To: Michael Heerdegen <[email-masked]>
Cc: Lars Ingebrigtsen <[email-masked]>, [email-masked]
Date: Sat, 17 Apr 2021 23:56:11 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Michael Heerdegen [2021-04-18 01:21:13] wrote:
> Stefan Monnier <[email-masked]> writes:
>> Done, thanks,
> I am happy with all the changes.

Thanks, closing,

        Stefan

Subject: 28.0.50; Confusing new calling convention for define-minor-mode
From: Michael Heerdegen <[email-masked]>
To: [email-masked]
Cc: Stefan Monnier <[email-masked]>
Date: Fri, 16 Apr 2021 03:51:04 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

the new advertised calling contention for `define-minor-mode' is

| (mode doc &rest body)

Nothing wrong with that, but this part from the doc string:

| If you provide BODY, then you must provide at least one keyword
| argument.

says that the convention as printed is not valid - and indeed it
isn't -- e.g. this errors:

  (define-minor-mode test-mode "..." (if test-mode 17 23))

Is it possible to make that keyword-less case work?  Else the calling
convention should be made clearer in some way.

TIA, Michael.

In GNU Emacs 28.0.50 (build 48, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-04-15 built on drachen
Repository revision: ed6b86457ddf73cc2cb2df6a1cf8dab79a265a93
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux bullseye/sid