From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 19:52:41 2021 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 23:52:41 +0000 Received: from localhost ([127.0.0.1]:39572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXBmr-0006BK-Bw for submit@debbugs.gnu.org; Thu, 15 Apr 2021 19:52:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXBmo-0006BB-67 for submit@debbugs.gnu.org; Thu, 15 Apr 2021 19:52:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXBmn-0001nC-UB for bug-guix@gnu.org; Thu, 15 Apr 2021 19:52:37 -0400 Received: from world.peace.net ([64.112.178.59]:52026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXBml-0000DQ-Of for bug-guix@gnu.org; Thu, 15 Apr 2021 19:52:37 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXBmj-0005vu-DD; Thu, 15 Apr 2021 19:52:33 -0400 From: Mark H Weaver To: bug-guix@gnu.org Subject: Incorrect code in the Guix manual, but only on the website Date: Thu, 15 Apr 2021 19:50:49 -0400 Message-ID: <87r1jbgl8r.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In the Guix manual, as it appears on our website, https://guix.gnu.org/manual/devel/en/html_node/X-Window.html the manual entry for 'slim-service-type' suggests the following code to remove the 'gdm' service from %desktop-services. --8<---------------cut here---------------start------------->8--- (modify-services %desktop-services (delete gdm-service-type)) --8<---------------cut here---------------end--------------->8--- This code is incorrect. 'modify-services' does not support deleting services. The puzzling thing is that I can't find where this suggested code exists in our git repository. The manual in our git repository is correct. Instead of the code above, it suggests: --8<---------------cut here---------------start------------->8--- (remove (lambda (service) (eq? (service-kind service) gdm-service-type)) %desktop-services) --8<---------------cut here---------------end--------------->8--- This is the case on our 'master', 'core-updates', and 'version-1.2.0' branches. See: https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?id=ebd021f73292bf47b26a799665d6204574bae239#n17891 https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?h=core-updates&id=76fc36d0a7215979bb74c05840f5a4de4ab5ea93#n17756 https://git.sv.gnu.org/cgit/guix.git/tree/doc/guix.texi?h=version-1.2.0&id=8603bcd5822a1a8364a7a74a698059d3d147568b#n17076 The correct text was added about 2 years ago, in the following commit: https://git.sv.gnu.org/cgit/guix.git/commit/?id=dbef9015db107dd148133420b89af552ef08f8ee I see no evidence of it being changed since then. Any idea where the incorrect code on the website manual is coming from? Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 20:14:06 2021 Received: (at 47812) by debbugs.gnu.org; 16 Apr 2021 00:14:06 +0000 Received: from localhost ([127.0.0.1]:39589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXC7a-0006ih-D4 for submit@debbugs.gnu.org; Thu, 15 Apr 2021 20:14:06 -0400 Received: from world.peace.net ([64.112.178.59]:41530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXC7Y-0006i7-QF for 47812@debbugs.gnu.org; Thu, 15 Apr 2021 20:14:05 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXC7S-0007Su-Mi; Thu, 15 Apr 2021 20:13:58 -0400 From: Mark H Weaver To: 47812@debbugs.gnu.org Subject: Re: bug#47812: Incorrect code in the Guix manual, but only on the website In-Reply-To: <87r1jbgl8r.fsf@netris.org> References: <87r1jbgl8r.fsf@netris.org> Date: Thu, 15 Apr 2021 20:12:13 -0400 Message-ID: <87o8efgk93.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47812 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mark H Weaver writes: > The correct text was added about 2 years ago, in the following commit: > > https://git.sv.gnu.org/cgit/guix.git/commit/?id=dbef9015db107dd148133420b89af552ef08f8ee > > I see no evidence of it being changed since then. > > Any idea where the incorrect code on the website manual is coming from? I see now that this new functionality was added to the 'staging' branch 3 days ago: https://git.sv.gnu.org/cgit/guix.git/commit/?h=staging&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 It seems inappropriate for our online website manual to be taken from 'staging'. It has already led to an experienced Guix developer repeatedly suggesting (to a new user) a code snippet that cannot possibly work on the 'master' branch: https://bugs.gnu.org/47748#14 https://bugs.gnu.org/47748#41 Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 21:13:19 2021 Received: (at 47812) by debbugs.gnu.org; 16 Apr 2021 01:13:19 +0000 Received: from localhost ([127.0.0.1]:39614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXD2s-000865-PT for submit@debbugs.gnu.org; Thu, 15 Apr 2021 21:13:18 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXD2o-00085l-4t for 47812@debbugs.gnu.org; Thu, 15 Apr 2021 21:13:17 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 035365C010B; Thu, 15 Apr 2021 21:13:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 15 Apr 2021 21:13:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=S1AU/1opB+pbARKJDdgfa//u AgV4gxLgktFBSF59WLY=; b=tdTY01n+VJ1K1D//0jXcwELz5j/qZADJXwwUCj6E WdWFJUd3GAKPUI0AZwLOem7Hy1fr8l2b6m9oocA9mHwSgoB9oX6yflnMPS7p81gI Gdw26o4IoKTS+0XhrQ/+3+Cr03bv7FDMtjsy9ZCLPnHyqUhyTcVnrZ6teJcjJE7I js0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=S1AU/1 opB+pbARKJDdgfa//uAgV4gxLgktFBSF59WLY=; b=aPFD1bTus/hQs2qucHsG+1 Ff3mKuBDnzbaUL9PNexmh9vfostM6vo+Twa6PtA6tVkcwYOwnMjW3NkTILHv4zs8 yYmS79HXRXFdM9xF3+n1CshFFFE0MRPAakYBXUiGfVsGW801rX93ZSxVqDfzQU1J o9eFQHG2O2alUe7OhEfqzTuaxFLeSi70fCT9ej84xDWW1ruyvEk9k4IxlzfeDYTK KTEl7o3B2lqcIbC6PsxpVh2Li10/VZaL+3QSZ2O6H2GqDGDKPgfv3GcbRJy9iQ/Y 6z4S3f2EmZEQq4mBro22omIWWKTe+XsH3zPpAxtb9Sa0eVGkjB2mv3DKvCUI/+rQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 4296E108005F; Thu, 15 Apr 2021 21:13:07 -0400 (EDT) Date: Thu, 15 Apr 2021 21:13:03 -0400 From: Leo Famulari To: Mark H Weaver Subject: Re: bug#47812: Incorrect code in the Guix manual, but only on the website Message-ID: References: <87r1jbgl8r.fsf@netris.org> <87o8efgk93.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8efgk93.fsf@netris.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47812 Cc: 47812@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Apr 15, 2021 at 08:12:13PM -0400, Mark H Weaver wrote: > Mark H Weaver writes: > > > The correct text was added about 2 years ago, in the following commit: > > > > https://git.sv.gnu.org/cgit/guix.git/commit/?id=dbef9015db107dd148133420b89af552ef08f8ee > > > > I see no evidence of it being changed since then. > > > > Any idea where the incorrect code on the website manual is coming from? > > I see now that this new functionality was added to the 'staging' branch > 3 days ago: > > https://git.sv.gnu.org/cgit/guix.git/commit/?h=staging&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 > > It seems inappropriate for our online website manual to be taken from > 'staging'. It has already led to an experienced Guix developer > repeatedly suggesting (to a new user) a code snippet that cannot > possibly work on the 'master' branch: Hm, that's not supposed to happen. It's supposed to be based on the 'master' branch. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 21:32:24 2021 Received: (at 47812) by debbugs.gnu.org; 16 Apr 2021 01:32:24 +0000 Received: from localhost ([127.0.0.1]:39670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXDLM-00009w-0M for submit@debbugs.gnu.org; Thu, 15 Apr 2021 21:32:24 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXDLK-00009j-7U for 47812@debbugs.gnu.org; Thu, 15 Apr 2021 21:32:22 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D7E8E5C00B1; Thu, 15 Apr 2021 21:32:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 15 Apr 2021 21:32:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=yKujQBZwGXoz8sYT/NlbBvBB JYByhFGxHNPgKeutaTI=; b=0JeEtvASC1vm7i+XhrlQtI7UxYsdFcG5PTO2Y8Lr vh7ilI/bTduOeaIsTmaeVaUuEqyPS4El0nVy9vi5iZ6/JODNdM2MQUnGj0bp2aRn g1+pZdpD9tUwyPO290JlistEB4dNXzVTYRjM41PlEQqI3E3q20CJzRTrD/B/uAMP t4k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yKujQB ZwGXoz8sYT/NlbBvBBJYByhFGxHNPgKeutaTI=; b=Qn/kSxI6/aWNoZ12ALLELB kK8m8M8RzW5EEDogDvxuOZvIVtU/3AF4oj3pcHN2tA/1f2Y4sPFuy8tzvPrbcjG4 T1px5h1Ni5toBBnVXR+dLziIfXgPRxvhVMTtksc9cHZ0xuxeQ79/UJIkhwwMFlEa cpBtUijL2nRDhalS00UNUd5eu/9tmxXT0djB2mM7aQTu3mNQMhMSP0Trkjm4Vk9S 7cfWneMgBQch4pZpqTHYNVbPvmZ5i3JwMxB230KZegocTerze18INaoPIw3Wi1mV pnLI4P9TEy2U+gGY2A4PDB0YVyRK8Uc8LFO4YCYMRqyG13f1bM5BDKrliW0VO8YA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelgedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 75AEE24006A; Thu, 15 Apr 2021 21:32:16 -0400 (EDT) Date: Thu, 15 Apr 2021 21:32:14 -0400 From: Leo Famulari To: Mark H Weaver Subject: Re: bug#47812: Incorrect code in the Guix manual, but only on the website Message-ID: References: <87r1jbgl8r.fsf@netris.org> <87o8efgk93.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8efgk93.fsf@netris.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47812 Cc: 47812@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Apr 15, 2021 at 08:12:13PM -0400, Mark H Weaver wrote: > I see now that this new functionality was added to the 'staging' branch > 3 days ago: > > https://git.sv.gnu.org/cgit/guix.git/commit/?h=staging&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 If I understand correctly, this commit is also on the master branch: https://git.savannah.gnu.org/cgit/guix.git/commit/?h=master&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 And I do see it in my local copy of the repo. Can you double-check on your end? Or have I misunderstood? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 23:40:50 2021 Received: (at 47812) by debbugs.gnu.org; 16 Apr 2021 03:40:50 +0000 Received: from localhost ([127.0.0.1]:39790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXFLe-0003BN-Gm for submit@debbugs.gnu.org; Thu, 15 Apr 2021 23:40:50 -0400 Received: from world.peace.net ([64.112.178.59]:42042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXFLc-0003B4-34; Thu, 15 Apr 2021 23:40:49 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXFLV-0004wJ-NO; Thu, 15 Apr 2021 23:40:41 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: bug#47812: Incorrect code in the Guix manual, but only on the website In-Reply-To: References: <87r1jbgl8r.fsf@netris.org> <87o8efgk93.fsf@netris.org> Date: Thu, 15 Apr 2021 23:38:57 -0400 Message-ID: <87k0p2hp8z.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47812 Cc: 47812@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47812 + notabug close 47812 thanks Hi Leo, Leo Famulari writes: > On Thu, Apr 15, 2021 at 08:12:13PM -0400, Mark H Weaver wrote: >> I see now that this new functionality was added to the 'staging' branch >> 3 days ago: >> >> https://git.sv.gnu.org/cgit/guix.git/commit/?h=staging&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 > > If I understand correctly, this commit is also on the master branch: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=master&id=a247f5c7537df7e0c09051ba22d5c95eb08f48b9 > > And I do see it in my local copy of the repo. > > Can you double-check on your end? Or have I misunderstood? No, you're right. When I first checked, I hadn't updated my local git repo recently enough to have the commit. However, I'm not sure how I managed to include (in my original report) a Savannah URL pointing to the relevant code without noticing that it had the newly updated code. I'm closing this bug now. Sorry for the noise. Thanks, Mark From unknown Thu Aug 14 12:22:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 May 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator