From unknown Fri Aug 15 01:57:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#47810 <47810@debbugs.gnu.org> To: bug#47810 <47810@debbugs.gnu.org> Subject: Status: 28.0.50; pulse no longer accepts a face argument Reply-To: bug#47810 <47810@debbugs.gnu.org> Date: Fri, 15 Aug 2025 08:57:05 +0000 retitle 47810 28.0.50; pulse no longer accepts a face argument reassign 47810 emacs submitter 47810 Protesilaos Stavrou severity 47810 normal tag 47810 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 15:35:54 2021 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 19:35:54 +0000 Received: from localhost ([127.0.0.1]:39273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX7mM-00023H-IV for submit@debbugs.gnu.org; Thu, 15 Apr 2021 15:35:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX7mJ-000233-Jv for submit@debbugs.gnu.org; Thu, 15 Apr 2021 15:35:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7mH-00085h-NW for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:35:51 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:31727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7mC-00089v-DY for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:35:49 -0400 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6C5C7240004 for ; Thu, 15 Apr 2021 19:35:37 +0000 (UTC) From: Protesilaos Stavrou To: bug-gnu-emacs@gnu.org Subject: 28.0.50; pulse no longer accepts a face argument Date: Thu, 15 Apr 2021 22:35:35 +0300 Message-ID: <87pmyvxrw8.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=217.70.183.193; envelope-from=info@protesilaos.com; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dear maintainers, I would expect the following two expressions to produce pulse effects that differ in colour (tried with emacs -Q): (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) Instead they use the background of pulse-highlight-start-face. This test confirms as much: (set-face-background 'pulse-highlight-start-face "red") (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) (set-face-background 'pulse-highlight-start-face "blue") (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) The following diff addresses the problem with the FACE argument, but introduces a noticeable delay to the pulse effect: lisp/cedet/pulse.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 1e4506713a..e4733ca007 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -147,7 +147,7 @@ (defun pulse-momentary-highlight-overlay (o &optional face) (add-hook 'pre-command-hook #'pulse-momentary-unhighlight)) ;; Pulse it. - (overlay-put o 'face 'pulse-highlight-face) + (overlay-put o 'face (or face 'pulse-highlight-start-face)) ;; The pulse function puts FACE onto 'pulse-highlight-face. ;; Thus above we put our face on the overlay, but pulse ;; with a reference face needed for the color. I am not sure what may be causing that delay. Thank you for your attention! -- Protesilaos Stavrou protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 04:32:59 2021 Received: (at 47810) by debbugs.gnu.org; 16 Apr 2021 08:32:59 +0000 Received: from localhost ([127.0.0.1]:40005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXJuM-0006Wy-Qh for submit@debbugs.gnu.org; Fri, 16 Apr 2021 04:32:59 -0400 Received: from heytings.org ([95.142.160.155]:40226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXJuI-0006Wn-N1 for 47810@debbugs.gnu.org; Fri, 16 Apr 2021 04:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618561973; bh=wqs0rMNYm+LvVmLoJx8WvwZU1exubVmFWGG01dZmu00=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ZEphT474jvw4PytaOkGcxAiCSHi6dLAip2KDSRpWDDSgNq70WQe0w1AWqeKs7Fpb3 TkFBEJ6gR/+SgG0q4P1cf2DhBp+CRKNK6mQkw7ZYPhzZ3S1hVv5gU+sHShDhdAKLaD pvDLz1u6gQNHwwiCqVhxEi/zzQ66xMENn6JGmLVpEEVfXMHAoum2gBRXwSX/oALW6+ q1dSQIvro5h3VJhEN2vVv98i64J5V/TB7+5HyNJq67Q1GiYoVlGYjqgwJVJjz3N1a4 eIkezy7B9ZXL0C8YUUuRLW6S3DTZcxG8ZwZvx+eMfWi09T4Rq9KSW1qcCNRrP/4ln+ q8g1FB/a+u9sw== Date: Fri, 16 Apr 2021 08:32:52 +0000 From: Gregory Heytings To: Protesilaos Stavrou Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument In-Reply-To: <87pmyvxrw8.fsf@protesilaos.com> Message-ID: <7dee3f42357b0b950c58@heytings.org> References: <87pmyvxrw8.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="zIqsQEBs4i" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47810 Cc: 47810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --zIqsQEBs4i Content-Type: text/plain; format=flowed; charset=us-ascii > > I would expect the following two expressions to produce pulse effects > that differ in colour (tried with emacs -Q): > > (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) > (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) > > Instead they use the background of pulse-highlight-start-face. > Indeed; patch attached. --zIqsQEBs4i Content-Type: text/x-diff; name=Use-correct-face-when-pulsing-Bug-47810.patch Content-Transfer-Encoding: base64 Content-ID: <7dee3f42350091471314@heytings.org> Content-Description: Content-Disposition: attachment; filename=Use-correct-face-when-pulsing-Bug-47810.patch RnJvbSBiODViYjE3MGIyZDRkMDUyNjk2ZTI5YzRmYTQyOTQzN2IyYjk1YzBj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBGcmksIDE2IEFw ciAyMDIxIDA4OjIzOjA0ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIFVzZSBj b3JyZWN0IGZhY2Ugd2hlbiBwdWxzaW5nIChCdWcjNDc4MTApDQoNCiogbGlz cC9jZWRldC9wdWxzZS5lbCAocHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1v dmVybGF5KTogVXNlDQpwdWxzZS1oaWdobGlnaHQtZmFjZSwgbm90IHB1bHNl LWhpZ2hsaWdodC1zdGFydC1mYWNlLg0KLS0tDQogbGlzcC9jZWRldC9wdWxz ZS5lbCB8IDMgKy0tDQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAyIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9jZWRldC9w dWxzZS5lbCBiL2xpc3AvY2VkZXQvcHVsc2UuZWwNCmluZGV4IDFlNDUwNjcx M2EuLjYyYjIwNzJlMTggMTAwNjQ0DQotLS0gYS9saXNwL2NlZGV0L3B1bHNl LmVsDQorKysgYi9saXNwL2NlZGV0L3B1bHNlLmVsDQpAQCAtMTUzLDggKzE1 Myw3IEBAIHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb3ZlcmxheQ0KICAg ICAgIDs7IHdpdGggYSByZWZlcmVuY2UgZmFjZSBuZWVkZWQgZm9yIHRoZSBj b2xvci4NCiAgICAgICAocHVsc2UtcmVzZXQtZmFjZSBmYWNlKQ0KICAgICAg IChsZXQqICgoc3RhcnQgKGNvbG9yLW5hbWUtdG8tcmdiDQotICAgICAgICAg ICAgICAgICAgICAgKGZhY2UtYmFja2dyb3VuZCAncHVsc2UtaGlnaGxpZ2h0 LXN0YXJ0LWZhY2UNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG5pbCAnZGVmYXVsdCkpKQ0KKyAgICAgICAgICAgICAgICAgICAg IChmYWNlLWJhY2tncm91bmQgJ3B1bHNlLWhpZ2hsaWdodC1mYWNlIG5pbCAn ZGVmYXVsdCkpKQ0KICAgICAgICAgICAgICAoc3RvcCAoY29sb3ItbmFtZS10 by1yZ2IgKGZhY2UtYmFja2dyb3VuZCAnZGVmYXVsdCkpKQ0KICAgICAgICAg ICAgICAoY29sb3JzIChtYXBjYXIgKGFwcGx5LXBhcnRpYWxseSAnYXBwbHkg J2NvbG9yLXJnYi10by1oZXgpDQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoY29sb3ItZ3JhZGllbnQgc3RhcnQgc3RvcCBwdWxzZS1pdGVyYXRp b25zKSkpKQ0KLS0gDQoyLjMwLjINCg0K --zIqsQEBs4i-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 07:09:33 2021 Received: (at 47810) by debbugs.gnu.org; 16 Apr 2021 11:09:34 +0000 Received: from localhost ([127.0.0.1]:40159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXMLs-00020T-LB for submit@debbugs.gnu.org; Fri, 16 Apr 2021 07:09:33 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXMLr-00020E-0u for 47810@debbugs.gnu.org; Fri, 16 Apr 2021 07:09:31 -0400 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D558CC0009; Fri, 16 Apr 2021 11:09:23 +0000 (UTC) From: Protesilaos Stavrou To: Gregory Heytings Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument References: <87pmyvxrw8.fsf@protesilaos.com> <7dee3f42357b0b950c58@heytings.org> Date: Fri, 16 Apr 2021 14:09:21 +0300 In-Reply-To: <7dee3f42357b0b950c58@heytings.org> (Gregory Heytings's message of "Fri, 16 Apr 2021 08:32:52 +0000") Message-ID: <87blae4hb2.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47810 Cc: 47810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-04-16, 08:32 +0000, Gregory Heytings wrote: >> >> I would expect the following two expressions to produce pulse effects >> that differ in colour (tried with emacs -Q): >> >> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) >> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) >> >> Instead they use the background of pulse-highlight-start-face. >> > > Indeed; patch attached. Thank you! I can confirm that this works. -- Protesilaos Stavrou protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 12:59:31 2021 Received: (at control) by debbugs.gnu.org; 18 Apr 2021 16:59:31 +0000 Received: from localhost ([127.0.0.1]:47628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYAlf-0001l7-6e for submit@debbugs.gnu.org; Sun, 18 Apr 2021 12:59:31 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:44747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYAlU-0001kO-3k for control@debbugs.gnu.org; Sun, 18 Apr 2021 12:59:20 -0400 Received: by mail-pj1-f54.google.com with SMTP id m6-20020a17090a8586b02901507e1acf0fso1686925pjn.3 for ; Sun, 18 Apr 2021 09:59:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=0Fl4IVcAQcklLdUTqzycqWbhd/RRodRyZMXM31xBAng=; b=cbYXz4mtQJmsRYuvHp+mF92u4+xS2aFSLfN3+qRRwK45D2Jk+cdHFX755u6zuu3dlM L/OLRMdxGqcPsuk0OA68mDSQhpbPmuda3TO5efSCbSlHLrKSXmJAjb8gyqVa2tBf2Tp1 zbvOBSjSdJwK6WC+Apc5i4eIq+ZjpZjIZy2SGNQGt7NNuuX7l6YoOE+gsArSzBjSH0Kv RcalEK8nE05H/u2D2Hwdtz+mw3mb+IU/kC8cExext8Dn+OBJFz8YprImDG5Blgpvt1FI OYl7oQlE9oGpZ8uKIioX/ITK9mStXwFfGjT5uNxCZOIcUyXVpS3GytfwqrwH2e1vZeLH cTzw== X-Gm-Message-State: AOAM531J9WPH0AAhjOfy43TRy02hdyQgM/9eDJHAjf4tiAQj+v9d34Ds MB9WuM3I49kLf2AlXvRAdsGml4zfUuVkMoXYiwoZXJ48 X-Google-Smtp-Source: ABdhPJxZayAyIwbiWrUOvYhpb5ruj6DCe385KpdaVaUWsEdCYVJEshSX3JsQ/1OG0L4JlS4f9hxz4l50iw3KQNSs9xk= X-Received: by 2002:a17:902:e9c4:b029:eb:4626:feba with SMTP id 4-20020a170902e9c4b02900eb4626febamr19694781plk.39.1618765154452; Sun, 18 Apr 2021 09:59:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 18 Apr 2021 11:59:14 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 18 Apr 2021 11:59:14 -0500 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47810 + patch thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.216.54 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.216.54 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47810 + patch thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.216.54 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.216.54 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines tags 47810 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 20:02:44 2021 Received: (at 47810) by debbugs.gnu.org; 21 Apr 2021 00:02:44 +0000 Received: from localhost ([127.0.0.1]:56397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0KK-0000sC-4E for submit@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:44 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:46616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0KI-0000rx-Me for 47810@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:43 -0400 Received: by mail-pg1-f174.google.com with SMTP id 31so12504442pgn.13 for <47810@debbugs.gnu.org>; Tue, 20 Apr 2021 17:02:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=x+Ce3gIa50XfCObCH2ctLYPnMJJ9ZydmdB9hGZu+/Jw=; b=AhxiC5DOAt23y88KXJOaT2MJZGWA4VaCHfv9C+vYrhOkQEurxOPw+PK9WTk1VgUPj8 xBdna47vhRzcBJAIJ/W1DQfoGwBTA14C9aeB8ESg5dclDRLrLQRIwd1d9CheRAUhEJpT ZzMzE5KVC0hgj5m7Yq6DOJQHKnFdL5U1ZMbITFvjXIE+UyPh32AwBlLVBtcfH4sEOO8l Wu/r64+lOL1NzQurbjieax0UCfQHyyx/Z3dH9aFmlL17evloN/XNgEsLb1akbhqbixwC Q85MJkaKEsHq3u5LykqqyoVCGWURrtvnImk53f3cMLi3adn6vOvZB3Whg3t+Tfmm5/AA hHgQ== X-Gm-Message-State: AOAM533HYNWpt12EBkDzC5MhyqY+xEUuS8PdKQ0oV08Lxyh9No2uAw1j vO/BZ8ShbvPX7m2SFnbSzXNgqYwcukXvsc7I6lDMg0U9 X-Google-Smtp-Source: ABdhPJzOS0v7cQe/wLcQz98JcyyNgC020Q5feXFI12uH1efMlBZLzQ4lfYSOmmXMvymRNUgNkDG7ADkGHdy2/1Dc11I= X-Received: by 2002:a17:90a:670b:: with SMTP id n11mr1040017pjj.104.1618963357024; Tue, 20 Apr 2021 17:02:37 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 19:02:36 -0500 From: Stefan Kangas In-Reply-To: <87blae4hb2.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 16 Apr 2021 14:09:21 +0300") References: <87pmyvxrw8.fsf@protesilaos.com> <7dee3f42357b0b950c58@heytings.org> <87blae4hb2.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 20 Apr 2021 19:02:36 -0500 Message-ID: Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument To: Protesilaos Stavrou Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47810 Cc: 47810@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Protesilaos Stavrou writes: > On 2021-04-16, 08:32 +0000, Gregory Heytings wrote: > >>> >>> I would expect the following two expressions to produce pulse effects >>> that differ in colour (tried with emacs -Q): >>> >>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) >>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) >>> >>> Instead they use the background of pulse-highlight-start-face. >>> >> >> Indeed; patch attached. > > Thank you! I can confirm that this works. I guess we are still waiting for Gregory's copyright papers to come through before this can be applied? From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 00:33:49 2021 Received: (at 47810) by debbugs.gnu.org; 4 May 2021 04:33:49 +0000 Received: from localhost ([127.0.0.1]:50634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldmkn-0003sn-1G for submit@debbugs.gnu.org; Tue, 04 May 2021 00:33:49 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldmkk-0003sh-Pz for 47810@debbugs.gnu.org; Tue, 04 May 2021 00:33:47 -0400 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 216E220003; Tue, 4 May 2021 04:33:38 +0000 (UTC) From: Protesilaos Stavrou To: Gregory Heytings Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument References: <87pmyvxrw8.fsf@protesilaos.com> <7dee3f42357b0b950c58@heytings.org> <87blae4hb2.fsf@protesilaos.com> Date: Tue, 04 May 2021 07:33:37 +0300 In-Reply-To: (Stefan Kangas's message of "Tue, 20 Apr 2021 19:02:36 -0500") Message-ID: <87v97z15jy.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47810 Cc: 47810@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-04-20, 19:02 -0500, Stefan Kangas wrote: > Protesilaos Stavrou writes: > >> On 2021-04-16, 08:32 +0000, Gregory Heytings wrote: >> >>>> >>>> I would expect the following two expressions to produce pulse effects >>>> that differ in colour (tried with emacs -Q): >>>> >>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) >>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) >>>> >>>> Instead they use the background of pulse-highlight-start-face. >>>> >>> >>> Indeed; patch attached. >> >> Thank you! I can confirm that this works. > > I guess we are still waiting for Gregory's copyright papers to come > through before this can be applied? Hello Gregory! Has your copyright assignment process been finalised? Maybe Stefan can help install your patches. There is this bug report as well as #47960. All the best, Protesilaos or "Prot" -- Protesilaos Stavrou https://protesilaos.com From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 00:22:59 2021 Received: (at 47810) by debbugs.gnu.org; 25 May 2021 04:22:59 +0000 Received: from localhost ([127.0.0.1]:44369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llOap-0000Rc-3b for submit@debbugs.gnu.org; Tue, 25 May 2021 00:22:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llOan-0000RO-HW for 47810@debbugs.gnu.org; Tue, 25 May 2021 00:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IGOv/WTYOBcam1jdDjqrEsmkwrQUPxkUIoBaax//QKk=; b=rzJ8ZSPDPljK5lT4AIrEuaCgCc KwmOKB6TEayvHOAqshCpqWuXdeHksrpBpS7N7dq9PYuJTtsMDUHIxNuXNrk6AHCsANpyeR8i3NA8m BXzqO9JWZgRaw657NpDVLE7lW5T+mOMnmHuYmiKf5glYCTp+kPw5ORPoTvMZhM27quvM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llOaf-0003Ib-K8; Tue, 25 May 2021 06:22:51 +0200 From: Lars Ingebrigtsen To: Gregory Heytings Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument References: <87pmyvxrw8.fsf@protesilaos.com> <7dee3f42357b0b950c58@heytings.org> X-Now-Playing: Bogdan Raczynski's _Muzyka Dla =?utf-8?Q?Imigrant=C3=B3w=5F?= =?utf-8?Q?=3A?= "Zagubiona Dusza W =?utf-8?Q?T=C5=82umie=22?= Date: Tue, 25 May 2021 06:22:49 +0200 In-Reply-To: <7dee3f42357b0b950c58@heytings.org> (Gregory Heytings's message of "Fri, 16 Apr 2021 08:32:52 +0000") Message-ID: <87cztf7886.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gregory Heytings writes: >> Instead they use the background of pulse-highlight-start-face. >> > > Indeed; patch attached. Thanks; applied to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47810 Cc: 47810@debbugs.gnu.org, Protesilaos Stavrou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gregory Heytings writes: >> Instead they use the background of pulse-highlight-start-face. >> > > Indeed; patch attached. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 00:23:08 2021 Received: (at control) by debbugs.gnu.org; 25 May 2021 04:23:08 +0000 Received: from localhost ([127.0.0.1]:44373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llOay-0000Sl-AR for submit@debbugs.gnu.org; Tue, 25 May 2021 00:23:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llOau-0000Rj-Iz for control@debbugs.gnu.org; Tue, 25 May 2021 00:23:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UlVUK6VLoRek6gotJ+j/fxswnNXoY5DxJLQjxhpFCL4=; b=tPgZNrAZv2zeb4pAMmY7zeKRnd gPGIn6GOzbhR62Qx/1aRRdWkOhOOVTOwTM/SduboEu+nZkxW8E6CkzOqr1SS+b+6v6Bjg3uxSng5r bmjlPApOwc4weEISQYFs/yu1BC9DxpZjqArc5yXIz2PhxCYnY5SE3dskHW8bGcLb5ipg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llOan-0003Iq-4S for control@debbugs.gnu.org; Tue, 25 May 2021 06:22:59 +0200 Date: Tue, 25 May 2021 06:22:56 +0200 Message-Id: <87bl8z787z.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47810 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47810 fixed close 47810 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47810 fixed close 47810 28.1 quit From unknown Fri Aug 15 01:57:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator