Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument

From: Gregory Heytings <[email-masked]>
Date: Fri, 16 Apr 2021 08:32:52 +0000

>
> I would expect the following two expressions to produce pulse effects 
> that differ in colour (tried with emacs -Q):
>
>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>
> Instead they use the background of pulse-highlight-start-face.
>

Indeed; patch attached.

From b85bb170b2d4d052696e29c4fa429437b2b95c0c Mon Sep 17 00:00:00 2001
From: Gregory Heytings <[email-masked]>
Date: Fri, 16 Apr 2021 08:23:04 +0000
Subject: [PATCH] Use correct face when pulsing (Bug#47810)

* lisp/cedet/pulse.el (pulse-momentary-highlight-overlay): Use
pulse-highlight-face, not pulse-highlight-start-face.
---
 lisp/cedet/pulse.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 1e4506713a..62b2072e18 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -153,8 +153,7 @@ pulse-momentary-highlight-overlay
       ;; with a reference face needed for the color.
       (pulse-reset-face face)
       (let* ((start (color-name-to-rgb
-                     (face-background 'pulse-highlight-start-face
-                                      nil 'default)))
+                     (face-background 'pulse-highlight-face nil 'default)))
              (stop (color-name-to-rgb (face-background 'default)))
              (colors (mapcar (apply-partially 'apply 'color-rgb-to-hex)
                              (color-gradient start stop pulse-iterations))))
-- 
2.30.2