GNU bug report logs - #47807
TeX-view-program settings for Xreader

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47807: closed (TeX-view-program settings for Xreader)
Date: Fri, 16 Apr 2021 16:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 16 Apr 2021 18:41:17 +0200
with message-id <878s5idvte.fsf <at> gnu.org>
and subject line Re: bug#47807: TeX-view-program settings for Xreader
has caused the debbugs.gnu.org bug report #47807,
regarding TeX-view-program settings for Xreader
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47807: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47807
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: TeX-view-program settings for Xreader
Date: Thu, 15 Apr 2021 15:35:59 -0300

Hi All,

This is a simple one.  `tex.el' includes settings for the "Xreader" to 
be used in Linux systems as defined in `TeX-view-program-list-builtin'. 
After loading, the entry for "Xreader" in that variable will be: 
`("Xreader" TeX-reader-sync-view "xreader")'.  However, the function 
`TeX-reader-sync-view' is actually not defined, but rather 
`TeX-xreader-sync-view' is (with an "x").  Therefore, using "Xreader" 
for `output-pdf' in `TeX-view-program-selection' will throw us error 
"Wrong type argument: listp, TeX-reader-sync-view".

As far as I can tell, the problem does not lie in the definition of 
`TeX-view-program-list-builtin', because 
`TeX-view-program-select-evince' relies on `TeX-evince-dbus-p' which 
will query the DBUS path/scheme/method which is indeed "org.x.reader" 
(at least in my machine, I suppose that's default, but I really don't 
know).  Thus, it seems `TeX-xreader-sync-view' is incorrectly named, and 
should drop the "x".  It's docstring also seems to not have been 
adjusted as required after it was "inherited" from 
`TeX-evince-sync-view'.

Best regards,
Gustavo.

PS: Please keep me CC'd.

[Message part 3 (message/rfc822, inline)]

From: Tassilo Horn <tsdh <at> gnu.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: bug-auctex <at> gnu.org, 47807-done <at> debbugs.gnu.org
Subject: Re: bug#47807: TeX-view-program settings for Xreader
Date: Fri, 16 Apr 2021 18:41:17 +0200

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

Hi Gustavo,

> This is a simple one.  `tex.el' includes settings for the "Xreader" to
> be used in Linux systems as defined in
> `TeX-view-program-list-builtin'. After loading, the entry for
> "Xreader" in that variable will be: `("Xreader" TeX-reader-sync-view
> "xreader")'.  However, the function `TeX-reader-sync-view' is actually
> not defined, but rather `TeX-xreader-sync-view' is (with an "x").
> Therefore, using "Xreader" for `output-pdf' in
> `TeX-view-program-selection' will throw us error "Wrong type argument:
> listp, TeX-reader-sync-view".
>
> As far as I can tell, the problem does not lie in the definition of
> `TeX-view-program-list-builtin', because
> `TeX-view-program-select-evince' relies on `TeX-evince-dbus-p' which
> will query the DBUS path/scheme/method which is indeed "org.x.reader"
> (at least in my machine, I suppose that's default, but I really don't
> know).  Thus, it seems `TeX-xreader-sync-view' is incorrectly named,
> and should drop the "x".

I approve your analysis.  Fixed on git master.  Please give it a whirl.

> It's docstring also seems to not have been adjusted as required after
> it was "inherited" from `TeX-evince-sync-view'.

Indeed, also fixed.

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.