From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Apr 2021 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47804@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161850247119132 (code B ref -1); Thu, 15 Apr 2021 16:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 16:01:11 +0000 Received: from localhost ([127.0.0.1]:38938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4QZ-0004yW-FM for submit@debbugs.gnu.org; Thu, 15 Apr 2021 12:01:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:52736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4QW-0004yM-8S for submit@debbugs.gnu.org; Thu, 15 Apr 2021 12:01:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX4QN-0008Ks-LO for guix-patches@gnu.org; Thu, 15 Apr 2021 12:01:02 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44274 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX4QL-0008FM-FR for guix-patches@gnu.org; Thu, 15 Apr 2021 12:00:59 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1618502447; bh=4CTUfwmeMJgVRM64aGe4q8bsDGP7W+gEfsdsFl/MgUo=; h=From:To:Subject:Date; b=rJUixx59NnHLbj8qnmIAtSBT/5RK6v71p+oXJkX/hADLIuQ5WqHDBkGw5CBUvjMyo qcyuEBVnfUHHLcYCW71RJx3s6SibPEY8cWB80aOeOdF8w4cEPa4O/P0I7RrpTOS01E jGz8ps1dU6d0PqRab9DCkrwfILoERww/wCZkGCM0= Message-Id: Date: Thu, 15 Apr 2021 18:00:46 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, FROM_SUSPICIOUS_NTLD_FP=0.001, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. --- There was some discussion about this on guix-devel[1], but no consensus was reached. Should we whitelist certain [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. --- There was some discussion about this on guix-devel[1], but no consensus was reached. Should we whitelist certain names like =E2=80=9C86_64=E2=80= =9D or something? [1]: https://yhetil.org/guix-devel/87v991vkpi.fsf@nckx guix/lint.scm | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index a7d6bbba4f..d5ad69475e 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; Copyright =C2=A9 2020 Chris Marusich ;;; Copyright =C2=A9 2020 Timothy Sample +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -173,14 +174,20 @@ (define (check-name package) "Check whether PACKAGE's name matches our guidelines." (let ((name (package-name package))) - ;; Currently checks only whether the name is too short. - (if (and (<=3D (string-length name) 1) - (not (string=3D? name "r"))) ; common-sense exception - (list - (make-warning package - (G_ "name should be longer than a single character") - #:field 'name)) - '()))) + (cond + ;; Currently checks only whether the name is too short. + ((and (<=3D (string-length name) 1) + (not (string=3D? name "r"))) ; common-sense exception + (list + (make-warning package + (G_ "name should be longer than a single character") + #:field 'name))) + ((string-match "_" name) + (list + (make-warning package + (G_ "name should use hyphens instead of underscores") + #:field 'name))) + (else '())))) =20 (define (properly-starts-sentence? s) (string-match "^[(\"'`[:upper:][:digit:]]" s)) base-commit: a5bbd38fd131282e928144e869dcdf1e09259085 --=20 2.31.1 From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Apr 2021 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47804@debbugs.gnu.org Received: via spool by 47804-submit@debbugs.gnu.org id=B47804.161850361621017 (code B ref 47804); Thu, 15 Apr 2021 16:21:01 +0000 Received: (at 47804) by debbugs.gnu.org; 15 Apr 2021 16:20:16 +0000 Received: from localhost ([127.0.0.1]:38966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4iy-0005Sr-IV for submit@debbugs.gnu.org; Thu, 15 Apr 2021 12:20:16 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:58988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4iv-0005Sa-1B for 47804@debbugs.gnu.org; Thu, 15 Apr 2021 12:20:10 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id t4L62400j0mfAB4014L7dU; Thu, 15 Apr 2021 18:20:07 +0200 Message-ID: From: Maxime Devos Date: Thu, 15 Apr 2021 18:19:53 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ZH1G+2Ai8B7rD/0ZjBh8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618503607; bh=Pr3C7895wLarTMujGQ2O8pTWOXpcgYTX3nMqjnUERrY=; h=Subject:From:To:Date:In-Reply-To:References; b=XUL/cL+hsvTi52+M1fA8VN48E5H1mbfEa22IIA74VGGtS+3CB/qNX+gLS8lReiXvZ /1N/En1DwudtnhGqckPVfpVSmEVDt9aYsK7t6t8t6imhfMCLXl7n/qu2I0RLyiDM0s aIXNsyuQeLGaiunvML2phFz2QVagqqoaJdHoY+XP85O7qhI5swmExQ9Q5AWEv4YZvQ REqk37gGOZefl9YNyaaEcgGU3HqH1vJgPD8O/f3smBf7EJLlJjsejJtL9Wk1vdpFOR nk0iT84MyRQWLb5lUWwZz45YXumEIurNnA0AH4JltbfrQev89VgCL27Zy5N6HvHFqu BzSY2SoJnCtgQ== X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, 2021-04-15 at 18:00 +0200, Xinglu Chen wrote: > As per section '16.4.2 Package Naming' in the manual, use hyphens > instead of underscores in package names. > > * guix/lint.scm (check-name): C [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [195.130.132.52 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [195.130.132.52 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-ZH1G+2Ai8B7rD/0ZjBh8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2021-04-15 at 18:00 +0200, Xinglu Chen wrote: > As per section '16.4.2 Package Naming' in the manual, use hyphens > instead of underscores in package names. >=20 > * guix/lint.scm (check-name): Check whether the package name contains > underscores. > --- > There was some discussion about this on guix-devel[1], but no consensus > was reached. Should we whitelist certain names like =E2=80=9C86_64=E2=80= =9D or something? I dunno. Perhaps for now, we can accept that the 'check-name' linter is sometimes overly strict, and punt the exceptions for later? > [1]: https://yhetil.org/guix-devel/87v991vkpi.fsf@nckx >=20 > guix/lint.scm | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) >=20 > diff --git a/guix/lint.scm b/guix/lint.scm > index a7d6bbba4f..d5ad69475e 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -11,6 +11,7 @@ > ;;; Copyright =C2=A9 2018, 2019 Arun Isaac > ;;; Copyright =C2=A9 2020 Chris Marusich > ;;; Copyright =C2=A9 2020 Timothy Sample > +;;; Copyright =C2=A9 2021 Xinglu Chen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -173,14 +174,20 @@ > (define (check-name package) > "Check whether PACKAGE's name matches our guidelines." > (let ((name (package-name package))) > - ;; Currently checks only whether the name is too short. > - (if (and (<=3D (string-length name) 1) > - (not (string=3D? name "r"))) ; common-sense exception > - (list > - (make-warning package > - (G_ "name should be longer than a single characte= r") > - #:field 'name)) > - '()))) > + (cond > + ;; Currently checks only whether the name is too short. > + ((and (<=3D (string-length name) 1) > + (not (string=3D? name "r"))) ; common-sense exception > + (list > + (make-warning package > + (G_ "name should be longer than a single character"= ) > + #:field 'name))) > + ((string-match "_" name) > + (list > + (make-warning package > + (G_ "name should use hyphens instead of underscores= ") > + #:field 'name))) > + (else '())))) I didn't test this, but that seems about right. Ideally, you should add a corresponding test in tests/lint.scm (IIRC, maybe the linter tests are elsewhere). However, Guix is currently in the "string freeze", so this cannot yet be me= rged, IIUC. Greetings, Maxime. --=-ZH1G+2Ai8B7rD/0ZjBh8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHhnqRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qHoAQCJkjMTs4202E/7IFSOPxia4GVu 4OHuE4d2j4Vici9O0QEAp56CBgX7ASGNK2RUFme7pCmtXujKI6TxpHcpx/804QE= =pJJG -----END PGP SIGNATURE----- --=-ZH1G+2Ai8B7rD/0ZjBh8-- From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Apr 2021 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 47804@debbugs.gnu.org Received: via spool by 47804-submit@debbugs.gnu.org id=B47804.161851051232585 (code B ref 47804); Thu, 15 Apr 2021 18:16:02 +0000 Received: (at 47804) by debbugs.gnu.org; 15 Apr 2021 18:15:12 +0000 Received: from localhost ([127.0.0.1]:39163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6WF-0008TV-Sz for submit@debbugs.gnu.org; Thu, 15 Apr 2021 14:15:12 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:55356 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6WD-0008Sm-3r for 47804@debbugs.gnu.org; Thu, 15 Apr 2021 14:15:10 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1618510501; bh=T11bgPTjNismhrl98pFU//7hhRTF3l8gRdp1WDz574s=; h=From:To:Subject:In-Reply-To:References:Date; b=WE9RDgZITX8YOElKBXXkwJ9y5fIot8oVWLgcVl1e8FbfcRhqnzXPj3ei0dbBAZ/vD Ps1U8CcUljNhHP0Bl0uKOdCzYmuLBfohJEHQ1hA2/0Fc33FPu5zdKgPxzumv7wsOkh GBRlJzjQdef8KFTgGThDfNJBvLsjI7kooCShV36E= In-Reply-To: References: Date: Thu, 15 Apr 2021 20:15:01 +0200 Message-ID: <8735vrh0t6.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, Apr 15 2021, Maxime Devos wrote: >> There was some discussion about this on guix-devel[1], but no >> consensus was reached. Should we whitelist certain names like >> =?UTF-8?Q?=E2=80=9C86=5F64=E2=80=9D?= or something? > > I dunno. Perhaps for now, we can acce [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, Apr 15 2021, Maxime Devos wrote: >> There was some discussion about this on guix-devel[1], but no >> consensus was reached. Should we whitelist certain names like >> =?UTF-8?Q?=E2=80=9C86=5F64=E2=80=9D?= or something? > > I dunno. Perhaps for now, we can acce [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD On Thu, Apr 15 2021, Maxime Devos wrote: >> There was some discussion about this on guix-devel[1], but no >> consensus was reached. Should we whitelist certain names like >> =E2=80=9C86_64=E2=80=9D or something? > > I dunno. Perhaps for now, we can accept that the 'check-name' linter > is sometimes overly strict, and punt the exceptions for later? Ok, that sounds like a good idea. > I didn't test this, but that seems about right. Ideally, you should > add a corresponding test in tests/lint.scm (IIRC, maybe the linter > tests are elsewhere). Will do. > However, Guix is currently in the "string freeze", so this cannot yet > be merged, IIUC. I thought the =E2=80=9Cstring freeze=E2=80=9D was for the manual, or did I = miss something? Thanks for the review! From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH v2] lint: Warn about underscores in package names. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Apr 2021 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47804@debbugs.gnu.org Cc: Maxime Devos X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16185115261740 (code B ref -1); Thu, 15 Apr 2021 18:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 18:32:06 +0000 Received: from localhost ([127.0.0.1]:39179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6mc-0000S0-FG for submit@debbugs.gnu.org; Thu, 15 Apr 2021 14:32:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:57840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6mZ-0000Rr-Nw for submit@debbugs.gnu.org; Thu, 15 Apr 2021 14:32:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX6mX-00054y-Vj for guix-patches@gnu.org; Thu, 15 Apr 2021 14:32:02 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:47486 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX6mO-0004m7-NN for guix-patches@gnu.org; Thu, 15 Apr 2021 14:32:01 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1618511505; bh=NcZC8tMC1i5grbNGiu9BNryoliYTp3NofHQT9VpO84Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LysxMsHl6XH62tKjG6z5D61mwSsiSJ8zM/nFqqbAumPUtQtfyH/544Hq9KLSorJbw HhKmzo1T+/okX9sMYeWLT0MswQUtUoRyf8J3CsKl63yU116AOUY1TdS6dhzoFEEpyp DuIfQvwGOMpLmpvxjLIRa2ev6N41yuaTB01cZZWY= In-Reply-To: References: Message-Id: <94d0b8cb2322ed634442c0ebb79589e5dc05e526.1618511382.git.public@yoctocell.xyz> Date: Thu, 15 Apr 2021 20:31:44 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. * tests/lint.scm ("name: use underscore in package name"): New test. --- Changes since v1: - Add test for package nam [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. * tests/lint.scm ("name: use underscore in package name"): New test. --- Changes since v1: - Add test for package name with underscore. guix/lint.scm | 24 ++++++++++++++++-------- tests/lint.scm | 7 +++++++ 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index a7d6bbba4f..38699e2927 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; Copyright =C2=A9 2020 Chris Marusich ;;; Copyright =C2=A9 2020 Timothy Sample +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -81,6 +82,7 @@ check-synopsis-style check-derivation check-home-page + check-name check-source check-source-file-name check-source-unstable-tarball @@ -173,14 +175,20 @@ (define (check-name package) "Check whether PACKAGE's name matches our guidelines." (let ((name (package-name package))) - ;; Currently checks only whether the name is too short. - (if (and (<=3D (string-length name) 1) - (not (string=3D? name "r"))) ; common-sense exception - (list - (make-warning package - (G_ "name should be longer than a single character") - #:field 'name)) - '()))) + (cond + ;; Currently checks only whether the name is too short. + ((and (<=3D (string-length name) 1) + (not (string=3D? name "r"))) ; common-sense exception + (list + (make-warning package + (G_ "name should be longer than a single character") + #:field 'name))) + ((string-match "_" name) + (list + (make-warning package + (G_ "name should use hyphens instead of underscores") + #:field 'name))) + (else '())))) =20 (define (properly-starts-sentence? s) (string-match "^[(\"'`[:upper:][:digit:]]" s)) diff --git a/tests/lint.scm b/tests/lint.scm index bd8604f589..a2c8665142 100644 --- a/tests/lint.scm +++ b/tests/lint.scm @@ -8,6 +8,7 @@ ;;; Copyright =C2=A9 2017 Efraim Flashner ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; Copyright =C2=A9 2020 Timothy Sample +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -270,6 +271,12 @@ (description "Imagine this is Taylor UUCP.")))) (check-synopsis-style pkg))) =20 +(test-equal "name: use underscore in package name" + "name should use hyphens instead of underscores" + (single-lint-warning-message + (let ((pkg (dummy-package "under_score"))) + (check-name pkg)))) + (test-equal "inputs: pkg-config is probably a native input" "'pkg-config' should probably be a native input" (single-lint-warning-message base-commit: a5bbd38fd131282e928144e869dcdf1e09259085 --=20 2.31.1 From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Apr 2021 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47804@debbugs.gnu.org Received: via spool by 47804-submit@debbugs.gnu.org id=B47804.16185683832426 (code B ref 47804); Fri, 16 Apr 2021 10:20:02 +0000 Received: (at 47804) by debbugs.gnu.org; 16 Apr 2021 10:19:43 +0000 Received: from localhost ([127.0.0.1]:40096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXLZf-0000d4-2C for submit@debbugs.gnu.org; Fri, 16 Apr 2021 06:19:43 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:47580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXLZd-0000cw-8T for 47804@debbugs.gnu.org; Fri, 16 Apr 2021 06:19:42 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id tNKf240060mfAB401NKfrE; Fri, 16 Apr 2021 12:19:39 +0200 Message-ID: <762053ed2175f1ded96da8d85855843d73936364.camel@telenet.be> From: Maxime Devos Date: Fri, 16 Apr 2021 12:19:39 +0200 In-Reply-To: <8735vrh0t6.fsf@yoctocell.xyz> References: <8735vrh0t6.fsf@yoctocell.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-lKS8BVTeB8AFsUhS77Ax" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618568380; bh=AmQwsmFcNChTEU9graKIX7zW5CqKxKfSz0jRVHWtNwo=; h=Subject:From:To:Date:In-Reply-To:References; b=afs7VeTg11FaKEFKjUm9xBiF4SiavsNKBvRexLy2KLjmqJXyoamnk27YPAghLcAXs J91EBzvzONxZKfv3GzVE7kOQVXb7KlgATo06H9TIhAeLEH0seJ63DKmgQtpxMCosVj wBqEqnOzClpPTGrvxMGM3NrKn1XhiVUYXHeGkgFKJ/JlzhkqLstxdjW6s8jcnRWRnW EPGk/GuUultU9XNcP+UeoKKo+9C+FEBnw+mvVbDMxhMiS/48ZcqcMnGZd2SjNAs/C7 Op1DEqftHYDs2M6IPJvvS1K6OSVHTy1gfJ82L/qE3/SrcUI/mLwJWoL5d4Xty0pXa/ kfwVaEIGxt4bw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-lKS8BVTeB8AFsUhS77Ax Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2021-04-15 at 20:15 +0200, Xinglu Chen wrote: > On Thu, Apr 15 2021, Maxime Devos wrote: > [...] >=20 > > However, Guix is currently in the "string freeze", so this cannot yet > > be merged, IIUC. >=20 > I thought the =E2=80=9Cstring freeze=E2=80=9D was for the manual, or did = I miss > something? The freeze if for both the manual and guix itself (but not the packages). Greetings, Maxime. --=-lKS8BVTeB8AFsUhS77Ax Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHlkuxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lSBAQCIDxvJ6k1JE0Eqj3baGyyz6uB5 PuXkpzcu20JXXLv7MQD/bsGmJZOwzsa2bGecPOdtIwbN18VF8ZEP140SvpbRUQA= =btmY -----END PGP SIGNATURE----- --=-lKS8BVTeB8AFsUhS77Ax-- From unknown Sat Aug 09 13:14:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xinglu Chen Subject: bug#47804: closed (Re: bug#47804: [PATCH] lint: Warn about underscores in package names.) Message-ID: References: <87eefa2bmw.fsf_-_@gnu.org> X-Gnu-PR-Message: they-closed 47804 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 47804@debbugs.gnu.org Date: Fri, 16 Apr 2021 20:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1618606562-16852-1" This is a multi-part message in MIME format... ------------=_1618606562-16852-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47804: [PATCH] lint: Warn about underscores in package names. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47804@debbugs.gnu.org. --=20 47804: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47804 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1618606562-16852-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47804-done) by debbugs.gnu.org; 16 Apr 2021 20:55:06 +0000 Received: from localhost ([127.0.0.1]:41801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXVUY-0004MY-3X for submit@debbugs.gnu.org; Fri, 16 Apr 2021 16:55:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXVUS-0004Ly-Tu for 47804-done@debbugs.gnu.org; Fri, 16 Apr 2021 16:55:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48305) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXVUK-0004af-7T; Fri, 16 Apr 2021 16:54:54 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXVUH-0004nW-LF; Fri, 16 Apr 2021 16:54:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Xinglu Chen Subject: Re: bug#47804: [PATCH] lint: Warn about underscores in package names. References: <94d0b8cb2322ed634442c0ebb79589e5dc05e526.1618511382.git.public@yoctocell.xyz> Date: Fri, 16 Apr 2021 22:54:47 +0200 In-Reply-To: <94d0b8cb2322ed634442c0ebb79589e5dc05e526.1618511382.git.public@yoctocell.xyz> (Xinglu Chen's message of "Thu, 15 Apr 2021 20:31:44 +0200") Message-ID: <87eefa2bmw.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Xinglu Chen skribis: > As per section '16.4.2 Package Naming' in the manual, use hyphens > instead of underscores in package names. > > * guix/lint.scm (check-name): Check whether the package name contains > underscores. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.92 listed in list.dnswl.org] X-Debbugs-Envelope-To: 47804-done Cc: 47804-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Xinglu Chen skribis: > As per section '16.4.2 Package Naming' in the manual, use hyphens > instead of underscores in package names. > > * guix/lint.scm (check-name): Check whether the package name contains > underscores. > * tests/lint.scm ("name: use underscore in package name"): New test. Applied with the minor change below, which avoids regexps (=E2=80=98string-match=E2=80=99 performs regexp matches, which is overkill = here). Thank you and thanks Maxime for the review! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/lint.scm b/guix/lint.scm index 38699e2927..1bebfe03d3 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -183,7 +183,7 @@ (make-warning package (G_ "name should be longer than a single character") #:field 'name))) - ((string-match "_" name) + ((string-index name #\_) (list (make-warning package (G_ "name should use hyphens instead of underscores") --=-=-=-- ------------=_1618606562-16852-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 16:01:11 +0000 Received: from localhost ([127.0.0.1]:38938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4QZ-0004yW-FM for submit@debbugs.gnu.org; Thu, 15 Apr 2021 12:01:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:52736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX4QW-0004yM-8S for submit@debbugs.gnu.org; Thu, 15 Apr 2021 12:01:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX4QN-0008Ks-LO for guix-patches@gnu.org; Thu, 15 Apr 2021 12:01:02 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44274 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX4QL-0008FM-FR for guix-patches@gnu.org; Thu, 15 Apr 2021 12:00:59 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1618502447; bh=4CTUfwmeMJgVRM64aGe4q8bsDGP7W+gEfsdsFl/MgUo=; h=From:To:Subject:Date; b=rJUixx59NnHLbj8qnmIAtSBT/5RK6v71p+oXJkX/hADLIuQ5WqHDBkGw5CBUvjMyo qcyuEBVnfUHHLcYCW71RJx3s6SibPEY8cWB80aOeOdF8w4cEPa4O/P0I7RrpTOS01E jGz8ps1dU6d0PqRab9DCkrwfILoERww/wCZkGCM0= To: guix-patches@gnu.org Subject: [PATCH] lint: Warn about underscores in package names. Message-Id: Date: Thu, 15 Apr 2021 18:00:46 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, FROM_SUSPICIOUS_NTLD_FP=0.001, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. --- There was some discussion about this on guix-devel[1], but no consensus was reached. Should we whitelist certain [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) As per section '16.4.2 Package Naming' in the manual, use hyphens instead of underscores in package names. * guix/lint.scm (check-name): Check whether the package name contains underscores. --- There was some discussion about this on guix-devel[1], but no consensus was reached. Should we whitelist certain names like =E2=80=9C86_64=E2=80= =9D or something? [1]: https://yhetil.org/guix-devel/87v991vkpi.fsf@nckx guix/lint.scm | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index a7d6bbba4f..d5ad69475e 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; Copyright =C2=A9 2020 Chris Marusich ;;; Copyright =C2=A9 2020 Timothy Sample +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -173,14 +174,20 @@ (define (check-name package) "Check whether PACKAGE's name matches our guidelines." (let ((name (package-name package))) - ;; Currently checks only whether the name is too short. - (if (and (<=3D (string-length name) 1) - (not (string=3D? name "r"))) ; common-sense exception - (list - (make-warning package - (G_ "name should be longer than a single character") - #:field 'name)) - '()))) + (cond + ;; Currently checks only whether the name is too short. + ((and (<=3D (string-length name) 1) + (not (string=3D? name "r"))) ; common-sense exception + (list + (make-warning package + (G_ "name should be longer than a single character") + #:field 'name))) + ((string-match "_" name) + (list + (make-warning package + (G_ "name should use hyphens instead of underscores") + #:field 'name))) + (else '())))) =20 (define (properly-starts-sentence? s) (string-match "^[(\"'`[:upper:][:digit:]]" s)) base-commit: a5bbd38fd131282e928144e869dcdf1e09259085 --=20 2.31.1 ------------=_1618606562-16852-1-- From unknown Sat Aug 09 13:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Apr 2021 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47804@debbugs.gnu.org, ludo@gnu.org, public@yoctocell.xyz Cc: 47804-done@debbugs.gnu.org, Maxime Devos X-Debbugs-Original-To: guix-patches@gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Xinglu Chen Received: via spool by submit@debbugs.gnu.org id=B.161860937721311 (code B ref -1); Fri, 16 Apr 2021 21:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Apr 2021 21:42:57 +0000 Received: from localhost ([127.0.0.1]:41879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXWEq-0005Xe-Nv for submit@debbugs.gnu.org; Fri, 16 Apr 2021 17:42:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:50818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXWEl-0005XT-Gs for submit@debbugs.gnu.org; Fri, 16 Apr 2021 17:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXWEk-000524-GM for guix-patches@gnu.org; Fri, 16 Apr 2021 17:42:51 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:51892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXWEi-0005rE-1u; Fri, 16 Apr 2021 17:42:50 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 62371430; Fri, 16 Apr 2021 21:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=S94FNkjoAoF45Rz21Kn8fxL4IwrT2lxyOarjvL9ZXnA=; b=IRpBAcC WRiuxijHiV1OfROohwhzAzLJJOE7t4DFysxm/x2RQ23JJT5bbszg1SrtbdIxUlei om+ADXd8nIbW08K16dK2xklHx4sYKWxDwEEEbayWpma7lcL3amksIfQgixONFgEI WA7FlmnRx8DNWw0bV8TXKAxXZaRc5PoQ5pTfA10uaL57g2m5DsBe4hh/BZiH4Rkq MDXWWFwDp6Uqj0BlfcDIpG2FedVaWTqFCpj8ef+48birTXX/XSCSXibWAxYuuigZ Ls9gr/VgTWdJCbQmPhX8o/DcUC/xKyw2IfZ2S+f+OiR6vVZwFHMC3jv2IxoUgrx9 TBItdqyu0kew6Kw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 952ea788 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 16 Apr 2021 21:42:40 +0000 (UTC) Date: Fri, 16 Apr 2021 17:42:30 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <87eefa2bmw.fsf_-_@gnu.org> References: <94d0b8cb2322ed634442c0ebb79589e5dc05e526.1618511382.git.public@yoctocell.xyz> <87eefa2bmw.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Julien Lepiller Message-ID: Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Le 16 avril 2021 16:54:47 GMT-04:00, "Ludovic Court=C3=A8s" a =C3=A9crit : >Hi, > >Xinglu Chen skribis: > >> As per section '16=2E4=2E2 Package Naming' in the manual, use hyphens >> instead of underscores in package names=2E >> >> * guix/lint=2Escm (check-name): Check whether the package name contains >> underscores=2E >> * tests/lint=2Escm ("name: use underscore in package name"): New test= =2E > >Applied with the minor change below, which avoids regexps >(=E2=80=98string-match=E2=80=99 performs regexp matches, which is overkil= l here)=2E > >Thank you and thanks Maxime for the review! > >Ludo=E2=80=99=2E Hm=E2=80=A6 unless I'm mistaken, this patch adds a string to the guix doma= in, which is part of the string freeze=2E The guix-packages is not part of the string freeze, that is to say synopsi= s and description of packages, only=2E