From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 03:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 47784@debbugs.gnu.org X-Debbugs-Original-To: Emacs Bug Reporting Received: via spool by submit@debbugs.gnu.org id=B.161845752024109 (code B ref -1); Thu, 15 Apr 2021 03:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 03:32:00 +0000 Received: from localhost ([127.0.0.1]:36116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWsjX-0006Gn-Ve for submit@debbugs.gnu.org; Wed, 14 Apr 2021 23:32:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:50984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWsjT-0006Gb-Su for submit@debbugs.gnu.org; Wed, 14 Apr 2021 23:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWsjT-0007nb-L2 for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:31:55 -0400 Received: from mout.gmx.net ([212.227.17.20]:42781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWsjR-00086Z-J5 for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 23:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618457510; bh=gemglBM5BHijUNyGkO439gw2idxnkfQnDv8DthDZN/g=; h=X-UI-Sender-Class:Date:From:To:Subject; b=KrDVUtUgKC/nmRkmqiWrAFY78Oz7tI2BKR1Tc1LbrjicYF9OXAKQxlDy60ekTlo40 f9sat7xnAtEp3dQxlzZUFAkdc8jgY9sU20k6qusYK2KBKe4s5LC2cn9YbhPnLxvWKH UYYFi/2A33r726u2ya+241nxfGltH3m+NYx4HZOc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2V0B-1lfrWk3gch-013uHT for ; Thu, 15 Apr 2021 05:31:50 +0200 Date: Wed, 14 Apr 2021 23:31:47 -0400 From: Boruch Baum Message-ID: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="wrvhv2sruki3lcpk" Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:2pso4Vtrv1z4bx8ryyYvHrKB9FS6by7Ri0QZ+dhFeNlWTtuMsR0 PMZ1e6palwTE4elx8934zZN/33TLfdn8/VbTk3vLiXbfdpKSPIz9+Ch2DuHme0wPzJidKgF h/juM7TDBJeTPnkqR1FTEZGuXZGb545BY9VVxurw+scXWvN4GqOf1IIgg/RYrsWEtVzQcRl WaxJx6YWXVuGCqazYmNKA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kI6Qi9ZLRZk=:TF6sZ45w+C9gw3sxIehHrq jtsMy8DrUP5QPJQTLnGYe7kAl/lpyj/+OHSWfQQS4aabffOWYjfDT54urry+G8+I/s0M6da6U OEXBgVCteTUeE1r8sp+5Zp4F7JW9Ub1cT5nO11Dg8HfUsIp0ZJb0SXAv3D1BtVjKKEbrNEeYN 6FDlMOC73xIBw+ibEoozk3/2cRADdRYgH/4kr8zvtnKj7DmGF+ainKEiM1naWqYBoTm+j3SCr wcS/PfcoGqffFxMV4LLV1aumk/A0pk1UIK2zqvND7Hw58a6t55tK1+/7bmiCxN6e1vMgRbLAv pjs7atFfOa/b6U0lR7ehd12SLgBsfKBNrvAMai7yEhLZEmQhfoW+irq73U6dTBm9TpiZA2SV7 uiuKy01NhoQ+49kTN2Cq9WlAo1MhQU8xzSsQUr1Kx5uYIDymMP4E6TW3/RCSc+QlYj/ids3mX J77VuM84+uLdDV6wQIvCBVS8zWQe9WEaQmBeaadXwIDDmYzHRc7tZUvxBeUdvhv7dW3lQngqs jNd7GGQwft/i5M5nxMh8xKN2FX9VD+HqgE/edUeewmALdrLQicTwwihUjTd/pXpKumFYChWKk hlQalLiRQCM4nIe/7mp51Q55xBBZ2rx7Q2KHUOvKmc/S4Wnn6lMRpNP57XRUWwCt8zJrk5PGE i7SY5SlZ2Ra2ySaXg19lm+z3ygg5N8zZqgZN5WV3ZaYMCDkfqrYg0Qd6jjkp54BSXZQyHlh/s b6K/u/zGpl4kIRonSfLtjIikVArgTJ+mfX/47pH40qlPZGfURhga+Jo8o7ixRc06SLxfq5GY/ Mc2C3FDPn7X1602g8v74vbK8treXsIh14MOUNFGUreibv6xX+5UWiYKXF3w/nfsCKDiteIzf/ T+3Ai9PRsLjvbOK8foXwe/FKEsDif3/ULx+G4jsb12d21q98a4K1mOlhFseW3CwK499XSvAAa kxYXwgbITdsozSZ1CPNLoqDZgCm1iZHPMNpglb7oSaJ2eu+pbpPIXt9S1aHvgL0T9qbljPK64 DDbL8EPq6jeQblXuVz0pjrLT88MCJMHW+iLX0RTMFpJt9fiD3o8lKOD1XhRa/sY68h2I4N+lb RbEyvc9IAi6tUlYyLGWtEAfKEhkx9Tsw4Koq0UNzITLktJYPVsWVdY1q42XPVWf8rDpLhftaN TCzBiDFxoAjVtwhyFAyhtMjE0ZyAXq6A30DnVWxGia4HmYXhVz7aPYufcyfjHk5sETO+o= Received-SPF: pass client-ip=212.227.17.20; envelope-from=boruch_baum@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --wrvhv2sruki3lcpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Two patch files are attached. + ses-header-row.patch + Function `ses-set-header-row' was determining the current row based upon variable `ses--curcell', but that variable is NIL until one begins an operation on a cell (eg. keybindings '=3D', '"'), so navigating to a row was insufficient to select that row, and further generated an ERROR because the code was not expecting a NIL value for variable `ses--curcell' + Using function `user-error' instead of `error' doesn't spawn a debug session and backtrace buffer when variable `toggle-debug-on-error' is set. + ses-user-error.patch + Quasi-randomly replaces some calls to function `error' with `user-error'. + There could be many other desirable points of replacement, but these were some obvious ones, and without knowing whether the patch would be accepted at all, it's what I invested. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --wrvhv2sruki3lcpk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ses-header-row.patch" diff --git a/ses.el b/ses.el index a2e6033..06a3d51 100644 --- a/ses.el +++ b/ses.el @@ -3457,7 +3457,9 @@ With a \\[universal-argument] prefix arg, prompt the user. The top row is row 1. Selecting row 0 displays the default header row." (interactive (list (if (numberp current-prefix-arg) current-prefix-arg - (let ((currow (1+ (car (ses-sym-rowcol ses--curcell))))) + (let* ((curcell (or (ses--cell-at-pos (point)) + (user-error "Invalid header-row"))) + (currow (1+ (car (ses-sym-rowcol curcell))))) (if current-prefix-arg (read-number "Header row: " currow) currow))))) --wrvhv2sruki3lcpk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ses-user-error.patch" diff --git a/ses.el b/ses.el index 06a3d51..f7893de 100644 --- a/ses.el +++ b/ses.el @@ -2252,7 +2252,7 @@ Based on the current set of columns and `window-hscroll' position." names))))) (if (string= s "") - (error "Invalid cell name") + (user-error "Invalid cell name") (list (intern s))))) (let ((rowcol (ses-sym-rowcol sym))) (or rowcol (error "Invalid cell name")) @@ -3380,7 +3380,7 @@ buffer." ((derived-mode-p 'ses-mode) ses--local-printer-hashmap) ((minibufferp) ses--completion-table) ((derived-mode-p 'help-mode) nil) - (t (error "Not in a SES buffer"))))) + (t (user-error "Not in a SES buffer"))))) (when local-printer-hashmap (let ((ses--list-orig-buffer (or ses--list-orig-buffer (current-buffer)))) (help-setup-xref @@ -3414,7 +3414,7 @@ buffer." ((derived-mode-p 'ses-mode) ses--named-cell-hashmap) ((minibufferp) ses--completion-table) ((derived-mode-p 'help-mode) nil) - (t (error "Not in a SES buffer"))))) + (t (user-error "Not in a SES buffer"))))) (when named-cell-hashmap (let ((ses--list-orig-buffer (or ses--list-orig-buffer (current-buffer)))) (help-setup-xref --wrvhv2sruki3lcpk-- From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16186878303325 (code B ref 47784); Sat, 17 Apr 2021 19:31:01 +0000 Received: (at 47784) by debbugs.gnu.org; 17 Apr 2021 19:30:30 +0000 Received: from localhost ([127.0.0.1]:44676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXqeD-0000rZ-NI for submit@debbugs.gnu.org; Sat, 17 Apr 2021 15:30:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXqeC-0000rI-HS for 47784@debbugs.gnu.org; Sat, 17 Apr 2021 15:30:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38983) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXqe7-0000VH-7M; Sat, 17 Apr 2021 15:30:23 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3213 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXqe5-00064X-JE; Sat, 17 Apr 2021 15:30:22 -0400 Date: Sat, 17 Apr 2021 22:30:08 +0300 Message-Id: <83eef8vhdr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (message from Boruch Baum on Wed, 14 Apr 2021 23:31:47 -0400) References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Wed, 14 Apr 2021 23:31:47 -0400 > From: Boruch Baum > > Two patch files are attached. > > + ses-header-row.patch > > + Function `ses-set-header-row' was determining the current row based > upon variable `ses--curcell', but that variable is NIL until one > begins an operation on a cell (eg. keybindings '=', '"'), so > navigating to a row was insufficient to select that row, and further > generated an ERROR because the code was not expecting a NIL value for > variable `ses--curcell' > > + Using function `user-error' instead of `error' doesn't spawn a > debug session and backtrace buffer when variable > `toggle-debug-on-error' is set. > > + ses-user-error.patch > > + Quasi-randomly replaces some calls to function `error' with > `user-error'. > > + There could be many other desirable points of replacement, but these > were some obvious ones, and without knowing whether the patch would > be accepted at all, it's what I invested. Thanks, but I don't think I understand the rationale for the second patch. What is the problem with signaling an error in those two places? From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.161882428219728 (code B ref 47784); Mon, 19 Apr 2021 09:25:01 +0000 Received: (at 47784) by debbugs.gnu.org; 19 Apr 2021 09:24:42 +0000 Received: from localhost ([127.0.0.1]:48433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQ94-000588-69 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 05:24:42 -0400 Received: from mout.gmx.net ([212.227.15.19]:42221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQ92-00057s-50 for 47784@debbugs.gnu.org; Mon, 19 Apr 2021 05:24:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618824273; bh=cb81+WJIKszz7QKo1g2/vAm6hDVyl8YUmU31uptBBXM=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=LVkW9kLFyJu0oCPMkkOqOAtrbm8nPovGxH1Dsr5GmTUyiH+H4j9JqS8TiV4QG+dwU PK/WR5af2XD4XDUjc2pVduQzTeyYfE1gEzEpOGFwIE0HCcYhv56GZhcB/QmkAvRY6P ASwVxdMucGRV2k7CfWpWo+U/Iel70EvkOWI95DYM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MG9kM-1lHxc51x1Q-00Gam2; Mon, 19 Apr 2021 11:24:33 +0200 Date: Mon, 19 Apr 2021 05:24:30 -0400 From: Boruch Baum Message-ID: <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83eef8vhdr.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:JhP19hBq6nJTBLUmD9ACgctwA5Utv20txsmNeME+S3y7I2iTAUq dVUZacQfptLTN+4FRPHSNrZPvVtktKU7Nx59bxYdVaf9skRwBEgCzRS5lZmvAoZXj0uUXI6 Pg+LNRccE9rsat2KHEegG/ewVzLKIpBUVrXWrK8E+QPVpoUKeGhIItA1giDDZy93TjCaCJ4 1Fi8yikg4yZ0fdy7Q40HA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OcvIo73/coE=:sqdFZzvfjvogDHar3dPDoq gZY2EKFdrYyPsFdM17F8ffA2zO1w9vNkvhIqz2SyGct8cVEGxT4CNx8A5gYu9VKX9uA2XK4VW 0JIeoWNAUeoq+nneox5iJNgKlSTp1vfDntDaeQ/gAkkJZTa2FYPlW6OxMA4V2cUuICfCYqMTZ eDLRAtuearmyI6vWz90s9MDXhBv6WyDKHLsKULK4IdxVGMySwb3cojjsTxNO5W03BFmWaREGm B4V96AhnjfkfQRkYW0u9UXqYkHbSgrHds8iwkNaV4aSUz0jRcdgL3u1jLTqHQuZbH2pB/etUn 1j4y8rqhRBfKQVtvDsesAYHZaLvCnwgLgOyuBSJuU/5rdw4n08vR49jOggvoTWhu8OVl/5rAX o7PJWRJf6XnsmY7IWAPcRfRkBKNZETJmg4IuOs8SjFkgJo9m6QBvKAT3pTZQYyA+j/KN7cr34 2EzH0EWa4IRNcDS9mkfsucdtvgJJ+MdhZE0fphZUsSmIINZZRuAJ1IHjfMlkmlMNswsUzAhj+ icypyiaWdLnOQ8lJA8+zbeRsqAoo9kPjWu7xX8rPSlfg3Q/bSHBa6vxnk7nxnATW/aTXO5kA/ 5vOWo4/hFuPEmNSYR99mVWIJUXiYYzKaT1RQFT7Oa1aMBAGUfL3UemodepwMSy8TUQohwrvvV uKYit0JJNoaMh3fBxIt36+cCjUSeZQ3TvLNurm/Bj2C0yK3gF9+KO9wzALk01het6vt89fm+G GWDgSdzbtJ6lpPXmPF+CycjqUDaGgjiAtQV/VqjgPTydg0lZ7INfo8PvDjr8d/QOw/Kvi83mw gxwZPMyprD+rhoTe0EGpKTgZvib40QUqFUZUlzwLzYclLlx1IYB6K/8DJxWC32it6bIKksorq PX3REyuYiM8HvYQbN//uxuBRNUnx5a+dsodsh/7F4aXEjaw4xlPUaT99j6yO1Ds/N3NspEGqQ 4cCycweytwwpr7rOGwQEcqavzcS9Z5w/9ISenc0nEYbnsAp/rsr0KnuPuWjO2Rwo5dvlZdUiB Y3CiVu2R9WCeujbopl2nu+ZGXN8nOKmNS/jbiCvY/LKTh5zwbb39BIxrY9Yn6H0QrrW5KXRGW oJp3ETyGo7cjXh+L7xnzrTGZwDvTIM+39tNHeFeVdPQTKCVRgCWU4gNEzUszbw4vqCnLVszAF xntCULBT5WlVjtnBzqrQSq3MTsgnczT7qWhyhNjjOLiFaEMuoG452h57cSv0e/pQtJ0tM= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-04-17 22:30, Eli Zaretskii wrote: > > Date: Wed, 14 Apr 2021 23:31:47 -0400 > > From: Boruch Baum > > ... > > + ses-user-error.patch > > > > + Quasi-randomly replaces some calls to function `error' with > > `user-error'. > > > > + There could be many other desirable points of replacement, but the= se > > were some obvious ones, and without knowing whether the patch woul= d > > be accepted at all, it's what I invested. > > Thanks, but I don't think I understand the rationale for the second > patch. What is the problem with signaling an error in those two > places? They avoid spawning a backtrace buffer when toggle-debug-on-error is set and the error is a user input error caught by a validation test within an `interactive' function call. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.161883742519076 (code B ref 47784); Mon, 19 Apr 2021 13:04:02 +0000 Received: (at 47784) by debbugs.gnu.org; 19 Apr 2021 13:03:45 +0000 Received: from localhost ([127.0.0.1]:48737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTZ3-0004xX-03 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 09:03:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTYw-0004x7-Ly for 47784@debbugs.gnu.org; Mon, 19 Apr 2021 09:03:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39794) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYTYp-0004yZ-RG; Mon, 19 Apr 2021 09:03:32 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYTYl-0006Vd-SK; Mon, 19 Apr 2021 09:03:31 -0400 Date: Mon, 19 Apr 2021 16:03:12 +0300 Message-Id: <83y2des9yn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> (message from Boruch Baum on Mon, 19 Apr 2021 05:24:30 -0400) References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Mon, 19 Apr 2021 05:24:30 -0400 > From: Boruch Baum > Cc: 47784@debbugs.gnu.org > > > Thanks, but I don't think I understand the rationale for the second > > patch. What is the problem with signaling an error in those two > > places? > > They avoid spawning a backtrace buffer when toggle-debug-on-error is set > and the error is a user input error caught by a validation test within > an `interactive' function call. I understand that, but the same is true for every call to 'error' whenever debug-on-error is set. Since by default debug-on-error is NOT set, I don't think I agree with that part of the change. (Why do you even have that variable set non-nil?) From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 13:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.161883888529926 (code B ref 47784); Mon, 19 Apr 2021 13:29:01 +0000 Received: (at 47784) by debbugs.gnu.org; 19 Apr 2021 13:28:05 +0000 Received: from localhost ([127.0.0.1]:48823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTwa-0007mb-JT for submit@debbugs.gnu.org; Mon, 19 Apr 2021 09:28:04 -0400 Received: from mout.gmx.net ([212.227.15.15]:54179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYTwX-0007m2-KK for 47784@debbugs.gnu.org; Mon, 19 Apr 2021 09:28:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618838875; bh=8abtfDjRt00Z/58McoGLPhCFr9ToCjg/OZEpAX8guVQ=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=ZaAFP8EuMRDYq4caqErOXyARXesVY4IKU7bcg1w2+bYNZenvv2jpfFzweHRF2TLpK PFIdCm0Zw+3EYVZHBSfIr+PIdrBNwbExdQKiH5W05eHQ4AFFG/PnoCNaqHTpUaYhgN TLlq9A7f50oikbdsHkK7hNyAMogxA2Pvx3Bk4Fzc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MulqD-1lqHwP4C2t-00rmGh; Mon, 19 Apr 2021 15:27:55 +0200 Date: Mon, 19 Apr 2021 09:27:52 -0400 From: Boruch Baum Message-ID: <20210419132752.2enm3o3zlbyify6p@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> <83y2des9yn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83y2des9yn.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:+PMmN5prvyqZNqowNcTulj/igQi88CkrurZacJbD3nBUVSMYfOT sDk18YrjFKDeoB5jRyzjU7wvRupsGV5T8l70hLpyre6iViaq24ktdLim2yW8q7gSAZdAhjn WcaD+KmxhDNaY08Npv4blr+DlMa+MLymwNKOppXvugQuPbwanEwZTHxteWknlfMirEtvrBv 6XiOJQ7jpu5idU2vLBl8w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:p6jF6z439iA=:Aeigo2LNTe7D3t7a+QbeFA unEMNx99Cu+FCcz28lv5Nai3ahEGEyR0PRObGl4DvbG6VK31SiPnp/edG0VLsooCs/rw+Mzr2 r+bs592umRbSDeUirf/2EMwvKcZ37Z+ROaGT/KxURT6gy/CMkbY0Sr8qkPFAYMYu6kMH2WERI aBmjDKMMRdBYt6KRgrgS06xG2l4cWoWW7zCq4An4raLYu/WrcCdzdZ/XmgotyvxpPu/MAcOKp fjB4aneM082Slq6pDlziopc5vhu/LvP+BRf9Q7Ec6kakT7F2PuPfPWCAI9SZtsLQSdTxWuyP5 2DMuXKXUQgq0gV9O/XmZ/qItPPHRRZedqIMbfQD19/j+EQVF6tWz+jfMPuCEUNf6dhP/C20fx KZp7j+mEXEZhUV8KPYeEhAN6Q/jL/HXLR4PTeKBdxtj95BDLYkiGXrTinjxhGA3uURYYL6fWe FsQYAvJ+lTJVYum8t2J4tQCDLgrgmbxoips+vv4N09NUq6AkdwQfto+X1No0Gekf2MIJtdV0L DiSKeJNAovCgspbt6GnVZUL8kMks+nbinuU3MdcuJcteGy4MIS0QBHzn2v4Rbpdm1VwnzrTs7 mh4S2RXpnPmkbA4LevVV2ZHmb6tc6mbb7GvnDtfWHT9eOYTG1twmyk4Ifu4ikUaLzP9ptvYZr nNcKa4gtCaMKF0xwrXp9Y9T9knj3o7Tdvmm1Csa/CArFVadxdVl+CJPI0YZMUF0iyad+A/G/D 5vp5Rn1hPbUttuWC3NYFXjeKlGm76SjzqFN3MJjxdVpCSlvlHfdZWTzQv+As23gcajyliqH8H YtfVPPvdIitlS2iBVsEq2M8blckIX9i+in89jQzVlPNnTtk5k2JYsPDjYRvDirOMUqQXKj6DE ti8GK0DWORuBDKb8FJB1Hgd/+AGRkCTMjP6fVZ1QBg7b1Yk0I/XPwlGGNNTORKbgFrdDpr/Xv WXjVWxAj/KpGrg+2OgLyDDDaI1ql+5k5JwcIbs/8ceuPsrLwvS3fJjUjY9IhQCQRQ/DIyDgH0 H4/DOUGdYtCktbCnjm+eX9Jq+ytgFIfGg+XjSnkgtfnCJMgUJJvH6DhO4iBwTXceEXs1HquV9 9UfpYNtlrILfB6EtiSJKUEZHJBBJoBcij/JxeF634BNAu487DDyCp4cWcAL68fWqEDyyV0BHC trygkrrqgYZQY4sdx0RZlopgCG8rPOQu3R5Nixr3Kl5zLQLBU2Hrd366U0H/EcIbcIsVM= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2021-04-19 16:03, Eli Zaretskii wrote: > > Date: Mon, 19 Apr 2021 05:24:30 -0400 > > From: Boruch Baum > > Cc: 47784@debbugs.gnu.org > > > > > Thanks, but I don't think I understand the rationale for the second > > > patch. What is the problem with signaling an error in those two > > > places? > > > > They avoid spawning a backtrace buffer when toggle-debug-on-error is s= et > > and the error is a user input error caught by a validation test within > > an `interactive' function call. > > I understand that, but the same is true for every call to 'error' > whenever debug-on-error is set. Not at all. The specific metrics are: 1) validation of user-input 2) interactive call Decide what your opinion is the purpose of function `user-error' separate from `error' and act accordingly. Whatever metric you use, you're bound to find cases of `error' being misused when `user-error' should be used. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Boruch Baum , 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16189633563340 (code B ref 47784); Wed, 21 Apr 2021 00:03:02 +0000 Received: (at 47784) by debbugs.gnu.org; 21 Apr 2021 00:02:36 +0000 Received: from localhost ([127.0.0.1]:56394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0KB-0000ri-Qp for submit@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:36 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:33438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0K9-0000rN-68 for 47784@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:33 -0400 Received: by mail-pf1-f178.google.com with SMTP id h11so9271394pfn.0 for <47784@debbugs.gnu.org>; Tue, 20 Apr 2021 17:02:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=xV3AH+E4stkuNJo9hHzAnv9ZYOsoLYkW4Mo8/MjgXi8=; b=L7LwEGaFcfvM6+7xdLDQh0dkA+bW5JJVr08i+u1y0wZtnY6O+q/KIeBwhbdrqD6PPx FoiAR9eLyPWpfTHRQ1TQvxvPTTocUpBEQj5fXNK67pzKMzLiOasIrLwXQKV0QL4G9Srd Uyo08vZqvcxnE30dG7GxaP8bqBbKTZ+82q0nw87bO329Mh6rWr4RrES/L6Wpci2s5iOE /tPo3yixsqzseyAB6hkvjb47o2HE3XcPmikBYwMTNOupJG027ZYLkfaJvhW++4ulFGPz rjQlZtMIc+uc9gJt5LqzUnJO8Ugs9Sd/tqAs8d7Yai7YXXsDgsnYnQF76q8Q2UmZhVT4 c9Aw== X-Gm-Message-State: AOAM533YYGBAt0WJTTo3pt0xaC7DLqM/bCB4U0FIh4BWC+FSP99PkOvi uP2DJw25/oegqBggtYltD3K96ey8Ykujl0odFzM= X-Google-Smtp-Source: ABdhPJw3MatilCVBmQh/NXugQONeliytXJEr/9Ioqdz0lnb8j6lZtmz8Yv9vsV2F0ozaHOxgwyPfeKy53YFRkoFYmlw= X-Received: by 2002:a05:6a00:2353:b029:25c:7dc5:a718 with SMTP id j19-20020a056a002353b029025c7dc5a718mr16949201pfj.58.1618963347304; Tue, 20 Apr 2021 17:02:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 19:02:26 -0500 From: Stefan Kangas In-Reply-To: <83y2des9yn.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Apr 2021 16:03:12 +0300") References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> <83y2des9yn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 20 Apr 2021 19:02:26 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> > Thanks, but I don't think I understand the rationale for the second >> > patch. What is the problem with signaling an error in those two >> > places? >> >> They avoid spawning a backtrace buffer when toggle-debug-on-error is set >> and the error is a user input error caught by a validation test within >> an `interactive' function call. > > I understand that, but the same is true for every call to 'error' > whenever debug-on-error is set. Since by default debug-on-error is > NOT set, I don't think I agree with that part of the change. (Why do > you even have that variable set non-nil?) AFAIU, `user-error' is to be used when, according to its docstring: This is like =E2=80=98error=E2=80=99 except that a user error (or "pilo= t error") comes from an incorrect manipulation by the user, not from an actual problem. So if that is the case here, then it should be `user-error's and otherwise it should be plain `error's. Right? From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 09:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: boruch_baum@gmx.com, 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.161899702327243 (code B ref 47784); Wed, 21 Apr 2021 09:24:01 +0000 Received: (at 47784) by debbugs.gnu.org; 21 Apr 2021 09:23:43 +0000 Received: from localhost ([127.0.0.1]:57008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ95D-00075L-5o for submit@debbugs.gnu.org; Wed, 21 Apr 2021 05:23:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ95B-000755-WA for 47784@debbugs.gnu.org; Wed, 21 Apr 2021 05:23:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52975) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZ956-0007cd-Eu; Wed, 21 Apr 2021 05:23:36 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3075 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZ955-0002DD-UR; Wed, 21 Apr 2021 05:23:36 -0400 Date: Wed, 21 Apr 2021 12:23:22 +0300 Message-Id: <83bla8q9dh.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Tue, 20 Apr 2021 19:02:26 -0500) References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> <83y2des9yn.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 20 Apr 2021 19:02:26 -0500 > Cc: Boruch Baum , 47784@debbugs.gnu.org > > >> They avoid spawning a backtrace buffer when toggle-debug-on-error is set > >> and the error is a user input error caught by a validation test within > >> an `interactive' function call. > > > > I understand that, but the same is true for every call to 'error' > > whenever debug-on-error is set. Since by default debug-on-error is > > NOT set, I don't think I agree with that part of the change. (Why do > > you even have that variable set non-nil?) > > AFAIU, `user-error' is to be used when, according to its docstring: > > This is like ‘error’ except that a user error (or "pilot error") comes > from an incorrect manipulation by the user, not from an actual problem. > > So if that is the case here, then it should be `user-error's and > otherwise it should be plain `error's. Right? How do you establish whether a particular problem is due to "incorrect manipulation by the user"? Since almost everything in Emacs comes from the user, one way or another, every error is due to "incorrect manipulation" of some kind. OTOH, commands can also be invoked from Lisp, non-interactively, in which case the user may have nothing to do with the problem, at least not directly. With that in mind, please look at the code where Boruch suggested to make these changes, and tell me what you think about them. Boruch's rationale was a different one, it stems from running with debug-on-error set non-nil. But that is a very unusual thing to do, and is bound to produce annoying backtraces all over the place. So I'm not sure I share the opinion that these changes should be made. I would like to hear other opinions, though. From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162022014320661 (code B ref 47784); Wed, 05 May 2021 13:10:01 +0000 Received: (at 47784) by debbugs.gnu.org; 5 May 2021 13:09:03 +0000 Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHGx-0005NB-Iu for submit@debbugs.gnu.org; Wed, 05 May 2021 09:09:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHGv-0005Mk-37 for 47784@debbugs.gnu.org; Wed, 05 May 2021 09:09:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqvN1EaSZgTf0j2IhSljw5XsrtUB2KZDzmXzAXgRo1U=; b=iRSnYMDgGNRJQp3QM8MVNse1Kc NNzMUbftgF7osIH0KcLnUoDuh+cB620KIVbpjyQhEgubmjKtiN72zB8mxuA+o6seNWJ0KP0wnk1HG Trgc3vTSxfGa7lB/98xdZmLNOtNHVm0FBLnMpctCRYRUM9unj3gkfFwYBWC//KTgjkeI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leHGm-000179-J4; Wed, 05 May 2021 15:08:54 +0200 From: Lars Ingebrigtsen References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> X-Now-Playing: Kreidler's _Flood_: "Flood V" Date: Wed, 05 May 2021 15:08:52 +0200 In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 14 Apr 2021 23:31:47 -0400") Message-ID: <87mtt95nvf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > Two patch files are attached. > > + ses-header-row.patch > > + Function `ses-set-header-row' was determining the current row based > upon variable `ses--curcell', but that variable is NIL until one [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > Two patch files are attached. > > + ses-header-row.patch > > + Function `ses-set-header-row' was determining the current row based > upon variable `ses--curcell', but that variable is NIL until one > begins an operation on a cell (eg. keybindings '=', '"'), so > navigating to a row was insufficient to select that row, and further > generated an ERROR because the code was not expecting a NIL value for > variable `ses--curcell' > > + Using function `user-error' instead of `error' doesn't spawn a > debug session and backtrace buffer when variable > `toggle-debug-on-error' is set. > > + ses-user-error.patch > > + Quasi-randomly replaces some calls to function `error' with > `user-error'. Looks good to me, so I've applied both patches to Emacs 28. Eli had some questions about the usage of user-error instead of error in the second patch, but as far as I can tell, using `user-error' is indeed the right thing here, because the errors in question seem more user initiated. I've got two tiny comments about the patch. First of all, the whitespace seemed odd: lisp/ses.el:3462: space before tab in indent. + (currow (1+ (car (ses-sym-rowcol curcell))))) So I fixed that up, but I've seen that in other patches -- could you have a look and see what's causing this mixture of tab and spaces? The other comment is that it would be nice to have ChangeLog-style commit messages -- use `C-x 4 a' to format one before sending patches. Less work when applying the patch. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 09:09:07 2021 Received: (at control) by debbugs.gnu.org; 5 May 2021 13:09:07 +0000 Received: from localhost ([127.0.0.1]:60058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHH0-0005NP-RZ for submit@debbugs.gnu.org; Wed, 05 May 2021 09:09:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHGz-0005Mm-2a for control@debbugs.gnu.org; Wed, 05 May 2021 09:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e/7TwgwQPjAtkCA58EZ9W0QgDu7b4yfhgl0tJhItMdk=; b=KfOQBgn9OXxOlBAiiWBxEk2l8b YjpFm0ffpx5cXITrxAcRrIKuuGM3F5fetYhgpv4n/6YfjpM6JvcuIiC3fng+pr+pF8URiOsRUXoB/ VAPZKkHgt3r+yklGabJ0WGbEq1xJFCjgUCwESi/9J5sOV635gc5Pa16nY6nQ6CDbnUWo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leHGr-00017G-K0 for control@debbugs.gnu.org; Wed, 05 May 2021 15:08:59 +0200 Date: Wed, 05 May 2021 15:08:57 +0200 Message-Id: <87lf8t5nva.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47784 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47784 fixed close 47784 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47784 fixed close 47784 28.1 quit From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162023284525248 (code B ref 47784); Wed, 05 May 2021 16:41:01 +0000 Received: (at 47784) by debbugs.gnu.org; 5 May 2021 16:40:45 +0000 Received: from localhost ([127.0.0.1]:33260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leKZp-0006ZA-F2 for submit@debbugs.gnu.org; Wed, 05 May 2021 12:40:45 -0400 Received: from mout.gmx.net ([212.227.17.20]:43789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leKZn-0006Z2-Gm for 47784@debbugs.gnu.org; Wed, 05 May 2021 12:40:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620232837; bh=9u+RJVISDECps5ELHk4nxhWcR8i2YaDeSJvYUEs7MpI=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=j2AQc66j4r/E8EdCpBajbJo2k7dKpwOlFZnyhdhg+PFnaRkVZbz4iQ9P8JEtGcQbL 9lkKnab4c2jlQmlwsiEmmqi5phZ7gvMuWuUAuAnkDspkhEvQuTDOJARmRRtlYR6Ose ZFUwlzCtSo4Q1ZQNcWSzBW8uZm3quQFvql3UA1zQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N1OXT-1lXH5i0Xgx-012qkJ; Wed, 05 May 2021 18:40:37 +0200 Date: Wed, 5 May 2021 12:40:34 -0400 From: Boruch Baum Message-ID: <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtt95nvf.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:bXANVbIXc/fKRJZtzix56yIW4kkkz/B5Ife0aIqlebOs7zPH5X3 m4j3QOMh1KDY5DP9tDR29/q2WZp4v7sAqXenr/tKk0NUVA+U2J3jPsKkk+ApZptTEU4LsSY 9CMdeC/jU/+5e1mpIKCHueo173yphbGCv77Gwu395bXXD3Oa4U7FwD4jCTEmZEN6aj/vkm5 tcGhokTYGN/ciKVS1dADA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Q3A0hzkEl4k=:wDsU0VjzVSWecNnSo2+97g yEzDu85PNgiLH9+LcnvwO7tnau/u0CDlTg0DGIO+oN9UQWKEfk8cJSOhbOUqvs03I5xXgADvQ dtkBr3h1V0DF9YCQIIxmPpb04PznVGPvr/Kso4dOnOBHpjTuzFsYiPaNGdpAw1mO72golFrbL CBUSwfjQhAlOB/ef4vejdwpShgm1ce4OIe+8KWHnaGWuv+TjFp+MO+H6FZtpZMZtDn5ZJfDEn +BrqnS9aq7+lDoIM1PU7LZe9fbX/BpKQ+M/7alSNrVv8Ne0CULAfbD0kYHhV0x8VheQ6hczSh 3YULF9a8ozYqRgnvHmVQ4niZieK2rSp1sb//+jHutquHvjatEWDdWMDhoGmmW9VgIjGLageud oSkwecDjCPJQcQ1eUTdfp3nwrWf/3WGRm8cLtR5muGRY7gfNx3U+ypnrazjhyH7XIfdt1VI2E Gw2LhJDZCwUcPj+6UwbxgLy2Q4piy2jMUQVPMR/6uJ4mcQFOoXAsJEF6dco68WSBr5N64LkE+ uwK+o6jeuO6l+8OnoC2Ah9KpSRCdplBTI6PK+RGI3HcuARd/deYNulGm6psg+KeQsPOEe9iLf j471lMJUZ6Z5+rNCEsY2uhl8yAkysT9NVjK0x0OYSqTias1UeeRYTYb8noduyrVstjPubDv4d l+wpOyQo5A/h9MZ+Kb8Pnm6B1eS2XOweAXMsNMx/lTkHioSHGRGEf51k9urzmMo0hcaIOEjlw hb4CRyP6bGtZ50PLyJjxmd///LOq4A/a7p61Q7GfLMKk+t33aX9lzoyRFnGAEN33Sr2BI0E2+ BnsA0oU0kewvHAc1dIruJEt/MLb6Il7QKxhbAavOaRhlVwch0HQftJk3uhcBuwlE8mWnBi04E qGtHaDc46G/9H1mRl0MO+Xg8korq9DmQBPIkYwYmBjjPeLtRu8ICLjV1jq+aJSXv+JtUqzR3h RrSWT2YC1iFg5kuxuypYfnxiZxfTb3xYksXLqz3rsMwLIScI4CRMUpV8eIwcXE/0FFlH9Bwbl 9G6i+Jo4X4UZBbmpvBlWqFqVUnvSVYSu+MI50ZVbFtpOflA90nDfhj1gdlAJAkyqTWdeydVWg QLyn4BcO4Yhg+ds9IQlk5W3SfUZxEui+WSYE/bF/7BwvMAiHTVpbuf8isWXiNNmCgE3nJBfcO ExKL3rESfhTNeMl+9Bhh681SdDLR7qKM8mtaYn26vh0Rbg/1u5tx6IH88VTF6OiCL7Pfk= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-05 15:08, Lars Ingebrigtsen wrote: > I've got two tiny comments about the patch. First of all, the > whitespace seemed odd: > ... > So I fixed that up, but I've seen that in other patches -- could you > have a look and see what's causing this mixture of tab and spaces? I could use a suggestion to automate that workflow: I never use tabs, but often find myself editing files that have them. As soon as it gets annoying, I remember to perform untabify on the buffer, but there's probably an accepted automated method to respect the tab/space preferences of everyone. > The other comment is that it would be nice to have ChangeLog-style > commit messages -- use `C-x 4 a' to format one before sending patches. > Less work when applying the patch. :-) I use `C-x 4 a' a lot, but for Changelog files. How can it be used for commit messages? Are you suggesting a temporary fake Changelog file? I see the output now in the online gnu cgit repository, so that's do-able manually. Are you saying that there's an automated way using function `add-change-log-entry-other-window'? =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 19:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Boruch Baum Cc: larsi@gnus.org, 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16202421385035 (code B ref 47784); Wed, 05 May 2021 19:16:02 +0000 Received: (at 47784) by debbugs.gnu.org; 5 May 2021 19:15:38 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leMzh-0001J9-Pc for submit@debbugs.gnu.org; Wed, 05 May 2021 15:15:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leMzd-0001J3-Oo for 47784@debbugs.gnu.org; Wed, 05 May 2021 15:15:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59308) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leMzY-0003FV-Hi; Wed, 05 May 2021 15:15:28 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3451 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leMzX-00042x-Kk; Wed, 05 May 2021 15:15:28 -0400 Date: Wed, 05 May 2021 22:15:17 +0300 Message-Id: <83czu5f0vu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> (message from Boruch Baum on Wed, 5 May 2021 12:40:34 -0400) References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 5 May 2021 12:40:34 -0400 > From: Boruch Baum > Cc: 47784@debbugs.gnu.org > > I use `C-x 4 a' a lot, but for Changelog files. How can it be used for > commit messages? Are you suggesting a temporary fake Changelog file? "C-x 4 a" will automatically produce a ChangeLog-formatted buffer, from which you could copy the log message when you commit. From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Eli Zaretskii Cc: larsi@gnus.org, 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16202436586004 (code B ref 47784); Wed, 05 May 2021 19:41:01 +0000 Received: (at 47784) by debbugs.gnu.org; 5 May 2021 19:40:58 +0000 Received: from localhost ([127.0.0.1]:34051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leNOE-0001Ym-BR for submit@debbugs.gnu.org; Wed, 05 May 2021 15:40:58 -0400 Received: from mout.gmx.net ([212.227.17.20]:51075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leNOC-0001Ye-Uh for 47784@debbugs.gnu.org; Wed, 05 May 2021 15:40:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620243650; bh=d4Vn+9H5pX/jYrDwG8fBVc6rEW9jka0PF+r07JmsLXg=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=JDKb+ZnEzmdSllY73UImr6FtON3cHEqEVj36XVL5DjvSTmPf+X881fxKfLa9G01yR t2nEHVrG1mRnbE7Ka31pBkGirZTdJ4QqEfTRdu05NqjH0R2X0yvsPQsifSI0rUcioP x165HJXSkRRkm9XvWsGLtzlyn2m+9iX1eclfEZAA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Ma20q-1m1Lld3enE-00VuFd; Wed, 05 May 2021 21:40:50 +0200 Date: Wed, 5 May 2021 15:40:46 -0400 From: Boruch Baum Message-ID: <20210505194046.c6oofhqfdwdqew4p@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <83czu5f0vu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83czu5f0vu.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:6g7lGuIaIeis1Ovk03M9SgcPHyMgY1jDncrW779YZ+AIK8W1x39 8lpXZqp6xY3vWHXRuwteQp2yqT6qVedGwUUmSfaD3dL/MB7Py5JRp6m/3uEzIrTbVTuvZsW Of8GXLs8cj9vaGo3vc47pnmsUywBVGxfYEAybHdZgXwqGKyg6hUss+4tyUSZBX6DQ3TJxxb 7nHOuBRQJzeOHpK34AqnQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ml/at7ANsiA=:i36pN72TuiJn/JANZSMkCb aWpsgAi4tBvnm0xelGuOMsOD6W2eyS3XH5LetKB75W6Bmccee9yj++DDjhBGrbdxOn8xK0OnH sBp3eKG6mHFkVVSFuB1Q+rQpcr4C6PsPgjcYJEpLupVHT1Szmi7eS+LxS8oMu++ovq5mQWO/+ Z7IscNx3G8VeGAvZnkIQoQzAyz/DFAZhu5LN3d2tQRprs7XTl1t27/K/Z+3000xLWWn4NAcTE G3a0Z6nNWMab9H3AfDDVB79Ub8Jdhzw6Z28Q7sKwjRHpRXLys6yqza7J6NdVvw0bhk57fKMvp FKo5CfDwNlfQv6UIO6nlyIJavZafEuXYrmTooY/9QImz/xw1SCLF5zqJ0IEOZZ7RmZLis4gKH y9rGospd6+cTCPoP0ZDMskBrRoy1ETw1UnVREBWMGEJfuw5HySoizb4+c2XZ1GMKb1ngp8AM9 lFwO1ru813csV+bnX+nB5eVUBLP+fCfIQQX05rAkxvD3RHbMDMpAZcxN/VsfdD4YZBl5d6c8O eLjm4gJSim9bK4fewKsLK2v66OiCTKQ/I4xmsBrRhg3lDxeaLEIpdaimIZVSAXj6IScB5Y/J6 IXRokcExiwsWNXnZd1MZLynxPq84hDCRISYOibi0jinVpvvl6t0OsNdpLp1cSm4ESBBPDLbPT Gmhh9tULCw/9pAIp3iniRj/C+uSeeGTywgAvsovmb7veugE0Ij2nIwZlzPmKw+bJMggNpdnp1 LpY7coRMIgJfKMu3UvUFYU10a+N4cZdNOb064W+rYb7f718Yap2d+kWqLCk4BwGeiMVyXCdEa d3RjQXLkSpu3meND47OtEhslNJp0F8Mpywu6Azcg52M+mNLFlSqG6ZAgvD8ANqJ4dU01mcMPv oOdD97Q/eKfhBbXG/t7owMuw7fGG9rj6Ekjc3UUBiGFXR4CH1I4XAQQ+xuFPvSSHa0uxCyiBp h1xnYLOwdsariCbCSS9/COxOQssUBA7VObxmPgibNrorlJpsearDsKHcW7V4/bqM3ZtI7OfQs 2b8vIkW2f9MoGtpOLFk/DnzydinDCiM2xfhdQ8zsDD/R6iv2hqccjIHs6vltu7blgX/1oKfaf TrZhIQ4WSEJkcFAOo4jlr1a+kRbdncxlhrwi7nBuOXCb4tGyfz+m/kBy2eFqiIIR83N4Q9X5i MCYV8RC3oOmUC6tVEa8hLMXWN6jop5XB8fIyUWtpxnHuUIXbcIsNCn9hV7q1aZr7IAekU= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-05 22:15, Eli Zaretskii wrote: > > Date: Wed, 5 May 2021 12:40:34 -0400 > > From: Boruch Baum > > Cc: 47784@debbugs.gnu.org > > > > I use `C-x 4 a' a lot, but for Changelog files. How can it be used for > > commit messages? Are you suggesting a temporary fake Changelog file? > > "C-x 4 a" will automatically produce a ChangeLog-formatted buffer, > from which you could copy the log message when you commit. Is this some new and 'backward-incompatible' behavior? In the past, I remember it always creating a Changelog file... =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Boruch Baum Cc: larsi@gnus.org, 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16202440306265 (code B ref 47784); Wed, 05 May 2021 19:48:02 +0000 Received: (at 47784) by debbugs.gnu.org; 5 May 2021 19:47:10 +0000 Received: from localhost ([127.0.0.1]:34076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leNUE-0001cz-1k for submit@debbugs.gnu.org; Wed, 05 May 2021 15:47:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leNU4-0001cZ-IT for 47784@debbugs.gnu.org; Wed, 05 May 2021 15:47:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59894) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leNTz-0003u1-7Q; Wed, 05 May 2021 15:46:55 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1389 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leNTt-0000ti-Ak; Wed, 05 May 2021 15:46:50 -0400 Date: Wed, 05 May 2021 22:46:35 +0300 Message-Id: <83bl9pezfo.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20210505194046.c6oofhqfdwdqew4p@E15-2016.optimum.net> (message from Boruch Baum on Wed, 5 May 2021 15:40:46 -0400) References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <83czu5f0vu.fsf@gnu.org> <20210505194046.c6oofhqfdwdqew4p@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 5 May 2021 15:40:46 -0400 > From: Boruch Baum > Cc: larsi@gnus.org, 47784@debbugs.gnu.org > > > "C-x 4 a" will automatically produce a ChangeLog-formatted buffer, > > from which you could copy the log message when you commit. > > Is this some new and 'backward-incompatible' behavior? It's new, but not backward-incompatible, I think. AFAIR it only happens when the buffer visits a versioned file. From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Eli Zaretskii Cc: larsi@gnus.org, Boruch Baum , 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16202886559708 (code B ref 47784); Thu, 06 May 2021 08:11:01 +0000 Received: (at 47784) by debbugs.gnu.org; 6 May 2021 08:10:55 +0000 Received: from localhost ([127.0.0.1]:36980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZ5y-0002WW-Vq for submit@debbugs.gnu.org; Thu, 06 May 2021 04:10:55 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:39478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZ5w-0002WO-Tm for 47784@debbugs.gnu.org; Thu, 06 May 2021 04:10:53 -0400 Received: by mail-wm1-f46.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso4796126wmh.4 for <47784@debbugs.gnu.org>; Thu, 06 May 2021 01:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=il6Fa0ruYVn65+lbcj4E4E87IGjDfcjV+0q/FIcFLwU=; b=gPs3BO+QaBiqdaFtKqgi5OZE6IeJ0UxZAHoEzywAHGCKZhonmV4Htmj1HDe2rR09Ji +IzOyOx0otqh7lvgZMJNN5VLqeXZP1suvcXDtva1x3GcxK/SLHfm9Im3/IfiRQkgRGou 6iMNIJbwXFl7da5QGNtKY2PwXGZBzpQeXvmprfZXXHTaq7xuRIwXdwN4OSI7i6KJRH1x 2U85XxHbTkczqnmN/CLB8kTbCmRQBtJhzxogFzgZv8DTduGhcvsqgkMQ6VUoZ9z0jBQR 5/bZ/A9k/YZfRK2Ktf9pLB3qOCNGztYy/RqIBYodfsOeLXyOrvPi8U2PBJOTVL//mMLM AyaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=il6Fa0ruYVn65+lbcj4E4E87IGjDfcjV+0q/FIcFLwU=; b=BXcTr4rM6dmGZiJQ7MAUAp92nnphPcDDLjwwIxmXTYMkCyyCGFQH4UrjJk1MpkqaRt bhugHlcs2/Vnk6l7dFc5kpsqnAdAWVvircN4ixOs+Rbx8ZUeQVUx1A2UXLOkFWY5JM7J CMJVGdkatdMeDJ/COYGRmk7A/+VvuyIKSsChhuSCoA55Jsd8wPKr5rsOTdNdqLR+5uxZ WW5Cm3tnYwudZOvcP6dRrmsbLzDfdubEwSDd2Oc2sc6d/f+l/m/lObhlJp8LM6nvhjwS Bpib/WZsBySkov7bDZ3Qx2O1VvW7MDC963/W0dLUp/rH4PyK//Myzjpu6uBRJQZd/chP dj5Q== X-Gm-Message-State: AOAM530fTKEqdwBs6Kq179ulH7M+h4DEFbI/C1x556rj9Xdb9emitoAE 14QsPrdyunzMPgUROXMD54Bu3AsJ9so= X-Google-Smtp-Source: ABdhPJwV6YclYX2zYksPen/ykNqnbHGmj2VY7W18veVOwP9tve6614Ts9Xp67Irb6WZ0dSeADYeQsQ== X-Received: by 2002:a05:600c:3643:: with SMTP id y3mr13564668wmq.159.1620288646625; Thu, 06 May 2021 01:10:46 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id t206sm2328434wmb.11.2021.05.06.01.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 01:10:45 -0700 (PDT) From: Robert Pluim References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <83czu5f0vu.fsf@gnu.org> <20210505194046.c6oofhqfdwdqew4p@E15-2016.optimum.net> <83bl9pezfo.fsf@gnu.org> Date: Thu, 06 May 2021 10:10:44 +0200 In-Reply-To: <83bl9pezfo.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 May 2021 22:46:35 +0300") Message-ID: <877dkc8epn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 05 May 2021 22:46:35 +0300, Eli Zaretskii said: >> Date: Wed, 5 May 2021 15:40:46 -0400 >> From: Boruch Baum >> Cc: larsi@gnus.org, 47784@debbugs.gnu.org >>=20 >> > "C-x 4 a" will automatically produce a ChangeLog-formatted buffer, >> > from which you could copy the log message when you commit. >>=20 >> Is this some new and 'backward-incompatible' behavior? Eli> It's new, but not backward-incompatible, I think. AFAIR it only Eli> happens when the buffer visits a versioned file. >From NEWS.27: *** New command 'log-edit-generate-changelog-from-diff', bound to 'C-c = C-w'. This generates ChangeLog entries from the VC fileset diff. *** Recording ChangeLog entries doesn't require an actual file. If a ChangeLog file doesn't exist, and if the new user option 'add-log-dont-create-changelog-file' is non-nil (which is the default), commands such as 'C-x 4 a' will add log entries to a suitable named temporary buffer. (An existing ChangeLog file will still be used if it exists.) Set the user option to nil to get the previous behavior of always creating a buffer that visits a ChangeLog file. If you use vc, then 'vc-checkin' will copy the log message from the ChangeLog to the commit log edit buffer for you (and that I think it=CA=BCs been doing for a long time). Robert --=20 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Boruch Baum Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16202890339989 (code B ref 47784); Thu, 06 May 2021 08:18:01 +0000 Received: (at 47784) by debbugs.gnu.org; 6 May 2021 08:17:13 +0000 Received: from localhost ([127.0.0.1]:36997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZC5-0002b3-Iq for submit@debbugs.gnu.org; Thu, 06 May 2021 04:17:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZC2-0002ax-MS for 47784@debbugs.gnu.org; Thu, 06 May 2021 04:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RhaIHUH5v+lz43M3isAA2Bs6/z4ZxuASXk6sba/Doh8=; b=O3OKNOIlT+vLKiUDTsC9Yw8QJL JuVdpplsYwbzyC2RKx5s1/9o8rDBMGBYW32EuKaciHR7nkwISoxOJyaJiWongbhzHt/TdivOJ+/ad sKyJD3/KHPEGugA0oIqhKiL6T6L4vOJNze1ONIzWV0Vj5sLcvHGkzKZLTRA1J6NQwHWE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZBt-0004qP-VK; Thu, 06 May 2021 10:17:04 +0200 From: Lars Ingebrigtsen References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUNDxEoQ1A3bYz/ //+S0I8SAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UFAgYqKy/uLrAAAAE/SURBVCjPhZDPasJAEMZn Q7bnFIxQz/WgTzEWc58tO0I8WTCF+BR5hBxKQU85JFL7lJ1ZVwy00D0s+5s/33yzALAmuB8D/539 6J18jaEf6+CvRvxL7R5FmMjtHXsJNaDKh9MwtOmsgTpAfUCYASwEltv6pLabqRTn1Se3MpLUfApu LZcoBBvfFT1gXMqc3xqDJguwOs9bA1ZErGYqAmPdtc75DMG4kTMTvigj0UW6ApCw6SECM+FzhJRZ lollWQhGQObXjxG4XuYEp4XBl85EsFLWxUxq3R2smqEb6CIiQI0ErfZ5dZ0g5KwOgMxOgk/HYaAb LMvqIpkswHzLR8lwon60hyZQlB2Kln9MxWXqWgWuuPAgaZ3yXggYZr/LAeqNZ7a8afXry1IkHE+p WgFMciyYD0W/57Cs9XzJ/YJ/ABgqU3MYWWtfAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTAy VDA2OjQyOjQzKzAwOjAwA/XC7gAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0wMlQwNjo0Mjo0 MyswMDowMHKoelIAAAAASUVORK5CYII= X-Now-Playing: Working Week's _Working Nights_: "Autumn Boy" Date: Thu, 06 May 2021 10:17:01 +0200 In-Reply-To: <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 5 May 2021 12:40:34 -0400") Message-ID: <87im3w2s5e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: >> So I fixed that up, but I've seen that in other patches -- could you >> have a look and see what's causing this mixture of tab and spaces? > > I could use a suggestion to automate that workflow: I [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: >> So I fixed that up, but I've seen that in other patches -- could you >> have a look and see what's causing this mixture of tab and spaces? > > I could use a suggestion to automate that workflow: I never use tabs, > but often find myself editing files that have them. As soon as it gets > annoying, I remember to perform untabify on the buffer, but there's > probably an accepted automated method to respect the tab/space > preferences of everyone. With the default Emacs settings, you should never end up with a space before a tab -- have you perhaps customised what the TAB key does here? In general, the default TAB function tries to respect the indentation style. (But it'll never insert a space before a tab.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 10:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162029618620398 (code B ref 47784); Thu, 06 May 2021 10:17:01 +0000 Received: (at 47784) by debbugs.gnu.org; 6 May 2021 10:16:26 +0000 Received: from localhost ([127.0.0.1]:37222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leb3S-0005Ic-AD for submit@debbugs.gnu.org; Thu, 06 May 2021 06:16:26 -0400 Received: from mout.gmx.net ([212.227.17.21]:40611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leb3Q-0005CV-Lc for 47784@debbugs.gnu.org; Thu, 06 May 2021 06:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620296178; bh=tYdYMylHhk1oU5jhQw1/xTmeHMTON0Eln8+Mi9ax5uI=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=QaeSUVK7MgUOafYlhD+YXKTWw8GwWb+FGiFxPCb9Rumlg9YuW063IK4dJjQfMnTez d5IqenvPoIS2zsm5LKOqj4xG395bH26Mmc/rDZb0V0sgLyD2JgTAxFOz9wVHM+9CrN K4F3DiqFCE4XL4a2cEvtLdsVUaogbeOwVmo6utbE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MVeMG-1m643R3xhc-00RXNf; Thu, 06 May 2021 12:16:18 +0200 Date: Thu, 6 May 2021 06:16:15 -0400 From: Boruch Baum Message-ID: <20210506101615.bkko5xqirskhvs2a@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <87im3w2s5e.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87im3w2s5e.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:SyXzcD1yvcpjZL82QKD7Fo/amftc5RSOEbJmoHOGu+LmzMs4D2w 7hdA95Y2JkPhl+m0WpEUtdI55FfTzU16xLnQg4FdTV/GUO0qAE25T3vWHpxj+l726IUzFbg anTz0JIC9S8dUFZi92CJ3vo9Hlulvt15MCjMvPgS7a1z/uQxfVITiSk/nlACDwg9UNEimoA t36W1a7WfVlbyaqbS7H3w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yduzHcKAxZI=:6uZo1jftFyk2tbuENH3cps Q9i8hMHsat7KwGbPWqoqwe71q2IdWpsNH6zjnHUXCX9oKSVaJxMoJQVJr6TQplkFoE1Zj2N3q TfE5OzwpsS+hgnNgYpQTAVt69FkGWoscigdJqmkBoHR8RywWGLdt/kqoEpJELZYQloJN1HhmA nTdtVAWfB/i2W2Dt5DnwnChnThQ30ATjx3sa2aghEv2YPi5A8lFIbMJ6IXEd9Qtynhxj+4vFg AIOpW1+0RJdNlp71TPPzEDYEEh8+gs+ZJ5fC6zkgTU8UH1qEe59vqgNKe9TKvedugz+qp1izp QVrk87KWQQwMoCyANZD9wb6jO5OiCytJHpGisSNpVBQQN4gkcWSoghaK/8QCK6FyjVAcsKNkI 8gZZUcgdIWI2UfTsgyFOOdH3XtQoEAYAfLMH/1d/XbHF/BMtWNoteY9iQwJ81YH8Cm+PmbCrG hyUwlGg52e2EPwAaaznbXvgzH34PZ7gMC7PdMUnaHzCiFLwniaBuhu/Lw9GKL1IGGVjtUFsqC +cUNMB/Oz7IQG9Xsw3tOMq75fAmLbDh7fTM37YKrEbLBD71DAen01RjXkkO/9eVNRhu5lKQ/g SYk7Vyn711pstZTOX0h9Uc9tkxgjsNkD4u02Mk7QGUFPpgVZrFujmIDTW/pBj7dlFf/9cUV77 bO6PPNzwSQg5UrUc7FVztKcpgMmt4jUk+gYcu58YHMSdTZft8sVobaWNYCF32HNvMPbfMW3nr tGB59LHYSJMOsOZzPhTdW8JIrzoUASgqkkN8ecnggsF1sRIPGy7BuuLxQOCyQzjGqK6v1vvz3 FHkBbYf1J9GD5M/k7l/PzywW+qyaRHfx2v7FAj/S8EWd6BvyNR7RzEZp5HEgD1oU79xSPJ4er MxZbOh3s3URcuJKQxDlJIiWv+Rhzmp9Huut2qwID6ZROZQCYjHf3HG0Z5+Nqzb0OF7TPZvMLn wbXzU5cdkx7Llm6kZX+1wxycBs1AoFhAsbj9Qu54nLtrwHJUa41cs/y9y+RGHGcZG1pWzl6/z WMtR/20Ey7FXKNqhbAE7EUqOrQ57O4btXyBDKj/UvOCNoJDTP6HC4Bx3UhzllHsYIaD0/sZ6Z pqqyVdXShYqS+uu1j9vhR8blDobAvdQ0KbvJEZiXeoYlxv+60dCjZOCxZMyr1ttyf/cH8LVbq ze396OHw265Ao+8a8uc9eT18b0tSx3UYSfTRsLDIrM4bGZzmVMuMcttHhHRoq2i+hREv0= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-06 10:17, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > >> So I fixed that up, but I've seen that in other patches -- could you > >> have a look and see what's causing this mixture of tab and spaces? > > > > I could use a suggestion to automate that workflow: I never use tabs, > > but often find myself editing files that have them. As soon as it gets > > annoying, I remember to perform untabify on the buffer, but there's > > probably an accepted automated method to respect the tab/space > > preferences of everyone. > > With the default Emacs settings, you should never end up with a space > before a tab -- have you perhaps customised what the TAB key does here? > In general, the default TAB function tries to respect the indentation > style. (But it'll never insert a space before a tab.) But I don't ever want a tab, ever, in any document that I work on, ever. If tabs are needed in order to be compatible with upstream then I'd want emacs to untabify on read and tabify on export. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 11:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Robert Pluim Cc: Eli Zaretskii , larsi@gnus.org, 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162029912819796 (code B ref 47784); Thu, 06 May 2021 11:06:02 +0000 Received: (at 47784) by debbugs.gnu.org; 6 May 2021 11:05:28 +0000 Received: from localhost ([127.0.0.1]:37395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebou-00059E-2X for submit@debbugs.gnu.org; Thu, 06 May 2021 07:05:28 -0400 Received: from mout.gmx.net ([212.227.17.21]:33199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebor-000595-8A for 47784@debbugs.gnu.org; Thu, 06 May 2021 07:05:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620299119; bh=c53fcHEUWuZJ4YO4opyqkkgfX2tQi/nho6Q35sYtg3Q=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=eyDp4gHydEUBCTt7JpS4c4Q6FIMvwVP2NWYQik3GRqO3fsRzFNanTyvZ+ssN3ttJz jrOF9fRmo2hZHKxdBkcHoO78pNe7Cnchm7g0JMgdZRkfTBfY6NIuDtTdtEIPrd0kx+ 4EeNGyM9Mu69ggedsw/ZICSljh/prRxTLxnVfev0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MUGiJ-1m49HB2HTf-00RFhr; Thu, 06 May 2021 13:05:18 +0200 Date: Thu, 6 May 2021 07:05:15 -0400 From: Boruch Baum Message-ID: <20210506110515.jemx5poua2ezav5d@E15-2016.optimum.net> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <83czu5f0vu.fsf@gnu.org> <20210505194046.c6oofhqfdwdqew4p@E15-2016.optimum.net> <83bl9pezfo.fsf@gnu.org> <877dkc8epn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877dkc8epn.fsf@gmail.com> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:ELgmAZJaQD81DxvvDrq3UiX+xBW6rAEc10FoQU5VdqAaRecJvdZ 6++ca6CXFVqc0NBQGsHN9zIEXemRX+ICnKN0OPEvmUh/3j+8JePi/AY1qfEretjCcD2JuPd tibVJN6/6F3QwnYctVpcwYjMc/yKNUlD8ZMTx/j7EnDvxfARvEVrALKR5BK1YDjHYDa4GYZ o/J4bjVdn27qE9GWCYanw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OKqRaGajiOo=:E4azQislvta7g63IXCNPSC eXV/ILD2bAs+nrS6LOalVoDUDKbhZvds60U64KhZvoKfylCnw+NOfxXkEMz3aM4Ww7k70ujYQ yiIu/W9yqasGsRarSYzhgF9IhckEuRjs6FT1AbXQC/j/ihCciXB/uqmYFEphGvA7qWq1tpwd9 6uNWnoE5yvAcMJ0UYicyG83YhydRuye3SwSofcbvlwafAkuwwx+KvSJxScNq/JWP+UVviCWco AbBtcnCU3Sl5WO7+yRM6b1MeylfeGkiw7NV5v8Bx2PdpgcLbhlYuYFd6VSM91pB3qOFKleCf+ ljudlsVAPNRDk6weIX/Tqnt3uMcFCcUD/oCRuyzAfI/lfhUv9jts3yKVw0w/BLjP93dQ78+5B ECy524/KjoIiVSeMG0uWWT1/8mL+ylgaXeAeUpO3qLg9HEWl1jv5AUrEpNP3a3gRftrA4NPDL gxlP2ESRbbFHXKviY67SS+ptoYoxNWr6852Z4ISHTSNcczfAl957sShRM2YgY0wXsfPeXfqaZ sIyIend+77Hs6vHuX1AYFueAfbrqcUastOPaxG881+O+qeg7poUcGHBzlSpDpBTPoifotOa6D UqvUmhe+ENRh77iGbTek9yLS2bsB8sXFefBSnScNl3I1vUkKeCDKbgGDwvAPCFVZejEsS3rCm tJw0bbR+vaHgmB7LQ/uU7T7I8rNHffoIfjVWscB1l+njEMVnyuCB+ZLgeKSUZ11eTT8OAq5EQ IwLnS8/a/W38pNSaU1XrFezahJfAPwtsEBhIOHqkKdpUQf9hYJnbwH9ysB9IM51Hfhes68UDU d/0kf5ES30tIK++ooqqND4+wdxN4hcxZRQSOrvLPf1ZUdb7iK6Oi1ZTyXNDC4OUy94VHPtXFE 5U31sRFTrOYJ86lh4Q+9EwQseA6K9buruqbYJDwH9S58n70SBXwOJ1/4rHOPMZbBYcEV9gLtf OHOSKRUXVe/4cSvukGmj9yolamxkrAVG+M9cALertCNKS73hcQdiixZVLDlZUD9zdcURE9pXr wpClNW4QAwHdgfhI0xFr2qK3lh73PHeLuuIrf41iJ1YLUqcbn3aiFngUrZwYnODE3SZJhRWRU IUaUkclWz+GFXuUiXMB10QJngVlHy8pF/6w2PXArGMyw33nX2/IrsI5QyoqjDtRonP1Z94zsB FT3iDjI8H/IQx9aBq6mMDv78Mg4CE2JIFZQ3zVxT0B/q487alq7aJT3LjAnUtZ2Kdpo3o= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-06 10:10, Robert Pluim wrote: > From NEWS.27: > ... Thanks, Robert! Very helpful pointers. And now that debian has finally bumped me to version 27.1, I really should read that NEWS file ... =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 04:09:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 11:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Boruch Baum Cc: 47784@debbugs.gnu.org Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162038605412850 (code B ref 47784); Fri, 07 May 2021 11:15:01 +0000 Received: (at 47784) by debbugs.gnu.org; 7 May 2021 11:14:14 +0000 Received: from localhost ([127.0.0.1]:43251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leyQv-0003LC-Rc for submit@debbugs.gnu.org; Fri, 07 May 2021 07:14:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leyQu-0003L4-TO for 47784@debbugs.gnu.org; Fri, 07 May 2021 07:14:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d62JquOe5Aer2w18GS/QBw53B/A/zBXm3mDRrJKovUg=; b=Uj/D12nrreIbPU5EG+uimivNzb 0tkcdhoklVf/hKIVE32TkSThYXvuS7M6Wu3WXz7mOQaiRiS7lEtoOSXhqufb7Qruh2H6wjolS3PYO NF8ktM6oHTHVA0De64LPW18P30/dlI7E1U2I8D5msHyU0X0c622XgSnwsE5ocWXzYc9w=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leyQl-0006iH-UG; Fri, 07 May 2021 13:14:06 +0200 From: Lars Ingebrigtsen References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <87mtt95nvf.fsf@gnus.org> <20210505164034.ri6mp7gefhz64ca2@E15-2016.optimum.net> <87im3w2s5e.fsf@gnus.org> <20210506101615.bkko5xqirskhvs2a@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAAIGNIUk0AAHomAACAhAAA+gAA AIDoAAB1MAAA6mAAADqYAAAXcJy6UTwAAAAMUExURZFsZ76Zl042MP///9rG5v0AAAABYktHRAMR DEzyAAAACXBIWXMAAFxGAABcRgEUlENBAAAAB3RJTUUH5QUHCwwSjDNG/QAAAF50RVh0UmF3IHBy b2ZpbGUgdHlwZSA4YmltAAo4YmltCiAgICAgIDI4CjM4NDI0OTRkMDNlZDAwMDAwMDAwMDAxMDAy NTgwMDAwMDAwMTAwMDEwMjU4MDAwMDAwMDEwMDAxChDG9fMAAAFJSURBVCjPbdDNasJAEAfw6WIl 7ElLc7CnWlqRfQopKnRPaUgEPRfBPsUqCrI3SwvqKQlWNvOUnc33oXtI9sf+Z7IZgHrdNvbAmtBN iMZeIXTo1YqyEoQQwGHGghMC4Ho4KhCOhMnCwiJA41mgxQwjb1PCR+Ub28xCIiY4pHrbjZ6IDtUT PE4HdIIWI4dfEQ3L0d5+U8yGIYCn34DywoK+nMqsR45YSjQFWCyzhjmMwCKGRXGOxsqg/8dWX+vY dnGpYEI/rrALZ2nV2qUZsBIBTWdTYtzx6tYd8CjG6aKCw33X+2hh8DM49V4J7uCCKzk9pALcd/dl jOPP9nm+gF7XXV5w+rA8HxC+Dmwykatd/23u21uLpPELNaJE6UdIIg2cw+b5BmLF9XGlJUQnuFuv E90+Etg+2vc5U0NHUYwKy8GBQSUqICpe4g/cmeV5+ShmDAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAy MS0wNS0wN1QxMToxMjoxOCswMDowMKJgDgoAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUtMDdU MTE6MTI6MTgrMDA6MDDTPba2AAAAAElFTkSuQmCC X-Now-Playing: Mikel Rouse's _Swingers Castle_: "The Pop Machine" Date: Fri, 07 May 2021 13:14:03 +0200 In-Reply-To: <20210506101615.bkko5xqirskhvs2a@E15-2016.optimum.net> (Boruch Baum's message of "Thu, 6 May 2021 06:16:15 -0400") Message-ID: <87h7jevls4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > But I don't ever want a tab, ever, in any document that I work on, ever. That's counter to how Emacs sources are (and should remain). We use a mix of tabs and spaces (but the spaces are after the tabs). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > But I don't ever want a tab, ever, in any document that I work on, ever. That's counter to how Emacs sources are (and should remain). We use a mix of tabs and spaces (but the spaces are after the tabs). > If tabs are needed in order to be compatible with upstream then I'd want > emacs to untabify on read and tabify on export. I don't think there's any such functionality in Emacs, but it shouldn't be difficult for you to hack up something like that to fix up your patches. It would be easier if you just didn't change your tab/space settings when you work on Emacs sources, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no