From unknown Fri Aug 15 04:04:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#47781 <47781@debbugs.gnu.org> To: bug#47781 <47781@debbugs.gnu.org> Subject: Status: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive Reply-To: bug#47781 <47781@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:04:45 +0000 retitle 47781 28.0.50; (window-list-1 nil t) returns nil when minibuffer is= inactive reassign 47781 emacs submitter 47781 marmot-te severity 47781 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 14 20:12:02 2021 Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 00:12:02 +0000 Received: from localhost ([127.0.0.1]:36039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWpc1-0001Og-Ml for submit@debbugs.gnu.org; Wed, 14 Apr 2021 20:12:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:50856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWpbx-0001OQ-4k for submit@debbugs.gnu.org; Wed, 14 Apr 2021 20:11:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWpbw-0007s2-PD for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 20:11:56 -0400 Received: from mx1.riseup.net ([198.252.153.129]:54622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWpbu-0003Di-1H for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 20:11:56 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FLKX56c4dzDqCG for ; Wed, 14 Apr 2021 17:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1618445509; bh=zuk+dzcJB6Zrm+oKIoKJ8akqrcAsTNba72Y+Rq/dsR0=; h=From:To:Subject:Date:From; b=JUKH9cCQuEYlJdAhT00Qk5tN4afkbpfW/Y75+j+dy7pcqfC1FKp6GaRlRRu6BPPhO yw5UxHSi4aQ/EAQgCWPn801pNP5bQEhS7kUFMHqIv08R6cnsYq7H/K5MHRoasJPPEj xE7dH09FAEhUbx8+MYFVrnv1XEhWDG7mW4AJCou4= X-Riseup-User-ID: AF126D4ED102BB2A9360C0CD08BDD9792722AA07281BC1D1054EC98EF79E7BDD Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FLKX50kGnz5vS1 for ; Wed, 14 Apr 2021 17:11:48 -0700 (PDT) From: marmot-te To: bug-gnu-emacs@gnu.org Subject: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive Date: Thu, 15 Apr 2021 00:11:34 +0000 Message-ID: <87czuw9zk9.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=198.252.153.129; envelope-from=marmot-te@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, I read from the docstring of the function > MINIBUF t means consider the minibuffer window even if the > minibuffer is not active However, with emacs -Q and the minibuffer inactive (window-list-1 nil t) ;; => nil I think this is related to this build since I cannot reproduce with emacs 26.1 (in this case it returns the list of windows, minibuffer included, as expected). In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2021-02-09 built on debian-10-gccemacs Repository revision: 1f626e9662d8120acd5a937f847123cc2b8c6e31 Repository branch: native-comp Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/native_comp/28.0.5:/usr/local/share/emacs/site-lisp --with-mailutils --with-sound=yes --without-gconf --without-gsettings --with-x=yes --without-toolkit-scroll-bars --with-x-toolkit=gtk3 --with-xwidgets --with-json --with-nativecomp 'CFLAGS=-O2 -Wall '' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US locale-coding-system: utf-8 Major mode: Org Minor modes in effect: flyspell-mode: t shell-dirtrack-mode: t electric-pair-mode: t eros-mode: t gcmh-mode: t recentf-mode: t global-flycheck-mode: t flycheck-mode: t engine-mode: t dired-async-mode: t ws-butler-global-mode: t ws-butler-mode: t global-so-long-mode: t global-undo-tree-mode: t undo-tree-mode: t counsel-mode: t ivy-rich-mode: t ivy-mode: t winner-mode: t show-paren-mode: t which-key-mode: t global-subword-mode: t subword-mode: t global-auto-revert-mode: t save-place-mode: t delete-selection-mode: t savehist-mode: t override-global-mode: t global-eldoc-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: /home/user/.emacs.d/elpa/lispy-20210121.926/elpa hides /home/user/.emacs.d/elpa/ivy-20210311.1638/elpa Features: (shadow sort mail-extr emacsbug sendmail two-column sh-script smie executable flyspell ispell org-element avl-tree ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader ol-docview doc-view image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ob-lisp ob-shell org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs olivetti gnutls network-stream url-http mail-parse rfc2231 url-gw nsm rmc url-cache url-auth cl-print debug crux tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 ls-lisp elisp-demos mule-util jka-compr cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs helpful imenu trace info-look elisp-refs windmove elec-pair cursor-sensor form-feed eros gcmh recentf tree-widget flycheck f dash s 18_pdf 17_mail gnus-win 16_elfeed 15_www eww url-queue shr kinsoku svg xml dom puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums time-date mail-utils mm-util mail-prsvr engine-mode format-spec 14_qubes epa-file epa derived epg epg-config 13_checkers 12_dired dired-async async dired-aux 11_shells 10_registers-and-bookmarks 09_languages cl-indent 08_editor ws-butler so-long undo-tree diff lispy ivy-avy counsel xdg dired dired-loaddefs compile text-property-search comint ansi-color swiper ivy-rich ivy ivy-faces ivy-overlay colir color lispy-inline thingatpt avy noutline outline etags fileloop generator xref project edebug backtrace help-fns radix-tree lispy-tags mode-local find-func 07_buffers-and-windows pcase winner ibuf-macs 06_completion 05_theme-customizations tao-yin-theme tao-theme paren 04_helpers hydra ring lv which-key advice 03_bindings edmacro kmacro 02_defaults comp comp-cstr warnings rx cap-words superword subword autorevert filenotify saveplace delsel savehist no-littering cl-extra help-mode cus-edit pp cus-start cus-load wid-edit use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf info package easymenu browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib chemacs iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 719060 139046) (symbols 48 44214 40) (strings 32 196396 14373) (string-bytes 1 7066646) (vectors 16 69368) (vector-slots 8 1910643 69822) (floats 8 502 513) (intervals 56 3871 4659) (buffers 984 25)) -- <:3nn~~ <:3nn~~ <:3nn~~ From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 04:10:32 2021 Received: (at 47781) by debbugs.gnu.org; 15 Apr 2021 08:10:32 +0000 Received: from localhost ([127.0.0.1]:36436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWx55-0004zV-G2 for submit@debbugs.gnu.org; Thu, 15 Apr 2021 04:10:31 -0400 Received: from mout.gmx.net ([212.227.17.20]:40257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWx53-0004zI-4j for 47781@debbugs.gnu.org; Thu, 15 Apr 2021 04:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618474220; bh=bUI65IDABbRRjEndlYYEPZ8kZougGWS61sjBxkiiiqU=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=VlJghe+e4/9XS57Jc1hxWnTcgbu5LCwbclS5JMuqWGa1jx0dVdO2LWohqQzq/2ohk AeMAaJlj6kV79YhcC8x2D1m7edsISl0Hh0/FLsCaCNMWqTyj41P4AgcNSH1JYKHu2c knU8NCNF3Up4YRgFD2G1BYs3JuprOp4u3/oaOahY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.198]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McH9Y-1m77F134Iu-00cgv8; Thu, 15 Apr 2021 10:10:19 +0200 Subject: Re: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive To: marmot-te , 47781@debbugs.gnu.org References: <87czuw9zk9.fsf@host.localdomain> From: martin rudalics Message-ID: Date: Thu, 15 Apr 2021 10:10:17 +0200 MIME-Version: 1.0 In-Reply-To: <87czuw9zk9.fsf@host.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:YimFL8yESc3wKKFW1PkwjOvqIzXtGvlj67NpFeUCJw0k5HIQI4S NvsnRjDwPk0/oyvzEW14y7v3QTnJ2Qm79x+bpzPlS5HX7Gs2xDpUsT0LHm6iW7j1hZefr5K FVH8iwkK++jtFZaiU6cItI5mVxUPhs9FzQfMxtgAHnsN0DtNjaRXFgEk9WAzmB20V2hZwGX Mn4l7v+yA39V0qpUlkYsw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0RO+PHffGBc=:uTKoqjHWmZO+WcxIKBdJup v/lXdfrrbx7WhBbVh6W4lTjXDEKkG+YMqeodt26mkkP5MXpV/Rcm/ZnbQ/dLPttwM/TP86/H3 iNVDQx/Plns1H/YKrZOiDLeLJu5ewOzZuiCNK+g9V/by2qQkH5oAFyIP6wI6gfMC1IVBBhHU8 fXZTmxwurrrE1K82UCGnhC2TbLidMQAvTTSHbVmRsPrS7BPvGPyZMQjyAF/jEn9Deg/5HIozy s3CZmuVzDTQeLbMpNrHdSyOoErl7KxE8Q/O1iNzacEsH9mboRAu+ituhnPVGu6A/SgwnHouBO iFFVDbzZoEk4eD9WbVu9iWU8f6DO508FHcqMJM0KkKaPIqFbxYCa04Wkh7TOLDEB3X11X0w9X vIUrfbQnDD7HgWshiNSbuX9ee/Z317KsCbV82HmTj4aZPMjsiC2JT5S8+F/XAnpW9OybQk+Te s4wFHU+pr3OKFiRHuSnAc5tUg/YLmdjHcOFSxIGe2UInaIWtUl6i0E61zNJmGKGtMOoG5I+S7 6+nZPQGiosL4z+wVE1ocXDj12it7DFlWOp4N1OCQKVyYzteNsA5VV2W+Tw+phuiFF2zdulP6m OP23Y9N3cIWgGfyXooUbrOQMudQYBLX8EQZTjO7QtNRSghq6P8UliTyITGaqsHoleWgYqvRhP N/Ow3Zz4PVzgdMQjyUdPT2UWZUrgEFG+x5pDcc32WMmJVTPwpu/CeN5/YW70p8r1KIyJTtlzw u6fDA6ulLxpqSZa8YTn71dIBpxRjO0cRR6Ic9WdKDyjZ7re5ncoTXQimOzNSnu9CFXmGltwvE eZZW7dQW0LypX+846p1Zy6y/moZGcOrpiTLqTcGY7OFcoTQc6vAr53haaGZIc5QhkztrVysv7 x1NlNx6tq80PN+MmJf0/0+mNPcFmUbP5gSdIBeapa6f52t0frf0TcmosVlps+cuZEAjzZJFn6 RIOwJU8263RJjyeUpJgbz5KcE5DXls2k9cyfUo8l9vcJmTIAeTrMYE4jXeDfzcfhMgpVrFWSf fysu65PSO7mlBeUdxS+5nNeQ956nsiE4I0FV5qnjtXnw+5Opx9wP2t4gQJ5gs5CTiNM629SwF CvaXIShKbR/S2SybcdN5RMx8BMMtfqJCAbnJSKA8TdvDG5ylwDaOhx/GMvPDM+zt/NjULxDhI 0W3pUq2luEdZnKeQvPQ/fgvRHoun97pSoAKaAsEQdxFHDoyT2oyD8q66L06KZDQZqqFNtd3WB XbQcRIfimJ5d+0Ndw X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I read from the docstring of the function >> MINIBUF t means consider the minibuffer window even if the minibuffer is not active > > However, with emacs -Q > and the minibuffer inactive > > (window [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.198 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 47781 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I read from the docstring of the function >> MINIBUF t means consider the minibuffer window even if the minibuffer is not active > > However, with emacs -Q > and the minibuffer inactive > > (window [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.198 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders > I read from the docstring of the function >> MINIBUF t means consider the minibuffer window even if the minibuffer is not active > > However, with emacs -Q > and the minibuffer inactive > > (window-list-1 nil t) > ;; => nil > > I think this is related to this build since I cannot reproduce with emacs 26.1 (in this case it returns the list of windows, minibuffer included, as expected). > > > In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) > of 2021-02-09 built on debian-10-gccemacs This is likely broken since a change in candidate_window_p from last year, see commit 2ecbf4cfae7bd504fbdca28e1e51ee2574fe5d12 (waiting for Gregory's confirmation). Since `window_list_1' is consulted in quite a number of places, the behavior of Emacs might be slightly unpredictable in this area. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 04:38:55 2021 Received: (at 47781) by debbugs.gnu.org; 15 Apr 2021 08:38:55 +0000 Received: from localhost ([127.0.0.1]:36476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWxWZ-0005gR-7a for submit@debbugs.gnu.org; Thu, 15 Apr 2021 04:38:55 -0400 Received: from heytings.org ([95.142.160.155]:39008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWxWU-0005gG-FK for 47781@debbugs.gnu.org; Thu, 15 Apr 2021 04:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618475928; bh=Dn8Meqo7V9Wp81AKZv12/u427OW8/0t9urZkRCXuV1A=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=El07Ev/RuXeD9rH4ROSE7xZVCtLa7yTLdzUd1po15iPT4sbZkLovrGUT1VnfLHkcd Jo5T8QsZRfO8hNpPXFdKAfmSs+/2owimh9MVZuUN3bV23kscyh0zWA9EO60QprAy6C QTHsoOVjmzHVALdn/SG6XfMr42LiX4MlYrUSW7iybV/q79VChyT5xoDigX6+tMrGcd +GZn6X6GLv2Jy6FzMwT7o9cjTcvhZmDwfjYBIAUv6naCGsD0rPJCJPN5h/6jWvYypJ GvkW1FDC1ef5d1tSs+5XxeoYGFGAH3OwuGhQvEMFHziqXnzxg82LIlPkg+IvbCYcVF zy6v0lk4MnaxA== Date: Thu, 15 Apr 2021 08:38:48 +0000 From: Gregory Heytings To: martin rudalics Subject: Re: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive In-Reply-To: Message-ID: <3ed97a9c531e42a5c986@heytings.org> References: <87czuw9zk9.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47781 Cc: 47781@debbugs.gnu.org, marmot-te X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > This is likely broken since a change in candidate_window_p from last > year, see commit 2ecbf4cfae7bd504fbdca28e1e51ee2574fe5d12 (waiting for > Gregory's confirmation). > I confirm. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 16 13:49:06 2021 Received: (at 47781) by debbugs.gnu.org; 16 Apr 2021 17:49:06 +0000 Received: from localhost ([127.0.0.1]:41599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSaY-0003sG-Cg for submit@debbugs.gnu.org; Fri, 16 Apr 2021 13:49:06 -0400 Received: from colin.muc.de ([193.149.48.1]:57173 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lXSaV-0003rh-TY for 47781@debbugs.gnu.org; Fri, 16 Apr 2021 13:49:05 -0400 Received: (qmail 13311 invoked by uid 3782); 16 Apr 2021 17:48:56 -0000 Received: from acm.muc.de (p4fe15aa2.dip0.t-ipconnect.de [79.225.90.162]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 16 Apr 2021 19:48:56 +0200 Received: (qmail 32750 invoked by uid 1000); 16 Apr 2021 17:48:56 -0000 Date: Fri, 16 Apr 2021 17:48:56 +0000 To: marmot-te Subject: Re: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive Message-ID: References: <87czuw9zk9.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87czuw9zk9.fsf@host.localdomain> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47781 Cc: 47781@debbugs.gnu.org, martin rudalics , Gregory Heytings , acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Marmot-Te. On Thu, Apr 15, 2021 at 00:11:34 +0000, marmot-te wrote: > Hi, > I read from the docstring of the function > > MINIBUF t means consider the minibuffer window even if the > > minibuffer is not active > However, > with emacs -Q > and the minibuffer inactive > (window-list-1 nil t) > ;; => nil > I think this is related to this build since I cannot reproduce > with emacs 26.1 (in this case it returns the list of windows, > minibuffer included, as expected). > In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.5, cairo version 1.16.0) > of 2021-02-09 built on debian-10-gccemacs > Repository revision: 1f626e9662d8120acd5a937f847123cc2b8c6e31 > Repository branch: native-comp > Windowing system distributor 'The X.Org Foundation', version > 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) [ .... ] I think the following patch, to .../src/window.c, fixes it: diff --git a/src/window.c b/src/window.c index caf9df6c13..23eb802950 100644 --- a/src/window.c +++ b/src/window.c @@ -2633,7 +2633,8 @@ candidate_window_p (Lisp_Object window, Lisp_Object owindow, candidate_p = ((EQ (XWINDOW (all_frames)->frame, w->frame) || (EQ (f->minibuffer_window, all_frames) && EQ (XWINDOW (all_frames)->frame, FRAME_FOCUS_FRAME (f)))) - && !is_minibuffer (0, XWINDOW (all_frames)->contents)); + && (EQ (minibuf, Qt) + || !is_minibuffer (0, XWINDOW (all_frames)->contents))); else if (FRAMEP (all_frames)) candidate_p = EQ (all_frames, w->frame); .. Please feel free to try it out, and let us know how well it works. Thanks! > -- > <:3nn~~ > <:3nn~~ > <:3nn~~ -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 17:29:13 2021 Received: (at 47781) by debbugs.gnu.org; 19 Apr 2021 21:29:13 +0000 Received: from localhost ([127.0.0.1]:52272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYbSD-0008Oe-Hn for submit@debbugs.gnu.org; Mon, 19 Apr 2021 17:29:13 -0400 Received: from mx1.riseup.net ([198.252.153.129]:44336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYbSB-0008OR-Vf for 47781@debbugs.gnu.org; Mon, 19 Apr 2021 17:29:12 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FPKh20LJkzDxfn; Mon, 19 Apr 2021 14:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1618867746; bh=f8ESRq+Ihw0jtRcu3fdjKaVryCAHaVaRLd1dUH14pcA=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=maBNuq2Tr8Gi8gkbED5jiv2j3tCx2jAg+/Wc8zOwNH8S9wjYP9GLmzzGAdYUpo08l ENzeadC232LnXMpRSjTtwjDfRIgAmtmm/P1jEDC3jDXyxNQowHKhbVNYHZiJgRakwY TbQAnp1IoR6gLRHlbc2tmaYCG4YyBgwRIQKjfDI8= X-Riseup-User-ID: 3D9AD94D7C8387AF4386F46F9D906860D9C5DBDFCA54832E18413DB3DDD6F72B Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FPKgz5C6xz5w5t; Mon, 19 Apr 2021 14:29:03 -0700 (PDT) References: <87czuw9zk9.fsf@host.localdomain> From: marmot-te To: Alan Mackenzie Subject: Re: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive In-reply-to: Date: Mon, 19 Apr 2021 21:28:10 +0000 Message-ID: <87blaa9d79.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 47781 Cc: 47781@debbugs.gnu.org, martin rudalics , Gregory Heytings , marmot-te X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Alan Mackenzie writes: > Hello, Marmot-Te. > > On Thu, Apr 15, 2021 at 00:11:34 +0000, marmot-te wrote: > >> Hi, > >> I read from the docstring of the function >> > MINIBUF t means consider the minibuffer window even if the >> > minibuffer is not active > >> However, >> with emacs -Q >> and the minibuffer inactive > >> (window-list-1 nil t) >> ;; => nil > > [ .... ] > > I think the following patch, to .../src/window.c, fixes it: > > [ ... ] > > .. Please feel free to try it out, and let us know how well it > works. > Thanks! Hi again, I just compiled the latest native-branch with your patch and can confirm that after testing the different clauses of MINIBUF, all works as expected. Thanks ! -- <:3nn~~ <:3nn~~ <:3nn~~ From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 06:59:02 2021 Received: (at 47781-done) by debbugs.gnu.org; 20 Apr 2021 10:59:02 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYo5t-0001Vu-VE for submit@debbugs.gnu.org; Tue, 20 Apr 2021 06:59:02 -0400 Received: from colin.muc.de ([193.149.48.1]:59511 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lYo5s-0001VR-ET for 47781-done@debbugs.gnu.org; Tue, 20 Apr 2021 06:59:01 -0400 Received: (qmail 60751 invoked by uid 3782); 20 Apr 2021 10:58:53 -0000 Received: from acm.muc.de (p4fe15986.dip0.t-ipconnect.de [79.225.89.134]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 20 Apr 2021 12:58:53 +0200 Received: (qmail 25578 invoked by uid 1000); 20 Apr 2021 10:58:52 -0000 Date: Tue, 20 Apr 2021 10:58:52 +0000 To: marmot-te Subject: Re: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive Message-ID: References: <87czuw9zk9.fsf@host.localdomain> <87blaa9d79.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blaa9d79.fsf@host.localdomain> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, Marmot-Te. On Mon, Apr 19, 2021 at 21:28:10 +0000, marmot-te wrote: [ .... ] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email X-Debbugs-Envelope-To: 47781-done Cc: 47781-done@debbugs.gnu.org, martin rudalics , Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Marmot-Te. On Mon, Apr 19, 2021 at 21:28:10 +0000, marmot-te wrote: [ .... ] > Hi again, > I just compiled the latest native-branch with your patch and can > confirm that after testing the different clauses of MINIBUF, all > works as expected. > Thanks ! Thank you for the testing! I have now committed the patch to the Emacs master branch, and I'm closing the bug with this post. > -- > <:3nn~~ > <:3nn~~ > <:3nn~~ -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Aug 15 04:04:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 May 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator