GNU bug report logs - #47778
[PATCH]: Update FreeCAD to 0.19.1

Previous Next

Full log

Message #8 received at 47778 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 47778 <at> debbugs.gnu.org
Subject: Re: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 23:39:14 +0200

[Message part 1 (text/plain, inline)]

On Wed, 2021-04-14 at 15:59 +0000, Ekaitz Zarraga wrote:
> Hi,
> 
> This set of patches update freecad from unstable to the 0.19.1 release.
> 
> More information in this help-guix thread:
> 
> https://lists.gnu.org/archive/html/help-guix/2021-04/msg00118.html
> 
> Thanks!

+       `(#:tests? #f
Why's that?  ‘We’ prefer to have tests enabled when possible.
Please document why tests are disabled here (with a comment
#:tests? #f ; no tests / tests require dependency X, which is not packaged ...).

+         (add-before 'configure 'restore-pythonpath
+           (lambda _
+             (substitute* "src/Main/MainGui.cpp"
+               (("_?putenv\\(\"PYTHONPATH=\"\\);") ""))
+             #t))

The #t can be removed.  The warning that results when #t is absent
has been removed on the core-updates branch; we might as well stop
introducing these silly #t now such that we don't have to remove them
later.

Greetings,
Maxme.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.