From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 14 08:53:58 2021 Received: (at submit) by debbugs.gnu.org; 14 Apr 2021 12:53:58 +0000 Received: from localhost ([127.0.0.1]:33895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWf1q-0006zu-IZ for submit@debbugs.gnu.org; Wed, 14 Apr 2021 08:53:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:42954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWf1m-0006zi-KK for submit@debbugs.gnu.org; Wed, 14 Apr 2021 08:53:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWf1m-0002ZE-2c for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 08:53:54 -0400 Received: from server.qxqx.de ([2a01:4f8:121:346::180]:52611 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWf1j-00083g-Ni for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 08:53:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:To:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7mMIy2Nl/mpx/4mLqSv+nUFrhKDa+/et7CITnH3D5R0=; b=UeE3BpocVMJ0ZDIgjxGA01NJ3+ WQZLmpi5oSOWs0aq1r3iMhxPRX4P/uAnKgpg+8mhFDweI/jvbv4gV9K+DBC+QXI29wmb3oTriiyhE GvqHvQzQ/Zy7aDCrKCXoEqL9gv+xCS0lWRWSxJj8AFWJApbgyCLN7RgOsT5XS5n/DlT4=; To: bug-gnu-emacs@gnu.org From: Daniel Mendler Subject: 27.1; `Info-read-node-name` throws error during completion Message-ID: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> Date: Wed, 14 Apr 2021 14:53:46 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The function `Info-read-node-name` uses the `Info-read-node-name-1` completion table. The completion table calls `Info-find-file`, which may throw a `user-error` "Info file ... does not exist". Icomplete (and many other completion systems) makes the assumption that completion tables do not fail. Furthermore, completion tables already have a mechanism to report missing completions by returning nil and printing a message. The issue can be reproduced as follows in emacs -Q: 1. M-x icomplete-mode 2. Press "C-h i" 3. Press "g" to run `Info-goto-node` 4. Enter "(boom)" 5. Move around with the cursor left to right or wait until the `icomplete-post-command-hook` fails. In order to fix the issue, the following patch can be applied: diff --git a/info.el b/info-patched.el index 3bed743..42a7fce 100644 --- a/info.el +++ b/info-patched.el @@ -1881,7 +1881,8 @@ See `completing-read' for a description of arguments and usage." (lambda (string pred action) (complete-with-action action - (Info-build-node-completions (Info-find-file file1 nil t)) + (let ((file2 (Info-find-file file1 'noerror t))) + (and file2 (Info-build-node-completions file2))) string pred)) nodename predicate code)))) ;; Otherwise use Info-read-node-completion-table. Alternatively wrap the whole line by `ignore-errors`. The downside of ignoring the error is that now the default completion system error message becomes slightly less meaningful. It shows "No matches" instead of "Info ... not found". In case it is desired to retain the better error messages, a discussion is needed on how completion tables could report their matching failure. Here it is probably sufficient to demote the error to a message. diff --git a/info.el b/info-patched.el index 3bed743..c38abd7 100644 --- a/info.el +++ b/info-patched.el @@ -1881,7 +1881,8 @@ See `completing-read' for a description of arguments and usage." (lambda (string pred action) (complete-with-action action - (Info-build-node-completions (Info-find-file file1 nil t)) + (with-demoted-errors "%S" + (Info-build-node-completions (Info-find-file file1 nil t))) string pred)) nodename predicate code)))) ;; Otherwise use Info-read-node-completion-table. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2021-02-09, modified by Debian built on 3df710f593d9 Repository revision: b0229d4bbaea7fcddffced393512c650212830db Repository branch: deb/emacs/d/sid/master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: Mark set [2 times] Auto-saving...done Mark set [3 times] next-line: End of buffer Mark set Icomplete mode enabled Error in post-command-hook (icomplete-post-command-hook): (user-error "Info file emacs does not exist") Quit From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 05:10:00 2021 Received: (at control) by debbugs.gnu.org; 19 Apr 2021 09:10:00 +0000 Received: from localhost ([127.0.0.1]:48416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYPuq-0002d5-AH for submit@debbugs.gnu.org; Mon, 19 Apr 2021 05:10:00 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:33654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYPuo-0002cr-4G for control@debbugs.gnu.org; Mon, 19 Apr 2021 05:09:58 -0400 Received: by mail-pl1-f176.google.com with SMTP id n10so6193196plc.0 for ; Mon, 19 Apr 2021 02:09:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=y+bC1HiDfaRLwh6smRmqdGnFWXFRgJU33GRLGQ/dM5o=; b=jNyA2dUezqNqWSZ/iT3LYCim1fRUI5RFgazPISYAJ4iIteCCbv1Td1baiBFdcTk7HN BmSyAUQUo6io9AZUsyNeZ8tHrTY1oKZN6HtNaYwys+EGjJGiibmg1lVsJcQXsAHstV0W IEvgolyPn7RDlC2RoVIJmtEhHwBWaoO0fbj1UWK/w+pGFzNRIEiwXf+I9JN1+DE7y/bj xzJWKb2AYKjFlzsZvMIDG0HrAgE0eukVh6Q4lWrPY4piOaL7SRRvtPlYXIW3mbtQJN5S 39aRPUDfpkn93Jg4jYHY18MimJ5MBS1eSch7i1RiUhoRvZcM7BkuyvHK9/mv8H4Mo5FY I+vQ== X-Gm-Message-State: AOAM530Jb5bSQNLSGiNah+Czs2C+n/GXRfcJCLRnST+nfPIXSXdyGCw7 sEu2wqkQQvVi8DkdOpJ0JO06wWfWhUTwqakkyDZsiQeB X-Google-Smtp-Source: ABdhPJw2FE3hg8gkRMsnGHt8WMEAHp2wID1q7WN3+7zmSWNOuJvMeqt/4fqI2Uoup5HlVjnkX/PWIzX1nyh2iWQW/z4= X-Received: by 2002:a17:902:7788:b029:e9:11:5334 with SMTP id o8-20020a1709027788b02900e900115334mr21981712pll.70.1618823392334; Mon, 19 Apr 2021 02:09:52 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Apr 2021 04:09:51 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 19 Apr 2021 04:09:51 -0500 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47771 confirmed severity 47771 minor thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.214.176 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.214.176 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 47771 confirmed severity 47771 minor thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.214.176 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.214.176 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines tags 47771 confirmed severity 47771 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 10:59:20 2021 Received: (at 47771) by debbugs.gnu.org; 5 May 2021 14:59:20 +0000 Received: from localhost ([127.0.0.1]:60780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIzg-0004kv-67 for submit@debbugs.gnu.org; Wed, 05 May 2021 10:59:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIzd-0004kk-3W for 47771@debbugs.gnu.org; Wed, 05 May 2021 10:59:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ufl1kfKJhQuTqCL2gzKsqObQBpU+QutBTNcZ7C3d7Xw=; b=WZmp6I1iqQOLSWtLoo2N7pMeYP 27zGOH4KRU0Wt5VydD0SJ+zY7phoR5GccZ+HUUcjgqcPg/Tt3QuMBHvsjFIGFmnRfMdD4Ot9l+epW InEUiKTQszPLTz1Jfz0k7RBK60Sx/e7Ariv3bLPuYO9mAwAXtlduMHci2cqh6Lm+YHvg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leIzU-0002Vj-6b; Wed, 05 May 2021 16:59:10 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#47771: 27.1; `Info-read-node-name` throws error during completion References: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> X-Now-Playing: Chrome Hoof's _Pre-Emptive False Rapture_: "Astral Suicide" Date: Wed, 05 May 2021 16:59:07 +0200 In-Reply-To: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> (Daniel Mendler's message of "Wed, 14 Apr 2021 14:53:46 +0200") Message-ID: <87zgx94478.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > 1. M-x icomplete-mode > 2. Press "C-h i" > 3. Press "g" to run `Info-goto-node` > 4. Enter "(boom)" > 5. Move around with the cursor left to right or wait until the > `icomplete-post-command-hook` f [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47771 Cc: 47771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mendler writes: > 1. M-x icomplete-mode > 2. Press "C-h i" > 3. Press "g" to run `Info-goto-node` > 4. Enter "(boom)" > 5. Move around with the cursor left to right or wait until the > `icomplete-post-command-hook` fails. > > In order to fix the issue, the following patch can be applied: > > diff --git a/info.el b/info-patched.el > index 3bed743..42a7fce 100644 > --- a/info.el > +++ b/info-patched.el > @@ -1881,7 +1881,8 @@ See `completing-read' for a description of > arguments and usage." > (lambda (string pred action) > (complete-with-action > action > - (Info-build-node-completions (Info-find-file file1 nil t)) > + (let ((file2 (Info-find-file file1 'noerror t))) > + (and file2 (Info-build-node-completions file2))) Thanks; applied to Emacs 28 (with some minor changes). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 10:59:24 2021 Received: (at control) by debbugs.gnu.org; 5 May 2021 14:59:24 +0000 Received: from localhost ([127.0.0.1]:60783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIzk-0004l8-EP for submit@debbugs.gnu.org; Wed, 05 May 2021 10:59:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIzj-0004kp-9d for control@debbugs.gnu.org; Wed, 05 May 2021 10:59:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5z6RfaagxBUCC7fEMXoXvh1+t1RnjoYfd6RHIWmiqz8=; b=i8C+l6nPAgPs8j4Z5ZwMiUQ7Jq pktBXiDQcl7eX14zcwKMWFq7MFkMs0GgatOcCfQ6cJuAjydNCnoa3EfYf5SZHsmSEV6gpBBozU/AR GsEPRxmws5c64TW1hJXswm3fnk7Pj/LX+oHNbuUvWnDl/+qewfug+alpMVF+nQzR6JjA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leIzb-0002Vx-NE for control@debbugs.gnu.org; Wed, 05 May 2021 16:59:17 +0200 Date: Wed, 05 May 2021 16:59:15 +0200 Message-Id: <87y2ct4470.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47771 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47771 fixed close 47771 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47771 fixed close 47771 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 11:48:44 2021 Received: (at 47771) by debbugs.gnu.org; 5 May 2021 15:48:44 +0000 Received: from localhost ([127.0.0.1]:32909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJlU-0003Rr-AT for submit@debbugs.gnu.org; Wed, 05 May 2021 11:48:44 -0400 Received: from server.qxqx.de ([178.63.65.180]:49381 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJlR-0003Rl-MZ for 47771@debbugs.gnu.org; Wed, 05 May 2021 11:48:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DitLUiTZebIBg/61t65M+1FF59G3EFyoFm2y4Z7YbSI=; b=HW9ldTkwaYdsgzYaIcUPtVbwas nF1gtdq62Vk+d1Fb65gmeLiOS+fkQ0sea3UGoH6lk7mjsrYIvahsX0BkpNPd11o67cuGu0yKA4u+q QMu5Y7pTX4d9Tw1JI9c9Q4NvIxvq4B8OAmiJAhXSaBG9wbQI4OZmJVp3UkfweGWAO8/U=; Subject: Re: bug#47771: 27.1; `Info-read-node-name` throws error during completion To: Lars Ingebrigtsen References: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> <87zgx94478.fsf@gnus.org> From: Daniel Mendler Message-ID: <76b980e3-3482-4abf-eb42-41c31382e145@daniel-mendler.de> Date: Wed, 5 May 2021 17:48:33 +0200 MIME-Version: 1.0 In-Reply-To: <87zgx94478.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47771 Cc: 47771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 5/5/21 4:59 PM, Lars Ingebrigtsen wrote: > Thanks; applied to Emacs 28 (with some minor changes). Thank you. There is one additional issue I missed in the bug report. If you call `Info-build-node-completions` with a file without info tags, it will also throw an error. So maybe it would be better to wrap `(Info-build-node-completions (Info-find-file file1 nil t))` with `ignore-errors`? Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 05:26:15 2021 Received: (at 47771) by debbugs.gnu.org; 6 May 2021 09:26:15 +0000 Received: from localhost ([127.0.0.1]:37111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaGt-0007af-Fp for submit@debbugs.gnu.org; Thu, 06 May 2021 05:26:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaGs-0007aZ-0a for 47771@debbugs.gnu.org; Thu, 06 May 2021 05:26:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=g9ME977Buy0fiX+9tk04JdtnOtELu6Q9sV8yY5iqVzQ=; b=E6+tWJGB+hW4qtrpDFz2ho3Z0/ iJ3xd6g4HatYLtC2nXMto5er3JvBNo4PFp+KozNJlVyagZnBBlykUxwTR0y4yWdMpcJ8EU1+QMRcs dgeN0BO1acKLQFulb9t5yIOz/Mg1ELneMn9akyzNlf+b/yg6lbyw5PD6S+cJHKxh1FSQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leaGi-0005Oc-Sg; Thu, 06 May 2021 11:26:07 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#47771: 27.1; `Info-read-node-name` throws error during completion References: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> <87zgx94478.fsf@gnus.org> <76b980e3-3482-4abf-eb42-41c31382e145@daniel-mendler.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUyNzg9QUM5PkEt MjUnLC9dX2HRzs6wr6/Av75MT1Ftb3CQkZHp5uV+gID///9zwziWAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UFBgg1JPf3h+IAAAF0SURBVDjLrZQ/T4NAGMavvl26iU52UvkCr56adDMpDMXFpQNOTnXQ wZgUkuqscy1Li4ODmrS42oF2lZiUT+CnEXr8uTtg8x0IvD+ee+457iA1RVF2iVwbCvdA14XiG5C0 KRXaeVPQQNqnyK4oC6jsIgFaMhS7rxAAigIkWzVlfw8KFnrP6tmP9gi4cGtg3C/6vhUBlEG/S9xl GQias+u57RRyGOHtwdP7QxkIdkw3dEBeEiNc1T9uAgeKisv6ZyiAxDx83X4J46GktTJWp+REVLDk xreGZ4EVASmHfjV5O/ZsJwuIKbBn04n9pWY5MuB3ZxfzO7XwzfVpY+CNz1UuH3PvTDeXPyZRs9li IuksBk3/EGOAInDchT8kvDkDreeG92sOBZBEBE1jX59FQX7/8BsrVxQ2nCzhD0IVwNgxWlYKFOQj 0jLHw3FU3RGIIJ0HAUmR2yDKAjY3oAVASqw5EamoSlLi8B9V+hch5EhLqt0Wsv8BKqKedXq3OdkA AAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDUtMDZUMDg6NTM6MzYrMDA6MDBbkxCZAAAAJXRFWHRk YXRlOm1vZGlmeQAyMDIxLTA1LTA2VDA4OjUzOjM2KzAwOjAwKs6oJQAAAABJRU5ErkJggg== X-Now-Playing: Zola Jesus's _New Amsterdam_: "Lady In The Radiator" Date: Thu, 06 May 2021 11:26:04 +0200 In-Reply-To: <76b980e3-3482-4abf-eb42-41c31382e145@daniel-mendler.de> (Daniel Mendler's message of "Wed, 5 May 2021 17:48:33 +0200") Message-ID: <87tungz00j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > Thank you. There is one additional issue I missed in the bug report. If > you call `Info-build-node-completions` with a file without info tags, it > will also throw an error. So maybe it would be be [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47771 Cc: 47771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mendler writes: > Thank you. There is one additional issue I missed in the bug report. If > you call `Info-build-node-completions` with a file without info tags, it > will also throw an error. So maybe it would be better to wrap > `(Info-build-node-completions (Info-find-file file1 nil t))` with > `ignore-errors`? Slapping an `ignore-errors' around all that code feels a bit excessive (it makes debugging hard), so I've instead made `Info-build-node-completions' a bit more resilient -- it'll catch errors from `Info-goto-node' instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 05:42:42 2021 Received: (at 47771) by debbugs.gnu.org; 6 May 2021 09:42:42 +0000 Received: from localhost ([127.0.0.1]:37137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaWo-0007l7-1V for submit@debbugs.gnu.org; Thu, 06 May 2021 05:42:42 -0400 Received: from server.qxqx.de ([178.63.65.180]:46517 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaWm-0007l1-57 for 47771@debbugs.gnu.org; Thu, 06 May 2021 05:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WCxqEPROXtV5OiLZVs89SmfcqzjUJ/rtHW4p1E+L18E=; b=d2czKESytciTFS+zsmtMu6wWTf zG0vOzBMWI8ODTV+CJe6MxSdpffwDYTDfHFGYIKd7u/G8SX+9Lm7wpoUxOL+QLBlAW4aV+FrNEu1O 0c2BYyhhuhLGDFskkCBaDuZqj9MAgraby+CfZHMDlf5jjKLRC6DC9N9zHhTc87z/EdeQ=; Subject: Re: bug#47771: 27.1; `Info-read-node-name` throws error during completion To: Lars Ingebrigtsen References: <4d2568fb-adad-6f3e-2684-13ec2cc70457@daniel-mendler.de> <87zgx94478.fsf@gnus.org> <76b980e3-3482-4abf-eb42-41c31382e145@daniel-mendler.de> <87tungz00j.fsf@gnus.org> From: Daniel Mendler Message-ID: <5e0f282c-69ad-f6f8-bfec-82649d9658e2@daniel-mendler.de> Date: Thu, 6 May 2021 11:42:32 +0200 MIME-Version: 1.0 In-Reply-To: <87tungz00j.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47771 Cc: 47771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 5/6/21 11:26 AM, Lars Ingebrigtsen wrote: > Slapping an `ignore-errors' around all that code feels a bit excessive > (it makes debugging hard), so I've instead made > `Info-build-node-completions' a bit more resilient -- it'll catch errors > from `Info-goto-node' instead. I agree with you, the approach you took is better than the `ignore-errors` sledgehammer. For the same reasons my initial proposal was to pass noerror to `Info-find-file`. Thank you for applying the fixes! Daniel From unknown Sun Aug 17 04:17:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Jun 2021 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator