GNU bug report logs - #47770
[PATCH core-updates 0/4] Update ibus

Previous Next

Full log

Message #41 received at 47770 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Maxime Devos <maximedevos <at> telenet.be>, 47770 <at> debbugs.gnu.org
Subject: Re: [bug#47770] [PATCH core-updates 2/4] gnu: ibus: Enable
 documentation.
Date: Thu, 15 Apr 2021 08:31:15 -0400

[Message part 1 (text/plain, inline)]

Hi Maxime!

> On Wed, 2021-04-14 at 07:53 -0400, Raghav Gururajan via Guix-patches via wrote:
>>          #:phases
>>          (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch-docbook-xml
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (with-directory-excursion "docs/reference/ibus"
>> +               (substitute* "ibus-docs.sgml.in"
>> +                 (("http://www.oasis-open.org/docbook/xml/4.1.2/")
>> +                  (string-append (assoc-ref inputs "docbook-xml")
>> +                                 "/xml/dtd/docbook/"))))
>> +              #t))
> 
> Letting a phase return #t isn't required anymore, and the warning has
> been removed on core-updates (which this patch series is targetting.
> The #t can be dropped now.
> 
>>            (add-after 'unpack 'patch-python-target-directories
>>              (lambda* (#:key outputs #:allow-other-keys)
>>                (let ((root (string-append (assoc-ref outputs "out")
>> @@ -127,6 +138,15 @@
>>                  (("\"(setxkbmap|xmodmap)\"" _ prog)
>>                   (string-append "\"" (assoc-ref inputs prog) "/bin/" prog "\"")))
>>                #t))
> 
> While you're modifying the package anyway, you might as well drop this one too.
>> +         (add-after 'install 'move-doc
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (doc (assoc-ref outputs "doc")))
>> +               (mkdir-p (string-append doc "/share"))
>> +               (rename-file
>> +                (string-append out "/share/gtk-doc")
>> +                (string-append doc "/share/gtk-doc"))
>> +               #t)))
> Likewise.

I have removed #t in v2.

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.