GNU bug report logs - #47768
[PATCH 00/37] Assorted OCaml patches

Previous Next

Full log

Message #428 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org, Xinglu Chen <public <at> yoctocell.xyz>,
 pukkamustard <pukkamustard <at> posteo.net>
Cc: Erik <erikl <at> posteo.net>, Maxime Devos <maximedevos <at> telenet.be>,
 47768 <at> debbugs.gnu.org, divoplade <d <at> divoplade.fr>
Subject: Re: [bug#47768] [PATCH v3 00/42] Assorted OCaml patches
Date: Tue, 01 Jun 2021 21:19:42 -0400

[Message part 1 (text/plain, inline)]

I keep telling myself I should review and merge the changes but I keep having better things to do :p. I'll have a look during the week-end if noone beats me at it :)

Le 1 juin 2021 17:46:36 GMT-04:00, Xinglu Chen <public <at> yoctocell.xyz> a écrit :
>On Tue, Jun 01 2021, pukkamustard wrote:
>
>> Hi,
>>
>> Xinglu Chen <public <at> yoctocell.xyz> writes:
>>
>>> All the packages build fine, but I haven’t tested anything.
>>
>> Thanks for the review!
>
>You are welcome!
>
>> It follows a V3 with the two changes you suggested (add tests for
>> ocaml-uunf and merge patches 10 and 11 of V2).
>
>The changes look good to me, and ‘ocaml-uunf’ builds fine.
>
>> Erik has tested some of the packages and reports that everything
>seems
>> to be fine.
>>
>>> LGTM!
>>
>> Maybe we are good to merge now?
>
>No objections from me, but I don’t have commit access. :(
>
>Thank you and divoplade for the work!

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.