GNU bug report logs - #47768
[PATCH 00/37] Assorted OCaml patches

Previous Next

Full log

Message #425 received at 47768 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: pukkamustard <pukkamustard <at> posteo.net>, divoplade <d <at> divoplade.fr>,
 47768 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>,
 Erik <erikl <at> posteo.net>
Subject: Re: [bug#47768] [PATCH v3 00/42] Assorted OCaml patches
Date: Tue, 01 Jun 2021 23:46:36 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jun 01 2021, pukkamustard wrote:

> Hi,
>
> Xinglu Chen <public <at> yoctocell.xyz> writes:
>
>> All the packages build fine, but I haven’t tested anything.
>
> Thanks for the review!

You are welcome!

> It follows a V3 with the two changes you suggested (add tests for
> ocaml-uunf and merge patches 10 and 11 of V2).

The changes look good to me, and ‘ocaml-uunf’ builds fine.

> Erik has tested some of the packages and reports that everything seems
> to be fine.
>
>> LGTM!
>
> Maybe we are good to merge now?

No objections from me, but I don’t have commit access. :(

Thank you and divoplade for the work!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.