From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Madhu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 05:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47766@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16183766101735 (code B ref -1); Wed, 14 Apr 2021 05:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2021 05:03:30 +0000 Received: from localhost ([127.0.0.1]:33157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWXgX-0000Rv-KF for submit@debbugs.gnu.org; Wed, 14 Apr 2021 01:03:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:57406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWXgV-0000Rn-I6 for submit@debbugs.gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWXgV-0006is-Bw for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from smtp6.ctinetworks.com ([205.166.61.199]:50196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWXgT-0004xP-Uw for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from localhost (unknown [117.193.4.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id 5F0C88515F for ; Wed, 14 Apr 2021 01:03:18 -0400 (EDT) Date: Wed, 14 Apr 2021 10:33:08 +0530 (IST) Message-Id: <20210414.103308.2181932615044049035.enometh@meer.net> From: Madhu X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 5F0C88515F.A90D3 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-SpamCheck: X-ctinetworks-Watermark: 1619240602.1906@xHNhX9j0/e0iiQVZ0AjnBQ Received-SPF: pass client-ip=205.166.61.199; envelope-from=enometh@meer.net; helo=smtp6.ctinetworks.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo version 1.16.0) of 2021-04-14 built on maher based on master 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert reverted) 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' 2. C-x b TAB this would pop up a new *Completions* buffer in a new frame with are two choices *Messages* and *scratch* 3. choose a completion (click or hit enter on one of the choices) user-error: Cannot switch buffers in minibuffer window From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 08:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Madhu Cc: 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.161838981324259 (code B ref 47766); Wed, 14 Apr 2021 08:44:01 +0000 Received: (at 47766) by debbugs.gnu.org; 14 Apr 2021 08:43:33 +0000 Received: from localhost ([127.0.0.1]:33346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWb7V-0006JD-Cl for submit@debbugs.gnu.org; Wed, 14 Apr 2021 04:43:33 -0400 Received: from heytings.org ([95.142.160.155]:37822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWb7T-0006J3-GO for 47766@debbugs.gnu.org; Wed, 14 Apr 2021 04:43:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618389810; bh=NA3xisiMdL5NhvaKS51y9jEQc3uqBvd8cDHb+0LQYSc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=vnGA9V4X841978dyuWsdyDM8fa8M0QkDrkeqqIzaNmLOmGtNu3KgroG8dPQdJtL1E Ea6bwij9AnzXf8shGgzGp45sPHFzPZTj8Gr/AG7TlhnZ47FOxHFrK+ymey15nDvAS+ AUTIaf7dFd4aLsphHzWjeLI1YxpwLbIB2UWrD5wk82HOk/UqUqgJgL80XnNC+mEy1J Ag/p8z4IqaX0MiaRRffZVRPL4nB9IrgSXxklT7JOk1pO7mxDc7zOl+ip1NXn+8UtVm gwE/Bo1DMwcoePYp0k5uvxR3knmBmeOepqpAPDWAACW9Kfg3rhuny5k+wKhZVfE1YY xGE4SoLC5fC8g== Date: Wed, 14 Apr 2021 08:43:29 +0000 From: Gregory Heytings In-Reply-To: <20210414.103308.2181932615044049035.enometh@meer.net> Message-ID: <7d9667a70f0babba48d0@heytings.org> References: <20210414.103308.2181932615044049035.enometh@meer.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, > cairo version 1.16.0) of 2021-04-14 built on maher based on master > 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert > reverted) > > 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' > 2. C-x b TAB > > this would pop up a new *Completions* buffer in a new frame with are two > choices *Messages* and *scratch* > > 3. choose a completion (click or hit enter on one of the choices) > > user-error: Cannot switch buffers in minibuffer window > This is because of commit 7c2ebf6e23. From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Apr 2021 13:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gregory Heytings Cc: Alan Mackenzie , Madhu , 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.16189251223998 (code B ref 47766); Tue, 20 Apr 2021 13:26:01 +0000 Received: (at 47766) by debbugs.gnu.org; 20 Apr 2021 13:25:22 +0000 Received: from localhost ([127.0.0.1]:53282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYqNW-00012P-9Z for submit@debbugs.gnu.org; Tue, 20 Apr 2021 09:25:22 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:43646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYqNU-000128-H2 for 47766@debbugs.gnu.org; Tue, 20 Apr 2021 09:25:20 -0400 Received: by mail-pj1-f47.google.com with SMTP id f6-20020a17090a6546b029015088cf4a1eso4616777pjs.2 for <47766@debbugs.gnu.org>; Tue, 20 Apr 2021 06:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=eJKnAyP81LZLlxuAyZ8GjtT+6uhREdTZJIJllXZnPT8=; b=hxOVM71dwru1Pg2A+lvk7nvyPllgxcLzCcUBvAbvh3fdRCuqH1QO6LnrpRTI6RPwk4 Y603NBrn57iF4dTYuKdZrY6c2NDX7snZxQlZsMuLVJVaHXlwTMaSG5OIewaHZd+fIjMn Qo9AaUBnZ39UIoUQJtj779TAIhWL8Dz1TcIH9PJH4mMK/7KcxZ25NFiXVlvpmcYLDdka yEx8PKXNChWc4qhI0qyIr0Z1lLUDKp4zAYGMkPJi1yt8+P0cFnnGnUYOvC6H+dJv49Zk FFbVw3/2HDCaZMH8V3sPRlZqxhHHFcxXCXcVRWDtND6AuL8BXp8yGW1WJ4KGGd1jRZIj fnWg== X-Gm-Message-State: AOAM531iipl+3W61uxoJ8us8KpJWO0NyRm0LiQsd6pYvptg/lKATdn6r MCY7kddinIlaEdHuGgj0zS+OCGQnWaKmpcbaWg3W08ZK X-Google-Smtp-Source: ABdhPJyDylpKojNhvBzJD6mPGCMDuI9MGRqUYtXsmRx0sLWlkaTaLmD3Xc4WwfiMf7xzO2/ESKg1e+J1Czy9DP2ydZ0= X-Received: by 2002:a17:902:7788:b029:e9:11:5334 with SMTP id o8-20020a1709027788b02900e900115334mr28807876pll.70.1618925114246; Tue, 20 Apr 2021 06:25:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 08:25:13 -0500 From: Stefan Kangas In-Reply-To: <7d9667a70f0babba48d0@heytings.org> (Gregory Heytings's message of "Wed, 14 Apr 2021 08:43:29 +0000") References: <20210414.103308.2181932615044049035.enometh@meer.net> <7d9667a70f0babba48d0@heytings.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 20 Apr 2021 08:25:13 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Gregory Heytings writes: >> In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo >> version 1.16.0) of 2021-04-14 built on maher based on master >> 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert reverted) >> >> 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' >> 2. C-x b TAB >> >> this would pop up a new *Completions* buffer in a new frame with are two >> choices *Messages* and *scratch* >> >> 3. choose a completion (click or hit enter on one of the choices) >> >> user-error: Cannot switch buffers in minibuffer window > > This is because of commit 7c2ebf6e23. Copying in Alan here. From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: Gregory Heytings , Madhu , 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.16190132715982 (code B ref 47766); Wed, 21 Apr 2021 13:55:02 +0000 Received: (at 47766) by debbugs.gnu.org; 21 Apr 2021 13:54:31 +0000 Received: from localhost ([127.0.0.1]:57247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZDJH-0001YQ-GS for submit@debbugs.gnu.org; Wed, 21 Apr 2021 09:54:31 -0400 Received: from colin.muc.de ([193.149.48.1]:45618 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lZDJE-0001Y8-1E for 47766@debbugs.gnu.org; Wed, 21 Apr 2021 09:54:29 -0400 Received: (qmail 70864 invoked by uid 3782); 21 Apr 2021 13:54:21 -0000 Received: from acm.muc.de (p4fe15ced.dip0.t-ipconnect.de [79.225.92.237]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 21 Apr 2021 15:54:20 +0200 Received: (qmail 12837 invoked by uid 1000); 21 Apr 2021 13:54:20 -0000 Date: Wed, 21 Apr 2021 13:54:20 +0000 Message-ID: References: <20210414.103308.2181932615044049035.enometh@meer.net> <7d9667a70f0babba48d0@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Madhu. I've been looking into this bug for several hours, and it may take some while to fix. Thanks for taking the trouble to report it. On Tue, Apr 20, 2021 at 08:25:13 -0500, Stefan Kangas wrote: > Gregory Heytings writes: > >> In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo > >> version 1.16.0) of 2021-04-14 built on maher based on master > >> 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert reverted) > >> 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' > >> 2. C-x b TAB > >> this would pop up a new *Completions* buffer in a new frame with are two > >> choices *Messages* and *scratch* > >> 3. choose a completion (click or hit enter on one of the choices) > >> user-error: Cannot switch buffers in minibuffer window Gregory and Stefan: > > This is because of commit 7c2ebf6e23. > Copying in Alan here. Thanks for drawing my attention towards the bug. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Madhu , Stefan Kangas Cc: Gregory Heytings , 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.161910407929610 (code B ref 47766); Thu, 22 Apr 2021 15:08:01 +0000 Received: (at 47766) by debbugs.gnu.org; 22 Apr 2021 15:07:59 +0000 Received: from localhost ([127.0.0.1]:35276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZavu-0007hV-CO for submit@debbugs.gnu.org; Thu, 22 Apr 2021 11:07:59 -0400 Received: from colin.muc.de ([193.149.48.1]:37826 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lZavr-0007hE-FI for 47766@debbugs.gnu.org; Thu, 22 Apr 2021 11:07:56 -0400 Received: (qmail 87416 invoked by uid 3782); 22 Apr 2021 15:07:48 -0000 Received: from acm.muc.de (p4fe15bfe.dip0.t-ipconnect.de [79.225.91.254]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 22 Apr 2021 17:07:47 +0200 Received: (qmail 26412 invoked by uid 1000); 22 Apr 2021 15:07:47 -0000 Date: Thu, 22 Apr 2021 15:07:47 +0000 Message-ID: References: <20210414.103308.2181932615044049035.enometh@meer.net> <7d9667a70f0babba48d0@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Madhu and Stefan. On Tue, Apr 20, 2021 at 08:25:13 -0500, Stefan Kangas wrote: > Gregory Heytings writes: > >> In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo > >> version 1.16.0) of 2021-04-14 built on maher based on master > >> 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert reverted) > >> 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' > >> 2. C-x b TAB > >> this would pop up a new *Completions* buffer in a new frame with are two > >> choices *Messages* and *scratch* > >> 3. choose a completion (click or hit enter on one of the choices) > >> user-error: Cannot switch buffers in minibuffer window > > This is because of commit 7c2ebf6e23. Or, more accurately, because the changes in that commit were incomplete. In particular, functions iconify-frame and make-frame-invisible were moving minibuffers in a way no longer consistent with the rest of Emacs. Madhu, would you please try out the following patch (which gives a couple of harmless warnings in compilation), and tell us whether it fixes the problems in your setup, or what is still not working properly. Thanks! diff --git a/lisp/window.el b/lisp/window.el index 071761ea50..faf639cddd 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4119,7 +4119,7 @@ window-deletable-p (let ((minibuf (active-minibuffer-window))) (and minibuf (eq frame (window-frame minibuf)) (not (eq (default-toplevel-value - minibuffer-follows-selected-frame) + 'minibuffer-follows-selected-frame) t))))) 'frame)) ((window-minibuffer-p window) diff --git a/src/frame.c b/src/frame.c index 097cd555c6..a1a6d58cb6 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2085,9 +2085,10 @@ delete_frame (Lisp_Object frame, Lisp_Object force) do_switch_frame (frame1, 0, 1, Qnil); sf = SELECTED_FRAME (); } - - /* Don't allow minibuf_window to remain on a deleted frame. */ - check_minibuf_window (frame, minibuffer_selected); + else + /* Ensure any minibuffers on FRAME are moved onto the selected + frame. */ + move_minibuffers_onto_frame (f, true); /* Don't let echo_area_window to remain on a deleted frame. */ if (EQ (f->minibuffer_window, echo_area_window)) @@ -2718,9 +2719,6 @@ DEFUN ("make-frame-invisible", Fmake_frame_invisible, Smake_frame_invisible, if (NILP (force) && !other_frames (f, true, false)) error ("Attempt to make invisible the sole visible or iconified frame"); - /* Don't allow minibuf_window to remain on an invisible frame. */ - check_minibuf_window (frame, EQ (minibuf_window, selected_window)); - if (FRAME_WINDOW_P (f) && FRAME_TERMINAL (f)->frame_visible_invisible_hook) FRAME_TERMINAL (f)->frame_visible_invisible_hook (f, false); @@ -2763,9 +2761,6 @@ DEFUN ("iconify-frame", Ficonify_frame, Siconify_frame, } #endif /* HAVE_WINDOW_SYSTEM */ - /* Don't allow minibuf_window to remain on an iconified frame. */ - check_minibuf_window (frame, EQ (minibuf_window, selected_window)); - if (FRAME_WINDOW_P (f) && FRAME_TERMINAL (f)->iconify_frame_hook) FRAME_TERMINAL (f)->iconify_frame_hook (f); diff --git a/src/minibuf.c b/src/minibuf.c index c4482d7f1e..bc7d439398 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -212,7 +212,23 @@ DEFUN ("active-minibuffer-window", Factive_minibuffer_window, doc: /* Return the currently active minibuffer window, or nil if none. */) (void) { - return minibuf_level ? minibuf_window : Qnil; + Lisp_Object frames, frame; + struct frame *f; + Lisp_Object innermost_MB; + + if (!minibuf_level) + return Qnil; + + innermost_MB = nth_minibuffer (minibuf_level); + FOR_EACH_FRAME (frames, frame) + { + f = XFRAME (frame); + if (FRAME_LIVE_P (f) + && WINDOW_LIVE_P (f->minibuffer_window) + && EQ (XWINDOW (f->minibuffer_window)->contents, innermost_MB)) + return f->minibuffer_window; + } + return minibuf_window; /* "Can't happen." */ } DEFUN ("set-minibuffer-window", Fset_minibuffer_window, > Copying in Alan here. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Madhu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: acm@muc.de Cc: gregory@heytings.org, stefan@marxist.se, 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.161910752419175 (code B ref 47766); Thu, 22 Apr 2021 16:06:01 +0000 Received: (at 47766) by debbugs.gnu.org; 22 Apr 2021 16:05:24 +0000 Received: from localhost ([127.0.0.1]:35356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZbpU-0004zD-Cc for submit@debbugs.gnu.org; Thu, 22 Apr 2021 12:05:24 -0400 Received: from smtp6.ctinetworks.com ([205.166.61.199]:55834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZbpS-0004z3-Lm for 47766@debbugs.gnu.org; Thu, 22 Apr 2021 12:05:23 -0400 Received: from localhost (unknown [117.193.3.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id 68ECC850D6; Thu, 22 Apr 2021 12:05:14 -0400 (EDT) Date: Thu, 22 Apr 2021 21:34:29 +0530 (IST) Message-Id: <20210422.213429.112377311480064511.enometh@meer.net> From: Madhu In-Reply-To: References: <7d9667a70f0babba48d0@heytings.org> X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 68ECC850D6.A9578 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-SpamCheck: X-ctinetworks-Watermark: 1619971521.90473@hHt/jgxrffH/FzrUkSPxPg X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Alan Mackenzie Wrote on Thu, 22 Apr 2021 15:07:47 +0000 > Or, more accurately, because the changes in that commit were incomplete. > In particular, functions iconify-frame and make-frame-invisible were > moving minibuffers in a way no longer consistent with the rest of Emacs. > > Madhu, would you please try out the following patch (which gives a couple > of harmless warnings in compilation), and tell us whether it fixes the > problems in your setup, or what is still not working properly. Thanks! Thank you. I'm running it now and will let you know if i spot anything. The rest of this is not directlty related to the bug, but somewhat related to your post on emacs-devel invisible and iconified windows. mutter (gnome-shell) and wayland throw some more spanners into the works - mutter does not have a concept of "iconified" it only has a notion of "hidden". A hidden window has no "hidden" state as far as the compositor is concerned. M-TAB/switchers would show previews of the current state of the window. If an emacs frame iconifies itself (gtk:gtk_window_iconify) rather than the user causing the compositing window manager to hide it, it cannot map itself back. I end up with something like ;; work around gnome-shell error (defadvice make-frame-visible (around mutter-workaround (&optional frame) activate) (if (or (eql (frame-parameter frame 'visibility) 'icon) (eql (frame-parameter frame 'visibility) nil)) ;gnome-shell40.a (set-frame-parameter frame 'visibility nil)) ad-do-it) to make make-frame-visible work. [PS. There seem to be some other rough corners - sometimes I end up in a recursive-edit where one cannot go back to the top-level and have to quit emacs instead - but i haven't triggered this one in the past week so i don't have a recipe for it.] From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Madhu Cc: acm@muc.de, gregory@heytings.org, stefan@marxist.se, 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.16202288464130 (code B ref 47766); Wed, 05 May 2021 15:35:01 +0000 Received: (at 47766) by debbugs.gnu.org; 5 May 2021 15:34:06 +0000 Received: from localhost ([127.0.0.1]:60992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJXK-00014Y-BM for submit@debbugs.gnu.org; Wed, 05 May 2021 11:34:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJXI-000148-0w for 47766@debbugs.gnu.org; Wed, 05 May 2021 11:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3GsX3DcffCWZ9iM3I4o6L1cpKYE0ZoWjL7fbaaQTbUg=; b=bfWuvr/QICKIYveEACH0UNVPOa 8EMkhMxLq2xjP15IU+1esIBJyJqYcmAnXMX3wY0WGA5m2+jg1OtVpF9CIsxzqsHRo/t6EHUq8XoBt 0QS4HvdLvO+VRimwtAMEwgL6VytSthkigwVDtxYhIpAerZit994QBwj5JkQk6uXTeWew=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leJX8-0002xk-N0; Wed, 05 May 2021 17:33:57 +0200 From: Lars Ingebrigtsen References: <7d9667a70f0babba48d0@heytings.org> <20210422.213429.112377311480064511.enometh@meer.net> X-Now-Playing: Shara Nelson's _What Silence Knows_: "Uptight" Date: Wed, 05 May 2021 17:33:54 +0200 In-Reply-To: <20210422.213429.112377311480064511.enometh@meer.net> (Madhu's message of "Thu, 22 Apr 2021 21:34:29 +0530 (IST)") Message-ID: <87a6p942l9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Madhu writes: >> Madhu, would you please try out the following patch (which gives a couple >> of harmless warnings in compilation), and tell us whether it fixes the >> problems in your setup, or what is still not w [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Madhu writes: >> Madhu, would you please try out the following patch (which gives a couple >> of harmless warnings in compilation), and tell us whether it fixes the >> problems in your setup, or what is still not working properly. Thanks! > > Thank you. I'm running it now and will let you know if i spot > anything. This was almost two weeks ago -- did the patch work well? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 11:34:12 2021 Received: (at control) by debbugs.gnu.org; 5 May 2021 15:34:12 +0000 Received: from localhost ([127.0.0.1]:60997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJXQ-00014m-He for submit@debbugs.gnu.org; Wed, 05 May 2021 11:34:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJXO-00014X-Bl for control@debbugs.gnu.org; Wed, 05 May 2021 11:34:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K3s49ntGTlARhoTu1ROFQSMC50M8JI4wXYYqK5zvQ98=; b=HH8tdtnZsr1toRrXKI8//yLkMe beFSdCRnlobboPr5BRabIoPUKWK2ENPWcT9Oj229OWQSizcVdM6myIXBrL+Npw0aV4bG/IR2gqK7T 2mEbnyca321Y0I/qBp8k2P2lrqVwBDE17urNa1sG13Uv+VUZOwIxgvlHT28hCQA6w2QA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leJXG-0002xt-TS for control@debbugs.gnu.org; Wed, 05 May 2021 17:34:04 +0200 Date: Wed, 05 May 2021 17:34:02 +0200 Message-Id: <878s4t42l1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47766 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47766 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47766 + moreinfo quit From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Madhu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 02:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: larsi@gnus.org Cc: acm@muc.de, gregory@heytings.org, stefan@marxist.se, 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.162026920428833 (code B ref 47766); Thu, 06 May 2021 02:47:01 +0000 Received: (at 47766) by debbugs.gnu.org; 6 May 2021 02:46:44 +0000 Received: from localhost ([127.0.0.1]:35984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leU2G-0007Uz-DY for submit@debbugs.gnu.org; Wed, 05 May 2021 22:46:44 -0400 Received: from smtp6.ctinetworks.com ([205.166.61.199]:35474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leU2B-0007Ut-PK for 47766@debbugs.gnu.org; Wed, 05 May 2021 22:46:42 -0400 Received: from localhost (unknown [117.193.9.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id BF58984978; Wed, 5 May 2021 22:46:27 -0400 (EDT) Date: Thu, 06 May 2021 08:16:39 +0530 (IST) Message-Id: <20210506.081639.1881805365026827947.enometh@meer.net> From: Madhu In-Reply-To: <87a6p942l9.fsf@gnus.org> References: <20210422.213429.112377311480064511.enometh@meer.net> <87a6p942l9.fsf@gnus.org> X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: BF58984978.A7BA0 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-SpamCheck: X-ctinetworks-Watermark: 1621133198.74262@RrCc64nOjCDqz9eIwZVnbQ X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Lars Ingebrigtsen <87a6p942l9.fsf@gnus.org> Wrote on Wed, 05 May 2021 17:33:54 +0200 > Madhu writes: >> Thank you. I'm running it now and will let you know if i spot >> anything. > This was almost two weeks ago -- did the patch work well? Yes. I haven't seen any problems (though I can't claim to have tested all the corner cases) ---Madhu From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Madhu Cc: acm@muc.de, gregory@heytings.org, stefan@marxist.se, 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.162029000819007 (code B ref 47766); Thu, 06 May 2021 08:34:01 +0000 Received: (at 47766) by debbugs.gnu.org; 6 May 2021 08:33:28 +0000 Received: from localhost ([127.0.0.1]:37033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZRo-0004wV-Kz for submit@debbugs.gnu.org; Thu, 06 May 2021 04:33:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZRl-0004wP-F7 for 47766@debbugs.gnu.org; Thu, 06 May 2021 04:33:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/DDOCfkCPmn/GHMmbbQcHnNk/2SpGSBnTQ7+6xIBXzc=; b=XdRFBU6eYGJ4YvnuNLBcgLCYME 8gvZsn6Cxrsh+NhRqJQ2K7veUt1vMVwzOFoPEDnSo+sb61o9M7/Rt6uLm/oFxW4GT7uUT99G36lOV KsfUNY71LlMyHWWnAaKjiAvPvDbDTovyvwu9kgl3ZXSE5/12TfbHglhiMYsKR+2cd4i8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZRZ-0004yN-7D; Thu, 06 May 2021 10:33:18 +0200 From: Lars Ingebrigtsen References: <20210422.213429.112377311480064511.enometh@meer.net> <87a6p942l9.fsf@gnus.org> <20210506.081639.1881805365026827947.enometh@meer.net> X-Now-Playing: Working Week's _Working Nights_: "No Cure No Pay" Date: Thu, 06 May 2021 10:33:12 +0200 In-Reply-To: <20210506.081639.1881805365026827947.enometh@meer.net> (Madhu's message of "Thu, 06 May 2021 08:16:39 +0530 (IST)") Message-ID: <875yzw2ref.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Madhu writes: > Yes. I haven't seen any problems (though I can't claim to have tested > all the corner cases) OK. Alan, are you pushing the change, then? This bit looks odd, though: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Madhu writes: > Yes. I haven't seen any problems (though I can't claim to have tested > all the corner cases) OK. Alan, are you pushing the change, then? This bit looks odd, though: --- a/lisp/window.el +++ b/lisp/window.el @@ -4119,7 +4119,7 @@ window-deletable-p (let ((minibuf (active-minibuffer-window))) (and minibuf (eq frame (window-frame minibuf)) (not (eq (default-toplevel-value - minibuffer-follows-selected-frame) + 'minibuffer-follows-selected-frame) t))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 08:39:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47766: 28.0.50; choose-completion fails Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Lars Ingebrigtsen Cc: Madhu , stefan@marxist.se, gregory@heytings.org, 47766@debbugs.gnu.org Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.16202949126184 (code B ref 47766); Thu, 06 May 2021 09:56:01 +0000 Received: (at 47766) by debbugs.gnu.org; 6 May 2021 09:55:12 +0000 Received: from localhost ([127.0.0.1]:37160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaiu-0001bg-6j for submit@debbugs.gnu.org; Thu, 06 May 2021 05:55:12 -0400 Received: from colin.muc.de ([193.149.48.1]:20615 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1leais-0001bU-GI for 47766@debbugs.gnu.org; Thu, 06 May 2021 05:55:11 -0400 Received: (qmail 44035 invoked by uid 3782); 6 May 2021 09:55:03 -0000 Received: from acm.muc.de (p4fe15eae.dip0.t-ipconnect.de [79.225.94.174]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 06 May 2021 11:55:03 +0200 Received: (qmail 8566 invoked by uid 1000); 6 May 2021 09:55:02 -0000 Date: Thu, 6 May 2021 09:55:02 +0000 Message-ID: References: <20210422.213429.112377311480064511.enometh@meer.net> <87a6p942l9.fsf@gnus.org> <20210506.081639.1881805365026827947.enometh@meer.net> <875yzw2ref.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875yzw2ref.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Lars. On Thu, May 06, 2021 at 10:33:12 +0200, Lars Ingebrigtsen wrote: > Madhu writes: > > Yes. I haven't seen any problems (though I can't claim to have tested > > all the corner cases) > OK. Alan, are you pushing the change, then? I'll commit the change, yes, soon, hopefully today. > This bit looks odd, though: > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -4119,7 +4119,7 @@ window-deletable-p > (let ((minibuf (active-minibuffer-window))) > (and minibuf (eq frame (window-frame minibuf)) > (not (eq (default-toplevel-value > - minibuffer-follows-selected-frame) > + 'minibuffer-follows-selected-frame) > t))))) Yes, I was hoping nobody would notice that. ;-) The quote is absolutely required for correct functioning. Missing the quote didn't throw an error when m-f-s-frame was t or nil (but the whole point of default-toplevel-value was lost), but did when it was 'hybrid. With the commit, the glitch will be fixed forever. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Jun 15 08:39:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Madhu Subject: bug#47766: closed (Re: bug#47766: 28.0.50; choose-completion fails) Message-ID: References: <20210414.103308.2181932615044049035.enometh@meer.net> X-Gnu-PR-Message: they-closed 47766 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: moreinfo Reply-To: 47766@debbugs.gnu.org Date: Thu, 06 May 2021 11:00:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1620298803-10749-1" This is a multi-part message in MIME format... ------------=_1620298803-10749-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47766: 28.0.50; choose-completion fails which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47766@debbugs.gnu.org. --=20 47766: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47766 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1620298803-10749-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47766-done) by debbugs.gnu.org; 6 May 2021 10:59:53 +0000 Received: from localhost ([127.0.0.1]:37373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebjU-0002mn-PA for submit@debbugs.gnu.org; Thu, 06 May 2021 06:59:52 -0400 Received: from colin.muc.de ([193.149.48.1]:22385 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lebjS-0002mh-PS for 47766-done@debbugs.gnu.org; Thu, 06 May 2021 06:59:51 -0400 Received: (qmail 87710 invoked by uid 3782); 6 May 2021 10:59:44 -0000 Received: from acm.muc.de (p4fe15eae.dip0.t-ipconnect.de [79.225.94.174]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 06 May 2021 12:59:43 +0200 Received: (qmail 18699 invoked by uid 1000); 6 May 2021 10:59:43 -0000 Date: Thu, 6 May 2021 10:59:43 +0000 To: Madhu Subject: Re: bug#47766: 28.0.50; choose-completion fails Message-ID: References: <20210422.213429.112377311480064511.enometh@meer.net> <87a6p942l9.fsf@gnus.org> <20210506.081639.1881805365026827947.enometh@meer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210506.081639.1881805365026827947.enometh@meer.net> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47766-done Cc: acm@muc.de, larsi@gnus.org, stefan@marxist.se, gregory@heytings.org, 47766-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Madhu. On Thu, May 06, 2021 at 08:16:39 +0530, Madhu wrote: > * Lars Ingebrigtsen <87a6p942l9.fsf@gnus.org> > Wrote on Wed, 05 May 2021 17:33:54 +0200 > > Madhu writes: > >> Thank you. I'm running it now and will let you know if i spot > >> anything. > > This was almost two weeks ago -- did the patch work well? > Yes. I haven't seen any problems (though I can't claim to have tested > all the corner cases) Thanks for the testing! I wouldn't worry about the corner cases too much. As far as the minibuffer goes, corner cases constitute a near infinite set. ;-( I'm closing the bug with this post. If any more problems turn up in this area, please report them in a new bug. Thanks! > ---Madhu -- Alan Mackenzie (Nuremberg, Germany). ------------=_1620298803-10749-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Apr 2021 05:03:30 +0000 Received: from localhost ([127.0.0.1]:33157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWXgX-0000Rv-KF for submit@debbugs.gnu.org; Wed, 14 Apr 2021 01:03:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:57406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWXgV-0000Rn-I6 for submit@debbugs.gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWXgV-0006is-Bw for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from smtp6.ctinetworks.com ([205.166.61.199]:50196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWXgT-0004xP-Uw for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 01:03:27 -0400 Received: from localhost (unknown [117.193.4.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id 5F0C88515F for ; Wed, 14 Apr 2021 01:03:18 -0400 (EDT) Date: Wed, 14 Apr 2021 10:33:08 +0530 (IST) Message-Id: <20210414.103308.2181932615044049035.enometh@meer.net> To: bug-gnu-emacs@gnu.org Subject: 28.0.50; choose-completion fails From: Madhu X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 5F0C88515F.A90D3 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-SpamCheck: X-ctinetworks-Watermark: 1619240602.1906@xHNhX9j0/e0iiQVZ0AjnBQ Received-SPF: pass client-ip=205.166.61.199; envelope-from=enometh@meer.net; helo=smtp6.ctinetworks.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, Motif Version 2.3.8, cairo version 1.16.0) of 2021-04-14 built on maher based on master 844b8949a71f180d395a237c768b22d91cf91ded (with the motif revert reverted) 1. emacs -Q -eval '(setq pop-up-windows nil pop-up-frames t)' 2. C-x b TAB this would pop up a new *Completions* buffer in a new frame with are two choices *Messages* and *scratch* 3. choose a completion (click or hit enter on one of the choices) user-error: Cannot switch buffers in minibuffer window ------------=_1620298803-10749-1-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 11:18:42 2021 Received: (at control) by debbugs.gnu.org; 6 May 2021 15:18:42 +0000 Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lefly-0001le-Ax for submit@debbugs.gnu.org; Thu, 06 May 2021 11:18:42 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:47021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leflv-0001lT-Uy for control@debbugs.gnu.org; Thu, 06 May 2021 11:18:41 -0400 Received: by mail-wm1-f45.google.com with SMTP id k4-20020a7bc4040000b02901331d89fb83so3244705wmi.5 for ; Thu, 06 May 2021 08:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=fnpJTR0gpb6lPnizuS7AgAYOHfQGDAUylKAcaOT+8E0=; b=f+Vlgs7VZqLeFbt+bV6BSBBn5AZCboISrD2Z4b83VZ7OUhV7epNMbCpWIHmHf6S+xD F04RmZfhLV/SppoSrARA/6rOCXyWHyhPlbsxwyIfvNd3ItMF+uBrHfcUm+dk7gJaX6QX VxWsQC0pqx1KntxKNK27Hvg+Kbktqk8lrUhcLK7ObJyZXxA9idOAwiFtXqSsC+WGoraf RGe2x4wjgIUDqhn9/O3dUc5QM/Dbls9L1h+tVouwbk8kgL3+2zM9sGbw7ePiQUEYOVmn +ZvWZkW90rE/A3CxLmvWgG+YEhXTGP8XCO6h2qUZZ3YRF2Bt5BDE6Es06WUKh+f4Jc/E uNvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=fnpJTR0gpb6lPnizuS7AgAYOHfQGDAUylKAcaOT+8E0=; b=feyrD+1MtI7fkTzv2HuObucwS5X6iWxQEFhQTI1G4SQhHxOEzD+pcAISn7nMTmFRQA jkXv1EkvXJBaJveln9Gu4dxffxIgdgMS6WnAieQU2YsO0eiiWJceDn27SgUOIXpgN39F 9ZXzjrpAV8uhlY5N7p6hQQXALnRMNATNFqluxVd2cvLsArtkxJjR0d6J6LAVsUVLgu7A CXkKr1b4qKnAzsGDBWcRhSDJV/zuA0M8Ls6AXhA+6pJBxpn26vXOE+Of3hbGjwi2B3SQ maYU/D+6cEwOwapDqmb6lI/mmT1Hrv2Tjjp1WNHFBTfg+Fss2LjwTrS0lCRYIYTZqQie Dn3Q== X-Gm-Message-State: AOAM5301ltW4eEd2l2hsBG8Osp104qDvBnfBaIoTY6BQdW9j0PlE5Tja FAnaXR4AexPayZO4Iw5/AsCZVWB7baXQRA== X-Google-Smtp-Source: ABdhPJzuXM/J6nRrqpv2TWoLO1DPlwP/FWNmr1Su0L2MPJKT72pU9h4tVzVMrFnX2LyZLrAR1tv4Sg== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr4631012wmc.44.1620314313743; Thu, 06 May 2021 08:18:33 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id m11sm3306759wmq.33.2021.05.06.08.18.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 08:18:33 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #47766 Date: Thu, 06 May 2021 16:18:31 +0100 Message-ID: <87lf8r3n7c.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47766 - moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 11:24:57 2021 Received: (at control) by debbugs.gnu.org; 6 May 2021 15:24:57 +0000 Received: from localhost ([127.0.0.1]:38071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lefs0-0001qL-Pw for submit@debbugs.gnu.org; Thu, 06 May 2021 11:24:57 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:46753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lefrv-0001q1-3P for control@debbugs.gnu.org; Thu, 06 May 2021 11:24:53 -0400 Received: by mail-wr1-f43.google.com with SMTP id x5so6046577wrv.13 for ; Thu, 06 May 2021 08:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DfeijziWD8b8zTFiSr/0tVIcOdQ7qNliaD/GFrAssNQ=; b=SKlmWum7wzhsCAKWx/GkNmRp5nrJOKZwj6c/AsK1+YRBLm7ySBlLM6D0b8wSZPfCc5 P8WDCk4QD5giMIEpqXzDbKgT88enY9R5dtn/SzkTIhAgvA59owyQcFbAEb2PG2BEZQRU DoFNpuBXm6UM0mKZcj4qoloCAR/5e2w6Z2gkiM5h9LZryGJwEfOwAKMYyXClJOyjDZeY 5I6tfsn2x3ncpzFIBJP/rdTh5OVD4r9E9Lptx5DYWJzRI9KvBTmKtv5rvP89WCJFuNQ0 izsfFcctosxzIf+vV2w528TwG+TdL3o1tsqnqvQsVgOaU5AxEb2KNJUocH0EtDADU3BT CKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DfeijziWD8b8zTFiSr/0tVIcOdQ7qNliaD/GFrAssNQ=; b=iqaQfcZ6P7P9tiIoS24+Nn40mKk6Z4oyX/Z3CBPRnK7aog7vvYwPolQ8VSgchJzOPV ERN5IfnF7vqIqTaHtpchTydPx3xpiWuaZulYUK9KbNwXfg2mj9zYesz6p5304F0WBD8k BiBkaltQqnfhUwIJ44vgqCU6d3ogS8uV6v9jm8BhuBJ+ynczIQSDT1BXYHA4ULCHdPB6 Y3ydPknJC8/8yDIx99b7K+yFAW3APWLoNaH99Y7RhUz/HMLNl0bVuFvdRlS8C3R07eRU ye6bkxvkNqp5TYJC2Lyx9L9aKxVDkU1+HJsuzeiNtiSJDbkmOeFf8Ftq34OaZSyH3pP8 nzEA== X-Gm-Message-State: AOAM532wqeSk0/NtPnNEtvs/vaMGzcLZjQ2L4L/4rt3blExHwfN+eqEE wE1netrc7xRMkymRikoz02aD7A== X-Google-Smtp-Source: ABdhPJzL1sNKw04Cq9ph5B5CptO0kinTqyr1VmEW9cNqDDNxuUuADnlPEABS+NrWrRgB+alf+UT/hw== X-Received: by 2002:adf:d0cd:: with SMTP id z13mr5999533wrh.373.1620314685154; Thu, 06 May 2021 08:24:45 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id s83sm3716009wms.16.2021.05.06.08.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 08:24:44 -0700 (PDT) From: "Basil L. Contovounesios" To: martin rudalics Subject: Re: bug#48229: 28.0.50; C-g leaves inactive minibuffer selected with pop-up-frames References: <87zgxaqzca.fsf@tcd.ie> Date: Thu, 06 May 2021 16:24:43 +0100 In-Reply-To: (martin rudalics's message of "Thu, 6 May 2021 09:45:38 +0200") Message-ID: <878s4r3mx0.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: Alan Mackenzie , 48229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 47766 48229 quit martin rudalics writes: >> Ignore the missing scrollbar; that's a separate long-standing issue ;). > > You mean a missing slider and a strange background? Yes, although the background isn't strange: it's a small section of a scenic wallpaper from my home country, I think you'd like it ;). > Would it help to put scroll bars on the right? Yes, I no longer get a missing slider after (set-scroll-bar-mode 'right). > In either case we should investigate this, or at least document it. Indeed, it's on my todo to report this properly (I also get a missing menu bar sometimes with Lucid/GTK, but I only notice it when I'm in the middle of something else in 'emacs -Q', because in my config I have all of these elements disabled), but I need to study for my finals first. >> 3. q >> >> As part of another long-standing issue on Xmonad (I guess because it >> doesn't really do invisibility/minimisation/what-have-you), this >> actually retains the *Completions* frame (which is still highlighted as >> focused by the WM), but now neither frame looks "active" (all three >> visible cursors are hollow): > > Have you ever tried to customize `frame-auto-hide-function'? Yes, in my config I have: (defun blc-delete-spare-frame (&optional frame force) "Delegate to `delete-frame' unless FRAME is alone in terminal." (unless (eq (next-frame) (selected-frame)) (delete-frame frame force))) (setq-default frame-auto-hide-function #'blc-delete-spare-frame) amongst various other settings and advice to elevate the citizenship status of pop-up-frames. > If it's really impossible to get rid of that frame, we should document > it too. > >> 4. Close the *Completions* frame. In Xmonad that's Mod-Shift-c by >> default. >> >> The minibuffer of the original frame is now selected: >> >> 5. C-g >> >> This leaves the inactive minibuffer selected: > > But C-x o will select another window, right? Right, but thereafter any use of the minibuffer leaves the minibuffer selected at the end, that is until I type C-x o again. Anyway, I can no longer reproduce the recipe in the OP following: Fix wrong handling of minibuffers when frames get iconified/made invisible c873d16af6 2021-05-06 10:48:14 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=c873d16af61ae9b956c6dd6d9e50ebad2bb7666e So I'm merging this report with bug#47766. As Gregory points out, the related bug#48249 remains. Thanks, -- Basil