GNU bug report logs - #47730
[PATCH 0/4] gnu: add watson

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Sebastian Gibb <mail <at> sebastiangibb.de>, 47730 <at> debbugs.gnu.org
Subject: [bug#47730] [PATCH 4/4] gnu: Add watson.
Date: Mon, 12 Apr 2021 21:42:08 +0200

[Message part 1 (text/plain, inline)]

On Mon, 2021-04-12 at 17:48 +0200, Sebastian Gibb via Guix-patches via wrote:
> [...]
> +     `(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _
> +                      (invoke "pytest")
> +                      #t)))))

Phases do not need to return #t anymore.  The warning that results
if a phase doesn't return #t has been removed on the core-updates
branch, which will at some point in time be merged in master.

From a cursory look, I don't see any other problems, except perhaps ...

> +    (synopsis
> +     "Command-line time tracker")

I don't see a reason for a newline afer 'synopsis' here.

Thanks,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.