GNU bug report logs - #47726
[PATCH] gnu: Add vice emulator

Previous Next

Full log

View this message in rfc822 format

From: Felipe Balbi <balbi <at> kernel.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 47726-done <at> debbugs.gnu.org
Subject: [bug#47726] [PATCH] gnu: Add vice emulator
Date: Mon, 26 Apr 2021 21:57:04 +0300

Hi,

On Mon, Apr 26, 2021 at 9:55 PM Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
>
> Hello,
>
> balbi <at> kernel.org writes:
>
> > From: Felipe Balbi <balbi <at> kernel.org>
> >
> > * gnu/packages/emulators.scm (vice): New variable.
>
> Thank you! I applied it.

Awesome, thanks :-)

> > Signed-off-by: Felipe Balbi <balbi <at> kernel.org>
>
> We don't have the habit of signing our own patches.
>
> > +       (uri (string-append "mirror://sourceforge/vice-emu/releases/"
> > +                           name "-" version ".tar.gz"))
>
> Nitpick: we hard-code the name in the URI.

sure thing, I'll keep that in mind next time :-)

I did see a couple packages doing that, though.

-- 
balbi

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.