Subject: Re: [bug#47726] [PATCH] gnu: Add vice emulator

From: Nicolas Goaziou <[email-masked]>
Date: Mon, 26 Apr 2021 20:55:33 +0200

Hello,

[email-masked] writes:

> From: Felipe Balbi <[email-masked]>
>
> * gnu/packages/emulators.scm (vice): New variable.

Thank you! I applied it.

> Signed-off-by: Felipe Balbi <[email-masked]>

We don't have the habit of signing our own patches.

> +       (uri (string-append "mirror://sourceforge/vice-emu/releases/"
> +                           name "-" version ".tar.gz"))

Nitpick: we hard-code the name in the URI.

Regards,
-- 
Nicolas Goaziou