GNU bug report logs - #47722
[PATCH] gnu: python-mechanicalsoup: Update to 1.0.0

Previous Next

Full log

Message #8 received at 47722 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 47722 <at> debbugs.gnu.org
Subject: Re: [bug#47722] [PATCH] gnu: python-mechanicalsoup: Update to 1.0.0
Date: Mon, 12 Apr 2021 17:04:09 +0200

[Message part 1 (text/plain, inline)]

On Mon, 2021-04-12 at 10:22 +0000, Ekaitz Zarraga wrote:
> From 3fe85d531c56e025868eb90def1b491a9fa32a60 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Mon, 12 Apr 2021 12:15:44 +0200
> Subject: [PATCH] gnu: python-mechanicalsoup: Update to 1.0.0
> 
>     * gnu/packages/python-web.scm (python-mechanicalsoup): Update to
>     1.0.0.
>     (python-machanicalsoup): Enable tests
Nitpick: a period after ‘Enable tests’.

Unlike in "ChangeLog" files, the changelog entry in commit messages
are not indented.  These tabs can be removed.

> ---
>  gnu/packages/python-web.scm | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index c79fa1bfc4..e842112e97 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -40,6 +40,7 @@
>  ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
>  ;;; Copyright © 2020 Konrad Hinsen <konrad.hinsen <at> fastmail.net>
>  ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
> +;;; Copyright © 2021 Ekaitz Zarraga <ekaitz <at> elenq.tech>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -795,29 +796,27 @@ object graph to and from JSON.")
>  (define-public python-mechanicalsoup
>    (package
>      (name "python-mechanicalsoup")
> -    (version "0.11.0")
> +    (version "1.0.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "MechanicalSoup" version))
>         (sha256
> -        (base32 "0k59wwk75q7nz6i6gynvzhagy02ql0bv7py3qqcwgjw7607yq4i7"))))
> +        (base32 "01sddjxy3rznh63hnl5lbv1hhk6xyiviwmkiw4x7v4ap35fb3lrp"))))
>      (build-system python-build-system)
> -    (arguments
> -     ;; TODO: Enable tests when python-flake8 <at> 3.5 hits master.
> -     `(#:tests? #f))

Nice!

Warning: I haven't tried to build this.  But from a cursory look, the patch LGTM!
This package has one depending package: hangups <at> 0.4.13.  Does that package still
build?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.