GNU bug report logs - #47710
[PATCH] website: Fix dropdown menu shrinking when clicked

Previous Next

Full log

Message #13 received at 47710 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 47710 <at> debbugs.gnu.org
Subject: Re: [bug#47710] [PATCH] website: Fix dropdown menu shrinking when
 clicked
Date: Sun, 11 Apr 2021 23:48:56 +0200

On Sun, Apr 11, 2021 at 03:35:32PM +0000, Luis Felipe via Guix-patches via wrote:
> Subject: [PATCH] website: Fix dropdown menu shrinking when clicked.
> […]
> This change fixes these problems by leaving the menu width as wide as
> its longest item when the button is toggled.

Thank you, this does the trick.  (Except on Microsoft Internet
Explorer, which we do not need to care about anymore.)

> * apps/base/templates/components.scm (menu-dropdown): Set width to
>   max-content on :checked.

The last line should not be indented, but it does not matter.

> ---
>  website/apps/base/templates/components.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
> index 5440408..f521436 100644
> --- a/website/apps/base/templates/components.scm
> +++ b/website/apps/base/templates/components.scm
> @@ -310,7 +310,7 @@ manual.
>  {
>      min-width: 150px;
>      /* reset to initial values: */
> -    width: auto;
> +    width: max-content;
>      height: auto;
>      overflow: visible;
>  }"))

The comment /* reset to initial values: */ is misplaced now;
max-content is not an initial value for width.  I have moved the
comment down one line in commit
81a6c477d92b2c4a206c390b97c9cb0159d79719.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.