GNU bug report logs - #47705
[PATCH] EWW: Customize display of images

Previous Next

Package: emacs;

Reported by: Ralph Schleicher <rs <at> ralph-schleicher.de>

Date: Sun, 11 Apr 2021 10:16:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ralph Schleicher <rs <at> ralph-schleicher.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47705 <at> debbugs.gnu.org
Subject: bug#47705: [PATCH] EWW: Customize display of images
Date: Mon, 12 Apr 2021 19:36:15 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> Additionally, images or ALT texts are always displayed on a line by
>> itself.  This may waste a lot of vertical space, e.g. when displaying
>> the Common Lisp HyperSpec.  The attached patch fixes these issues.
>
> But not this bit.
[...]
> shr should instead include images in-line if they are "small" -- i.e.,
> if they've got a height that's somewhat comparable to the line height,
> but not otherwise.
>
> This sounds like trivial thing to do, but it's not -- we don't know the
> size of the images until we load them (usually), and shr doesn't to
> re-flowing at all.
>
> shr could do inline images if the images have known width/heights (and
> the images are "small"), though.  Patches welcome.

I see your point.  Would it be acceptable if, as a first step, inlining
of images is combined with shr-inhibit-images non-nil?  Then we know
that the ALT texts fit into a line.

-- 
Ralph





This bug report was last modified 4 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.