GNU bug report logs - #47704
[PATCH] services: mysql: Add extra-environment as configuration option.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: david larsson <david.larsson <at> selfhosted.xyz>
Subject: bug#47704: closed (Re: [bug#47704] [PATCH] services: mysql: Add
 extra-environment as configuration option.)
Date: Tue, 13 Apr 2021 17:00:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#47704: [PATCH] services: mysql: Add extra-environment as configuration option.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 47704 <at> debbugs.gnu.org.

-- 
47704: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47704
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Maxime Devos <maximedevos <at> telenet.be>, david larsson
 <david.larsson <at> selfhosted.xyz>
Cc: 47704-done <at> debbugs.gnu.org
Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as
 configuration option.
Date: Tue, 13 Apr 2021 18:58:57 +0200

Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos:
> I think your original patch is good to go into the git repo.  I'll
> open a
> separate bug report about ‘absolutising’ the binaries referred to
> from the scripts.
I've pushed this patch now, but let us still look for a smaller
solution if applicable.  (That said, I'm not a mysql user and I'm happy
to leave security stuff to lle_bout.)

@david: Note, that I did not change the author, meaning it is committed
as "methuselah-0 <david.larsson <at> selfhosted.xyz>" rather than 
"david larsson <david.larsson <at> selfhosted.xyz>".  Since this patch is
hopefully small enough to not require attribution, that is fine, but if
you plan on making bigger changes, please consider setting your git up
appropriately.

Regards,
Leo 

[Message part 3 (message/rfc822, inline)]

From: david larsson <david.larsson <at> selfhosted.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: mysql: Add extra-environment as configuration
 option.
Date: Sun, 11 Apr 2021 10:44:43 +0200

[Message part 4 (text/plain, inline)]

Hi!
This patch is needed for the Galera add-on to MariaDB, which runs some 
scripts like for example wsrep_sst_rsync that needs access to additional 
binaries in PATH.

I tested the patch with (and without) below snippets to the 
mysql-service in my config.scm and successfully connected to a 
MariaDB/Galera cluster.

I ran these commands to test:
guix pull --url=/home/user1/src/guix --profile=/tmp/guix.master 
--disable-authentication --allow-downgrades ; 
GUIX_PROFILE="/tmp/guix.master" ; . "$GUIX_PROFILE/etc/profile" ; guix 
system reconfigure config.scm --fallback --allow-downgrades

------------------------------------------------------------------

(extra-environment #~(list (string-append "PATH=/usr/bin:/bin:" #$rsync 
"/bin:" #$coreutils "/bin:" #$gawk "/bin:" #$grep "/bin:" #$mariadb 
"/bin:" #$iproute "/sbin:" 
"/run/setuid-programs:/run/current-system/profile/bin:/run/current-system/profile/sbin" 
) (string-append "SHELL=" #$bash) "USER=mysql" 
"SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt" 
"SSL_CERT_DIR=/run/current-system/profile/etc/ssl/certs"))


(extra-content #~(string-append "log_error=/var/lib/mysql/log_error.log
# 
https://www.percona.com/blog/2017/07/26/what-is-innodb_autoinc_lock_mode-and-why-should-i-care/
binlog_format=ROW
default-storage-engine=innodb
innodb_autoinc_lock_mode=2

# Galera Provider Configuration
wsrep_on=ON
wsrep_provider=" #$galera "/lib/libgalera_smm.so

# Galera Cluster Configuration
wsrep_cluster_name=\"test_cluster\"
wsrep_cluster_address=\"gcomm://redacted,redacted\"
# according to 
https://galeracluster.com/library/documentation/mysql-wsrep-options.html
# leaving it empty starts a new cluster, so you should immediately 
reconfigure again after doing this.
#wsrep_cluster_address=\"gcomm://\"

# Galera Synchronization Configuration
wsrep_sst_method=rsync

# Galera Node Configuration
wsrep_node_address=\"redacted\"
wsrep_node_name=\"librem13v3guixsd\""))
                               ))

------------------------------------------------------------------

Please someone also review [bug#47517] [PATCH] gnu: nginx: Enable stream 
module

which adds support for tcp loadbalancing that can be used to scale a 
MariaDB/Galera cluster.

Best regards,
David

[0001-services-mysql-Add-extra-environment-as-configuratio.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.