From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 04:45:14 2021 Received: (at submit) by debbugs.gnu.org; 11 Apr 2021 08:45:14 +0000 Received: from localhost ([127.0.0.1]:53962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVViN-0003hX-T5 for submit@debbugs.gnu.org; Sun, 11 Apr 2021 04:45:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:48412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVViJ-0003hI-O7 for submit@debbugs.gnu.org; Sun, 11 Apr 2021 04:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVViJ-0005Cj-Gk for guix-patches@gnu.org; Sun, 11 Apr 2021 04:45:03 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:51200) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVViG-0007dI-BN for guix-patches@gnu.org; Sun, 11 Apr 2021 04:45:03 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 9773B1D08398 for ; Sun, 11 Apr 2021 10:44:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1618130689; bh=NvxHACZ+e8H7FjsLRsozdI8CQBzraNkq+U9du13nHi4=; h=Date:From:To:Subject; b=VRyJZl8DLggIar6Nj2heDxnHZeirzGSX+uXJyMTVsbarMGvx//kvhnxrRtJnl2WD7 PRBTFNanZL+4I0deTkqMos8bHUsfd4LJNiKvc3daNv0ZBvVBq+f12T8xWROCwNXit5 JLay3BKeOOqQv8FwT3fz8VG4FdnA1mRBHnw+z344mKMfI6TcMGG88o3lV358Wj06TT 89ArMmx0qy6JpxxS9tEXNi0B8XW0BoGr0p5uRp6Q1GPWT9DDsvooTssR70JaG4ERw3 IncwCQYgErQ/Kmklw8M4Vjzc35xf+ve6IlNZBdOxTv7OVutOq9jitexCjfKYHz8ju9 vdj0EFH0ahS0Q== X-Fuglu-Suspect: 4ccbea31caa04b95a9482c87fb3ed6d5 X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA for ; Sun, 11 Apr 2021 10:44:43 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_e3c828103ebcd526c94d2436e10c1ce5" Date: Sun, 11 Apr 2021 10:44:43 +0200 From: david larsson To: guix-patches@gnu.org Subject: [PATCH] services: mysql: Add extra-environment as configuration option. Message-ID: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz Received-SPF: pass client-ip=217.64.149.7; envelope-from=david.larsson@selfhosted.xyz; helo=server0.selfhosted.xyz X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=1.33, PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi! This patch is needed for the Galera add-on to MariaDB, which runs some scripts like for example wsrep_sst_rsync that needs access to additional binaries in PATH. I tested the patch with (and without) below snippets to the mysql-service in my config.scm and successfully connected to a MariaDB/Galera cluster. Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=david.larsson%40selfhosted.xyz; ip=209.51.188.17; r=debbugs.gnu.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 1.3 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi! This patch is needed for the Galera add-on to MariaDB, which runs some scripts like for example wsrep_sst_rsync that needs access to additional binaries in PATH. I tested the patch with (and without) below snippets to the mysql-service in my config.scm and successfully connected to a MariaDB/Galera cluster. Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=david.larsson%40selfhosted.xyz;ip=209.51.188.17;r=debbugs.gnu.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD --=_e3c828103ebcd526c94d2436e10c1ce5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi! This patch is needed for the Galera add-on to MariaDB, which runs some scripts like for example wsrep_sst_rsync that needs access to additional binaries in PATH. I tested the patch with (and without) below snippets to the mysql-service in my config.scm and successfully connected to a MariaDB/Galera cluster. I ran these commands to test: guix pull --url=/home/user1/src/guix --profile=/tmp/guix.master --disable-authentication --allow-downgrades ; GUIX_PROFILE="/tmp/guix.master" ; . "$GUIX_PROFILE/etc/profile" ; guix system reconfigure config.scm --fallback --allow-downgrades ------------------------------------------------------------------ (extra-environment #~(list (string-append "PATH=/usr/bin:/bin:" #$rsync "/bin:" #$coreutils "/bin:" #$gawk "/bin:" #$grep "/bin:" #$mariadb "/bin:" #$iproute "/sbin:" "/run/setuid-programs:/run/current-system/profile/bin:/run/current-system/profile/sbin" ) (string-append "SHELL=" #$bash) "USER=mysql" "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt" "SSL_CERT_DIR=/run/current-system/profile/etc/ssl/certs")) (extra-content #~(string-append "log_error=/var/lib/mysql/log_error.log # https://www.percona.com/blog/2017/07/26/what-is-innodb_autoinc_lock_mode-and-why-should-i-care/ binlog_format=ROW default-storage-engine=innodb innodb_autoinc_lock_mode=2 # Galera Provider Configuration wsrep_on=ON wsrep_provider=" #$galera "/lib/libgalera_smm.so # Galera Cluster Configuration wsrep_cluster_name=\"test_cluster\" wsrep_cluster_address=\"gcomm://redacted,redacted\" # according to https://galeracluster.com/library/documentation/mysql-wsrep-options.html # leaving it empty starts a new cluster, so you should immediately reconfigure again after doing this. #wsrep_cluster_address=\"gcomm://\" # Galera Synchronization Configuration wsrep_sst_method=rsync # Galera Node Configuration wsrep_node_address=\"redacted\" wsrep_node_name=\"librem13v3guixsd\"")) )) ------------------------------------------------------------------ Please someone also review [bug#47517] [PATCH] gnu: nginx: Enable stream module which adds support for tcp loadbalancing that can be used to scale a MariaDB/Galera cluster. Best regards, David --=_e3c828103ebcd526c94d2436e10c1ce5 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-services-mysql-Add-extra-environment-as-configuratio.patch Content-Disposition: attachment; filename=0001-services-mysql-Add-extra-environment-as-configuratio.patch; size=2954 RnJvbSA5Mjc0NDQ2NTJmNGI3NzQ5MjhkZTc4YzE1NThiNGU5NDJhYmZmMjAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZXRodXNlbGFoLTAgPGRhdmlkLmxhcnNzb25Ac2VsZmhvc3Rl ZC54eXo+CkRhdGU6IFN1biwgMTEgQXByIDIwMjEgMTA6MzA6MDEgKzAyMDAKU3ViamVjdDogW1BB VENIXSBzZXJ2aWNlczogbXlzcWw6IEFkZCBleHRyYS1lbnZpcm9ubWVudCBhcyBjb25maWd1cmF0 aW9uCiBvcHRpb24uCgoqIGdudS9zZXJ2aWNlcy9kYXRhYmFzZXMuc2NtIChteXNxbC1jb25maWd1 cmF0aW9uKTogQWRkIGV4dHJhLWVudmlyb25tZW50CihteXNxbC1zZXJ2aWNlKTogVXNlICM6bG9n LWZpbGUgYW5kICM6ZW52aXJvbm1lbnQtdmFyaWFibGVzCgoqIGRvYy9ndWl4LnRleGk6IERvY3Vt ZW50IGl0LgotLS0KIGRvYy9ndWl4LnRleGkgICAgICAgICAgICAgIHwgMyArKysKIGdudS9zZXJ2 aWNlcy9kYXRhYmFzZXMuc2NtIHwgNyArKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9ndWl4LnRleGkgYi9kb2Mv Z3VpeC50ZXhpCmluZGV4IGMyM2QwNDRmZjUuLjI5ODU4NWE2OTUgMTAwNjQ0Ci0tLSBhL2RvYy9n dWl4LnRleGkKKysrIGIvZG9jL2d1aXgudGV4aQpAQCAtMTk4MDksNiArMTk4MDksOSBAQCBTb2Nr ZXQgZmlsZSB0byB1c2UgZm9yIGxvY2FsIChub24tbmV0d29yaykgY29ubmVjdGlvbnMuCiBAaXRl bSBAY29kZXtleHRyYS1jb250ZW50fSAoZGVmYXVsdDogQGNvZGV7IiJ9KQogQWRkaXRpb25hbCBz ZXR0aW5ncyBmb3IgdGhlIEBmaWxle215LmNuZn0gY29uZmlndXJhdGlvbiBmaWxlLgogCitAaXRl bSBAY29kZXtleHRyYS1lbnZpcm9ubWVudH0gKGRlZmF1bHQ6IEBjb2RleyN+JygpfSkKK0xpc3Qg b2YgZW52aXJvbm1lbnQgdmFyaWFibGVzIHBhc3NlZCB0byB0aGUgQGNvbW1hbmR7bXlzcWxkfSBw cm9jZXNzLgorCiBAaXRlbSBAY29kZXthdXRvLXVwZ3JhZGU/fSAoZGVmYXVsdDogQGNvZGV7I3R9 KQogV2hldGhlciB0byBhdXRvbWF0aWNhbGx5IHJ1biBAY29tbWFuZHtteXNxbF91cGdyYWRlfSBh ZnRlciBzdGFydGluZyB0aGUKIHNlcnZpY2UuICBUaGlzIGlzIG5lY2Vzc2FyeSB0byB1cGdyYWRl IHRoZSBAZGZue3N5c3RlbSBzY2hlbWF9IGFmdGVyCmRpZmYgLS1naXQgYS9nbnUvc2VydmljZXMv ZGF0YWJhc2VzLnNjbSBiL2dudS9zZXJ2aWNlcy9kYXRhYmFzZXMuc2NtCmluZGV4IGE4NDFlN2E1 MGUuLjhkMjY2YzFjYmEgMTAwNjQ0Ci0tLSBhL2dudS9zZXJ2aWNlcy9kYXRhYmFzZXMuc2NtCisr KyBiL2dudS9zZXJ2aWNlcy9kYXRhYmFzZXMuc2NtCkBAIC03LDYgKzcsNyBAQAogOzs7IENvcHly aWdodCDCqSAyMDE4IEp1bGllbiBMZXBpbGxlciA8anVsaWVuQGxlcGlsbGVyLmV1PgogOzs7IENv cHlyaWdodCDCqSAyMDE5IFJvYmVydCBWb2xsbWVydCA8cm9iQHZsbG1ydC5uZXQ+CiA7OzsgQ29w eXJpZ2h0IMKpIDIwMjAgTWFyaXVzIEJha2tlIDxtYXJpdXNAZ251Lm9yZz4KKzs7OyBDb3B5cmln aHQgwqkgMjAyMSBEYXZpZCBMYXJzc29uIDxkYXZpZC5sYXJzc29uQHNlbGZob3N0ZWQueHl6Pgog Ozs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTUyNyw2ICs1 MjgsNyBAQCBjcmVhdGVkIGFmdGVyIHRoZSBQb3N0Z3JlU1FMIGRhdGFiYXNlIGlzIHN0YXJ0ZWQu IikpKQogICAocG9ydCBteXNxbC1jb25maWd1cmF0aW9uLXBvcnQgKGRlZmF1bHQgMzMwNikpCiAg IChzb2NrZXQgbXlzcWwtY29uZmlndXJhdGlvbi1zb2NrZXQgKGRlZmF1bHQgIi9ydW4vbXlzcWxk L215c3FsZC5zb2NrIikpCiAgIChleHRyYS1jb250ZW50IG15c3FsLWNvbmZpZ3VyYXRpb24tZXh0 cmEtY29udGVudCAoZGVmYXVsdCAiIikpCisgIChleHRyYS1lbnZpcm9ubWVudCBteXNxbC1jb25m aWd1cmF0aW9uLWV4dHJhLWVudmlyb25tZW50IChkZWZhdWx0ICN+JygpKSkKICAgKGF1dG8tdXBn cmFkZT8gbXlzcWwtY29uZmlndXJhdGlvbi1hdXRvLXVwZ3JhZGU/IChkZWZhdWx0ICN0KSkpCiAK IChkZWZpbmUgJW15c3FsLWFjY291bnRzCkBAIC02MTEsMTEgKzYxMywxNCBAQCBGTFVTSCBQUklW SUxFR0VTOwogICAgICAgICAgKHByb3Zpc2lvbiAnKG15c3FsKSkKICAgICAgICAgIChkb2N1bWVu dGF0aW9uICJSdW4gdGhlIE15U1FMIHNlcnZlci4iKQogICAgICAgICAgKHN0YXJ0IChsZXQgKCht eXNxbCAgKG15c3FsLWNvbmZpZ3VyYXRpb24tbXlzcWwgY29uZmlnKSkKKyAgICAgICAgICAgICAg ICAgICAgICAoZXh0cmEtZW52IChteXNxbC1jb25maWd1cmF0aW9uLWV4dHJhLWVudmlyb25tZW50 IGNvbmZpZykpCiAgICAgICAgICAgICAgICAgICAgICAgKG15LmNuZiAobXlzcWwtY29uZmlndXJh dGlvbi1maWxlIGNvbmZpZykpKQogICAgICAgICAgICAgICAgICAgI34obWFrZS1mb3JrZXhlYy1j b25zdHJ1Y3RvcgogICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKHN0cmluZy1hcHBlbmQgIyRt eXNxbCAiL2Jpbi9teXNxbGQiKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1h cHBlbmQgIi0tZGVmYXVsdHMtZmlsZT0iICMkbXkuY25mKSkKLSAgICAgICAgICAgICAgICAgICAg ICM6dXNlciAibXlzcWwiICM6Z3JvdXAgIm15c3FsIikpKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgIzp1c2VyICJteXNxbCIgIzpncm91cCAibXlzcWwiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAjOmxvZy1maWxlICIvdmFyL2xvZy9teXNxbGQubG9nIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIzplbnZpcm9ubWVudC12YXJpYWJsZXMgIyRleHRyYS1lbnYpKSkKICAgICAg ICAgIChzdG9wICN+KG1ha2Uta2lsbC1kZXN0cnVjdG9yKSkpKSkKIAogKGRlZmluZSAobXlzcWwt dXBncmFkZS13cmFwcGVyIG15c3FsIHNvY2tldC1maWxlKQotLSAKMi4zMC4yCgo= --=_e3c828103ebcd526c94d2436e10c1ce5-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 11:33:12 2021 Received: (at 47704) by debbugs.gnu.org; 11 Apr 2021 15:33:12 +0000 Received: from localhost ([127.0.0.1]:55750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVc5I-0007sl-72 for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:33:12 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:38444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVc5F-0007sY-2s for 47704@debbugs.gnu.org; Sun, 11 Apr 2021 11:33:10 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id rTZ7240070mfAB401TZ7bD; Sun, 11 Apr 2021 17:33:07 +0200 Message-ID: Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. From: Maxime Devos To: david larsson , 47704@debbugs.gnu.org Date: Sun, 11 Apr 2021 17:33:01 +0200 In-Reply-To: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-OGB/jXZmRIIb+Z+/SZ7D" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618155187; bh=nzWQkFp8fsuNNjEuxZBiRikhSBLVInF/GUXQ1e8QBls=; h=Subject:From:To:Date:In-Reply-To:References; b=ICCwjfUNnd6QxNusXiq+4qVBcV1j7hY0fmX/GC4WD5PPOsCWAZPx0JuG4fnxV4WcR ixOXh+PtdHMdfhgU4+Ju6vt2ng1oWNORnXEVHMvXxPCXA9LErrqRdjYMqP6HE03Xjj ytVANCOCkf0fMtNuNXuywwLZrOA8cjp9IRB6ZdwoZML6ZgjgPt+7dU7D44ktSFcer3 UdhumIXaO6UpfE4tU+BV+OLGQ1pnS0UZf/jWFza5XV0G/5+ECsgTNt6YTRWInno6JO Xp05A1hApD0SA7DqdpML9ldmi4INkgY5AIU21rDjAfZ5O/bN4kbO5P4Ji412AyZTp8 D9P2rXlIuCySg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47704 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-OGB/jXZmRIIb+Z+/SZ7D Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-04-11 at 10:44 +0200, david larsson wrote: > Hi! > This patch is needed for the Galera add-on to MariaDB, which runs some= =20 > scripts like for example wsrep_sst_rsync that needs access to additional= =20 > binaries in PATH. > [... reordered ...] > (extra-environment #~(list (string-append "PATH=3D/usr/bin:/bin:" #$rsync= =20 > "/bin:" #$coreutils "/bin:" #$gawk "/bin:" #$grep "/bin:" #$mariadb=20 > "/bin:" #$iproute "/sbin:"=20 > "/ Please corect the galera package to refer to the coreutils (ls, stat, ...) by absolute file name instead, using something like (add-after 'install (substitute* "INSTALL-LOCATION/wsrep_sst_rsync" (("\\bls\\b") (string-append (assoc-ref inputs "coreutils") "/bin/ls")) ...)) (Likewise for rsync, gawk, iproute ...) Don't use (which "ls") instead of string-append + assoc-ref! (which "ls") i= s incorrect when cross-compiling; That way, people don't have to fiddle with PATH in their configuration file= . > I tested the patch with (and without) below snippets to the=20 > mysql-service in my config.scm and successfully connected to a=20 > MariaDB/Galera cluster. If possible, consider writing a "system test" automatically testing some very basic functionality of mariadb + galera (gnu/tests/databases.scm)= . > I ran these commands to test: > guix pull --url=3D/home/user1/src/guix --profile=3D/tmp/guix.master=20 > --disable-authentication --allow-downgrades ;=20 > GUIX_PROFILE=3D"/tmp/guix.master" ; . "$GUIX_PROFILE/etc/profile" ; guix= =20 > system reconfigure config.scm --fallback --allow-downgrades >=20 > ------------------------------------------------------------------ >=20 > (extra-environment #~(list ... > > "USER=3Dmysql"=20 > "SSL_CERT_FILE=3D/etc/ssl/certs/ca-certificates.crt"=20 > "SSL_CERT_DIR=3D/run/current-system/profile/etc/ssl/certs")) It seems extra-environment is still useful. "USER=3Dmysql" should probably= be added automatically, though (see my proposal below). >=20 > (extra-content #~(string-append "log_error=3D/var/lib/mysql/log_error.log > #=20 > https://www.percona.com/blog/2017/07/26/what-is-innodb_autoinc_lock_mode-= and-why-should-i-care/ > binlog_format=3DROW > default-storage-engine=3Dinnodb > innodb_autoinc_lock_mode=3D2 >=20 > # Galera Provider Configuration > wsrep_on=3DON > wsrep_provider=3D" #$galera "/lib/libgalera_smm.so >=20 > # Galera Cluster Configuration > wsrep_cluster_name=3D\"test_cluster\" > wsrep_cluster_address=3D\"gcomm://redacted,redacted\" > # according to=20 > https://galeracluster.com/library/documentation/mysql-wsrep-options.html > # leaving it empty starts a new cluster, so you should immediately=20 > reconfigure again after doing this. > #wsrep_cluster_address=3D\"gcomm://\" >=20 > # Galera Synchronization Configuration > wsrep_sst_method=3Drsync >=20 > # Galera Node Configuration > wsrep_node_address=3D\"redacted\" > wsrep_node_name=3D\"librem13v3guixsd\"")) > )) Perhaps you could extend "mysql-configuration" with a "galera" field (with #f as default)? Theoretical example: (mysql-configuration (port A-DIFFERENT-PORT) ;; [...] other fields (galera (package my-version-of-galera) ; optional (cluster-name "test_cluster") (cluster-address "gcom://...") (synchronization-method 'rsync) (node-adress "redacted") (node-name "librem13v3guixsd"))) .. and modify mysql-service-type to insert appropriate configuration entrie= s and perhaps add things to the PATH of the shepherd service as appropriate. Escape hatches like "extra-content" are useful, but this seems a bit neater. > ------------------------------------------------------------------ >=20 > Please someone also review [bug#47517] [PATCH] gnu: nginx: Enable stream= =20 > module I'll take a look at it. Greetings, Maxime.=20 --=-OGB/jXZmRIIb+Z+/SZ7D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHMWrRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ktzAP9Kkf6RoBHbkGmFNTbwbC940xhH V8t0U4rW8DjiwuH0WAD/UgcUarIcTtNxZS86B+sl+P0I/h7gfZxdWPqE8tcnJww= =JcEP -----END PGP SIGNATURE----- --=-OGB/jXZmRIIb+Z+/SZ7D-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 14:07:33 2021 Received: (at 47704) by debbugs.gnu.org; 11 Apr 2021 18:07:33 +0000 Received: from localhost ([127.0.0.1]:55853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVeUf-00035b-D5 for submit@debbugs.gnu.org; Sun, 11 Apr 2021 14:07:33 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:60592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVeUc-00035K-SQ for 47704@debbugs.gnu.org; Sun, 11 Apr 2021 14:07:32 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 9BA581D09FB8; Sun, 11 Apr 2021 20:07:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1618164441; bh=xGrzip8cYdD8fq9ns3hViPvS1MusnSJ5p6rQZMiFoTQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Iuf9yJHd5O7baZ8t3bVyZzNFvfzusO7B+vJRDS9fz52wjtJ3UeGASNRi1LgHviVL7 1AbmIqKyLxM1r/av1BDn1ZhybYjieAHtSaX/aUFVXgONjhjytFdsE4+NJRg1dAlXWp QJkSUM9SLpFSKiIgA0oTvz5P+bU6Pl4TJEW6fr2oHH4NS130C+2Av7oXT/xfSTW0hY ksL0GwKYpwGZR82REj4JzsCuqw2VEdu2pFhz8amZ440o3BND0DO7gH/NpkBmODew85 IoZ/qvFZDKOkDhqKapkbJlb4qefQ4WRR+zUBZ/FBdfrmyQxsJhhBmqXw78Q2BxXJVI 5oOdfIK80gh4g== X-Fuglu-Suspect: a54c7072ac974b14a944803a6fe1bb2a X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Sun, 11 Apr 2021 20:07:15 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 11 Apr 2021 20:07:15 +0200 From: david larsson To: Maxime Devos Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. In-Reply-To: References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> Message-ID: <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Maxime! On 2021-04-11 17:33, Maxime Devos wrote: > Please corect the galera package to refer to the coreutils (ls, stat, > ...) > by absolute file name instead, using something like > > (add-after 'install > (substitute* "INSTALL-LOCATION/wsrep_sst_rsync" > (("\\bls\\b") (string-append (assoc-ref inputs "coreutils") > "/bin/ls")) > ...)) > > (Likewise for rsync, gawk, iproute ...) > > Don't use (which "ls") instead of string-append + assoc-ref! (which > "ls") is > incorrect when cross-compiling; > > That way, people don't have to fiddle with PATH in their configuration > file. I think you misundestood here - these rsync, gawk, iproute etc are executed as part of scripts in the mysqld/bin package output folder (see `ls -la $(dirname $(readlink -f $(which mysqld)))/` ) because the Galera add-on was (at least partially) merged into the regular mariadb sources, so the scripts where the binaries are needed are not from the galera package outputs but the mysql one. The galera package in guix master today only provides the #$galera "/lib/libgalera_smm.so file. I agree it would be nice to patch all the shell scripts in the $#mysql/bin folder but this would 1. require maintaining all the additional patching of those scripts as part of the mysql package and 2. since custom wsrep_sst_ shell scripts are possible and are usually added to /usr/bin/wsrep_sst_ those binaries will also require setting additional environment variables or the same type of patching (which would therefore "require" this patch to make it easier). > If possible, consider writing a "system test" automatically testing > some very basic functionality of mariadb + galera > (gnu/tests/databases.scm). I would have liked to, but Im sorry - I do not have the time/skill for this for the time being. I hope the current patch is simple enough that an additional test is not currently needed. >> I ran these commands to test: >> guix pull --url=/home/user1/src/guix --profile=/tmp/guix.master >> --disable-authentication --allow-downgrades ; >> GUIX_PROFILE="/tmp/guix.master" ; . "$GUIX_PROFILE/etc/profile" ; guix >> system reconfigure config.scm --fallback --allow-downgrades >> >> ------------------------------------------------------------------ >> >> (extra-environment #~(list ... >> >> "USER=mysql" >> "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt" >> "SSL_CERT_DIR=/run/current-system/profile/etc/ssl/certs")) > > It seems extra-environment is still useful. "USER=mysql" should > probably be > added automatically, though (see my proposal below). Yes, in particular for custom wsrep scripts. The "USER=mysql" may not be needed per se for the example snippet config I sent earlier as I did not make sure that the list of environment variables there were the minimal amount needed; I mainly hoped to provide a repeatable example of something to test with. > Perhaps you could extend "mysql-configuration" with a "galera" field > (with #f as default)? Theoretical example: > > (mysql-configuration > (port A-DIFFERENT-PORT) > ;; [...] other fields > (galera > (package my-version-of-galera) ; optional > (cluster-name "test_cluster") > (cluster-address "gcom://...") > (synchronization-method 'rsync) > (node-adress "redacted") > (node-name "librem13v3guixsd"))) > > .. and modify mysql-service-type to insert appropriate configuration > entries > and perhaps add things to the PATH of the shepherd service as > appropriate. > > Escape hatches like "extra-content" are useful, but this seems a bit > neater. This looks nice! I agree that something like what you show here is the better option, at the same time I don't have the time/skill to provide a patch with a well-featured interface to the galera options for the time being. The "escape hatch" would therefore be very useful for now, and less hassle to maintain - compare with for example the vpn service and the amount of emails in the lists regarding lack of options that could have easily been added via some g-expression strings. In general I don't see the harm in providing both "the escape hatch" way to add options to a configuration file and the guile interface which is otherwise nicer (IMO). >> ------------------------------------------------------------------ >> >> Please someone also review [bug#47517] [PATCH] gnu: nginx: Enable >> stream >> module > > I'll take a look at it. Thanks! Best regards, David From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 16:44:19 2021 Received: (at 47704) by debbugs.gnu.org; 11 Apr 2021 20:44:19 +0000 Received: from localhost ([127.0.0.1]:55928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVgwM-0000WR-GK for submit@debbugs.gnu.org; Sun, 11 Apr 2021 16:44:18 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVgwJ-0000WI-W1 for 47704@debbugs.gnu.org; Sun, 11 Apr 2021 16:44:17 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id rYkD2400T0mfAB406YkEzz; Sun, 11 Apr 2021 22:44:14 +0200 Message-ID: <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. From: Maxime Devos To: david larsson Date: Sun, 11 Apr 2021 22:44:09 +0200 In-Reply-To: <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-uAwkIQDLM0cJT3nLpsm8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618173854; bh=UwrrecMC8IUP7WWHfX6NCmwbhaE/9K5Qz5RX7nt+lC4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=imzfSXg9l/JyWgel54R+8GBxKr/LJMQYDWglbD5zhqEoeuNc/MNC4oHw7LBk533hs tTDC/IE21WCDmFsQqhaTQh8EhK1i422PglljV5rNOCKjR+3f3E7e4j0G1+aAV7mjEV TjQ3k74OSzwzCsSVRnlRmEIXwsG99fEfIfOx3yTsAVI0+mIqylvVuOD6FApb/peFpQ LKW8q/FHN6BYamc1HlxlvQWUpQ0iL5YyG+dmXQwVc7KxnhKeKeMyvLXKmtIQiOMCSf +bekjxqeWK/VxSV8x1pUXrq1CSjNhsBCEWDbXZufEaUyz+p4eorOEDfmk2O3t0VJ71 Q11zjAPhcfTtA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-uAwkIQDLM0cJT3nLpsm8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-04-11 at 20:07 +0200, david larsson wrote: > Hi Maxime! >=20 > On 2021-04-11 17:33, Maxime Devos wrote: > > Please corect the galera package to refer to the coreutils (ls, stat,= =20 > > ...) > > by absolute file name instead, using something like > >=20 > > (add-after 'install > > (substitute* "INSTALL-LOCATION/wsrep_sst_rsync" > > (("\\bls\\b") (string-append (assoc-ref inputs "coreutils")=20 > > "/bin/ls")) > > ...)) > >=20 > > (Likewise for rsync, gawk, iproute ...) > >=20 > > Don't use (which "ls") instead of string-append + assoc-ref! (which=20 > > "ls") is > > incorrect when cross-compiling; > >=20 > > That way, people don't have to fiddle with PATH in their configuration= =20 > > file. >=20 > I think you misundestood here - these rsync, gawk, iproute etc are=20 > executed as part of scripts in the mysqld/bin package output folder Ok, I should have asked to modify the mariadb package instead. > (see=20 > `ls -la $(dirname $(readlink -f $(which mysqld)))/` ) because the Galera= =20 > add-on was (at least partially) merged into the regular mariadb sources,= =20 > so the scripts where the binaries are needed are not from the galera=20 > package outputs but the mysql one. The galera package in guix master=20 > today only provides the #$galera "/lib/libgalera_smm.so file. So the mariadb package has the scripts, and the galera package has a librar= y. > I agree it=20 > would be nice to patch all the shell scripts in the $#mysql/bin folder= =20 > but this would 1. require maintaining all the additional patching of=20 > those scripts as part of the mysql package This shouldn't be complicated, though possibly somewhat tedious. I took a look at /gnu/store/bjgz8jnfsbb4qvaa9csfy8i3x1i3ivp7-mariadb-10.5.8= /bin/wsrep_* (your hash may vary). The following should be =E2=80=98absolutised=E2=80= =99: * In wsrep_sst_mariabackup: OS=3D$(uname) sfmt=3D"tar" if pv --help 2>/dev/null | grep -q FORMAT;then mariabackup wsrep_log_error mbstream xbcrypt (*) [more things] * In wsrep_sst_*: other things (eg. rm) The following shouldn't be required, and could be commented out: # Setting the path for lsof on CentOS export PATH=3D"/usr/sbin:/sbin:$PATH" It's a little tedious, but it should be worth it. This could be done in the post-install phase of mariadb. For an (almost) good example on how to =E2=80=98absolutise=E2=80=99, see 'xvfb-run'. Actually, it uses "wh= ich" which is incorrect when cross-compiling, but that can be worked-around by adding (setenv "PATH" (string-append BINDIR-OF-INPUTS-COREUTILS ":" BINDIR-OF-INPUTS-AWK ...)) About xbcrypt (*): I have no idea from which package this comes. Is it an optional dependency? If it is optional, _not_ patching it could make sense, as to avoid increasing the closure. This would extra-environment. > and 2. since custom=20 > wsrep_sst_ shell scripts are possible and are usually added to=20 > /usr/bin/wsrep_sst_ those binaries will also require setting=20 > additional environment variables or the same type of patching > (which would therefore "require" this patch to make it easier). I'd recommend that these custom shell scripts are patched as well, but idk how they would be used with mariadb, perhaps there are some complications here. That said, if that's too much work or too error-prone, I've an alternative proposal below, which is a little more =E2=80=98high level=E2=80=99 than as= king the user to spell out the PATH: Take a look at 'nscd-shepherd-service' in gnu/serices/base.scm: [snip] #:environment-variables (list (string-append "LD_LIBRARY_PATH=3D" (string-join (map (lambda (dir) (string-append dir "/lib")) (list #$@name-services)) ":"))))) Replace LD_LIBRARY_PATH with PATH. Add a "extensions" field to . Replace 'name-services' with 'extensions'. Procedures you need to modify: * mysql-cofiguration-file: add the field to $ * mysql-shepherd-service: add #:environment-variables as appropriate * mysql-upgrade-shepherd-service: also, maybe, I don't know? Possible problems: maybe some scripts need some additional environment variables. Mabe provide both an "extensions" field, and an "extra-environment" field, and combine the results? > > If possible, consider writing a "system test" automatically testing > > some very basic functionality of mariadb + galera=20 > > (gnu/tests/databases.scm). >=20 > I would have liked to, but Im sorry - I do not have the time/skill for= =20 > this for the time being. I hope the current patch is simple enough that= =20 > an additional test is not currently needed. For the patch as you've submitted it, the lack of a system test shouldn't be a problem, as Guix System doesn't support mariadb + galera. The system test is more for if =E2=80=98we=E2=80=99 add a 'galera' field to 'mysql-con= figuration' as I suggested. > > It seems extra-environment is still useful. "USER=3Dmysql" should=20 > > probably be > > added automatically, though (see my proposal below). >=20 > Yes, in particular for custom wsrep scripts. > The "USER=3Dmysql" may not be=20 > needed per se for the example snippet config I sent earlier as I did not= =20 > make sure that the list of environment variables there were the minimal= =20 > amount needed; I mainly hoped to provide a repeatable example of=20 > something to test with. Warning: I didn't actually test your patch. I don't have a mysql service. > > Perhaps you could extend "mysql-configuration" with a "galera" field > > (with #f as default)? Theoretical example: > >=20 > > (mysql-configuration [...] (galera [...])) > > > .. and modify mysql-service-type to insert appropriate configuration= =20 > > entries > > and perhaps add things to the PATH of the shepherd service as=20 > > appropriate. > >=20 > > Escape hatches like "extra-content" are useful, but this seems a bit > > neater. >=20 > This looks nice! I agree that something like what you show here is the= =20 > better option, at the same time I don't have the time/skill to provide a= =20 > patch with a well-featured interface to the galera options for the time= =20 > being. The "escape hatch" would therefore be very useful for now, and=20 > less hassle to maintain - compare with for example the vpn service and= =20 > the amount of emails in the lists regarding lack of options that could= =20 > have easily been added via some g-expression strings. Somewhat off-topic, which e-mails would these be? > In general I don't=20 > see the harm in providing both "the escape hatch" way to add options to= =20 > a configuration file and the guile interface which is otherwise nicer=20 > (IMO). Agreed. I believe the current plan is to: * add the 'extra-environment' escape hatch. * (possibly [dubious-discuss]) Add the extensions field (a list of package objects). This adds the listed packages to PATH. Slightly neater than 'extra-environment', but is not as general as 'extra-environment'. * The contents of 'extra-environment' and and 'extensions' are merged. > Best regards, > David ^W^W^W^W^W Maxime --=-uAwkIQDLM0cJT3nLpsm8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHNfmRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7t3HAP93dk3g0LqnHS4M2eSHlTNxIvUI SDLmLDY9ANYNLptPUAEA1W1G/6CJ+Mk7/whluJgTq9SHJnZ0LLCR2/3C3RQZ+w4= =1nDU -----END PGP SIGNATURE----- --=-uAwkIQDLM0cJT3nLpsm8-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 14:06:34 2021 Received: (at 47704) by debbugs.gnu.org; 12 Apr 2021 18:06:34 +0000 Received: from localhost ([127.0.0.1]:58012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW0xF-0006Cy-J8 for submit@debbugs.gnu.org; Mon, 12 Apr 2021 14:06:34 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:33814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW0xC-0006Cg-Qg for 47704@debbugs.gnu.org; Mon, 12 Apr 2021 14:06:32 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 1E6411D0FC04; Mon, 12 Apr 2021 20:06:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1618250782; bh=9iP7Q2gQ3EARAnJ4/ZPvgKNkUOtl+FUt7C3sipdYIDk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=nv1isoM2jYwOEllbvRYkEyFSFE7Petg0QS7E7eCv4eYi5ngWC+hgm77BnMfu1ywhD Hyp4gavTb1kAve7uR8s/lM4JEkxVHeiBVhDIKkZ/poBZ0GdjcMEjQDpCV6l+rpxf8H hC2CqbZAdtpddQ8mR+Grt2zHUtA602QcWDrJAfoEPe4uO3sIDx+L+8wYNQcQWzon8U 8RvBzenZGN9JGDvuuGv/0qsGe9histPf3zM9kkNCIh4Fzi6qHXb91/jrIb57wcUwEt 9yyIw8CjPzFT/FxzmPrsy/WmbWdDtWRSw1P3jMRoCz0hxWR5cWz49QynNlWgmtB9LP ocVeAsFaVrnWA== X-Fuglu-Suspect: 8a00938977fa4b35a4a2188b027c0d3c X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Mon, 12 Apr 2021 20:06:15 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 12 Apr 2021 20:06:14 +0200 From: david larsson To: Maxime Devos Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. In-Reply-To: <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> Message-ID: <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) >> On 2021-04-11 17:33, Maxime Devos wrote: >> > Please corect the galera package to refer to the coreutils (ls, stat, >> > ...) >> > by absolute file name instead, using something like >> > >> > (add-after 'install >> > (substitute* "INSTALL-LOCATION/wsrep_sst_rsync" >> > (("\\bls\\b") (string-append (assoc-ref inputs "coreutils") >> > "/bin/ls")) >> > ...)) >> > >> > (Likewise for rsync, gawk, iproute ...) I don't think this is a nice solution because for every update to the mysql package would mean to verify that we are actually hitting a bunch of spread out invocations of external programs inside those shell scripts with the regex in the (substitute* .. procedure. I would suggest instead to define a variable like say: (define %default-mysqld-environment #~(list (string-append #$gawk "/bin/awk") ..) which contains all the external commands invoked from the shell scripts in the mysql/bin folder, and append that to the extra-environment list. >> I agree it >> would be nice to patch all the shell scripts in the $#mysql/bin folder >> but this would 1. require maintaining all the additional patching of >> those scripts as part of the mysql package > > This shouldn't be complicated, though possibly somewhat tedious. > I took a look at > /gnu/store/bjgz8jnfsbb4qvaa9csfy8i3x1i3ivp7-mariadb-10.5.8/bin/wsrep_* > (your hash may vary). The following should be ‘absolutised’: > > * In wsrep_sst_mariabackup: > > OS=$(uname) > sfmt="tar" > if pv --help 2>/dev/null | grep -q FORMAT;then > mariabackup > wsrep_log_error > mbstream > xbcrypt (*) > [more things] > * In wsrep_sst_*: other things (eg. rm) > > The following shouldn't be required, and could be commented out: > # Setting the path for lsof on CentOS > export PATH="/usr/sbin:/sbin:$PATH" > > It's a little tedious, but it should be worth it. This could be done > in the post-install phase of mariadb. I find this to be too tedious, and since it introduces maintenance hassle I would prefer my suggestion above. > For an (almost) good example on > how to ‘absolutise’, see 'xvfb-run'. Actually, it uses "which" which > is incorrect when cross-compiling, but that can be worked-around by > adding (setenv "PATH" (string-append BINDIR-OF-INPUTS-COREUTILS ":" > BINDIR-OF-INPUTS-AWK ...)) > > About xbcrypt (*): I have no idea from which package this comes. > Is it an optional dependency? If it is optional, _not_ patching it > could make sense, as to avoid increasing the closure. This would > extra-environment. [..] > That said, if that's too much work or too error-prone, I've an > alternative > proposal below, which is a little more ‘high level’ than asking the > user to > spell out the PATH: > > Take a look at 'nscd-shepherd-service' in gnu/serices/base.scm: > > [snip] > #:environment-variables > (list (string-append "LD_LIBRARY_PATH=" > (string-join > (map (lambda (dir) > (string-append dir "/lib")) > (list #$@name-services)) > ":"))))) > > Replace LD_LIBRARY_PATH with PATH. Add a "extensions" field to > . Replace 'name-services' with 'extensions'. Not sure if you mean to keep /lib in the above procedure and use this for Galera's .so file, or to help set the PATH for the external programs invoked from the shell scripts? AFAIK the galera service requires you to specify the full path to the .so either way, and if you meant to use /bin instead of /lib above; the binaries of the external programs that are needed are sometimes in out/sbin and sometimes in out/bin so this would unfortunately miss programs occasionally. > Procedures you need to modify: > * mysql-cofiguration-file: add the field to $ > * mysql-shepherd-service: add #:environment-variables as appropriate > * mysql-upgrade-shepherd-service: also, maybe, I don't know? > > Possible problems: maybe some scripts need some additional environment > variables. Mabe provide both an "extensions" field, and an > "extra-environment" field, and combine the results? Possibly. What would you say about opening a separate bug report and potentially fix those things in separate PATCH-set? The mysql-upgrade service in particular is something I don't know whether it could benefit from adding some things to the PATH. > For the patch as you've submitted it, the lack of a system test > shouldn't > be a problem, as Guix System doesn't support mariadb + galera. The > system > test is more for if ‘we’ add a 'galera' field to 'mysql-configuration' > as > I suggested. Great! >> The "escape hatch" would therefore be very useful for now, and >> less hassle to maintain - compare with for example the vpn service and >> the amount of emails in the lists regarding lack of options that could >> have easily been added via some g-expression strings. > > Somewhat off-topic, which e-mails would these be? This one for example: https://lists.gnu.org/archive/html/bug-guix/2020-02/msg00321.html But I would also assume that some of the interest in using network-manager's vpn plugin is due to it being hard to cover all the options in openvpn-client-configuration. (There was also an issue with cert and key options being mandatory in openvpn-client-configuration) > Agreed. I believe the current plan is to: > > * add the 'extra-environment' escape hatch. > * (possibly [dubious-discuss]) Add the extensions field (a list of > package objects). This adds the listed packages to PATH. > Slightly neater than 'extra-environment', but is not as general > as 'extra-environment'. > * The contents of 'extra-environment' and and 'extensions' are merged. Can we do or discuss these things in a separately filed BUG report or PATCH? Best regards, David From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 16:09:25 2021 Received: (at 47704) by debbugs.gnu.org; 12 Apr 2021 20:09:25 +0000 Received: from localhost ([127.0.0.1]:58164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2s9-00056U-CX for submit@debbugs.gnu.org; Mon, 12 Apr 2021 16:09:25 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2s6-00056K-Fb for 47704@debbugs.gnu.org; Mon, 12 Apr 2021 16:09:23 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id rw9L2400A0mfAB401w9LuV; Mon, 12 Apr 2021 22:09:21 +0200 Message-ID: <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. From: Maxime Devos To: david larsson Date: Mon, 12 Apr 2021 22:09:14 +0200 In-Reply-To: <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Y1jgmKD75vu75SmyxXkD" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618258161; bh=ZQAW0MWNCelz3u1C5/2j8fTGG2iqy7baJOeSqnefrY8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZSAx7DFG838W7/A2q/b66nJgyc8E6XFST+45gq9sD6wZ8JgBpfWmPscDtT9LCqJRY V9BAqoILBVCs+saDLUZMDGKzZpIp4/NwjZSso7ZlSb07Cnao+Xfdu7sBhAbbSE585/ HcmJZ5fDAleWYn/Hnn0wtmMHDfhrIm1tj1EtAUQujQytF9cil8qOIL84eqlK/NHA6x 9H/+JzVZeXDz4jHHIA6zYhjONBE+/vHUoLe9VxXHaLN0dEQTOHVVhj3zXqMNnaMJ+I 8l3Y4XzbwH0WsCTilZBpTqEkcynR4iTC9eM+Q06ih2l4pjQqTVMW2Pbtx2mzfBud6j vy7QHpmEfWoqw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-Y1jgmKD75vu75SmyxXkD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2021-04-12 at 20:06 +0200, david larsson wrote: > > > On 2021-04-11 17:33, Maxime Devos wrote: > > > > Please corect the galera package to refer to the coreutils (ls, sta= t, > > > > ...) > > > > by absolute file name instead, using something like > > > >=20 > > > > (add-after 'install > > > > (substitute* "INSTALL-LOCATION/wsrep_sst_rsync" > > > > (("\\bls\\b") (string-append (assoc-ref inputs "coreutils") > > > > "/bin/ls")) > > > > ...)) > > > >=20 > > > > (Likewise for rsync, gawk, iproute ...) >=20 > I don't think this is a nice solution because for every update to the=20 > mysql package would mean to verify that we are actually hitting a bunch= =20 > of spread out invocations of external programs inside those shell=20 > scripts with the regex in the (substitute* .. procedure. I would suggest= =20 > instead to define a variable like say: (define=20 > %default-mysqld-environment #~(list (string-append #$gawk "/bin/awk")=20 > ..) which contains all the external commands invoked from the shell=20 > scripts in the mysql/bin folder, and append that to the=20 > extra-environment list. What about inserting a (string-append "export PATH=3D" #$(file-apend gawk "= /bin/awk") ...) line in the scripts? Some of the scripts even already have a PATH=3D... li= ne (PATH=3D/bin:/sbin:/usr/bin or something like that). > I find this to be too tedious, and since it introduces maintenance=20 > hassle I would prefer my suggestion above. Fair enough (-:. > > [...] > > Take a look at 'nscd-shepherd-service' in gnu/serices/base.scm: > >=20 > > [snip] > > #:environment-variables > > (list (string-append "LD_LIBRARY_PATH=3D" > > (string-join > > (map (lambda (dir) > > (string-append dir "/lib")) > > (list #$@name-services)) > > ":"))))) > >=20 > > Replace LD_LIBRARY_PATH with PATH. Add a "extensions" field to > > . Replace 'name-services' with 'extensions'. >=20 > Not sure if you mean to keep /lib in the above procedure and use this=20 > for Galera's .so file, or to help set the PATH for the external programs= =20 > invoked from the shell scripts? I meant for help setting the PATH for the external programs invoked from the shell scripts.=20 > AFAIK the galera service requires you to specify the full path to the=20 > .so either way, and if you meant to use /bin instead of /lib above; the= =20 > binaries of the external programs that are needed are sometimes in=20 > out/sbin and sometimes in out/bin so this would unfortunately miss=20 > programs occasionally. I guess both out/bin and out/sbin could be added to the PATH. > > Procedures you need to modify: > > * mysql-cofiguration-file: add the field to $ > > * mysql-shepherd-service: add #:environment-variables as appropriate > > * mysql-upgrade-shepherd-service: also, maybe, I don't know? > >=20 > > Possible problems: maybe some scripts need some additional environment > > variables. Mabe provide both an "extensions" field, and an > > "extra-environment" field, and combine the results? >=20 > Possibly. What would you say about opening a separate bug report and=20 > potentially fix those things in separate PATCH-set? The mysql-upgrade=20 > service in particular is something I don't know whether it could benefit= =20 > from adding some things to the PATH. mysql-configuration-file deconstruct the struct. I'm= not 100% sure, but I think when you have a (match obj (($ field ...) .= ..)) expression, and you add a field to , you need to add the new field = to $ field ..., in the same order. mysql-shepherd-service: no need to explain, you have modified it in your pa= tch to pass #:enviroment-variables #$extra-env. mysql-upgrade-service: I don't know either. I'm not going to write a patch. I don't have a mysql service on my system; it was only a suggestion. > [...] > This one for example:=20 > https://lists.gnu.org/archive/html/bug-guix/2020-02/msg00321.html > But I would also assume that some of the interest in using=20 > network-manager's vpn plugin is due to it being hard to cover all the=20 > options in openvpn-client-configuration. (There was also an issue with= =20 > cert and key options being mandatory in openvpn-client-configuration) That's an informtive example, thanks! >=20 > > Agreed. I believe the current plan is to: > >=20 > > * add the 'extra-environment' escape hatch. > > * (possibly [dubious-discuss]) Add the extensions field (a list of > > package objects). This adds the listed packages to PATH. > > Slightly neater than 'extra-environment', but is not as general > > as 'extra-environment'. > > * The contents of 'extra-environment' and and 'extensions' are merged. >=20 > Can we do or discuss these things in a separately filed BUG report or=20 > PATCH? These things =3D the 'extensions' field, and merging 'extra-environment' an= d 'extensions'? As I said, it was only a suggestion and I won't be working o= n it. I think your original patch is good to go into the git repo. I'll open a separate bug report about =E2=80=98absolutising=E2=80=99 the binaries refer= red to from the scripts. Note: I do not have commit access. Greetings, Maxime. --=-Y1jgmKD75vu75SmyxXkD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHSo6hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7q13AP9rfOcbfRSxrJ/IrUD5m0AknBXT 11QFKQ/ZZL9txDfhrQD+M/G0DWsn/FKpGkmaLuG/pYOTq+hDCJPSH6AQyE2RBQg= =PgDB -----END PGP SIGNATURE----- --=-Y1jgmKD75vu75SmyxXkD-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 13 12:59:06 2021 Received: (at 47704-done) by debbugs.gnu.org; 13 Apr 2021 16:59:06 +0000 Received: from localhost ([127.0.0.1]:60652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWMNW-0003LE-Bz for submit@debbugs.gnu.org; Tue, 13 Apr 2021 12:59:06 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:41938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWMNT-0003L3-5u for 47704-done@debbugs.gnu.org; Tue, 13 Apr 2021 12:59:04 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FKWz647dHz3wY8; Tue, 13 Apr 2021 18:58:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618333139; bh=2jfvbbos2ejMp7Hb/ricEDzXDaBk8PblUZt5aEZOtf0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=tSCQP+qAZhTVt5hNnkmp8T48H1GR5z8oREhYrbI63k86TOAJpX8yR3LQ1qVRBFi+5 FPYSPCxct/mbTjv3WPbR1HlDpxVMVw5k7zj+OvPOLgcqKl/7n6mHf5LicXl7LoFUVa qS51CddcplaMfOLh4ACADRxoVrN4Dn3wZtaGhFdE= Message-ID: <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. From: Leo Prikler To: Maxime Devos , david larsson Date: Tue, 13 Apr 2021 18:58:57 +0200 In-Reply-To: <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 47704-done Cc: 47704-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos: > I think your original patch is good to go into the git repo. I'll > open a > separate bug report about ‘absolutising’ the binaries referred to > from the scripts. I've pushed this patch now, but let us still look for a smaller solution if applicable. (That said, I'm not a mysql user and I'm happy to leave security stuff to lle_bout.) @david: Note, that I did not change the author, meaning it is committed as "methuselah-0 " rather than "david larsson ". Since this patch is hopefully small enough to not require attribution, that is fine, but if you plan on making bigger changes, please consider setting your git up appropriately. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 13 18:30:18 2021 Received: (at 47704) by debbugs.gnu.org; 13 Apr 2021 22:30:18 +0000 Received: from localhost ([127.0.0.1]:32863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRY2-0007lu-HA for submit@debbugs.gnu.org; Tue, 13 Apr 2021 18:30:18 -0400 Received: from lepiller.eu ([89.234.186.109]:34154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRXx-0007lb-7L for 47704@debbugs.gnu.org; Tue, 13 Apr 2021 18:30:17 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id d3b3aff4; Tue, 13 Apr 2021 22:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=dumgsdDdjjv5 prIXD5fCfTGqxAd1gc31QxxYMRsrnsE=; b=ZSaJ59r4/BzxJwlMbUK9iFrm7flx i40GB9edawpPSRZ+300q2SpcVoAGb+xHiLOgYrchRbbezr0iPHcKNb556wpWAqBx gDwRL9Eoh0beebHTIgO3GpNWb46qehsA9lsAb3ULutZMFTgN5qVAhopdyuQgOp/P My2lq3AnA55aM1dQmg+CBo0qE8St0ph3my7VRVuMCTh4xHUwBMT41YHbEsPlgPE2 2egJd64iCQhtDcRDFolVEsbMixJ9miFK8vAUVUPivqPeEmsS43kPSgQLoUKeuvZO LEI9zkJZMzWUmZwuhBXpKnh+t0BHRk4sZ6zu+qGlLGRLXZUZFE4Rh/6yaA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6762b74e (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 13 Apr 2021 22:30:10 +0000 (UTC) Date: Wed, 14 Apr 2021 00:29:58 +0200 From: Julien Lepiller To: Leo Prikler Subject: Re: bug#47704: [PATCH] services: mysql: Add extra-environment as configuration option. Message-ID: <20210414002958.2c5a6e19@tachikoma.lepiller.eu> In-Reply-To: <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Tue, 13 Apr 2021 18:58:57 +0200, Leo Prikler a écrit : > Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos: > > I think your original patch is good to go into the git repo. I'll > > open a > > separate bug report about ‘absolutising’ the bin [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] 0.0 T_SPF_HELO_TEMPERROR SPF: test of HELO record failed (temperror) -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 47704 Cc: Maxime Devos , 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Le Tue, 13 Apr 2021 18:58:57 +0200, Leo Prikler a =C3=A9crit : > Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos: > > I think your original patch is good to go into the git repo. I'll > > open a > > separate bug report about =E2=80=98absolutising=E2=80=99 the binaries r= eferred to > > from the scripts. =20 > I've pushed this patch now, but let us still look for a smaller > solution if applicable. (That said, I'm not a mysql user and I'm > happy to leave security stuff to lle_bout.) >=20 > @david: Note, that I did not change the author, meaning it is > committed as "methuselah-0 " rather > than "david larsson ". Since this > patch is hopefully small enough to not require attribution, that is > fine, but if you plan on making bigger changes, please consider > setting your git up appropriately. >=20 > Regards, > Leo=20 >=20 >=20 >=20 >=20 Hi! I saw this patch went through, but it updates the Guix Manual while we are in string freeze. The change is very small and close to the start of string freeze, so I'm willing to let it go. However, please refrain from pushing such changes to the manual. Ideally, this patch should have been pushed yesterday or postponed until after the release. As a reminder, the string freeze applies to guix and to the manual. It does not apply to the website, package synopsis and descriptions, nor to the cookbook. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 13 18:39:01 2021 Received: (at 47704) by debbugs.gnu.org; 13 Apr 2021 22:39:01 +0000 Received: from localhost ([127.0.0.1]:32882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRgT-0007zI-9T for submit@debbugs.gnu.org; Tue, 13 Apr 2021 18:39:01 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:65252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRgN-0007z5-OJ for 47704@debbugs.gnu.org; Tue, 13 Apr 2021 18:39:00 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FKgWH0pjJz1LLyL; Wed, 14 Apr 2021 00:38:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FKgWH0pjJz1LLyL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618353531; bh=FluXJmfi2W2BgSFMD4sMQDB77LuBhBjlFtJXurg/03Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dt9IG/b39O+Ix8uhjUihBlo29vq0+Wv+AgoK1sylHFXAdDBXQTM0/D416mRkV2opH c40yJn0Kh5SjuGevvRMay11UsCrD448LferJrgfFFlIhsJvWOTWYDMq/yE/wZiKry0 F5pwSXWLWdUeXualEr6MoM4isW6j6tx6yfybwQrs= Message-ID: <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> Subject: Re: bug#47704: [PATCH] services: mysql: Add extra-environment as configuration option. From: Leo Prikler To: Julien Lepiller Date: Wed, 14 Apr 2021 00:38:50 +0200 In-Reply-To: <20210414002958.2c5a6e19@tachikoma.lepiller.eu> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> <20210414002958.2c5a6e19@tachikoma.lepiller.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien Lepiller: > Le Tue, 13 Apr 2021 18:58:57 +0200, > Leo Prikler a écrit : > > > Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos: > > > I think your original patch is good to go into the git > > > repo. I'll > > > open a > > > separate bug report about ‘absolutising’ the binaries referred to > > > from the scripts. > > I've pushed this patch now, but let us still look for a smaller > > solution if applicable. (That said, I'm not a mysql user and I'm > > happy to leave security stuff to lle_bout.) > > > > @david: Note, that I did not change the author, meaning it is > > committed as "methuselah-0 " rather > > than "david larsson ". Since this > > patch is hopefully small enough to not require attribution, that is > > fine, but if you plan on making bigger changes, please consider > > setting your git up appropriately. > > > > Regards, > > Leo > > > > > > > > > > Hi! > > I saw this patch went through, but it updates the Guix Manual while > we > are in string freeze. The change is very small and close to the start > of string freeze, so I'm willing to let it go. However, please > refrain > from pushing such changes to the manual. Ideally, this patch should > have been pushed yesterday or postponed until after the release. > > As a reminder, the string freeze applies to guix and to the manual. > It > does not apply to the website, package synopsis and descriptions, nor > to the cookbook. > > Thank you! Ahh, my bad, I totally missed that. Would it be better to revert this change until April 18th and then apply it again? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 13 18:56:38 2021 Received: (at 47704) by debbugs.gnu.org; 13 Apr 2021 22:56:38 +0000 Received: from localhost ([127.0.0.1]:32933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRxV-0008RW-V3 for submit@debbugs.gnu.org; Tue, 13 Apr 2021 18:56:38 -0400 Received: from lepiller.eu ([89.234.186.109]:34182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWRxT-0008RN-EA for 47704@debbugs.gnu.org; Tue, 13 Apr 2021 18:56:36 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7bf978cb; Tue, 13 Apr 2021 22:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=qEPeRUBytVyz hg5vxRp0TUF2bUTLY7exelsJ7p7zwNA=; b=k+gNdRYmVsI+r+GCVMSeFzqwfcpF J/dmJhyLdonDSsLTTX5mthZ38LPWcaRfORLA34MHN5m9fB9fSz6UjANPsk8fFwpv ErapOrhapVLvLLAwAcmX8lJLAQLOLSubefOeOmnVKjrpwvB9lsgCKfXuL/2SNQ3E BQQn5FS0Qfrtz/aXGlfueo6CahwUQ2gSYzeGa4BJjYfv/8Be9nqwOZ5cT222Jrpz 473vtDXoPiiLBiqUIjsQUYq82ZsFFuWjYD/zu7EdIFkuVlAT0RDjnTiaiK8p0tZR /YRH4HvX/DwYHzjTX8lC1Lz8RTiYRSFijIti+TcVrgJAkQLWwVat8b+4vA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id df31ad69 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 13 Apr 2021 22:56:33 +0000 (UTC) Date: Wed, 14 Apr 2021 00:56:27 +0200 From: Julien Lepiller To: Leo Prikler Subject: Re: bug#47704: [PATCH] services: mysql: Add extra-environment as configuration option. Message-ID: <20210414005627.6b900925@tachikoma.lepiller.eu> In-Reply-To: <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> <20210414002958.2c5a6e19@tachikoma.lepiller.eu> <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Wed, 14 Apr 2021 00:38:50 +0200, Leo Prikler a écrit : > Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien Lepiller: > > Le Tue, 13 Apr 2021 18:58:57 +0200, > > Leo Prikler a écrit : > > > > > Am Montag, den 12.04.20 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Le Wed, 14 Apr 2021 00:38:50 +0200, Leo Prikler a =C3=A9crit : > Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien Lepiller: > > Le Tue, 13 Apr 2021 18:58:57 +0200, > > Leo Prikler a =C3=A9crit : > > =20 > > > Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos: =20 > > > > I think your original patch is good to go into the git > > > > repo. I'll > > > > open a > > > > separate bug report about =E2=80=98absolutising=E2=80=99 the binari= es referred > > > > to from the scripts. =20 > > > I've pushed this patch now, but let us still look for a smaller > > > solution if applicable. (That said, I'm not a mysql user and I'm > > > happy to leave security stuff to lle_bout.) > > >=20 > > > @david: Note, that I did not change the author, meaning it is > > > committed as "methuselah-0 " rather > > > than "david larsson ". Since this > > > patch is hopefully small enough to not require attribution, that > > > is fine, but if you plan on making bigger changes, please consider > > > setting your git up appropriately. > > >=20 > > > Regards, > > > Leo=20 > > >=20 > > >=20 > > >=20 > > > =20 > >=20 > > Hi! > >=20 > > I saw this patch went through, but it updates the Guix Manual while > > we > > are in string freeze. The change is very small and close to the > > start of string freeze, so I'm willing to let it go. However, please > > refrain > > from pushing such changes to the manual. Ideally, this patch should > > have been pushed yesterday or postponed until after the release. > >=20 > > As a reminder, the string freeze applies to guix and to the manual. > > It > > does not apply to the website, package synopsis and descriptions, > > nor to the cookbook. > >=20 > > Thank you! =20 > Ahh, my bad, I totally missed that. Would it be better to revert this > change until April 18th and then apply it again? >=20 Yeah, it would be nicer for our translators if you could revert the change for now. Can you do it? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 19 05:59:24 2021 Received: (at 47704) by debbugs.gnu.org; 19 Apr 2021 09:59:24 +0000 Received: from localhost ([127.0.0.1]:48467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQge-0005yY-Df for submit@debbugs.gnu.org; Mon, 19 Apr 2021 05:59:24 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:32574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYQgc-0005yQ-OI for 47704@debbugs.gnu.org; Mon, 19 Apr 2021 05:59:23 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FP2N80SlXz1LBRx; Mon, 19 Apr 2021 11:59:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FP2N80SlXz1LBRx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618826360; bh=zbRXZkz88r2OHAonKyVyTYyHEF5bWtM2QVjJ5pobKmM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=NjEq1DGUbRqRH/FKMp8cJwMKldV0JEzxFSvw7bwJWni2CHb89COovYi6ZQMo3cs57 y4Dj2MnPdyPU1elNAvjYpH9ws6HBiDo6sCJIx1J64qWxCPGraJp0s0IizG+tB8pAsd ZIj1aYEqGkolu7CWahhH4zUlL5U48MTA+DQfxl6c= Message-ID: <39c4166f7f0e7a74aa900f92856d7b9a95b5fe40.camel@student.tugraz.at> Subject: Re: bug#47704: [PATCH] services: mysql: Add extra-environment as configuration option. From: Leo Prikler To: Julien Lepiller Date: Mon, 19 Apr 2021 11:59:19 +0200 In-Reply-To: <20210414005627.6b900925@tachikoma.lepiller.eu> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> <20210414002958.2c5a6e19@tachikoma.lepiller.eu> <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> <20210414005627.6b900925@tachikoma.lepiller.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47704 Cc: 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, den 14.04.2021, 00:56 +0200 schrieb Julien Lepiller: > Le Wed, 14 Apr 2021 00:38:50 +0200, > Leo Prikler a écrit : > > > Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien Lepiller: > > > Le Tue, 13 Apr 2021 18:58:57 +0200, > > > Leo Prikler a écrit : > > > > > > [...] > > > Hi! > > > > > > I saw this patch went through, but it updates the Guix Manual > > > while > > > we > > > are in string freeze. The change is very small and close to the > > > start of string freeze, so I'm willing to let it go. However, > > > please > > > refrain > > > from pushing such changes to the manual. Ideally, this patch > > > should > > > have been pushed yesterday or postponed until after the release. > > > > > > As a reminder, the string freeze applies to guix and to the > > > manual. > > > It > > > does not apply to the website, package synopsis and descriptions, > > > nor to the cookbook. > > > > > > Thank you! > > Ahh, my bad, I totally missed that. Would it be better to revert > > this > > change until April 18th and then apply it again? > > > > Yeah, it would be nicer for our translators if you could revert the > change for now. Can you do it? What's the current status w.r.t. string freeze and translations? Is this good to go? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 14:16:03 2021 Received: (at 47704) by debbugs.gnu.org; 27 Apr 2021 18:16:03 +0000 Received: from localhost ([127.0.0.1]:50869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbSFf-0003u6-8l for submit@debbugs.gnu.org; Tue, 27 Apr 2021 14:16:03 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:33900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbSFa-0003tR-I9 for 47704@debbugs.gnu.org; Tue, 27 Apr 2021 14:16:01 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id CFC6E1D6EAE3; Tue, 27 Apr 2021 20:15:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1619547352; bh=O9iiB1TKhwrjh1YNM57AYZmeKi9ht52WXs6uqWFleqg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bdkck2MwsNj8NrdOB/VAZEBZ6cWKJSHcus+t5370skYLwe3futxuqIpb7CCe4ZjFL +D8ClBz3K7j/9qgJBLS4KxsWyBoQ3tnHcP4HpJrHKjx3j4iKb9v3e7s6D5aJPTk9wQ fXFwNbD564ZGff0vVXosJO7s1FeWXYTvWsYxvVtSfJjlys0qB5hB7kgZGlWdWewwEE Qv9Zf+uJAz7+HBQshH8qFaIfbBpGIkJuw0sauZ2iwNHTYAabN+bhRa6ag0k138S8PJ xAkPfiVCOBJzUnt7KGy7LE8BzwCJOgFDeyigMbOKN9UQeGE5lKdOKGHRrDxncFPHzo 6utiCAcsQ52/w== X-Fuglu-Suspect: e929f3671fc844a7978447c43fc1471c X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Tue, 27 Apr 2021 20:15:46 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 27 Apr 2021 20:15:46 +0200 From: david larsson To: Leo Prikler Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. In-Reply-To: <39c4166f7f0e7a74aa900f92856d7b9a95b5fe40.camel@student.tugraz.at> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> <20210414002958.2c5a6e19@tachikoma.lepiller.eu> <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> <20210414005627.6b900925@tachikoma.lepiller.eu> <39c4166f7f0e7a74aa900f92856d7b9a95b5fe40.camel@student.tugraz.at> Message-ID: <01e11520eb02c2c3fedf639a778e24e2@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47704 Cc: Guix-patches , Julien Lepiller , 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 2021-04-19 11:59, Leo Prikler wrote: > Am Mittwoch, den 14.04.2021, 00:56 +0200 schrieb Julien Lepiller: >> Le Wed, 14 Apr 2021 00:38:50 +0200, >> Leo Prikler a écrit : >> >> > Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien Lepiller: >> > > Le Tue, 13 Apr 2021 18:58:57 +0200, >> > > Leo Prikler a écrit : >> > > >> > > [...] >> > > Hi! >> > > >> > > I saw this patch went through, but it updates the Guix Manual >> > > while >> > > we >> > > are in string freeze. The change is very small and close to the >> > > start of string freeze, so I'm willing to let it go. However, >> > > please >> > > refrain >> > > from pushing such changes to the manual. Ideally, this patch >> > > should >> > > have been pushed yesterday or postponed until after the release. >> > > >> > > As a reminder, the string freeze applies to guix and to the >> > > manual. >> > > It >> > > does not apply to the website, package synopsis and descriptions, >> > > nor to the cookbook. >> > > >> > > Thank you! >> > Ahh, my bad, I totally missed that. Would it be better to revert >> > this >> > change until April 18th and then apply it again? >> > >> >> Yeah, it would be nicer for our translators if you could revert the >> change for now. Can you do it? > What's the current status w.r.t. string freeze and translations? Is > this good to go? Ping! :-) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 14:47:41 2021 Received: (at 47704) by debbugs.gnu.org; 27 Apr 2021 18:47:41 +0000 Received: from localhost ([127.0.0.1]:50891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbSkH-0004gB-0H for submit@debbugs.gnu.org; Tue, 27 Apr 2021 14:47:41 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:59070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbSkD-0004g1-VZ for 47704@debbugs.gnu.org; Tue, 27 Apr 2021 14:47:39 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FV9jy1vJtz1LBRv; Tue, 27 Apr 2021 20:47:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FV9jy1vJtz1LBRv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619549254; bh=RBZJD/peApsT2z3KgwA2q4sksG0Qriw616edAqIl/ZU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=i6eecxCa38MUkfap+OACfdiQxK7JZ0lObQsp2PcLkC0zB2M0f8/NEVfLTysuQVy+u I3RBXqhVCEIGea/2JlWsLVnUkfk8zDGuaGmM2TSDhlnNMz+mV5TJpy2I8oZkYir1xC W6QLSZYBBA9W3t0/BF02kbbrWQ5ulVILLE1corqA= Message-ID: Subject: Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option. From: Leo Prikler To: david larsson Date: Tue, 27 Apr 2021 20:47:32 +0200 In-Reply-To: <01e11520eb02c2c3fedf639a778e24e2@selfhosted.xyz> References: <91c1726e12b938f7656d7d7862920f69@selfhosted.xyz> <7d2d1250a3e87ac67c80897bffe0b82c@selfhosted.xyz> <7cfafd05c98540590905ceb5f3cd554fc9e2b79b.camel@telenet.be> <701e03466beb09a26cc25e444382d14e@selfhosted.xyz> <60efaa4ac56f3dda7da44f0e60df921ccdd7bc89.camel@telenet.be> <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at> <20210414002958.2c5a6e19@tachikoma.lepiller.eu> <8202cabb845f308220a32c28c88bc29f75fd1364.camel@student.tugraz.at> <20210414005627.6b900925@tachikoma.lepiller.eu> <39c4166f7f0e7a74aa900f92856d7b9a95b5fe40.camel@student.tugraz.at> <01e11520eb02c2c3fedf639a778e24e2@selfhosted.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47704 Cc: Guix-patches , Julien Lepiller , 47704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Dienstag, den 27.04.2021, 20:15 +0200 schrieb david larsson: > On 2021-04-19 11:59, Leo Prikler wrote: > > Am Mittwoch, den 14.04.2021, 00:56 +0200 schrieb Julien Lepiller: > > > Le Wed, 14 Apr 2021 00:38:50 +0200, > > > Leo Prikler a écrit : > > > > > > > Am Mittwoch, den 14.04.2021, 00:29 +0200 schrieb Julien > > > > Lepiller: > > > > > Le Tue, 13 Apr 2021 18:58:57 +0200, > > > > > Leo Prikler a écrit : > > > > > > > > > > [...] > > > > > Hi! > > > > > > > > > > I saw this patch went through, but it updates the Guix Manual > > > > > while > > > > > we > > > > > are in string freeze. The change is very small and close to > > > > > the > > > > > start of string freeze, so I'm willing to let it go. However, > > > > > please > > > > > refrain > > > > > from pushing such changes to the manual. Ideally, this patch > > > > > should > > > > > have been pushed yesterday or postponed until after the > > > > > release. > > > > > > > > > > As a reminder, the string freeze applies to guix and to the > > > > > manual. > > > > > It > > > > > does not apply to the website, package synopsis and > > > > > descriptions, > > > > > nor to the cookbook. > > > > > > > > > > Thank you! > > > > Ahh, my bad, I totally missed that. Would it be better to > > > > revert > > > > this > > > > change until April 18th and then apply it again? > > > > > > > > > > Yeah, it would be nicer for our translators if you could revert > > > the > > > change for now. Can you do it? > > What's the current status w.r.t. string freeze and > > translations? Is > > this good to go? > > Ping! :-) Pushed once again, thanks for the reminder! From unknown Tue Jun 17 01:44:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 May 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator