From unknown Sun Aug 17 10:19:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#47658] [PATCH] etc/committer: Use git plumbing instead of porcelain Resent-From: Morgan.J.Smith@outlook.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Apr 2021 16:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47658 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47658@debbugs.gnu.org Cc: Morgan Smith X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16178995466171 (code B ref -1); Thu, 08 Apr 2021 16:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Apr 2021 16:32:26 +0000 Received: from localhost ([127.0.0.1]:48080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUXZy-0001bS-7K for submit@debbugs.gnu.org; Thu, 08 Apr 2021 12:32:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:57774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUXZw-0001bK-2N for submit@debbugs.gnu.org; Thu, 08 Apr 2021 12:32:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXZv-0000xE-3w for guix-patches@gnu.org; Thu, 08 Apr 2021 12:32:23 -0400 Received: from mail-mw2nam12olkn2056.outbound.protection.outlook.com ([40.92.23.56]:8256 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXZl-0001Sq-EV for guix-patches@gnu.org; Thu, 08 Apr 2021 12:32:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lP9uTV+92nJO67yg7vpQMHJzJBvtgZrpnOpml4CfTka85STQTu/1YQLzc1CfCAz4SUZ9pQnTxL2ozkh/Ym8Xxt2nQ4BDGB7Lt/mK/tpdF1ptDboEwUwkoakASPootKSPCKZknKlgLCm6IlWbuEteWoSVJmo5A1M10zXVJn2+PEYTipD0H+r2O5zCQYFCHfz/Gg20B2gnQtzFJQ6MTWIhrE2G6i9sE40xEBBaUoml+rIl6/lzpBvG4BVdattnxyXgIOir93QWkEDcWBu/pw9SZ9MKtEAVD4AMpmk70ILt0uBzr4uX5tkMUJ6kvQ7JzzsmVbHJqUjCvUWIJMpvDO3UBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QxAEU87FJQofYq7sbl7iiCYwRWeS9x1nTzV/PE8U2c=; b=lGYzaxm7xy2frwz4gAtAshWcXf1fIDZihvhClbXpi2gFTI5zbjh6CleAE+AMSq8xfn1YKvwzbab/KFjquIZj3q24k/B6qd0G2YkjjL/FF/rz0uNjvFFx8V3FdLYylIT77e0+3m8tRkq4iyb15SoarpadHSdoE5fc+GXYT3qDIGKqpwi1zrlZGCl8V/qbQmiv4vq14br2yy+jeG8KeOYogI6Xyc/3dP1jttBExYX49I/WgvzFbtXnlfXIuRZ7p1ZiHSYvdgwIfg6xeKUEkHmE9jLbirJiA8hw/nxmRFDAHq7vShcFaL28/rZv0ioNuUaRzw64IgQtVrZXthsTaKPtrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QxAEU87FJQofYq7sbl7iiCYwRWeS9x1nTzV/PE8U2c=; b=VT41qlxAgPdBdR6gT3LW+dRGNmKWtkbzYidv0iwiWAdlnj2jrMPWx0HSSbS35TdjmSiQ6E0m+KOntkqbbrGjHqvJ3jRgw4B6U+mkw4pwg0Lb9p9bCyFdjSvUDjn/btx3B5LjbF+BNh4UmomJN26BNkPLYZWRpjUoRRkHfJmS/E9z+3NKxlF8yi+hGdn+bqqCI1TnhjPiMEwODpDasoCCG31ARb9aCHPyGwrodd6DgvWj+ERij0f3kSDhl4ftfmfLyL9rGH/bo6cK4tCaPDqgBxTPQgPW1tIxmceQmdC0wHaiNJ/NlWUdB/jgZJyPIX6kTXANWBpXC3HWt/eKF13n4w== Received: from MW2NAM12FT060.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::45) by MW2NAM12HT158.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::316) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8; Thu, 8 Apr 2021 16:17:05 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2a01:111:e400:fc65::4a) by MW2NAM12FT060.mail.protection.outlook.com (2a01:111:e400:fc65::323) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.6 via Frontend Transport; Thu, 8 Apr 2021 16:17:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:585CBF666806B5A6BB83DDADACA86DD59C74054DCFFB2EE92F4B29156F2AEFCE; UpperCasedChecksum:A6EE6CBC907C3EA8A0665E496E3D1F4B766EC4D526583F60A5653E8073360025; SizeAsReceived:7304; Count:45 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::b92f:829e:18e4:7ba9]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::b92f:829e:18e4:7ba9%2]) with mapi id 15.20.4020.016; Thu, 8 Apr 2021 16:17:05 +0000 From: Morgan.J.Smith@outlook.com Date: Thu, 8 Apr 2021 12:16:35 -0400 Message-ID: X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [vVaUmaZo1QPkUqetyNKYDMV2tc/HRJFn] X-ClientProxiedBy: YQBPR0101CA0080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::13) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20210408161634.5879-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pancake.hitronhub.home (170.52.80.149) by YQBPR0101CA0080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32 via Frontend Transport; Thu, 8 Apr 2021 16:17:03 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c894bf24-72fb-4c87-24be-08d8faa9bf55 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNUUcF99Xf9jcIXGW7k1i2KF2bb3AfKUxzdW0TRytoJ3Ob26cVgjOo+dniOiRxU3IPsEMFCEat81KxRUCE+rC6sebJVOvoA//Ny05TVBC2wveCaPA4uGt3shkbE5ntmfAFiL6Oj9WKHdb5lKwp2PQOLIUqPuxLBd8V2TT6IIOOXhr+RA3pndpnCEsdoacinzqQlDDitgSdLdhHcECZ02DNR6HVcv5gJFg2xNdhN81EkNW9JEWNrl3jCdPnTvqnro0kIWPZBgioKhHAAhArw4vcAWOlsw9yV51/i2zs67QMj/CfLlH0fLHNg4PaXsBdAOiJBMU3rWdgUNXkSP38zZcc6EuX4EvycobQyxKnzOYcETQdWOL7ZmmimxdJHmrk1+g4J+FCTxPqg/hoDRdOP34VlQZppw06Ocq+8bV6W1Mi0JhGqT5HaPHtOUCh0BBwzVxn/1BgQT6qbJ0FCpY8lxYNhBcUr2WPiRRIpNNvfbNtp1fXuRY8oXBWjBhdJHOWpd+yuqTySuNnV2sO8oloMKYYPHaUsQXWxCbFDwpWHeEJOKdGcuMr5BWmQXTF32FC542QdTrIr1w8U5HUdA224tyC4n8/xVP82lUsYK+emelEMCjw6vvOr9iV8Zt1JBq9IxDBx+5cz4FrfkqHkM2Mn8Yc1/Q2sImpuGHk81WXv4/KNFEDpt6xO3Va3rbbfV05UL/IyGwYZoMjl9xcmkHGRxHiFTd+aUn+GPtxc= X-MS-TrafficTypeDiagnostic: MW2NAM12HT158: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ptdUDqqDbeqUiOJIpc5EYfHwYtK6sDaYWuF0HXN0bb1hY1EtjXPtKzYhnGwoniFV44qT+u2TdX1t2Y6X1W7qsPMIALkG4OO+3RxMTUl8wqWPGq/B1WcvwuLIvdQijzCMyWyH2ac1JFpOys5ox6RNrkGFraw+18wm7ziaUvn55MO2tyB2cuJhCoVBorzDu8JhZlNeP5usn28jkj5S6J0b0fTYL3GdkCC/1Xty/vH/xJxQzY1JACyc64MSaYJN3CxM+0fteFMFC4EoLDQ45uD3zeq7k+5ZlpT3bzHWjc12IEJLJ/M4r7Hk9abU7FZNhNPYt0QmUKmnJWwsd0iJ0l1mTad9tyAXqk6jC6nMDRTf1CspaODb9VFvfKfwHmOe+Wz0xEuVCOnc7GRbgdmz79eVZA== X-MS-Exchange-AntiSpam-MessageData: cnRX2LyuMbUX4i7j5nN4FZRqJ3F8Fjd9grmlumC0WgrakfwB5TKVfixF9pIPBenvZosMvQJu0jUEfYNc7WjF9KIGBTmd0+BUia/T57Fbtx4AqtJTH2O6pldnQTq52XTol4j69HpJZm5C5H2VnlcK3w== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c894bf24-72fb-4c87-24be-08d8faa9bf55 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 16:17:05.4251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT060.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT158 Received-SPF: pass client-ip=40.92.23.56; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * etc/committer.scm.in (diff-info): Use git diff-files instead of git diff (old-sexp): Use git cat-file instead of git show (main): Add newline to displayed message --- etc/committer.scm.in | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/etc/committer.scm.in b/etc/committer.scm.in index 7991dc7430..1f19ccfd6d 100755 --- a/etc/committer.scm.in +++ b/etc/committer.scm.in @@ -89,7 +89,7 @@ LINE-NO in PORT." (define (diff-info) "Read the diff and return a list of values." (let ((port (open-pipe* OPEN_READ - "git" "diff" + "git" "diff-files" "--no-prefix" ;; Only include one context line to avoid lumping in ;; new definitions with changes to existing @@ -153,8 +153,9 @@ LINE-NO in PORT." corresponding to the top-level definition containing the staged changes." ;; TODO: We can't seek with a pipe port... (let* ((port (open-pipe* OPEN_READ - "git" "show" (string-append "HEAD:" - (hunk-file-name hunk)))) + "git" "cat-file" "-p" (string-append + "HEAD:" + (hunk-file-name hunk)))) (contents (get-string-all port))) (close-pipe port) (call-with-input-string contents @@ -253,7 +254,7 @@ modifying." (define (main . args) (match (diff-info) (() - (display "Nothing to be done." (current-error-port))) + (display "Nothing to be done.\n" (current-error-port))) (hunks (let-values (((definitions changes) -- 2.31.1 From unknown Sun Aug 17 10:19:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Morgan.J.Smith@outlook.com Subject: bug#47658: closed (Re: Fwd: [PATCH] etc/committer: Use git plumbing instead of porcelain) Message-ID: References: <877dl7uvyo.fsf@elephly.net> X-Gnu-PR-Message: they-closed 47658 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 47658@debbugs.gnu.org Date: Mon, 12 Apr 2021 19:48:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1618256881-17433-1" This is a multi-part message in MIME format... ------------=_1618256881-17433-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47658: [PATCH] etc/committer: Use git plumbing instead of porcelain which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47658@debbugs.gnu.org. --=20 47658: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47658 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1618256881-17433-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47658-done) by debbugs.gnu.org; 12 Apr 2021 19:47:12 +0000 Received: from localhost ([127.0.0.1]:58145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2Wd-0004Vu-Um for submit@debbugs.gnu.org; Mon, 12 Apr 2021 15:47:12 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lW2Wb-0004Vk-0Z for 47658-done@debbugs.gnu.org; Mon, 12 Apr 2021 15:47:10 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1618256820; cv=none; d=zohomail.com; s=zohoarc; b=HHjmXhXcVKKK3XQeWdUfIRlHwRtmpzrk+a+JQIC3g2AUDRob3FT44xGxQx8TyPcTChw/qo5g85lPzuRJI38fAUlPzv3Gx+i+y1YEjn5JXwRAaoY6cGzkWKWmmzSbY3tkxTBeTcxm5q3b32I6lQ2EImeOAU+37GFkwXFF8U7lldw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618256820; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=waS1eO/RV7CBVjq4gkzRwbd80fx8PoEOygPW3NbWOXA=; b=m+N0+XGnzj79YAeRmnFj3YGTdMHATxiJhSD8fQuMb4D6UeYVAC0bVzGHP2K8b/IJiUitQFrcciWAfHM3MdfEwEYLLsKlHdkLuZaIqNOtEAPE/55h7HGzFEwnZ5HQ4UX/5BUYB+RkFc5Pu835FXt6VWtHhqWGf74KnM5S0aS+x84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1618256820; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; bh=waS1eO/RV7CBVjq4gkzRwbd80fx8PoEOygPW3NbWOXA=; b=c5bYNyPKgYbiG/PbmLFEvYV+hlIPZQhNW2W1usjvhxqCgKCq4/sNvEc/No4KC25n f8/CpLF49uR7ozYwSDjwO5oNny1KhSisolQ+aD/QjxVL31NNGgXcUMg64ID/tgq727D zr4Yxa7ktjtvVNSJRwQPKyG80M/RAM9E1OhtgYWY= Received: from localhost (p54ad4dc1.dip0.t-ipconnect.de [84.173.77.193]) by mx.zohomail.com with SMTPS id 1618256818836109.67684702472025; Mon, 12 Apr 2021 12:46:58 -0700 (PDT) References: User-agent: mu4e 1.4.15; emacs 27.2 From: Ricardo Wurmus To: Morgan Smith Subject: Re: Fwd: [PATCH] etc/committer: Use git plumbing instead of porcelain In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 12 Apr 2021 21:46:55 +0200 Message-ID: <877dl7uvyo.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47658-done Cc: 47658-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Subject: [PATCH] etc/committer: Use git plumbing instead of porcelain > Date: Thu, 8 Apr 2021 12:16:35 -0400 > From: Morgan.J.Smith@outlook.com > To: guix-patches@gnu.org > CC: Morgan Smith > > From: Morgan Smith > > * etc/committer.scm.in > (diff-info): Use git diff-files instead of git diff > (old-sexp): Use git cat-file instead of git show > (main): Add newline to displayed message I broke this up into two commits and pushed them. Thank you! -- Ricardo ------------=_1618256881-17433-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Apr 2021 16:32:26 +0000 Received: from localhost ([127.0.0.1]:48080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUXZy-0001bS-7K for submit@debbugs.gnu.org; Thu, 08 Apr 2021 12:32:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:57774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUXZw-0001bK-2N for submit@debbugs.gnu.org; Thu, 08 Apr 2021 12:32:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXZv-0000xE-3w for guix-patches@gnu.org; Thu, 08 Apr 2021 12:32:23 -0400 Received: from mail-mw2nam12olkn2056.outbound.protection.outlook.com ([40.92.23.56]:8256 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXZl-0001Sq-EV for guix-patches@gnu.org; Thu, 08 Apr 2021 12:32:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lP9uTV+92nJO67yg7vpQMHJzJBvtgZrpnOpml4CfTka85STQTu/1YQLzc1CfCAz4SUZ9pQnTxL2ozkh/Ym8Xxt2nQ4BDGB7Lt/mK/tpdF1ptDboEwUwkoakASPootKSPCKZknKlgLCm6IlWbuEteWoSVJmo5A1M10zXVJn2+PEYTipD0H+r2O5zCQYFCHfz/Gg20B2gnQtzFJQ6MTWIhrE2G6i9sE40xEBBaUoml+rIl6/lzpBvG4BVdattnxyXgIOir93QWkEDcWBu/pw9SZ9MKtEAVD4AMpmk70ILt0uBzr4uX5tkMUJ6kvQ7JzzsmVbHJqUjCvUWIJMpvDO3UBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QxAEU87FJQofYq7sbl7iiCYwRWeS9x1nTzV/PE8U2c=; b=lGYzaxm7xy2frwz4gAtAshWcXf1fIDZihvhClbXpi2gFTI5zbjh6CleAE+AMSq8xfn1YKvwzbab/KFjquIZj3q24k/B6qd0G2YkjjL/FF/rz0uNjvFFx8V3FdLYylIT77e0+3m8tRkq4iyb15SoarpadHSdoE5fc+GXYT3qDIGKqpwi1zrlZGCl8V/qbQmiv4vq14br2yy+jeG8KeOYogI6Xyc/3dP1jttBExYX49I/WgvzFbtXnlfXIuRZ7p1ZiHSYvdgwIfg6xeKUEkHmE9jLbirJiA8hw/nxmRFDAHq7vShcFaL28/rZv0ioNuUaRzw64IgQtVrZXthsTaKPtrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QxAEU87FJQofYq7sbl7iiCYwRWeS9x1nTzV/PE8U2c=; b=VT41qlxAgPdBdR6gT3LW+dRGNmKWtkbzYidv0iwiWAdlnj2jrMPWx0HSSbS35TdjmSiQ6E0m+KOntkqbbrGjHqvJ3jRgw4B6U+mkw4pwg0Lb9p9bCyFdjSvUDjn/btx3B5LjbF+BNh4UmomJN26BNkPLYZWRpjUoRRkHfJmS/E9z+3NKxlF8yi+hGdn+bqqCI1TnhjPiMEwODpDasoCCG31ARb9aCHPyGwrodd6DgvWj+ERij0f3kSDhl4ftfmfLyL9rGH/bo6cK4tCaPDqgBxTPQgPW1tIxmceQmdC0wHaiNJ/NlWUdB/jgZJyPIX6kTXANWBpXC3HWt/eKF13n4w== Received: from MW2NAM12FT060.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::45) by MW2NAM12HT158.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::316) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8; Thu, 8 Apr 2021 16:17:05 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2a01:111:e400:fc65::4a) by MW2NAM12FT060.mail.protection.outlook.com (2a01:111:e400:fc65::323) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.6 via Frontend Transport; Thu, 8 Apr 2021 16:17:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:585CBF666806B5A6BB83DDADACA86DD59C74054DCFFB2EE92F4B29156F2AEFCE; UpperCasedChecksum:A6EE6CBC907C3EA8A0665E496E3D1F4B766EC4D526583F60A5653E8073360025; SizeAsReceived:7304; Count:45 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::b92f:829e:18e4:7ba9]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::b92f:829e:18e4:7ba9%2]) with mapi id 15.20.4020.016; Thu, 8 Apr 2021 16:17:05 +0000 From: Morgan.J.Smith@outlook.com To: guix-patches@gnu.org Subject: [PATCH] etc/committer: Use git plumbing instead of porcelain Date: Thu, 8 Apr 2021 12:16:35 -0400 Message-ID: X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [vVaUmaZo1QPkUqetyNKYDMV2tc/HRJFn] X-ClientProxiedBy: YQBPR0101CA0080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::13) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20210408161634.5879-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pancake.hitronhub.home (170.52.80.149) by YQBPR0101CA0080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32 via Frontend Transport; Thu, 8 Apr 2021 16:17:03 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c894bf24-72fb-4c87-24be-08d8faa9bf55 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNUUcF99Xf9jcIXGW7k1i2KF2bb3AfKUxzdW0TRytoJ3Ob26cVgjOo+dniOiRxU3IPsEMFCEat81KxRUCE+rC6sebJVOvoA//Ny05TVBC2wveCaPA4uGt3shkbE5ntmfAFiL6Oj9WKHdb5lKwp2PQOLIUqPuxLBd8V2TT6IIOOXhr+RA3pndpnCEsdoacinzqQlDDitgSdLdhHcECZ02DNR6HVcv5gJFg2xNdhN81EkNW9JEWNrl3jCdPnTvqnro0kIWPZBgioKhHAAhArw4vcAWOlsw9yV51/i2zs67QMj/CfLlH0fLHNg4PaXsBdAOiJBMU3rWdgUNXkSP38zZcc6EuX4EvycobQyxKnzOYcETQdWOL7ZmmimxdJHmrk1+g4J+FCTxPqg/hoDRdOP34VlQZppw06Ocq+8bV6W1Mi0JhGqT5HaPHtOUCh0BBwzVxn/1BgQT6qbJ0FCpY8lxYNhBcUr2WPiRRIpNNvfbNtp1fXuRY8oXBWjBhdJHOWpd+yuqTySuNnV2sO8oloMKYYPHaUsQXWxCbFDwpWHeEJOKdGcuMr5BWmQXTF32FC542QdTrIr1w8U5HUdA224tyC4n8/xVP82lUsYK+emelEMCjw6vvOr9iV8Zt1JBq9IxDBx+5cz4FrfkqHkM2Mn8Yc1/Q2sImpuGHk81WXv4/KNFEDpt6xO3Va3rbbfV05UL/IyGwYZoMjl9xcmkHGRxHiFTd+aUn+GPtxc= X-MS-TrafficTypeDiagnostic: MW2NAM12HT158: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ptdUDqqDbeqUiOJIpc5EYfHwYtK6sDaYWuF0HXN0bb1hY1EtjXPtKzYhnGwoniFV44qT+u2TdX1t2Y6X1W7qsPMIALkG4OO+3RxMTUl8wqWPGq/B1WcvwuLIvdQijzCMyWyH2ac1JFpOys5ox6RNrkGFraw+18wm7ziaUvn55MO2tyB2cuJhCoVBorzDu8JhZlNeP5usn28jkj5S6J0b0fTYL3GdkCC/1Xty/vH/xJxQzY1JACyc64MSaYJN3CxM+0fteFMFC4EoLDQ45uD3zeq7k+5ZlpT3bzHWjc12IEJLJ/M4r7Hk9abU7FZNhNPYt0QmUKmnJWwsd0iJ0l1mTad9tyAXqk6jC6nMDRTf1CspaODb9VFvfKfwHmOe+Wz0xEuVCOnc7GRbgdmz79eVZA== X-MS-Exchange-AntiSpam-MessageData: cnRX2LyuMbUX4i7j5nN4FZRqJ3F8Fjd9grmlumC0WgrakfwB5TKVfixF9pIPBenvZosMvQJu0jUEfYNc7WjF9KIGBTmd0+BUia/T57Fbtx4AqtJTH2O6pldnQTq52XTol4j69HpJZm5C5H2VnlcK3w== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c894bf24-72fb-4c87-24be-08d8faa9bf55 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 16:17:05.4251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT060.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT158 Received-SPF: pass client-ip=40.92.23.56; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Morgan Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * etc/committer.scm.in (diff-info): Use git diff-files instead of git diff (old-sexp): Use git cat-file instead of git show (main): Add newline to displayed message --- etc/committer.scm.in | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/etc/committer.scm.in b/etc/committer.scm.in index 7991dc7430..1f19ccfd6d 100755 --- a/etc/committer.scm.in +++ b/etc/committer.scm.in @@ -89,7 +89,7 @@ LINE-NO in PORT." (define (diff-info) "Read the diff and return a list of values." (let ((port (open-pipe* OPEN_READ - "git" "diff" + "git" "diff-files" "--no-prefix" ;; Only include one context line to avoid lumping in ;; new definitions with changes to existing @@ -153,8 +153,9 @@ LINE-NO in PORT." corresponding to the top-level definition containing the staged changes." ;; TODO: We can't seek with a pipe port... (let* ((port (open-pipe* OPEN_READ - "git" "show" (string-append "HEAD:" - (hunk-file-name hunk)))) + "git" "cat-file" "-p" (string-append + "HEAD:" + (hunk-file-name hunk)))) (contents (get-string-all port))) (close-pipe port) (call-with-input-string contents @@ -253,7 +254,7 @@ modifying." (define (main . args) (match (diff-info) (() - (display "Nothing to be done." (current-error-port))) + (display "Nothing to be done.\n" (current-error-port))) (hunks (let-values (((definitions changes) -- 2.31.1 ------------=_1618256881-17433-1--