GNU bug report logs - #47652
28.0.50; completion-at-point fails in verilog-mode

Previous Next

Package: emacs;

Reported by: Simon McFarlane <sm <at> desu.ne.jp>

Date: Thu, 8 Apr 2021 11:29:01 UTC

Severity: normal

Tags: fixed

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Simon McFarlane <sm <at> desu.ne.jp>
Cc: 47652 <at> debbugs.gnu.org
Subject: bug#47652: 28.0.50; completion-at-point fails in verilog-mode
Date: Mon, 12 Apr 2021 11:46:40 +0200
Simon McFarlane <sm <at> desu.ne.jp> writes:

> After a very pleasant evening with Edebug (seriously, debugging Emacs
> is such a smooth experience) I found what I believe to be the culprit
> and have attached a patch that fixes the issue for me. This is my
> first time contributing to Emacs so I apologize if I've violated the
> mailing list convention or etiquette.

It's a perfect bug report.  :-)

> Happy to make adjustments if my patch isn't quite right.

[...]

> -	       (verilog-func-completion 'module)
> +	       (save-excursion (verilog-func-completion 'module))

I used your general idea here, but I moved the save-excursion into the
function instead of wrapping the call sites in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 41 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.