Subject: Re: [bug#47643] [PATCH staging 07/10] gnu: gst-plugins-bad: Update to 1.18.4.

From: Maxime Devos <[email-masked]>
Date: Fri, 09 Apr 2021 21:33:36 +0200

On Fri, 2021-04-09 at 20:38 +0200, Leo Prikler wrote:
> From: Raghav Gururajan <[email-masked]>
> 
> * gnu/packages/gstreamer.scm (gst-plugins-bad)[version]: Update to 1.18.4.
> [arguments](glib-or-gtk): New argument.
> [phases](pre-check): New phase.
> [propagated-inputs]: Add gstreamer.
> [native-inputs]: Add gettext-minimal, gsettings-desktop-schemas, perl and
> xorg-server-for-tests. Replace python with python-wrapper.
> 
> Signed-off-by: Leo Prikler <[email-masked]>
> ---
>  gnu/packages/gstreamer.scm | 32 +++++++++++++++++++++++++-------
>  1 file changed, 25 insertions(+), 7 deletions(-)
> 
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index 38b4fdbe63..cc739bd904 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -718,17 +718,18 @@ model to base your own plug-in on, here it is.")
>  (define-public gst-plugins-bad
>    (package
>      (name "gst-plugins-bad")
> -    (version "1.18.2")
> +    (version "1.18.4")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://gstreamer.freedesktop.org/src/"
>                                    name "/" name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "06ildd4rl6cynirv3p00d2ddf5is9svj4i7mkahldzhq24pq5mca"))))
> +                "0py8k4pbalm9mxkpjbjxis0gp7g74wg5g4yax5q8rccmany0ds3l"))))
>      (build-system meson-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:glib-or-gtk? #t     ; To wrap binaries and/or compile schemas
> +       #:phases
>         (modify-phases %standard-phases
>           ,@%common-gstreamer-phases
>           ,@(if (string-prefix? "arm" (or (%current-target-system)
> @@ -761,15 +762,32 @@ model to base your own plug-in on, here it is.")
>                   ((".*elements/curlhttpsrc\\.c.*") "")
>                   ;; https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1412
>                   ((".*elements/dtls\\.c.*") ""))
> -               #t))))))
> +               #t)))

Phases do not need to return #t anymore.  IIUC, the warning you
get when phases return something else has been removed on core-updates.

> +         (add-before 'check 'pre-check
> +           (lambda _
> +             ;; Tests require a running X server.
> +             (system "Xvfb :1 +extension GLX &")
> +             (setenv "DISPLAY" ":1")
> +             ;; Tests write to $HOME.
> +             (setenv "HOME" (getcwd))
> +             ;; Tests look for $XDG_RUNTIME_DIR.
> +             (setenv "XDG_RUNTIME_DIR" (getcwd))
> +             ;; For missing '/etc/machine-id'.
> +             (setenv "DBUS_FATAL_WARNINGS" "0")
> +             #t)))))

Likewise.  Likewise for the other patches.  I don't see any other problems
at the moment (I didn't test though).

Greetings,
Maxime.