GNU bug report logs - #47615
[PATCH 0/9] Add 32-bit powerpc support

Previous Next

Full log

Message #161 received at 47615 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: guix-devel <at> gnu.org, Efraim Flashner <efraim <at> flashner.co.il>,
 47615 <at> debbugs.gnu.org
Subject: Re: bug#47615: [PATCH 0/9] Add 32-bit powerpc support
Date: Thu, 06 May 2021 16:51:41 +0200

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Efraim Flashner schreef op do 22-04-2021 om 10:59 [+0300]:
>> * gnu/packages/version-control.scm (mercurial)[arguments]: Skip tests on
>> powerpc-linux.
>> ---
>>  gnu/packages/version-control.scm | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> Unchanged since last patchset, IMO not ready for upstreaming.
>> 
>> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
>> index 4d4b276a10..13e2ccd400 100644
>> --- a/gnu/packages/version-control.scm
>> +++ b/gnu/packages/version-control.scm
>> @@ -1688,7 +1688,11 @@ execution of any hook written in any language before every commit.")
>>                           "--slowtimeout" "86400"
>>                           ;; The test suite takes a long time and produces little
>>                           ;; output by default.  Prevent timeouts due to silence.
>> -                         "-v"))))))))
>> +                         "-v"))))))
>> +       ;; Tests on powerpc-linux take more than 10 hours.
>> +       #:tests? ,(if (string=? "powerpc-linux" (or (%current-system)
>> +                                                   (%current-target-system)))
>> +                   '#f '#t)))
>
> You can remove ' in '#f and '#t here.

You can even write:

  #:tests? (not (string-prefix? "powerpc-" (or …)))

Note: use ‘string-prefix?’ because ‘%current-target-system’ returns a
triplet, not a “system type”.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.