GNU bug report logs - #47615
[PATCH 0/9] Add 32-bit powerpc support

Previous Next

Full log

Message #137 received at 47615 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Efraim Flashner <efraim <at> flashner.co.il>, 47615 <at> debbugs.gnu.org, 
 guix-devel <at> gnu.org
Subject: Re: [bug#47615] [PATCH v2 09/12] gnu: mercurial: Skip tests on
 powerpc-linux.
Date: Thu, 22 Apr 2021 18:41:24 +0200

[Message part 1 (text/plain, inline)]

Efraim Flashner schreef op do 22-04-2021 om 10:59 [+0300]:
> * gnu/packages/version-control.scm (mercurial)[arguments]: Skip tests on
> powerpc-linux.
> ---
>  gnu/packages/version-control.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Unchanged since last patchset, IMO not ready for upstreaming.
> 
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index 4d4b276a10..13e2ccd400 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -1688,7 +1688,11 @@ execution of any hook written in any language before every commit.")
>                           "--slowtimeout" "86400"
>                           ;; The test suite takes a long time and produces little
>                           ;; output by default.  Prevent timeouts due to silence.
> -                         "-v"))))))))
> +                         "-v"))))))
> +       ;; Tests on powerpc-linux take more than 10 hours.
> +       #:tests? ,(if (string=? "powerpc-linux" (or (%current-system)
> +                                                   (%current-target-system)))
> +                   '#f '#t)))

You can remove ' in '#f and '#t here.
That shouldn't cause a derivation change.
Keeping ' is harmless though, it's just superfluous.
Likewise for some other commits.

I'm not really familiar with powerpc and the packages you modified,
so I'm just looking at style, and cross-compilation issues (which you seem
to have covered).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.