Subject: bug#47605: closed (Re: [bug#47605] [PATCH] gnu: Add emacs-mode-line-idle.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 11 Apr 2021 09:12:03 +0000

Your bug report

#47605: [PATCH] gnu: Add emacs-mode-line-idle.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
47605: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47605
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#47605] [PATCH] gnu: Add emacs-mode-line-idle.
From: Nicolas Goaziou <[email-masked]>
To: Eugene Klimov via Guix-patches via <[email-masked]>
Cc: Eugene Klimov <[email-masked]>, [email-masked]
Date: Sun, 11 Apr 2021 11:11:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Eugene Klimov via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-mode-line-idle): New variable.

Thank you. I applied the patch with the tweaks below.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://gitlab.com/ideasman42/emacs-mode-line-idle.git")

I removed the ".git" suffix

> +      (description
> +       "Mode Line Idle (mode-line-idle.el) is a minor mode that
> +provides a convenient way to defer text evaluation in a way that can
> +be easily integrated into existing mode-line's without requiring a
> +minor mode or configuration.

I slightly reworded this part, which looks very odd, to say the least.

> +Mode Line Idle helps to add useful information into the mode-line
> +without slowing down Emacs performance.  While delaying updates is not
> +so difficult, having multiple timers can become awkward when mixed in
> +with the mode-lines configuration.  Instead of avoiding expensive
> +information in the mode-line, it can be calculated when idle.")

I removed this part of the description, since it is a detail of
implementation.

For future patches, please avoid inserting the package definition at the
end of the file, as this is more likely to introduce merge conflicts.
You wouldn't want to make my life miserable, would you ? ;)

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add emacs-mode-line-idle.
From: Eugene Klimov <[email-masked]>
To: [email-masked]
Cc: Eugene Klimov <[email-masked]>
Date: Tue, 6 Apr 2021 01:08:07 +0500
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-mode-line-idle): New variable.
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 239915fffe..ea9f3bfcd1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -96,6 +96,7 @@
 ;;; Copyright © 2021 Xinglu Chen <[email-masked]>
 ;;; Copyright © 2021 Stefan Reichör <[email-masked]>
 ;;; Copyright © 2021 Simon Tournier <[email-masked]>
+;;; Copyright © 2021 Eugene Klimov <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27566,3 +27567,34 @@ and prefered services can easily be configured.")
 quasi-prefix map, with many useful bindings.  These bindings are
 shorter than usual, using mostly unprefixed keys.")
     (license license:gpl3+)))
+
+(define-public emacs-mode-line-idle
+  ;; Package has no release.  Version is extracted from "Version:" keyword in
+  ;; main file.
+  (let ((commit "02b1da6278e43cc9cc0356110cc6bfbb37eb8241")
+	(revision "1"))
+    (package
+      (name "emacs-mode-line-idle")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/ideasman42/emacs-mode-line-idle.git")
+                      (commit commit)))
+                (sha256 (base32 "0ky330b2sfbzkbxbfp9b21hdywsjw26bllspglz08hrbni7jmry8"))
+                (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/ideasman42/emacs-mode-line-idle")
+      (synopsis "Simple delayed text evaluation for the mode-line")
+      (description
+       "Mode Line Idle (mode-line-idle.el) is a minor mode that
+provides a convenient way to defer text evaluation in a way that can
+be easily integrated into existing mode-line's without requiring a
+minor mode or configuration.
+
+Mode Line Idle helps to add useful information into the mode-line
+without slowing down Emacs performance.  While delaying updates is not
+so difficult, having multiple timers can become awkward when mixed in
+with the mode-lines configuration.  Instead of avoiding expensive
+information in the mode-line, it can be calculated when idle.")
+      (license license:gpl3+))))
-- 
2.31.1