From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 16:58:47 2021 Received: (at submit) by debbugs.gnu.org; 4 Apr 2021 20:58:48 +0000 Received: from localhost ([127.0.0.1]:36562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9pX-0000Xf-IO for submit@debbugs.gnu.org; Sun, 04 Apr 2021 16:58:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:35478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9pU-0000XW-Vu for submit@debbugs.gnu.org; Sun, 04 Apr 2021 16:58:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT9pU-0001jT-NM for guix-patches@gnu.org; Sun, 04 Apr 2021 16:58:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9pU-0006dQ-GJ; Sun, 04 Apr 2021 16:58:44 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45014 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT9pT-0003xJ-BE; Sun, 04 Apr 2021 16:58:43 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/3] Add SourceForge updater and lint warnings Date: Sun, 4 Apr 2021 22:58:35 +0200 Message-Id: <20210404205835.30850-1-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! These patches add a ‘sourceforge’ updater. Initially I tried implementing it in terms of ‘latest-html-release’ but that doesn’t work because of the peculiar URL scheme that SF uses, with “/download” appended to otherwise nice-looking URLs. Instead, this one looks at the /latest URL supported by SourceForge. It’s less efficient than ‘generic-html’ for instance because there’s no caching and there’s up to three additional HEAD requests performed to find if there are detached signatures. The last patch has ‘guix lint -c refresh’ emit warnings when a package lacks an updater or when its updater doesn’t work. This should help us find out which updaters need to be improved or implemented. Feedback welcome! Ludo’. Ludovic Courtès (3): gnu-maintenance: Add 'sourceforge' updater. upstream: 'package-latest-release' tries all the matching updaters. lint: refresh: Warn about missing or dysfunctional updaters. doc/guix.texi | 2 ++ guix/gnu-maintenance.scm | 55 ++++++++++++++++++++++++++++++++++++++++ guix/lint.scm | 41 +++++++++++++++++++----------- guix/upstream.scm | 15 ++++++----- 4 files changed, 92 insertions(+), 21 deletions(-) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 17:03:38 2021 Received: (at 47597) by debbugs.gnu.org; 4 Apr 2021 21:03:38 +0000 Received: from localhost ([127.0.0.1]:36569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uE-0000gf-9M for submit@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uB-0000gD-QT for 47597@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45764) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9u5-0000V2-Se; Sun, 04 Apr 2021 17:03:30 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45190 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT9u5-00049w-BL; Sun, 04 Apr 2021 17:03:29 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 47597@debbugs.gnu.org Subject: [PATCH 1/3] gnu-maintenance: Add 'sourceforge' updater. Date: Sun, 4 Apr 2021 23:03:14 +0200 Message-Id: <20210404210316.31198-1-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This updater currently covers 2.4% of the packages. * guix/gnu-maintenance.scm (latest-sourceforge-release): New procedure. (%sourceforge-updater): New variable. * doc/guix.texi (Invoking guix refresh): Document it. --- doc/guix.texi | 2 ++ guix/gnu-maintenance.scm | 55 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index bada446357..d9ab8090a0 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11713,6 +11713,8 @@ list of updaters). Currently, @var{updater} may be one of: the updater for GNU packages; @item savannah the updater for packages hosted at @uref{https://savannah.gnu.org, Savannah}; +@item sourceforge +the updater for packages hosted at @uref{https://sourceforge.net, SourceForge}; @item gnome the updater for GNOME packages; @item kde diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index c7972d13a5..79214ae1a0 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -66,6 +66,7 @@ %gnu-updater %gnu-ftp-updater %savannah-updater + %sourceforge-updater %xorg-updater %kernel.org-updater %generic-html-updater)) @@ -660,6 +661,53 @@ GNOME packages; EMMS is included though, because its releases are on gnu.org." #:directory directory) (cut adjusted-upstream-source <> rewrite)))) +(define (latest-sourceforge-release package) + "Return the latest release of PACKAGE." + (define (uri-append uri extension) + ;; Return URI with EXTENSION appended. + (build-uri (uri-scheme uri) + #:host (uri-host uri) + #:path (string-append (uri-path uri) extension))) + + (define (valid-uri? uri) + ;; Return true if URI is reachable. + (catch #t + (lambda () + (case (response-code (http-head uri)) + ((200 302) #t) + (else #f))) + (const #f))) + + (let* ((name (package-upstream-name package)) + (base (string-append "https://sourceforge.net/projects/" + name "/files")) + (url (string-append base "/latest/download")) + (response (catch #t (lambda () (http-head url)) + (const #f)))) + (and response + (= 302 (response-code response)) + (response-location response) + (match (string-tokenize (uri-path (response-location response)) + (char-set-complement (char-set #\/))) + ((_ components ...) + (let* ((path (string-join components "/")) + (url (string-append "mirror://sourceforge/" path))) + (and (release-file? name (basename path)) + + ;; Take the heavy-handed approach of probing 3 additional + ;; URLs. XXX: Would be nicer if this could be avoided. + (let* ((loc (response-location response)) + (sig (any (lambda (extension) + (let ((uri (uri-append loc extension))) + (and (valid-uri? uri) + (string-append url extension)))) + '(".asc" ".sig" ".sign")))) + (upstream-source + (package name) + (version (tarball->version (basename path))) + (urls (list url)) + (signature-urls (and sig (list sig)))))))))))) + (define (latest-xorg-release package) "Return the latest release of PACKAGE." (let ((uri (string->uri (origin-uri (package-source package))))) @@ -774,6 +822,13 @@ the directory containing its source tarball." (pred (url-prefix-predicate "mirror://savannah/")) (latest latest-savannah-release))) +(define %sourceforge-updater + (upstream-updater + (name 'sourceforge) + (description "Updater for packages hosted on sourceforge.net") + (pred (url-prefix-predicate "mirror://sourceforge/")) + (latest latest-sourceforge-release))) + (define %xorg-updater (upstream-updater (name 'xorg) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 17:03:40 2021 Received: (at 47597) by debbugs.gnu.org; 4 Apr 2021 21:03:40 +0000 Received: from localhost ([127.0.0.1]:36571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uF-0000gq-P7 for submit@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uB-0000gF-VQ for 47597@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45766) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9u6-0000VF-Pq; Sun, 04 Apr 2021 17:03:30 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45190 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT9u6-00049w-6V; Sun, 04 Apr 2021 17:03:30 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 47597@debbugs.gnu.org Subject: [PATCH 2/3] upstream: 'package-latest-release' tries all the matching updaters. Date: Sun, 4 Apr 2021 23:03:15 +0200 Message-Id: <20210404210316.31198-2-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210404210316.31198-1-ludo@gnu.org> References: <20210404210316.31198-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * guix/upstream.scm (package-latest-release): Try UPDATERS until one of them returns an upstream source. This is useful for packages with several matching updaters, such a zlib ('sourceforge' and 'generic-html'). --- guix/upstream.scm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/guix/upstream.scm b/guix/upstream.scm index accd8967d8..632e9ebc4f 100644 --- a/guix/upstream.scm +++ b/guix/upstream.scm @@ -264,12 +264,15 @@ them matches." #:optional (updaters (force %updaters))) "Return an upstream source to update PACKAGE, a object, or #f if -none of UPDATERS matches PACKAGE. It is the caller's responsibility to ensure -that the returned source is newer than the current one." - (match (lookup-updater package updaters) - ((? upstream-updater? updater) - ((upstream-updater-latest updater) package)) - (_ #f))) +none of UPDATERS matches PACKAGE. When several updaters match PACKAGE, try +them until one of them returns an upstream source. It is the caller's +responsibility to ensure that the returned source is newer than the current +one." + (any (match-lambda + (($ name description pred latest) + (and (pred package) + (latest package)))) + updaters)) (define* (package-latest-release* package #:optional -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 17:03:47 2021 Received: (at 47597) by debbugs.gnu.org; 4 Apr 2021 21:03:47 +0000 Received: from localhost ([127.0.0.1]:36573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uG-0000gs-1j for submit@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uC-0000gG-Mi for 47597@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45767) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9u7-0000WC-HX; Sun, 04 Apr 2021 17:03:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45190 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT9u7-00049w-1q; Sun, 04 Apr 2021 17:03:31 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 47597@debbugs.gnu.org Subject: [PATCH 3/3] lint: refresh: Warn about missing or dysfunctional updaters. Date: Sun, 4 Apr 2021 23:03:16 +0200 Message-Id: <20210404210316.31198-3-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210404210316.31198-1-ludo@gnu.org> References: <20210404210316.31198-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This feedback should help us improve updaters. * guix/lint.scm (check-for-updates): Return a warning when PACKAGE lacks an updater or when the updater returns #f. --- guix/lint.scm | 41 ++++++++++++++++++++++++++--------------- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index cdd9dd14d7..a7d6bbba4f 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1191,21 +1191,32 @@ vulnerability records for PACKAGE by calling PACKAGE-VULNERABILITIES." (define (check-for-updates package) "Check if there is an update available for PACKAGE." - (match (with-networking-fail-safe - (format #f (G_ "while retrieving upstream info for '~a'") - (package-name package)) - #f - (package-latest-release* package)) - ((? upstream-source? source) - (if (version>? (upstream-source-version source) - (package-version package)) - (list - (make-warning package - (G_ "can be upgraded to ~a") - (list (upstream-source-version source)) - #:field 'version)) - '())) - (#f '()))) ; cannot find newer upstream release + (match (lookup-updater package) + (#f + (list (make-warning package (G_ "no updater for ~a") + (list (package-name package)) + #:field 'source))) + ((? upstream-updater? updater) + (match (with-networking-fail-safe + (format #f (G_ "while retrieving upstream info for '~a'") + (package-name package)) + #f + (package-latest-release package)) + ((? upstream-source? source) + (if (version>? (upstream-source-version source) + (package-version package)) + (list + (make-warning package + (G_ "can be upgraded to ~a") + (list (upstream-source-version source)) + #:field 'version)) + '())) + (#f ;cannot find upstream release + (list (make-warning package + (G_ "updater '~a' failed to find \ +upstream releases") + (list (upstream-updater-name updater)) + #:field 'source))))))) (define (check-archival package) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 11:38:54 2021 Received: (at 47597) by debbugs.gnu.org; 5 Apr 2021 15:38:54 +0000 Received: from localhost ([127.0.0.1]:38410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRJW-0007nU-CQ for submit@debbugs.gnu.org; Mon, 05 Apr 2021 11:38:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRJU-0007nI-Sc for 47597@debbugs.gnu.org; Mon, 05 Apr 2021 11:38:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60197) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTRJP-0006Bo-7U; Mon, 05 Apr 2021 11:38:47 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=34248 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lTRJO-0005M1-GR; Mon, 05 Apr 2021 11:38:47 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#47597: [PATCH 0/3] Add SourceForge updater and lint warnings References: <20210404205835.30850-1-ludo@gnu.org> <20210404210316.31198-1-ludo@gnu.org> Date: Mon, 05 Apr 2021 17:38:43 +0200 In-Reply-To: <20210404210316.31198-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Sun, 4 Apr 2021 23:03:14 +0200") Message-ID: <875z103fng.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597 Cc: 47597@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hey Ludo, > + (catch #t > + (lambda () > + (case (response-code (http-head uri)) > + ((200 302) #t) > + (else #f))) > + (const #f))) Any reason not to use "false-if-exception" here ... > + (response (catch #t (lambda () (http-head url)) > + (const #f)))) ... and here? Otherwise, I tested the whole patchset, seems fine :). Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 11:46:35 2021 Received: (at 47597) by debbugs.gnu.org; 5 Apr 2021 15:46:35 +0000 Received: from localhost ([127.0.0.1]:38420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRQx-0007z4-7U for submit@debbugs.gnu.org; Mon, 05 Apr 2021 11:46:35 -0400 Received: from mail.zaclys.net ([178.33.93.72]:46451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRQv-0007yq-1F for 47597@debbugs.gnu.org; Mon, 05 Apr 2021 11:46:33 -0400 Received: from [192.168.1.115] (lsl43-1_migr-78-195-19-20.fbx.proxad.net [78.195.19.20] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 135FkQYd039188 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <47597@debbugs.gnu.org>; Mon, 5 Apr 2021 17:46:26 +0200 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 135FkQYd039188 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1617637586; bh=tragFzG+B0q72GCiNu+MX9PIYedarMFIuODYJmPVAv0=; h=Subject:From:To:Date:From; b=iGz6ZykHELd+tqqnOn6DZsAuAfXO1x1mbUMOgG5yGGHB9m7Qf/gGs+LnvO/mDv0Gx dcrkFz52DoOkxy5OL7384XwxVqIEMCiO71zN7/gurvCaM+PyF9lSniDrIL+iLtVkh4 ZUeF8XtCaSsgLwnfQvfb1Jv5Be90K9PLduXK208A= Message-ID: Subject: [PATCH 0/3] Add SourceForge updater and lint warnings From: =?ISO-8859-1?Q?L=E9o?= Le Bouter To: 47597@debbugs.gnu.org Date: Mon, 05 Apr 2021 17:46:21 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-9ihwznQ+OowKbYi5vHxc" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47597 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-9ihwznQ+OowKbYi5vHxc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks a lot Ludo for this! Sourceforge updater was wondering why it didnt exist maybe not possible but you did it! Also linter to check if updaters are working correctly, really awesome idea! L=C3=A9o --=-9ihwznQ+OowKbYi5vHxc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBrMM0ACgkQRaix6GvN EKa0bg/+P1H8ldjCAjtSZXTNzebt8VjnjWGm796v9VBr95ECUIZeiZ20yjdIVEuD oZTb8hu8IGTKTdtqcfr1XT9/PvNpUnoRDeFlzHkyL5Ov1buA5WyUvU/E/XjPk8yn o3xHjrfwgIE+2AG5afhVCUuW6rBj8qVNZPoXk021jV2ziA/szvIfOlRwiLL3BMhS Y1XUyIOYWaPLCYUkko+/EcTMoRxIwTgQXXqvZi+0FsD7JvFGbjee09qjNCqHCEMa uhEPHYHSi6I83m5qLHIWi8FBkFzbCIN+1y8EKA0YluBnNWhk/Z1DxNLuueTHzkVZ jnbaAGhqa+3OSkatzF+IPUy0/s5WC6Ch792DGtRMOT64ZgXRw50jiFTabeIZa6xy icO3RXz9kB3olw4L3CqbcsDaDDZOqfr4lh+x9khLm+0z6dymYDFoAMETwkq32pAO Xd1GtPR+Nv7BEIha71pVT9okRgZYebFruyAA5DSmN2NV9W8+9W3l8+eyEFyUBTC4 zmyLdIC1UGTZYY7MQrJT6Eu/OmIBdqoVhcJ/ALcrFyfmzvRURoeXB3IyHHtPvVTF lU+xFzLGQ0zSLgsMf0idv5DcaCOYhETNkjs/Mj0A3kMZpxvuy7F9tWfqJTISepMs DrBriF1aNwcww1DGzs4Ep8vuQiFpxqajY5jFxy6SemunQWZgu84= =QY02 -----END PGP SIGNATURE----- --=-9ihwznQ+OowKbYi5vHxc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 12:03:51 2021 Received: (at 47597) by debbugs.gnu.org; 5 Apr 2021 16:03:51 +0000 Received: from localhost ([127.0.0.1]:38428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRhf-0008QI-0s for submit@debbugs.gnu.org; Mon, 05 Apr 2021 12:03:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTRhc-0008Q0-Uh for 47597@debbugs.gnu.org; Mon, 05 Apr 2021 12:03:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60591) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTRhX-0004Fc-Ij for 47597@debbugs.gnu.org; Mon, 05 Apr 2021 12:03:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46424 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lTRhW-0000je-8L; Mon, 05 Apr 2021 12:03:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#47597: [PATCH 0/3] Add SourceForge updater and lint warnings References: <20210404205835.30850-1-ludo@gnu.org> <20210404210316.31198-1-ludo@gnu.org> <875z103fng.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Germinal an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 05 Apr 2021 18:03:39 +0200 In-Reply-To: <875z103fng.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Mon, 05 Apr 2021 17:38:43 +0200") Message-ID: <87a6qcvhus.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597 Cc: 47597@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Mathieu, Mathieu Othacehe skribis: >> + (catch #t >> + (lambda () >> + (case (response-code (http-head uri)) >> + ((200 302) #t) >> + (else #f))) >> + (const #f))) > > Any reason not to use "false-if-exception" here ... > >> + (response (catch #t (lambda () (http-head url)) >> + (const #f)))) > > ... and here? No good reason, not sure what was on my mind. I=E2=80=99ll adjust accordin= gly. > Otherwise, I tested the whole patchset, seems fine :). Cool, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 06 18:01:54 2021 Received: (at 47597-done) by debbugs.gnu.org; 6 Apr 2021 22:01:54 +0000 Received: from localhost ([127.0.0.1]:42105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTtlh-0008Hq-Sp for submit@debbugs.gnu.org; Tue, 06 Apr 2021 18:01:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTtlh-0008Hd-3H for 47597-done@debbugs.gnu.org; Tue, 06 Apr 2021 18:01:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTtlb-0002JW-K7; Tue, 06 Apr 2021 18:01:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51344 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lTtlZ-00066z-KL; Tue, 06 Apr 2021 18:01:46 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#47597: [PATCH 0/3] Add SourceForge updater and lint warnings References: <20210404205835.30850-1-ludo@gnu.org> <20210404210316.31198-1-ludo@gnu.org> <875z103fng.fsf_-_@gnu.org> Date: Wed, 07 Apr 2021 00:01:44 +0200 In-Reply-To: <875z103fng.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Mon, 05 Apr 2021 17:38:43 +0200") Message-ID: <87blarjcmv.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47597-done Cc: 47597-done@debbugs.gnu.org, =?utf-8?Q?L=C3=A9o_Le_Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Pushed as 709f30b8e466b5f7155255be4f2cee008f8d01a9 with changes as Mathieu suggested. Thanks for your feedback! Ludo=E2=80=99. From unknown Sat Jun 21 10:38:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 May 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator