From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 11:25:25 2021 Received: (at submit) by debbugs.gnu.org; 3 Apr 2021 15:25:25 +0000 Received: from localhost ([127.0.0.1]:34307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSi9M-00016e-Hz for submit@debbugs.gnu.org; Sat, 03 Apr 2021 11:25:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:50428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSi9J-00016S-LY for submit@debbugs.gnu.org; Sat, 03 Apr 2021 11:25:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSi9J-000514-Fc for guix-patches@gnu.org; Sat, 03 Apr 2021 11:25:21 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:35932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSi9G-0003V3-5x for guix-patches@gnu.org; Sat, 03 Apr 2021 11:25:21 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FCLGl67VYz1rwmn for ; Sat, 3 Apr 2021 17:21:03 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FCLGl60p6z1qqx5 for ; Sat, 3 Apr 2021 17:21:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id EczxDAyatj3h for ; Sat, 3 Apr 2021 17:21:02 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-58-114.dynamic.mnet-online.de [188.174.58.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Sat, 3 Apr 2021 17:21:02 +0200 (CEST) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.24]) by hermia.goebel-consult.de (Postfix) with ESMTP id E2245601A3; Sat, 3 Apr 2021 17:29:05 +0200 (CEST) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: lksctp-tools: Fix build of include file. Date: Sat, 3 Apr 2021 17:20:59 +0200 Message-Id: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.21.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.18.0.10; envelope-from=h.goebel@crazy-compilers.com; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch: New file. * gnu/local.mk[patches]: Add it. * gnu/packages/networking.scm(/lksctp-tools)[source]: Use this patch. --- gnu/local.mk | 1 + gnu/packages/networking.scm | 2 ++ ...tp-tools-1.0.18-fix-header-file-name.patch | 32 +++++++++++++++++++ 3 files changed, 35 insertions(+) create mode 100644 gnu/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch diff --git a/gnu/local.mk b/gnu/local.mk index deb4ddcede..728c0fc718 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1264,6 +1264,7 @@ dist_patch_DATA = \ %D%/packages/patches/libffi-float128-powerpc64le.patch \ %D%/packages/patches/libvirt-create-machine-cgroup.patch \ %D%/packages/patches/libziparchive-add-includes.patch \ + %D%/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch \ %D%/packages/patches/localed-xorg-keyboard.patch \ %D%/packages/patches/kdiagram-Fix-missing-link-libraries.patch \ %D%/packages/patches/kiki-level-selection-crash.patch \ diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 7dd484fa94..a227cb2d3e 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -448,6 +448,8 @@ performance across unpredictable networks, such as the Internet.") (url "https://github.com/sctp/lksctp-tools") (commit (string-append "v" version)))) (file-name (git-file-name name version)) + (patches + (search-patches "lksctp-tools-1.0.18-fix-header-file-name.patch")) (sha256 (base32 "1x4fwzrlzvfa3vcpja97m8w5g9ir2zrh4zs7zksminrnmdrs0dsr")))) (build-system gnu-build-system) diff --git a/gnu/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch b/gnu/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch new file mode 100644 index 0000000000..1ebe6c803d --- /dev/null +++ b/gnu/packages/patches/lksctp-tools-1.0.18-fix-header-file-name.patch @@ -0,0 +1,32 @@ +From 378560050a8f93786c590cc99a55461666205b61 Mon Sep 17 00:00:00 2001 +From: Xin Long +Date: Fri, 24 Aug 2018 01:13:32 +0800 +Subject: [PATCH] build: fix netinet/sctp.h not to be installed + +After libcnetinet_HEADERS was set to sctp.h.in, netinet/sctp.h can +no longer be installed into ${includedir}. + +Since "AC_CONFIG_HEADERS([src/include/netinet/sctp.h])" is already +added into configure.ac, there's no need to generate sctp.h by +automake. + +So we simply set libcnetinet_HEADERS back to sctp.h. + +Fixes: 9607dd85e70a ("netinet/sctp.h: dynamically build based on system setup") +Signed-off-by: Xin Long +Signed-off-by: Marcelo Ricardo Leitner +--- + src/include/netinet/Makefile.am | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/src/include/netinet/Makefile.am b/src/include/netinet/Makefile.am +index ca0aac2..965db8c 100644 +--- a/src/include/netinet/Makefile.am ++++ b/src/include/netinet/Makefile.am +@@ -11,5 +11,4 @@ libcnetinetdir = $(includedir)/netinet + # API. + include_HEADERS = + +-libcnetinet_HEADERS = sctp.h.in +-BUILT_SOURCES = sctp.h ++libcnetinet_HEADERS = sctp.h -- 2.21.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 11:28:08 2021 Received: (at submit) by debbugs.gnu.org; 3 Apr 2021 15:28:08 +0000 Received: from localhost ([127.0.0.1]:34316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSiC0-0001B8-Fs for submit@debbugs.gnu.org; Sat, 03 Apr 2021 11:28:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:51012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSiBz-0001Av-96 for submit@debbugs.gnu.org; Sat, 03 Apr 2021 11:28:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSiBz-0005Y2-3S for guix-patches@gnu.org; Sat, 03 Apr 2021 11:28:07 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:35118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSiBx-0005Bx-HU for guix-patches@gnu.org; Sat, 03 Apr 2021 11:28:06 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FCLQr21grz1qsbw; Sat, 3 Apr 2021 17:28:04 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FCLQr0RlYz1qqxB; Sat, 3 Apr 2021 17:28:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id tFvV8KoOzj77; Sat, 3 Apr 2021 17:28:03 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-58-114.dynamic.mnet-online.de [188.174.58.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sat, 3 Apr 2021 17:28:03 +0200 (CEST) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.24]) by hermia.goebel-consult.de (Postfix) with ESMTP id B0BBF60166; Sat, 3 Apr 2021 17:36:06 +0200 (CEST) From: Hartmut Goebel To: 47582@debbugs.gnu.org, guix-patches@gnu.org Subject: [PATCH 2/2] gnu: Add python-pysctp. Date: Sat, 3 Apr 2021 17:28:00 +0200 Message-Id: <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.21.4 In-Reply-To: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.18.0.9; envelope-from=h.goebel@crazy-compilers.com; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/networking.scm(python-pysctp): New variable. --- gnu/packages/networking.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index a227cb2d3e..f8ab1bbddb 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -473,6 +473,40 @@ sockets, and also some helper utilities around SCTP.") ;; Others. license:gpl2+)))) +(define-public python-pysctp +(package + (name "python-pysctp") + (version "0.6.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pysctp" version)) + (sha256 + (base32 "14h2qlmfi24bizhvvqkfqfa78pzm3911ibrzy9k94i97xy1978dy")))) + (build-system python-build-system) + (inputs + `(("lksctp-tools" ,lksctp-tools))) + (arguments + `(#:tests? #f ;; require network + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-setup.py + (lambda _ + (substitute* "setup.py" + (("include_dirs\\s*=.*") + (string-append "include_dirs = ['.'] + '" + (getenv "C_INCLUDE_PATH") "'.split(':'),")) + (("library_dirs\\s*=.*") + (string-append "library_dirs = '" + (getenv "LIBRARY_PATH") "'.split(':'),"))) + #t))))) + (home-page "https://github.com/p1sec/pysctp") + (synopsis "Python module for the SCTP protocol stack and library") + (description + "@code{pysctp} implements the SCTP socket API. You need a SCTP-aware +kernel (most are).") + (license license:lgpl2.1+))) + (define-public knockd (package (name "knockd") -- 2.21.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 12:12:14 2021 Received: (at 47582) by debbugs.gnu.org; 3 Apr 2021 16:12:14 +0000 Received: from localhost ([127.0.0.1]:34346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSisg-0002HZ-3i for submit@debbugs.gnu.org; Sat, 03 Apr 2021 12:12:14 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSisb-0002HN-Kx for 47582@debbugs.gnu.org; Sat, 03 Apr 2021 12:12:13 -0400 Received: from butterfly.local ([213.132.158.53]) by baptiste.telenet-ops.be with bizsmtp id oGC72400319Qjf101GC7E3; Sat, 03 Apr 2021 18:12:08 +0200 Message-ID: <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. From: Maxime Devos To: Hartmut Goebel , 47582@debbugs.gnu.org Date: Sat, 03 Apr 2021 18:12:06 +0200 In-Reply-To: <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-nJG8quj4NIO19lynfBCL" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617466328; bh=tb071P9nCxUVraAo2I+O7zNh+FKuGthseloecw/Hu6o=; h=Subject:From:To:Date:In-Reply-To:References; b=R/wb5PRDSO2DAgU7Xp4o+jiNQoqC36szOoLSiWJnjoJ4mOQQJ9asJIaSvg0mdyMbZ ymMmPNViqIq1JxIzEuTIbS1uZGAFJUFnVTOgtrwFBVIg+eiuAMrixosyMGT4knE3C9 hUhffij7wtpFVRKPYuIUIirJhkdKAimdBMbjI7Oo0oC0bjvUaC3Mb+pd99MogDy3kQ M6YFbcDqGqJ6X0fbiaGZpN87J+aIaZY7YJnEXcqHk3B74I1rbydN/g0/SBgZsAeh1d /iUUR1uqRPpPGMsm9Hvr1hgrnbZNpdhK2xR0KMXD/3bwRkz8pizHsLrJcAmuHSnm/d waBcf72RaW+Ag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-nJG8quj4NIO19lynfBCL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-04-03 at 17:28 +0200, Hartmut Goebel wrote: > * gnu/packages/networking.scm(python-pysctp): New variable. > --- > gnu/packages/networking.scm | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > [...] > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-setup.py > + (lambda _ > + (substitute* "setup.py" > + (("include_dirs\\s*=3D.*") > + (string-append "include_dirs =3D ['.'] + '" > + (getenv "C_INCLUDE_PATH") "'.split(':'),")) > + (("library_dirs\\s*=3D.*") > + (string-append "library_dirs =3D '" > + (getenv "LIBRARY_PATH") "'.split(':'),"))) > + #t))))) Phases do not need to return #t anymore. IIUC the warning message that res= ults if it is left out has been removed on core-updates. Greetings, Maxime. --=-nJG8quj4NIO19lynfBCL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGiT1hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7n1hAQDmP7IWDQG2IGUVTXCIG5ygPv1Y 8Rzl51Axy1MbgyIAvgEAtN7V8EE8JNzXsChQn+XRrw72Y5RASRKZxYkpMOM7IgA= =V0FC -----END PGP SIGNATURE----- --=-nJG8quj4NIO19lynfBCL-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 13:37:19 2021 Received: (at 47582) by debbugs.gnu.org; 3 Apr 2021 17:37:19 +0000 Received: from localhost ([127.0.0.1]:34395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSkD0-0006SY-U1 for submit@debbugs.gnu.org; Sat, 03 Apr 2021 13:37:19 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSkCx-0006SO-Mz for 47582@debbugs.gnu.org; Sat, 03 Apr 2021 13:37:17 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FCPHt2X62z1qt3d; Sat, 3 Apr 2021 19:37:14 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FCPHt2LhVz1qrxQ; Sat, 3 Apr 2021 19:37:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id O0lgJobXszKM; Sat, 3 Apr 2021 19:37:13 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-58-114.dynamic.mnet-online.de [188.174.58.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sat, 3 Apr 2021 19:37:13 +0200 (CEST) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 63DE560166; Sat, 3 Apr 2021 19:45:19 +0200 (CEST) Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. To: Maxime Devos , 47582@debbugs.gnu.org References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Sat, 3 Apr 2021 19:37:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O7tmvRZHtdwllCEy7I4Ixo6QhiWZJc7Pk" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O7tmvRZHtdwllCEy7I4Ixo6QhiWZJc7Pk Content-Type: multipart/mixed; boundary="JlG2IRNL65kQcIOtGIKwlXFOdn9ZQWfpi"; protected-headers="v1" From: Hartmut Goebel To: Maxime Devos , 47582@debbugs.gnu.org Message-ID: Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> In-Reply-To: <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> --JlG2IRNL65kQcIOtGIKwlXFOdn9ZQWfpi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE Am 03.04.21 um 18:12 schrieb Maxime Devos: > Phases do not need to return #t anymore. IIUC the warning message that= results > if it is left out has been removed on core-updates. Okay, will do. Any other remarks? --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --JlG2IRNL65kQcIOtGIKwlXFOdn9ZQWfpi-- --O7tmvRZHtdwllCEy7I4Ixo6QhiWZJc7Pk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE1K2LnBZ7dXxPCOh3e3UoEb93O2UFAmBop8YACgkQe3UoEb93 O2XUrA/8DqRepR2hS+9tK0HJV5nkTkT6O6ebLfxkrmgVNAAJ0E9bJe+GdHIBzS3b XZrPmBefbPZDDb3ZVcbdnCQpWPuKxUARFRpik9BEOmTcsAvdWTRF2de67zi4vJR7 He9OysYASYKrv/3/BA7qy50zaUwFEpLBSLoU0tBRkB+ZKEyk61p2VR3iAZykYV51 0s7afIkt5mu6NpUEridJAQday6QAWSeSXFnPFpQmxn93+p4iYBdYX+k8EKuYoUBS pbRvP6PlY2tv8zpUlzqbISWst7ZloKDYgjksOVNQur5a9u8fTYudyEAOWSSkpsqu 4kPNbH5xBgsAq9ZLssi95EGic8NiUlKCkjxBQFE0UeOyHUNqowo0lOL5JqWTrmfI NavFicBNTOd/NdXUo8jfIA2CTo63Hmi6sSm6LvmRKxWFFgRWJhRrUymJ2N1Cd2zX qvNDq+csuqlH0aKFxJcAq2ivcQFw3fcK8xGug0VLGYe/6EmoWbauezxVy4qLSpwJ PeglpCdtHAvSLo1JBTxLOjPgVCrqyECIrLTGR+XE9HA2ceiV4ZhthuWYpLxiUpbW 9GrAB+Qi7wyB/lIWhdYZAV+1oqDUwYPdDJGVdlOEKPmrzgWkP1fGKeuogN5evdjf sZygszrEtQ+W6T63Ujo6JAgRWkdJuZVh5W5GCufwpc4VUdSLkMs= =mTHK -----END PGP SIGNATURE----- --O7tmvRZHtdwllCEy7I4Ixo6QhiWZJc7Pk-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 03 15:01:21 2021 Received: (at 47582) by debbugs.gnu.org; 3 Apr 2021 19:01:21 +0000 Received: from localhost ([127.0.0.1]:34438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSlWL-00005P-79 for submit@debbugs.gnu.org; Sat, 03 Apr 2021 15:01:21 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:55594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSlWI-000057-0M for 47582@debbugs.gnu.org; Sat, 03 Apr 2021 15:01:20 -0400 Received: from butterfly.local ([213.119.170.42]) by xavier.telenet-ops.be with bizsmtp id oK1F240030vDxTp01K1FDK; Sat, 03 Apr 2021 21:01:16 +0200 Message-ID: <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. From: Maxime Devos To: Hartmut Goebel , 47582@debbugs.gnu.org Date: Sat, 03 Apr 2021 21:01:01 +0200 In-Reply-To: References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-a4smc+8val6layiwwhCS" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617476476; bh=zJgs3InbkagXImjOLixnYYam/FQJsnq8W7EaguuCFcE=; h=Subject:From:To:Date:In-Reply-To:References; b=JQbno8xMMKHHCmQSZaXLrg0MJyPe7j7Fh5J+s2bdjjos/ovAx2eHcTvIIAUVUwyRZ KkJvfxfpVQo9CNK5jR503iw6afIldOxn1hkASHtfJMg6298LTlggEXOERJgHKIh0Eq QWYtFeiQdqftwirrAetDhzl94isW8nLwDoWDK29EI9MG0zXYarIbi6wopA+DkVoYfa D05gTinhnoQzkbPN1fXOBnGTMh6VIxTyFzX6oO0MR3OlAPYrZNNa5x2pL/iIbAl8SZ azO+qmGAVP8PhWbfZJhUcUcKeO3o7PyzuuTxeKJcDSCzMmjYhhl7SNl+z3qXdlwnz+ kirc+/wtCrDAQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-a4smc+8val6layiwwhCS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-04-03 at 19:37 +0200, Hartmut Goebel wrote: > Am 03.04.21 um 18:12 schrieb Maxime Devos: > > Phases do not need to return #t anymore. IIUC the warning message that= results > > if it is left out has been removed on core-updates. >=20 > Okay, will do. Any other remarks? About the following code: > + (substitute* "setup.py" > + (("include_dirs\\s*=3D.*") > + (string-append "include_dirs =3D ['.'] + '" > + (getenv "C_INCLUDE_PATH") "'.split(':'),")) > + (("library_dirs\\s*=3D.*") > + (string-append "library_dirs =3D '" > + (getenv "LIBRARY_PATH") "'.split(':'),"))) When cross-compiling, this code should most likely use CROSS_C_INCLUDE_PATH and CROSS_LIBRARY_PATH instead. (Admittedly, python-build-system does not support cross-compilation yet, so this is not important ... yet.) Suggestion: replace (getenv "C_INCLUDE_PATH") with (getenv ,(if (%current-target-system) "CROSS_C_INCLUDE_PATH" "C_INCLUDE_PATH")). Likewise for LIBRARY_PATH. Some aesthetic nitpicks (YMMV): > + (synopsis "Python module for the SCTP protocol stack and library") A space has been doubled. > * gnu/packages/networking.scm(python-pysctp): New variable. I would put a space between .scm and (python-pysctp). Most commit messages do. +(define-public python-pysctp +(package + (name "python-pysctp") + ... Indentation is wrong here. See 16.5.4 Formatting Code for how to automatic= ally indent code. Greetings, Maxime. --=-a4smc+8val6layiwwhCS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGi7bRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7u0DAP9dF0lyeAcS5Llq5gibg/f1HN+6 MbtOA0SPqeTwy3FbOwEAzFgswhtvShuOqUK6OMKzRl6GxyYXG4NaFYtdOPm+KwI= =T94u -----END PGP SIGNATURE----- --=-a4smc+8val6layiwwhCS-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 11:07:32 2021 Received: (at 47582) by debbugs.gnu.org; 11 Apr 2021 15:07:32 +0000 Received: from localhost ([127.0.0.1]:55724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbgS-0007Fb-0T for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:07:32 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:53683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbgP-0007FR-T3 for 47582@debbugs.gnu.org; Sun, 11 Apr 2021 11:07:30 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FJFbM3gtxz1qsk3; Sun, 11 Apr 2021 17:07:27 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FJFbM1wqFz1qqkq; Sun, 11 Apr 2021 17:07:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 5bzMlVbXAxyl; Sun, 11 Apr 2021 17:07:26 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-60-147.dynamic.mnet-online.de [188.174.60.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 11 Apr 2021 17:07:26 +0200 (CEST) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 0CBB86018B; Sun, 11 Apr 2021 17:07:44 +0200 (CEST) Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. To: Maxime Devos , 47582@debbugs.gnu.org References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> Date: Sun, 11 Apr 2021 17:07:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UikwNbckV0sK9RAw1B8Lhkjf31VczylK6" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UikwNbckV0sK9RAw1B8Lhkjf31VczylK6 Content-Type: multipart/mixed; boundary="7XehaWtqxpzFYOpTDPhDAxKgHZNKLhwX0"; protected-headers="v1" From: Hartmut Goebel To: Maxime Devos , 47582@debbugs.gnu.org Message-ID: <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> In-Reply-To: <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> --7XehaWtqxpzFYOpTDPhDAxKgHZNKLhwX0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Thanks for the review. I applied most of the changes and poushed as 03e80cf42240f65346713ff414eb2ca628ef0884 If did not apply > Suggestion: replace (getenv "C_INCLUDE_PATH") with > (getenv ,(if (%current-target-system) > "CROSS_C_INCLUDE_PATH" > "C_INCLUDE_PATH")). > Likewise for LIBRARY_PATH. since "CROSS_C" is used on 14 times in gnu/packages/*.scm and not at all in guix/build*. So I assume this is not the way to implement cross-compiling :-) --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --7XehaWtqxpzFYOpTDPhDAxKgHZNKLhwX0-- --UikwNbckV0sK9RAw1B8Lhkjf31VczylK6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE1K2LnBZ7dXxPCOh3e3UoEb93O2UFAmBzEKsACgkQe3UoEb93 O2XaQw//W/JecKiU+B7B79y5/dRF18NFsWuqdtXmREjVRVhlYhR7ob9LByt/5m3t KAP1Y06LQ/YmpK0va2qKrZUe2rlE+yK+TcYxTy4G789SvmLoQhNWnED+vV0wATFT r+W9f9/uYQkdxmnxGeh4BjtGk0upVjl1nzsQJ9xjo+KFsY97cucZYmCJztuaWWmK hiYZp3A1hIQj5oAUf5V1sE0rqvXt6HiAZ57nWgdyNpx7PmtOzH14ccYyJi8N4hqh LKsxpZBePr8mcxGhWWAI8BO25AkAtLZFZ8xviTqDOV9PiW3ZSrwU1whlTILVMxMF jACc+Irm4uv2tb73PQZLzrlTT027QIzsI9qpUtZtlnF6TwwDEEtIBciwuNvGe3To RQo+Xt/1fB6w8V8EMlDq7F39v+sHNrPqPtrUzhTkEkh+NbvhSwtaNsMqGVYHUtyF ahXHWRWao8VGkBmc1X/uXXS7vHsor2e15qsUoGxdcpB0CMPoJtc0iLy+I8qx00yB lN53OdFz7foklCKdkOMbxVlb+/ZZ7ynPgdRQvSourFg6cjJVNfnp204Yu2pciipR 5uCTNqhgpfN5JxR8yaqsuZmaRNkcLQiqLxzdVcKyzA9OZudNON0sXUALg/XefA+x yHAZ57Z9pCgOp9DoXdf/wQKnhUuU5Lw4RNIpTw0N6PDe0hPLA8U= =4W5D -----END PGP SIGNATURE----- --UikwNbckV0sK9RAw1B8Lhkjf31VczylK6-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 11:07:48 2021 Received: (at 47582-close) by debbugs.gnu.org; 11 Apr 2021 15:07:48 +0000 Received: from localhost ([127.0.0.1]:55728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbgi-0007GC-8z for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:07:48 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:60000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbgg-0007G2-K9 for 47582-close@debbugs.gnu.org; Sun, 11 Apr 2021 11:07:46 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FJFbj5MGCz1s0tT for <47582-close@debbugs.gnu.org>; Sun, 11 Apr 2021 17:07:45 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FJFbj3CwWz1qqkq for <47582-close@debbugs.gnu.org>; Sun, 11 Apr 2021 17:07:45 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id PfX4vnNcnTgR for <47582-close@debbugs.gnu.org>; Sun, 11 Apr 2021 17:07:44 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-60-147.dynamic.mnet-online.de [188.174.60.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <47582-close@debbugs.gnu.org>; Sun, 11 Apr 2021 17:07:44 +0200 (CEST) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id C0AD06018B for <47582-close@debbugs.gnu.org>; Sun, 11 Apr 2021 17:08:02 +0200 (CEST) Subject: Re: bug#47582: Acknowledgement ([PATCH 1/2] gnu: lksctp-tools: Fix build of include file.) To: 47582-close@debbugs.gnu.org References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Sun, 11 Apr 2021 17:07:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 11 11:51:41 2021 Received: (at 47582) by debbugs.gnu.org; 11 Apr 2021 15:51:41 +0000 Received: from localhost ([127.0.0.1]:55767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVcNA-0008Jv-NX for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:51:41 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:35344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVcN8-0008Jm-GJ for 47582@debbugs.gnu.org; Sun, 11 Apr 2021 11:51:39 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id rTrb2400h0mfAB401TrcZS; Sun, 11 Apr 2021 17:51:36 +0200 Message-ID: <70afbbd7c248c27ddb9b7df9e454ad8697d354d1.camel@telenet.be> Subject: Re: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. From: Maxime Devos To: Hartmut Goebel , 47582@debbugs.gnu.org Date: Sun, 11 Apr 2021 17:51:32 +0200 In-Reply-To: <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Pw3lo+RtP1jGh18Px5Aw" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618156296; bh=991Dm1m2Yy/MFyEbIT07zGq0cYal96e0ekaIWVSnziw=; h=Subject:From:To:Date:In-Reply-To:References; b=lNj7xGEX8eed02qymDMVPwqJXGKouRHHgsxIhO9QvsJ2WfJbRbUn1oXmXPyEAYyAy V8pkKWZkvapS81ZvUsaaX/qPcVb6Il1KAq3Mg41yZ3iW/3Hg2PE9AGvU4HFP3EIwU1 eTYrLtCIpX+h79GcJNKXA/CPLXG5P5xiO7P18laMmLbjVDqqmKLj6aTYs0dE1oaSwp jmQzZVMY+SzkTkyM8mwvJI/xE8mMwBExTDYonnOSONONk4Wqkgr2gwLRiK8MByS1/T 0iEI7jTEKEODD0UgC45zJIXsHH/YAAJHa8I/U96UPc8BS8lOMDCwUy42WRvUm9hRP9 OffCY1eLk1P/A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47582 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-Pw3lo+RtP1jGh18Px5Aw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-04-11 at 17:07 +0200, Hartmut Goebel wrote: > Thanks for the review. I applied most of the changes and poushed as > 03e80cf42240f65346713ff414eb2ca628ef0884 >=20 > If did not apply >=20 > > Suggestion: replace (getenv "C_INCLUDE_PATH") with > > (getenv ,(if (%current-target-system) > > "CROSS_C_INCLUDE_PATH" > > "C_INCLUDE_PATH")). > > Likewise for LIBRARY_PATH. I could be wrong about how/when "CROSS_C_INCLUDE_PATH" or "C_INCLUDE_PATH" = should be used. I don't agree with the following reasoning however: > since "CROSS_C" is used on 14 times in gnu/packages/*.scm and not at all > in guix/build*. So I assume this is not the way to implement > cross-compiling :-) ... as many (much more than 14) packages have cross-compilation bugs. For example, try searching for "CC=3Dgcc". Practically all usages are inco= rrect, they should use ,(string-append "CC=3D" (cc-for-target)) instead. gcc =3D *not* the cross-compiler (cc-for-target): when cross-compiling, something like "aarch64-linux-gnu-gc= c", otherwise simply "gcc". I've submitted a patch adding a linter, and a patch series fixing some of t= he buggy packages (at least instances of "CC=3Dgcc", there may be other bugs). Links: https://issues.guix.gnu.org/47676, https://issues.guix.gnu.org/47693 Greetings, Maxime. --=-Pw3lo+RtP1jGh18Px5Aw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHMbBBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hNPAQCwhZSXlOHO90kCh8mJTeTtgWK9 n9UwxfbXhmpgiYAKggD/fGBa93Vy7Q7Mt62cd1za22RzkmVcaOawwDqdu8jeOQw= =Y4Uj -----END PGP SIGNATURE----- --=-Pw3lo+RtP1jGh18Px5Aw-- From unknown Sun Jun 22 00:53:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 May 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator