GNU bug report logs - #47575
python-shell-completion-at-point omits %magic commands

Previous Next

To reply to this bug, email your comments to 47575 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: python-shell-completion-at-point omits %magic commands
Date: Sat, 3 Apr 2021 00:21:54 -0400

[Message part 1 (text/plain, inline)]

When using iPython as the inferior shell of python.el, `python-shell-completion-at-point' skips a `simple-operator’ regexp which include ?%.  In iPython, magic commands begin with ‘%’, and the fallback completion method happily provides them for completion:

In [67]: __PYTHON_EL_get_completions("%ru")
Out[91]: ['%%ruby', '%run’]

python-shell-completion-at-point trims this to “ru”, which also provides the same completions above, but which `try-completions’ rejects as non-matching.   So that:

In [1]: %ru[Tab]

Leads to “No matches”.

The solution would be to not skip the ?% character if it is at the start of the line.  The modulo operator cannot occur there in any case. 

One other point: the fallback mechanism sends and compiles the relatively long __PYTHON_EL_get_completions function each and every time it is called.  Because of how CAPF functions, this actually occurs 3 times in quick succession with a single Tab press like the above!  A more performant approach (esp. over remote buffer connections) would be to just call __PYTHON_EL_get_completions, and check for failure, setting up that function again if necessary.  This would parallel the readline completer native method, which is only setup once. 

[Message part 2 (text/html, inline)]

Message #8 received at 47575 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 47575 <at> debbugs.gnu.org, Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#47575: python-shell-completion-at-point omits %magic commands
Date: Thu, 06 May 2021 13:05:04 +0200

JD Smith <jdtsmith <at> gmail.com> writes:

> When using iPython as the inferior shell of python.el,
> `python-shell-completion-at-point' skips a `simple-operator’ regexp which include
> ?%.  In iPython, magic commands begin with ‘%’, and the fallback completion
> method happily provides them for completion:
>
>  In [67]: __PYTHON_EL_get_completions("%ru")
>  Out[91]: ['%%ruby', '%run’]
>
> python-shell-completion-at-point trims this to “ru”, which also provides the same
> completions above, but which `try-completions’ rejects as non-matching.   So that:
>
>  In [1]: %ru[Tab]
>
> Leads to “No matches”.
>
> The solution would be to not skip the ?% character if it is at the start of the line.  The
> modulo operator cannot occur there in any case. 

The simple-operator was added to fix bug#37808 in:

commit 51d3c95147efa80fd3e09c90705439517e8fb6ca
Author:     Andrii Kolomoiets <andreyk.mad <at> gmail.com>
AuthorDate: Fri Oct 18 16:04:32 2019 +0300

I've added Andrii to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 47575 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47575 <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#47575: python-shell-completion-at-point omits %magic commands
Date: Thu, 06 May 2021 16:38:55 +0300

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> JD Smith <jdtsmith <at> gmail.com> writes:
>
>> The solution would be to not skip the ?% character if it is at the start of the line.  The
>> modulo operator cannot occur there in any case. 

Well :)

    >>> foo=1
    >>> bar=2
    >>> foo\
    ... %bar
    1

Though I don't think it's the common use case.


--
Andrii

Message #14 received at 47575 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 47575 <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#47575: python-shell-completion-at-point omits %magic commands
Date: Wed, 29 Jun 2022 12:46:01 +0200

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

>>> The solution would be to not skip the ?% character if it is at the
>>> start of the line.  The
>>> modulo operator cannot occur there in any case. 
>
> Well :)
>
>     >>> foo=1
>     >>> bar=2
>     >>> foo\
>     ... %bar
>     1
>
> Though I don't think it's the common use case.

It does sounds very unlikely, so should JD's suggestion be implemented?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 47575 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47575 <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#47575: python-shell-completion-at-point omits %magic commands
Date: Wed, 29 Jun 2022 23:31:54 +0300

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>>>> modulo operator cannot occur there in any case. 
>>     ... %bar
>>     1
>>
>> Though I don't think it's the common use case.
>
> It does sounds very unlikely, so should JD's suggestion be implemented?

Agree, sounds good.


--
Andrii

Message #20 received at 47575 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 47575 <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#47575: python-shell-completion-at-point omits %magic commands
Date: Thu, 30 Jun 2022 12:06:13 +0200

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

>>>>> modulo operator cannot occur there in any case. 
>>>     ... %bar
>>>     1
>>>
>>> Though I don't think it's the common use case.
>>
>> It does sounds very unlikely, so should JD's suggestion be implemented?
>
> Agree, sounds good.

I'm really not that familiar with python-mode -- can anybody suggest a
patch here?  (The code is question is in
python-shell-completion-at-point.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.